Fisheye on dgfirmware/firmware/App/Controllers/ROPump.c

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4534: Removed function name from @brief

Tue, 25 Aug 2020 10:41:01 -0700

Quang Nguyen committed 482f446 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 233 more in dgfirmware

DEN-4534: Removed function name from @brief

· /firmware/App/Controllers/ConductivitySensors.c

(-3, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-2, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/CPLD.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Drivers/Comm.c

(-17, +17)

| History

| Source

| Diff

… 6 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4534: Updated doxygen comment for App/Controllers

Fri, 21 Aug 2020 10:57:52 -0700

Quang Nguyen committed 5a882c7 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 233 more in dgfirmware

DEN-4534: Updated doxygen comment for App/Controllers

· /firmware/App/Controllers/ConductivitySensors.c	(-47, +47)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.h	(-8, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-59, +56)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-202, +176)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.h	(-16, +16)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-27, +25)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.h	(-8, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-54, +51)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.h	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-65, +59)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-216, +200)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.h	(-11, +10)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-31, +26)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-9, +8)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Dara Navaei — Wed, 19 Aug 2020 14:56:33 -0700

Dara Navaei committed dc0d9b0 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 233 more in dgfirmware

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

· /firmware/App/Controllers/DrainPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/CPLD.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/Comm.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/InternalADC.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/SafetyShutdown.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-2, +2)

| History

| Source

| Diff

… 24 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4217: Fixed merge conflicts and Vectorcast issues.

Sean Nash — Wed, 19 Aug 2020 14:41:45 -0700

Sean Nash committed f308cc4 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 234 more in dgfirmware

DEN-4217: Fixed merge conflicts and Vectorcast issues.

· /firmware/App/Controllers/DrainPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-53, +121)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-286, +297)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/InternalADC.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-2, +10)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-4, +11)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-2, +6)

| History

| Source

| Diff

· /firmware/App/Modes/ModeRecirculate.c

(-5, +14)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.c

(-2, +2)

| History

| Source

| Diff

… 17 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4217: Updated @param formats in all modules.

Sean Nash — Thu, 13 Aug 2020 17:03:55 -0700

Sean Nash committed 8e6488e on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 234 more in dgfirmware

DEN-4217: Updated @param formats in all modules.

· /firmware/App/Controllers/DrainPump.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-24, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-4, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-9, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-22, +25)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-10, +10)

| History

| Source

| Diff

· /firmware/App/Drivers/CPLD.c

(-6, +3)

| History

| Source

| Diff

· /firmware/App/Drivers/Comm.c

(-17, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/InternalADC.c

(-6, +5)

| History

| Source

| Diff

· /firmware/App/Drivers/SafetyShutdown.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-2, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.c

(-16, +14)

| History

| Source

| Diff

… 10 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4217: Fixed Doxygen scope in several modules.

Sean Nash — Wed, 12 Aug 2020 17:36:40 -0700

Sean Nash committed 075a45f on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 234 more in dgfirmware

DEN-4217: Fixed Doxygen scope in several modules.

· /firmware/App/Controllers/DrainPump.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-5, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4217: Fixed Vectorcast math.h issue and removed band-aid macros in common.h.

Sean Nash — Wed, 12 Aug 2020 14:41:46 -0700

Sean Nash committed 6d43aaf on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 234 more in dgfirmware

DEN-4217: Fixed Vectorcast math.h issue and removed band-aid macros in common.h.

· /firmware/App/Controllers/DrainPump.c	(-3, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-3, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c	(-3, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Dara Navaei — Fri, 24 Jul 2020 14:02:27 -0700

Dara Navaei committed 0dec874 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 235 more in dgfirmware

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/InternalADC.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeRecirculate.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-2, +2)

| History

| Source

| Diff

… 12 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3922 Addressed code reviews and removed VC previous import errors

Tue, 21 Jul 2020 20:56:50 -0700

Quang Nguyen committed 5cfa1f3 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 236 more in dgfirmware

DEN-3922 Addressed code reviews and removed VC previous import errors

· /firmware/App/Controllers/ConductivitySensors.c

(-12, +18)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-2, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Drivers/InternalADC.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeRecirculate.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

… 13 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Handle CAN and UART error/warning notifications. Differentiated HD from DG s/w fault. Updated some older module/functio...

Sean Nash — Mon, 20 Jul 2020 17:53:23 -0700

Sean Nash committed 8f5feed on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 235 more in dgfirmware

Handle CAN and UART error/warning notifications. Differentiated HD from DG s/w fault. Updated some older module/function headers to latest format.

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Drivers/InternalADC.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeRecirculate.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeSolo.c

(-2, +32)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-4, +6)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.c

(-2, +2)

| History

| Source

| Diff

… 13 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Dara Navaei — Wed, 08 Jul 2020 16:59:23 -0700

Dara Navaei committed a7bf3ca on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 237 more in dgfirmware

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

· /firmware/App/Controllers/DrainPump.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-9, +10)

| History

| Source

| Diff

… 60 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Fixed initial broadcast intervals for RO and Drain pumps.

Sean Nash — Wed, 08 Jul 2020 14:56:23 -0700

Sean Nash committed 0d0b8f3 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Fixed initial broadcast intervals for RO and Drain pumps.

· /firmware/App/Controllers/DrainPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /results/Build_Status_Report.csv	(-3, +14)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-243, +293)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Fix reservoir mix-up in Drain/Fill modes. Added test code to turn fan on when starting re-circ mode to cool heater unti...

Sean Nash — Thu, 02 Jul 2020 17:27:20 -0700

Sean Nash committed 4c20f6a on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Fix reservoir mix-up in Drain/Fill modes. Added test code to turn fan on when starting re-circ mode to cool heater until fan module is written.

· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeRecirculate.c	(-0, +9)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): UT updates. Updated RO pump PI coefficients to make less aggressive based on lab testing.

Sean Nash — Thu, 25 Jun 2020 16:46:51 -0700

Sean Nash committed 4545a74 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

UT updates. Updated RO pump PI coefficients to make less aggressive based on lab testing.

· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-0, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Added EMC test code to RO pump control. Fixed debug alarm output bug.

Sean Nash — Wed, 24 Jun 2020 19:01:39 -0700

Sean Nash committed 738afd1 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Added EMC test code to RO pump control. Fixed debug alarm output bug.

· /firmware/App/Controllers/ROPump.c	(-2, +18)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): More EMC test build changes. Set Primary heater PWM freq to 15KHz.

Sean Nash — Fri, 12 Jun 2020 14:57:03 -0700

Sean Nash committed e66245b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

More EMC test build changes. Set Primary heater PWM freq to 15KHz.

· /firmware/.launches/DG.launch	(-8, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-3, +11)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-0, +25)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-4, +3)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-0, +14)	\| History	\| Source	\| Diff
· /firmware/DG.dil	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/include/etpwm.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/source/etpwm.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Merge branch 'DEN-2650-dg-firmware-infrastructure' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-2650-dg-firmware-inf...

Sean Nash — Thu, 04 Jun 2020 16:59:08 -0700

Sean Nash committed 99011bf on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Merge branch 'DEN-2650-dg-firmware-infrastructure' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-2650-dg-firmware-infrastructure

· /firmware/App/Controllers/ROPump.c	(-0, +14)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-0, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Doxygen comment updates.

Sean Nash — Thu, 04 Jun 2020 16:59:00 -0700

Sean Nash committed c081112 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Doxygen comment updates.

· /firmware/App/Controllers/DrainPump.c	(-7, +9)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-7, +9)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-2650 conducted unit testing and integration testing

Dara Navaei — Thu, 04 Jun 2020 15:29:59 -0700

Dara Navaei committed be027f8 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

DEN-2650 conducted unit testing and integration testing

· /firmware/App/Controllers/Heaters.c	(-20, +34)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-0, +14)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-1, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-4, +4)	\| History	\| Source	\| Diff
· /results/.gitignore	(-1, +0)	\| History	\| Source	\| Diff
· /results/StatusReport.csv	(-14, +0)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-9092, +0)	\| History	\| Source	\| Diff
· /results/cppcheck.log	(-122, +0)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-102, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Added filtering to pressures and RO flow.

Sean Nash — Wed, 03 Jun 2020 17:54:15 -0700

Sean Nash committed 0831cb6 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Added filtering to pressures and RO flow.

· /firmware/App/Controllers/LoadCell.c	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-12, +54)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +18)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Fixed load cell publishing as integers bug. Increased I term in PI control for RO pump. Changed CAN interrupts from FI...

Sean Nash — Thu, 28 May 2020 15:01:06 -0700

Sean Nash committed c443438 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Fixed load cell publishing as integers bug. Increased I term in PI control for RO pump. Changed CAN interrupts from FIQ to IRQ to see if resolves intermittent lock up.

· /firmware/.launches/DG.launch	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/CommBuffers.c	(-7, +18)	\| History	\| Source	\| Diff
· /firmware/DG.dil	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/include/sys_vim.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/source/can.c	(-4, +0)	\| History	\| Source	\| Diff
· /firmware/source/sys_vim.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): UF fixes. Doxygen fixes.

Sean Nash — Tue, 26 May 2020 10:39:19 -0700

Sean Nash committed bbf1e37 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

UF fixes. Doxygen fixes.

· /firmware/.launches/DG.launch

(-0, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-0, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-42, +81)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-5, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-0, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-59, +71)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.h

(-0, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-1, +1)

| History

| Source

| Diff

… 23 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Addressed code review feedback.

Sean Nash — Mon, 18 May 2020 10:54:36 -0700

Sean Nash committed 8ff2c0f on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Addressed code review feedback.

· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Merged updates to Valves module and UT/IT for Valves module.

Sean Nash — Mon, 18 May 2020 09:49:46 -0700

Sean Nash committed 77738b4 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Merged updates to Valves module and UT/IT for Valves module.

· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +25)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Updates to RO pump UT. Added UT for load cells and pressure sensors modules.

Sean Nash — Thu, 23 Apr 2020 11:45:50 -0700

Sean Nash committed 228bdc5 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Updates to RO pump UT. Added UT for load cells and pressure sensors modules.

· /firmware/App/Controllers/LoadCell.c	(-8, +14)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-10, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Added UT for RO and Drain pump modules. Minor fixes to RO pump module per UT. Decoupled average sample count from ADC ...

Sean Nash — Wed, 22 Apr 2020 16:43:18 -0700

Sean Nash committed a721c4f on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Added UT for RO and Drain pump modules. Minor fixes to RO pump module per UT. Decoupled average sample count from ADC to grams conversion in load cell module. Addressed code review feedback.

· /firmware/App/Controllers/LoadCell.c	(-6, +12)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-13, +7)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-8, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Added Dialin support to pumps, pressures, and load cells.

Sean Nash — Mon, 20 Apr 2020 16:39:25 -0700

Sean Nash committed a75923f on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Added Dialin support to pumps, pressures, and load cells.

· /firmware/App/Controllers/DrainPump.c	(-0, +101)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.h	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-1, +74)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.h	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-11, +11)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-45, +99)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Added more mode handling and associated messaging.

Sean Nash — Mon, 20 Apr 2020 14:15:42 -0700

Sean Nash committed c48a99d on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Added more mode handling and associated messaging.

· /firmware/App/Controllers/LoadCell.c

(-64, +39)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.h

(-3, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-28, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-4, +3)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-7, +33)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.h

(-1, +12)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDisinfect.c

(-63, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDisinfect.h

(-28, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-9, +67)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.h

(-2, +13)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-10, +36)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.h

(-1, +12)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-49, +27)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-11, +38)

| History

| Source

| Diff

… 22 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Added DG op mode broadcast.

Sean Nash — Tue, 14 Apr 2020 16:41:10 -0700

Sean Nash committed c548570 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Added DG op mode broadcast.

· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-6, +23)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-16, +15)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-3, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Updated GPIO pin configurations and pin assignments.

Sean Nash — Mon, 13 Apr 2020 10:25:38 -0700

Sean Nash committed 216bd92 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Updated GPIO pin configurations and pin assignments.

· /firmware/App/Controllers/DrainPump.c	(-7, +17)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-0, +12)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/CPLD.c	(-0, +80)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/CPLD.h	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-7, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskPriority.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/DG.dil	(-30, +30)	\| History	\| Source	\| Diff
· /firmware/include/etpwm.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/include/mibspi.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/source/etpwm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/source/mibspi.c	(-8, +8)	\| History	\| Source	\| Diff
· /firmware/source/pinmux.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-0, +3)	\| History	\| Source	\| Diff