Fisheye on hdfirmware/firmware/App/Controllers/Valves.c https://devapps.diality.us/changelog/~br%3DDEN-5053-hd-air-trap/hdfirmware/firmware/App/Controllers/Valves.c Recent activity in "hdfirmware" under directory /firmware/App/Controllers/Valves.c hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-5053: Fixed merge conflicts from master. Re-ran local test script. Wed, 14 Oct 2020 09:44:17 -0700 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=e13152777df58456a873789fbfc3f889813109c9 https://devapps.diality.us/changelog/hdfirmware?cs=e13152777df58456a873789fbfc3f889813109c9 Sean Nash committed e131527 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 378 more in hdfirmware DEN-5053: Fixed merge conflicts from master. Re-ran local test script.

· /firmware/App/Controllers/Valves.c (-0, +16) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-0, +16) | History | Source | Diff
· /firmware/App/HDCommon.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeTreatmentParams.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/CommBuffers.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.c (-2, +2) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-2, +2) | History | Source | Diff
… 3 more files in changeset.
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces Tue, 13 Oct 2020 22:00:54 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=d5c5b1d2bc42b166f1ccff1aa4b2441db8f06d4b https://devapps.diality.us/changelog/hdfirmware?cs=d5c5b1d2bc42b166f1ccff1aa4b2441db8f06d4b Dara Navaei committed d5c5b1d on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 378 more in hdfirmware Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

· /firmware/App/Controllers/Valves.c (-0, +16) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-0, +16) | History | Source | Diff
· /firmware/App/HDCommon.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeTreatmentParams.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeTreatmentParams.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/CommBuffers.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.c (-2, +2) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-2, +2) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-5053: Fixed merge conflicts w/ valves branch. Mon, 12 Oct 2020 23:02:01 -0700 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=2d5157c59ced0866aaa32d9722d6f1ba28b0b18d https://devapps.diality.us/changelog/hdfirmware?cs=2d5157c59ced0866aaa32d9722d6f1ba28b0b18d Sean Nash committed 2d5157c on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 378 more in hdfirmware DEN-5053: Fixed merge conflicts w/ valves branch.

· /firmware/App/Controllers/Valves.c (-185, +261) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-3, +7) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-2, +6) | History | Source | Diff
· /firmware/App/Services/CommBuffers.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-13, +14) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +7) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +4) | History | Source | Diff
· /results/.gitignore (-0, +3) | History | Source | Diff
· /results/Build_Status_Report.csv (-0, +18) | History | Source | Diff
· /results/VectorCAST.log (-6713, +9451) | History | Source | Diff
· /results/cppcheck.log (-43, +53) | History | Source | Diff
· /results/cppcheckError.csv (-0, +49) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 updated the doxygen documentation and ran the test script Thu, 08 Oct 2020 17:26:25 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=ba882c318a6bedb3abe2f1fa4656dedbf2c60d9e https://devapps.diality.us/changelog/hdfirmware?cs=ba882c318a6bedb3abe2f1fa4656dedbf2c60d9e Dara Navaei committed ba882c3 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 updated the doxygen documentation and ran the test script

· /firmware/App/Controllers/Valves.c (-101, +67) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-1, +2) | History | Source | Diff
· /results/Build_Status_Report.csv (-1, +1) | History | Source | Diff
· /results/VectorCAST.log (-383, +383) | History | Source | Diff
· /results/cppcheckError.csv (-1, +1) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-5053: Added build switch for testing where 3-way valves are always open after homing. Wed, 07 Oct 2020 17:51:34 -0700 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=fd12aa494e60cc32852a32d1c3aa2b49eb013fdf https://devapps.diality.us/changelog/hdfirmware?cs=fd12aa494e60cc32852a32d1c3aa2b49eb013fdf Sean Nash committed fd12aa4 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 378 more in hdfirmware DEN-5053: Added build switch for testing where 3-way valves are always open after homing.

· /firmware/App/Controllers/Valves.c (-0, +10) | History | Source | Diff
· /firmware/App/HDCommon.h (-7, +8) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-3, +3) | History | Source | Diff
· /firmware/App/Modes/ModeTreatment.c (-0, +1) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 added another define for a larger range check in Position B during current relaxation Tue, 06 Oct 2020 10:34:04 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=3f2ea9e243b2c4ee4459b58348cdf74baf526c1a https://devapps.diality.us/changelog/hdfirmware?cs=3f2ea9e243b2c4ee4459b58348cdf74baf526c1a Dara Navaei committed 3f2ea9e on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 added another define for a larger range check in Position B during current relaxation

· /firmware/App/Controllers/Valves.c (-4, +13) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-1, +0) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 addressed the code review comments and worked on development testing Fri, 02 Oct 2020 16:37:00 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=db29226a158778db9c0bbcc202d3b56f9cf305c8 https://devapps.diality.us/changelog/hdfirmware?cs=db29226a158778db9c0bbcc202d3b56f9cf305c8 Dara Navaei committed db29226 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 addressed the code review comments and worked on development testing

· /firmware/App/Controllers/Valves.c (-14, +4) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-10, +0) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/CommBuffers.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-23, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-3, +0) | History | Source | Diff
· /firmware/source/sys_main.c (-3, +1) | History | Source | Diff
· /results/Build_Status_Report.csv (-16, +4) | History | Source | Diff
· /results/VectorCAST.log (-2026, +2608) | History | Source | Diff
· /results/cppcheckError.csv (-2, +2) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 Continued with development testing Wed, 30 Sep 2020 10:01:45 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=0074b704ffe85b2ad5600bcdf5e591e33808cdf5 https://devapps.diality.us/changelog/hdfirmware?cs=0074b704ffe85b2ad5600bcdf5e591e33808cdf5 Dara Navaei committed 0074b70 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 Continued with development testing

· /firmware/App/Controllers/Valves.c (-24, +1) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 addressed code review comments and continued dev testing Tue, 29 Sep 2020 18:10:20 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=a42f849450c65801f2d45ca9085af81a1f11269d https://devapps.diality.us/changelog/hdfirmware?cs=a42f849450c65801f2d45ca9085af81a1f11269d Dara Navaei committed a42f849 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 addressed code review comments and continued dev testing

· /firmware/App/Controllers/Valves.c (-88, +137) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-3, +9) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-0, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-20, +19) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-5053: Fixed doxygen function headers for inputs/outputs details section. Thu, 24 Sep 2020 11:25:06 -0700 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=37a8a58b766a496b39241dd7ae46dc10dbda35e4 https://devapps.diality.us/changelog/hdfirmware?cs=37a8a58b766a496b39241dd7ae46dc10dbda35e4 Sean Nash committed 37a8a58 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 378 more in hdfirmware DEN-5053: Fixed doxygen function headers for inputs/outputs details section.

· /firmware/App/Controllers/AirTrap.c (-54, +36) | History | Source | Diff
· /firmware/App/Controllers/AlarmLamp.c (-27, +18) | History | Source | Diff
· /firmware/App/Controllers/BloodFlow.c (-144, +96) | History | Source | Diff
· /firmware/App/Controllers/Buttons.c (-42, +28) | History | Source | Diff
· /firmware/App/Controllers/DGInterface.c (-78, +52) | History | Source | Diff
· /firmware/App/Controllers/DialInFlow.c (-144, +96) | History | Source | Diff
· /firmware/App/Controllers/DialOutFlow.c (-147, +98) | History | Source | Diff
· /firmware/App/Controllers/PresOccl.c (-81, +54) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-99, +66) | History | Source | Diff
· /firmware/App/Drivers/CPLD.c (-27, +18) | History | Source | Diff
· /firmware/App/Drivers/Comm.c (-51, +34) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-12, +8) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.c (-15, +10) | History | Source | Diff
· /firmware/App/Modes/Dialysis.c (-72, +48) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-9, +6) | History | Source | Diff
… 22 more files in changeset.
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-5053: Updated EMC test code to use valve functions. Added Dialin command for resetting f/w processor. Thu, 24 Sep 2020 10:57:24 -0700 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=61153247029a9a246ca1beadc66d772e3e583e4e https://devapps.diality.us/changelog/hdfirmware?cs=61153247029a9a246ca1beadc66d772e3e583e4e Sean Nash committed 6115324 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 378 more in hdfirmware DEN-5053: Updated EMC test code to use valve functions. Added Dialin command for resetting f/w processor.

· /firmware/App/Controllers/AirTrap.c (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-0, +3) | History | Source | Diff
· /firmware/App/HDCommon.h (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-16, +13) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-16, +20) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +25) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +3) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 Addressed code review comments and continued development testing Wed, 23 Sep 2020 10:19:57 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=dbcbd145954ef52510ac929a412e0dba42f0941b https://devapps.diality.us/changelog/hdfirmware?cs=dbcbd145954ef52510ac929a412e0dba42f0941b Dara Navaei committed dbcbd14 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 Addressed code review comments and continued development testing

· /firmware/App/Controllers/Valves.c (-60, +95) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-0, +3) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-0, +9) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +6) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +3) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-5053: Addressed code review feedback. Fixes to treatment workflow messaging with UI. Added an alarm lamp sync flag... Tue, 22 Sep 2020 19:03:38 -0700 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=d9d085cdca67200ecddbdfbc75c489e704b23081 https://devapps.diality.us/changelog/hdfirmware?cs=d9d085cdca67200ecddbdfbc75c489e704b23081 Sean Nash committed d9d085c on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 378 more in hdfirmware DEN-5053: Addressed code review feedback. Fixes to treatment workflow messaging with UI. Added an alarm lamp sync flag to alarm status message and increased transmission rate from 2 Hz to 4 Hz to allow alarm lamp sync flag to reach UI in timely manner. Added an assertion to give compiler error if new alarm is added to enumeration and not to alarm definition table. Update FPGA UT.

· /firmware/App/Controllers/AirTrap.c (-15, +19) | History | Source | Diff
· /firmware/App/Controllers/AirTrap.h (-3, +4) | History | Source | Diff
· /firmware/App/Controllers/AlarmLamp.c (-3, +22) | History | Source | Diff
· /firmware/App/Controllers/AlarmLamp.h (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/PresOccl.h (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-15, +9) | History | Source | Diff
· /firmware/App/HDCommon.h (-2, +4) | History | Source | Diff
· /firmware/App/Modes/Dialysis.c (-1, +2) | History | Source | Diff
· /firmware/App/Modes/ModePreTreat.c (-4, +38) | History | Source | Diff
· /firmware/App/Modes/ModePreTreat.h (-0, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-0, +7) | History | Source | Diff
· /firmware/App/Modes/ModeTreatment.c (-0, +4) | History | Source | Diff
· /firmware/App/Modes/ModeTreatmentParams.c (-0, +2) | History | Source | Diff
· /firmware/App/Modes/ModeTreatmentParams.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
… 8 more files in changeset.
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 Dev testing the code and addressing the code review comments Tue, 22 Sep 2020 13:39:33 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=4f4050a451d88043f170814d9929ff497dc43030 https://devapps.diality.us/changelog/hdfirmware?cs=4f4050a451d88043f170814d9929ff497dc43030 Dara Navaei committed 4f4050a on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 Dev testing the code and addressing the code review comments

· /firmware/App/Controllers/Valves.c (-46, +51) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-2, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-1, +11) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-5, +26) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +1) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 Unit tested valves.c. Added debug build switch for the valves PWM functions Fri, 18 Sep 2020 16:36:20 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=9725baecc8bf9720e4c27a4564b8aee3d62813e5 https://devapps.diality.us/changelog/hdfirmware?cs=9725baecc8bf9720e4c27a4564b8aee3d62813e5 Dara Navaei committed 9725bae on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 Unit tested valves.c. Added debug build switch for the valves PWM functions

· /firmware/App/Controllers/Valves.c (-33, +25) | History | Source | Diff
· /firmware/App/HDCommon.h (-1, +0) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-0, +8) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-6, +10) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 tested the code and updated the comments Thu, 17 Sep 2020 16:10:02 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=71e5d8968b369a4e94f65a40171f648f442b8f80 https://devapps.diality.us/changelog/hdfirmware?cs=71e5d8968b369a4e94f65a40171f648f442b8f80 Dara Navaei committed 71e5d89 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 tested the code and updated the comments

· /firmware/App/Controllers/Valves.c (-5, +3) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 updated the code after testing the PWM control mode Wed, 16 Sep 2020 10:36:17 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=b1c2d54d3d029ab1340d91193a7a4c81db8ba29d https://devapps.diality.us/changelog/hdfirmware?cs=b1c2d54d3d029ab1340d91193a7a4c81db8ba29d Dara Navaei committed b1c2d54 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 updated the code after testing the PWM control mode

· /firmware/App/Controllers/Valves.c (-63, +60) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-0, +10) | History | Source | Diff
· /firmware/App/HDCommon.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-5, +5) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 added a state to run the valves in bypass mode. Added a function to run the valves in bypass mode Sun, 13 Sep 2020 15:56:52 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=306243570641956ce4e2303380c9c0a02801726d https://devapps.diality.us/changelog/hdfirmware?cs=306243570641956ce4e2303380c9c0a02801726d Dara Navaei committed 3062435 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 added a state to run the valves in bypass mode. Added a function to run the valves in bypass mode

· /firmware/App/Controllers/Valves.c (-28, +270) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-0, +2) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-1, +112) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-0, +8) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +33) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +4) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 work in progress, added current relaxation to the valves module Fri, 11 Sep 2020 09:38:30 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=3477dd649f67442ad4bdea810ce5a251c1b0a2bf https://devapps.diality.us/changelog/hdfirmware?cs=3477dd649f67442ad4bdea810ce5a251c1b0a2bf Dara Navaei committed 3477dd6 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 work in progress, added current relaxation to the valves module

· /firmware/App/Controllers/Valves.c (-238, +373) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-5, +9) | History | Source | Diff
· /firmware/App/Modes/Dialysis.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeTreatment.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-20, +2) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-2, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +5) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-26, +27) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +1) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 Debugged the code Thu, 03 Sep 2020 19:12:12 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=85457b793bef9f18e2d04cbc8f901c138eae3609 https://devapps.diality.us/changelog/hdfirmware?cs=85457b793bef9f18e2d04cbc8f901c138eae3609 Dara Navaei committed 85457b7 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 Debugged the code

· /firmware/App/Controllers/Valves.c (-95, +81) | History | Source | Diff
· /firmware/App/HDCommon.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +3) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 addressed code review comments Wed, 02 Sep 2020 18:12:19 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=361e8cae2edec18e5ba1a26690788b5c30ce4833 https://devapps.diality.us/changelog/hdfirmware?cs=361e8cae2edec18e5ba1a26690788b5c30ce4833 Dara Navaei committed 361e8ca on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 addressed code review comments

· /firmware/App/Controllers/Valves.c (-223, +253) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-12, +10) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-16, +24) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-4, +4) | History | Source | Diff
· /results/Build_Status_Report.csv (-11, +51) | History | Source | Diff
· /results/VectorCAST.log (-1307, +10790) | History | Source | Diff
· /results/cppcheck.log (-43, +59) | History | Source | Diff
· /results/cppcheckError.csv (-73, +94) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 added NHET18 as a GIO for the VBT valve. Added gross check for the edges of the valves Thu, 27 Aug 2020 11:48:31 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=9224712d825c7ecee623abc78d704fbd3c2dbde8 https://devapps.diality.us/changelog/hdfirmware?cs=9224712d825c7ecee623abc78d704fbd3c2dbde8 Dara Navaei committed 9224712 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 added NHET18 as a GIO for the VBT valve. Added gross check for the edges of the valves

· /firmware/App/Controllers/Valves.c (-39, +75) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +29) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +4) | History | Source | Diff
· /firmware/HD.dil (-5, +5) | History | Source | Diff
· /firmware/include/het.h (-1, +1) | History | Source | Diff
· /firmware/source/het.c (-1, +1) | History | Source | Diff
· /firmware/source/pinmux.c (-1, +1) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 modified the homing sequence and worked on the unit test and integration test Tue, 25 Aug 2020 21:41:57 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=7ce686fa967206c341805b79916298ae187854de https://devapps.diality.us/changelog/hdfirmware?cs=7ce686fa967206c341805b79916298ae187854de Dara Navaei committed 7ce686f on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 modified the homing sequence and worked on the unit test and integration test

· /firmware/App/Controllers/Valves.c (-91, +48) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-3, +7) | History | Source | Diff
· /firmware/App/HDCommon.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +4) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 Initial commit of the valves unit test and integration test Sun, 23 Aug 2020 13:06:47 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=2b8e15565dbb160eeaca94e3126fc3e8a079a982 https://devapps.diality.us/changelog/hdfirmware?cs=2b8e15565dbb160eeaca94e3126fc3e8a079a982 Dara Navaei committed 2b8e155 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 Initial commit of the valves unit test and integration test

· /firmware/App/Controllers/Valves.c (-91, +81) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 added a temporary struct to publish the valves data every 10ms for characterization Sat, 22 Aug 2020 18:56:39 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=2a2d6a224532304e29f948fc43711ee6e99f915b https://devapps.diality.us/changelog/hdfirmware?cs=2a2d6a224532304e29f948fc43711ee6e99f915b Dara Navaei committed 2a2d6a2 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 added a temporary struct to publish the valves data every 10ms for characterization

· /firmware/App/Controllers/Valves.c (-3, +6) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-2, +3) | History | Source | Diff
· /firmware/App/Modes/ModeTreatmentParams.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeTreatmentParams.h (-27, +0) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +19) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +5) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 added another struct to publish valves data faster Fri, 21 Aug 2020 12:55:38 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=eb6bc75e3fef9936db1111751233cb4452315769 https://devapps.diality.us/changelog/hdfirmware?cs=eb6bc75e3fef9936db1111751233cb4452315769 Dara Navaei committed eb6bc75 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 added another struct to publish valves data faster

· /firmware/App/Controllers/Valves.c (-0, +4) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-0, +7) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-8, +0) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 work in progress. Added current and speed registers to the priority page of FPGA Thu, 20 Aug 2020 19:23:54 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=9d40104500ae1c144a19b36b83a0515d32fb7fc9 https://devapps.diality.us/changelog/hdfirmware?cs=9d40104500ae1c144a19b36b83a0515d32fb7fc9 Dara Navaei committed 9d40104 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 work in progress. Added current and speed registers to the priority page of FPGA

· /firmware/App/Controllers/Valves.c (-83, +157) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-0, +21) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-12, +30) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/MessagePayloads.h (-8, +0) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-6, +51) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +8) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 added override functions for the HD Valves module Sun, 16 Aug 2020 23:14:45 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=a6fec5578295ef0bb7223376facb7d0cbd2c1209 https://devapps.diality.us/changelog/hdfirmware?cs=a6fec5578295ef0bb7223376facb7d0cbd2c1209 Dara Navaei committed a6fec55 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 added override functions for the HD Valves module

· /firmware/App/Controllers/Valves.c (-38, +97) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-0, +4) | History | Source | Diff
· /firmware/App/Services/MessagePayloads.h (-0, +8) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-2, +48) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +4) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 Added comments and headers to the functions in valves.c Sun, 16 Aug 2020 18:09:46 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=28dd261825b2c742df73042ac2902db0c8f6f2b7 https://devapps.diality.us/changelog/hdfirmware?cs=28dd261825b2c742df73042ac2902db0c8f6f2b7 Dara Navaei committed 28dd261 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 Added comments and headers to the functions in valves.c

· /firmware/App/Controllers/Valves.c (-284, +606) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-12, +14) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-0, +4) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-0, +56) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-5, +9) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +5) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +4) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-4308 worked on the valves homing sequence Fri, 14 Aug 2020 00:08:28 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=62db7c6218b47db4ef80e1b528228a8887545aad https://devapps.diality.us/changelog/hdfirmware?cs=62db7c6218b47db4ef80e1b528228a8887545aad Dara Navaei committed 62db7c6 on branch master, DEN-10153_Treatment_Log_Prescribed_UF and 379 more in hdfirmware DEN-4308 worked on the valves homing sequence

· /firmware/App/Controllers/Valves.c (-143, +335) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-14, +2) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-0, +7) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-11, +11) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-10, +10) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.c (-1, +1) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-1, +4) | History | Source | Diff
]]>