Fisheye on dgfirmware/firmware/App/Services/Reservoirs.h

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Addressed code reviews

Tue, 10 Nov 2020 11:05:11 -0800

Quang Nguyen committed 62ee40b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Addressed code reviews

· /firmware/App/Controllers/ConcentratePumps.c	(-86, +57)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-43, +9)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-18, +18)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-10, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Moved target fill reached logic inside reservoir module

Thu, 22 Oct 2020 09:52:38 -0700

Quang Nguyen committed 945dcc1 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Moved target fill reached logic inside reservoir module

· /firmware/App/Modes/ModeFill.c	(-8, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-46, +68)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-3, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-3504: Refactor load cell and reservoirs modules

Thu, 08 Oct 2020 16:09:33 -0700

Quang Nguyen committed 87a22cb on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 228 more in dgfirmware

DEN-3504: Refactor load cell and reservoirs modules

· /firmware/App/Controllers/LoadCell.c	(-45, +58)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.h	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-32, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-43, +133)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-4, +16)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Dara Navaei — Mon, 31 Aug 2020 13:43:47 -0700

Dara Navaei committed 54f45c3 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 231 more in dgfirmware

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-2, +2)

| History

| Source

| Diff

… 61 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4534: Expand override macros

Tue, 25 Aug 2020 11:53:07 -0700

Quang Nguyen committed 99f108a on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 233 more in dgfirmware

DEN-4534: Expand override macros

· /firmware/App/Services/AlarmMgmt.c	(-6, +24)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-27, +485)	\| History	\| Source	\| Diff
· /firmware/App/Services/WatchdogMgmt.c	(-8, +69)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-4534: Updated doxygen for App/Services

Mon, 24 Aug 2020 19:44:13 -0700

Quang Nguyen committed 5e0cd9b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 233 more in dgfirmware

DEN-4534: Updated doxygen for App/Services

· /firmware/App/Services/AlarmMgmt.c

(-51, +43)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.h

(-21, +18)

| History

| Source

| Diff

· /firmware/App/Services/CommBuffers.c

(-59, +58)

| History

| Source

| Diff

· /firmware/App/Services/CommBuffers.h

(-18, +30)

| History

| Source

| Diff

· /firmware/App/Services/FPGA.c

(-195, +193)

| History

| Source

| Diff

· /firmware/App/Services/FPGA.h

(-1, +11)

| History

| Source

| Diff

· /firmware/App/Services/Interrupts.c

(-18, +19)

| History

| Source

| Diff

· /firmware/App/Services/MessagePayloads.h

(-50, +65)

| History

| Source

| Diff

· /firmware/App/Services/MsgQueues.c

(-25, +31)

| History

| Source

| Diff

· /firmware/App/Services/MsgQueues.h

(-15, +30)

| History

| Source

| Diff

· /firmware/App/Services/PIControllers.c

(-20, +19)

| History

| Source

| Diff

· /firmware/App/Services/PIControllers.h

(-17, +16)

| History

| Source

| Diff

· /firmware/App/Services/Reservoirs.c

(-40, +31)

| History

| Source

| Diff

· /firmware/App/Services/Reservoirs.h

(-5, +4)

| History

| Source

| Diff

· /firmware/App/Services/SystemComm.c

(-63, +58)

| History

| Source

| Diff

… 5 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Dara Navaei — Wed, 08 Jul 2020 16:59:23 -0700

Dara Navaei committed a7bf3ca on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 237 more in dgfirmware

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

· /firmware/App/Controllers/DrainPump.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-15, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-15, +16)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-9, +10)

| History

| Source

| Diff

… 60 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-2650 merged DEN-2379

Dara Navaei — Thu, 04 Jun 2020 11:07:50 -0700

Dara Navaei committed a504d68 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

DEN-2650 merged DEN-2379

· /firmware/.launches/DG.launch

(-0, +2)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-2, +3)

| History

| Source

| Diff

· /firmware/App/Drivers/SafetyShutdown.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-1, +15)

| History

| Source

| Diff

· /firmware/App/Modes/ModeRecirculate.c

(-0, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeSolo.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeSolo.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Services/FPGA.c

(-3, +40)

| History

| Source

| Diff

· /firmware/App/Services/PIControllers.c

(-2, +3)

| History

| Source

| Diff

· /firmware/App/Services/Reservoirs.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Services/Reservoirs.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Services/SystemComm.c

(-0, +11)

| History

| Source

| Diff

· /firmware/App/Services/SystemCommMessages.c

(-16, +159)

| History

| Source

| Diff

· /firmware/App/Services/SystemCommMessages.h

(-1, +15)

| History

| Source

| Diff

· /firmware/App/Tasks/TaskGeneral.c

(-0, +6)

| History

| Source

| Diff

… 3 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Merged prelim temp and heater modules from dev branch.

Sean Nash — Fri, 24 Apr 2020 09:50:47 -0700

Sean Nash committed 2496e92 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Merged prelim temp and heater modules from dev branch.

· /firmware/App/Controllers/DrainPump.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-0, +237)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.h	(-0, +42)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-0, +631)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.h	(-0, +43)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-4, +23)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskPriority.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/DG.dil	(-16, +16)	\| History	\| Source	\| Diff
· /firmware/include/etpwm.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/source/etpwm.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-0, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Added more mode handling and associated messaging.

Sean Nash — Mon, 20 Apr 2020 14:15:42 -0700

Sean Nash committed c48a99d on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Added more mode handling and associated messaging.

· /firmware/App/Controllers/LoadCell.c

(-64, +39)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.h

(-3, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-28, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-4, +3)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-7, +33)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.h

(-1, +12)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDisinfect.c

(-63, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDisinfect.h

(-28, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-9, +67)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.h

(-2, +13)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-10, +36)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.h

(-1, +12)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-49, +27)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-11, +38)

| History

| Source

| Diff

… 22 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Added messaging between HD and DG.

Sean Nash — Wed, 08 Apr 2020 16:14:13 -0700

Sean Nash committed 5ff39fd on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Added messaging between HD and DG.

· /firmware/App/Modes/OperationModes.c	(-0, +17)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-0, +23)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-6, +69)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +6)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-0, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Added new messaging between HD and DG.

Sean Nash — Wed, 08 Apr 2020 13:39:46 -0700

Sean Nash committed 5a61bcc on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 238 more in dgfirmware

Added new messaging between HD and DG.

· /firmware/.cproject	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-18, +23)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-4, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +28)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-4, +249)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +24)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Updated the Copyright with the current year and replaced tabs with 4 spaces

Dara Navaei — Fri, 03 Apr 2020 16:27:51 -0700

Dara Navaei committed fbf0498 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 241 more in dgfirmware

Updated the Copyright with the current year and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeSolo.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeSolo.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Rewrote load cells module.

Sean Nash — Sun, 22 Mar 2020 18:10:34 -0700

Sean Nash committed 8b56b0c on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 242 more in dgfirmware

Rewrote load cells module.

· /firmware/App/Controllers/LoadCell.c	(-146, +159)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.h	(-27, +35)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SensorProcess.c	(-34, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SensorProcess.h	(-26, +0)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/InternalADC.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/InternalADC.h	(-2, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-14, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-40, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-11, +2)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskPriority.c	(-3, +7)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Updated Reservoirs module.

Sean Nash — Thu, 19 Mar 2020 09:58:45 -0700

Sean Nash committed f6413fe on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 242 more in dgfirmware

Updated Reservoirs module.

· /firmware/App/Services/Reservoirs.c	(-32, +302)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-1, +25)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Added solo standby mode. Added Reservoirs service module. Updates to Standby mode.

Sean Nash — Wed, 18 Mar 2020 21:59:09 -0700

Sean Nash committed f267c42 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 242 more in dgfirmware

Added solo standby mode. Added Reservoirs service module. Updates to Standby mode.

· /firmware/App/DGCommon.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeSolo.c	(-0, +64)	\| History	\| Source
· /firmware/App/Modes/ModeSolo.h	(-0, +28)	\| History	\| Source
· /firmware/App/Modes/ModeStandby.c	(-0, +52)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-15, +24)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.h	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-0, +112)	\| History	\| Source
· /firmware/App/Services/Reservoirs.h	(-0, +39)	\| History	\| Source
· /firmware/App/Services/SystemComm.c	(-54, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-25, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-5, +0)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-11, +0)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-0, +2)	\| History	\| Source	\| Diff