Fisheye on dialin/Scripts https://devapps.diality.us/changelog/~br%3DDEN-6372-hd-rinseback/dialin/Scripts Recent activity in "dialin" under directory /Scripts DIALIN-ACK-1: closed by Dara Navaei Thu, 19 Oct 2023 13:19:52 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-ACK-1 https://devapps.diality.us/cru/DIALIN-ACK-1 Dara Navaei Closed DIALIN-ACK-1 ]]> DIALIN-ACK-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 13:19:42 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-ACK-1/#c19201 https://devapps.diality.us/cru/DIALIN-ACK-1/#c19201 Dara Navaei replied to Behrouz NematiPour in DIALIN-ACK-1

RESOLVED

]]> DIALIN-ACK-1: started by Dara Navaei Thu, 19 Oct 2023 13:19:20 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-ACK-1 https://devapps.diality.us/cru/DIALIN-ACK-1 Dara Navaei started review DIALIN-ACK-1 ]]> DIALIN-ACK-1: closed by plucia Tue, 28 Apr 2020 16:46:12 -0700 plucia https://devapps.diality.us/cru/DIALIN-ACK-1 https://devapps.diality.us/cru/DIALIN-ACK-1 plucia  (deleted user) Closed DIALIN-ACK-1 ]]> DIALIN-ACK-1: reviewers finished Tue, 28 Apr 2020 08:35:00 -0700 https://devapps.diality.us/cru/DIALIN-ACK-1 https://devapps.diality.us/cru/DIALIN-ACK-1 pmontazemi  (deleted user) finished reviewing DIALIN-ACK-1 DIALIN-ACK ]]> DIALIN-ACK-1: comment by pmontazemi "RESOLVED." Tue, 28 Apr 2020 08:34:55 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1716 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1716 pmontazemi  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-ACK-1

RESOLVED.

]]> DIALIN-ACK-1: comment by pmontazemi "This code has been modified since." Tue, 28 Apr 2020 08:34:48 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1715 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1715 pmontazemi  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-ACK-1

This code has been modified since.

]]> DIALIN-ACK-1: reviewers finished Wed, 01 Apr 2020 12:46:59 -0700 https://devapps.diality.us/cru/DIALIN-ACK-1 https://devapps.diality.us/cru/DIALIN-ACK-1 Behrouz NematiPour finished reviewing DIALIN-ACK-1 DIALIN-ACK ]]> DIALIN-ACK-1: comment by Behrouz NematiPour "I would keep bytearray as one word since it's a..." Wed, 01 Apr 2020 11:02:34 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-ACK-1/#c1600 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1600 Behrouz NematiPour commented on DIALIN-ACK-1

I would keep bytearray as one word since it's a python type .

]]> DIALIN-ACK-1: comment by pmontazemi "RESOLVED." Wed, 01 Apr 2020 08:44:30 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1599 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1599 pmontazemi  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-ACK-1

RESOLVED.

]]> DIALIN-ACK-1: comment by pmontazemi "RESOLVED." Wed, 01 Apr 2020 08:44:01 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1598 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1598 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-ACK-1

RESOLVED.

]]> DIALIN-ACK-1: comment by pmontazemi "RESOLVED." Wed, 01 Apr 2020 08:43:30 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1597 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1597 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-ACK-1

RESOLVED.

]]> DIALIN-ACK-1: comment by pmontazemi "RESOLVED." Wed, 01 Apr 2020 08:42:56 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1596 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1596 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-ACK-1

RESOLVED.

]]> DIALIN-ACK-1: comment by pmontazemi "RESOLVED." Wed, 01 Apr 2020 08:42:47 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1595 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1595 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-ACK-1

RESOLVED.

]]> DIALIN-ACK-1: comment by pmontazemi "RESOLVED." Wed, 01 Apr 2020 08:42:38 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1594 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1594 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-ACK-1

RESOLVED.

]]> DIALIN-ACK-1: comment by plucia "Requested changes are now added" Tue, 31 Mar 2020 11:57:35 -0700 plucia https://devapps.diality.us/cru/DIALIN-ACK-1/#c1589 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1589 plucia  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-ACK-1

Requested changes are now added

]]> DIALIN-ACK-1: comment by plucia "For now, I've updated them here manually (see l..." Tue, 31 Mar 2020 11:57:25 -0700 plucia https://devapps.diality.us/cru/DIALIN-ACK-1/#c1588 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1588 plucia  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-ACK-1

For now, I've updated them here manually (see latest changes)

]]> DIALIN-ACK-1: comment by plucia "Requested changes are now added" Tue, 31 Mar 2020 11:56:35 -0700 plucia https://devapps.diality.us/cru/DIALIN-ACK-1/#c1587 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1587 plucia  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-ACK-1

Requested changes are now added

]]> DIALIN-ACK-1: comment by plucia "This script has only been moved or renamed, as ..." Tue, 31 Mar 2020 09:47:01 -0700 plucia https://devapps.diality.us/cru/DIALIN-ACK-1/#c1586 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1586 plucia  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-ACK-1

This script has only been moved or renamed, as I am not the original author.
In this section, it appears to just be emitting a dummy payload to the DG sync broadcast channel id every second. I don't see how it could interfere with other messages being sent on the CAN bus since it is just adding a little traffic to the bus once every second. The type of other nodes on the bus shouldn't matter.

]]> DIALIN-ACK-1: comment by plucia "No, I think we need to separate them, potential..." Tue, 31 Mar 2020 09:34:08 -0700 plucia https://devapps.diality.us/cru/DIALIN-ACK-1/#c1585 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1585 plucia  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-ACK-1

No, I think we need to separate them, potentially putting them in a different repository altogether in the future

To avoid deleting people's work, I didn't delete test scripts in this commit. In future commits, I will reach out to people and let them know before they are deleted or moved

]]> DIALIN-ACK-1: reviewers removed from DIALIN-ACK Sat, 28 Mar 2020 11:03:54 -0700 https://devapps.diality.us/cru/DIALIN-ACK-1 https://devapps.diality.us/cru/DIALIN-ACK-1 Dara Navaei removed Dara Navaei and snejatali  (deleted user) from DIALIN-ACK-1 DIALIN-ACK ]]> DIALIN-ACK-1: comment by pmontazemi "Generally speaking, do we want to have a mix of..." Fri, 27 Mar 2020 09:21:48 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1528 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1528 pmontazemi  (deleted user) commented on DIALIN-ACK-1

Generally speaking, do we want to have a mix of Dialin API code and Python test scripts?

]]> DIALIN-ACK-1: comment by pmontazemi "Provide """ """ section in class header, ..." Fri, 27 Mar 2020 08:59:13 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1527 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1527 pmontazemi  (deleted user) commented on DIALIN-ACK-1

Provide """ """ section in class header, also provide the process by which these channel IDs get updated, using which files, located where.

]]> DIALIN-ACK-1: comment by pmontazemi "Author should list only last person who touched..." Fri, 27 Mar 2020 08:44:41 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1526 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1526 pmontazemi  (deleted user) commented on DIALIN-ACK-1

Author should list only last person who touched this code.

]]> DIALIN-ACK-1: comment by pmontazemi "This functions shall be updated because there a..." Fri, 27 Mar 2020 08:43:26 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1525 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1525 pmontazemi  (deleted user) commented on DIALIN-ACK-1

This functions shall be updated because there are more details to the various DG states and related modes of operation (not as simple as fill and drain).

]]> DIALIN-ACK-1: comment by pmontazemi "Once Dialin is added to nightly builds, dates a..." Fri, 27 Mar 2020 08:39:29 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1524 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1524 pmontazemi  (deleted user) commented on DIALIN-ACK-1

Once Dialin is added to nightly builds, dates and authors will be updated as well.

]]> DIALIN-ACK-1: comment by pmontazemi "Isn't the 1 second sleep going to interfere wit..." Fri, 27 Mar 2020 08:36:54 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1523 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1523 pmontazemi  (deleted user) commented on DIALIN-ACK-1

Isn't the 1 second sleep going to interfere with the faster messages transmitted and received by the laptop+CAN Analyzer node?

]]> DIALIN-ACK-1: comment by pmontazemi "Remove extra line" Fri, 27 Mar 2020 08:36:06 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-ACK-1/#c1522 https://devapps.diality.us/cru/DIALIN-ACK-1/#c1522 pmontazemi  (deleted user) commented on DIALIN-ACK-1

Remove extra line

]]> dialin (DEN-12358-sw_dev-sprint-67_mg): Restructured the repository, more refactoring. Wed, 25 Mar 2020 18:06:23 -0700 Peter Lucia <plucia@diality.com> https://devapps.diality.us/changelog/dialin?cs=68137f3ef7ad8dac0e1209b50272ba613543e2d9 https://devapps.diality.us/changelog/dialin?cs=68137f3ef7ad8dac0e1209b50272ba613543e2d9 Peter Lucia <plucia@diality.com> committed 68137f3 on branch 2020_EOY_DEMO, Calibration_fixes and 297 more in dialin Restructured the repository, more refactoring.

· /DG/DG_Firmware_Simulator.py (-0, +39) | History | Source
· /DG/DialIn (-0, +1) | History | Source
· /DG/DialysateGenerator.py (-0, +273) | History | Source
· /DialIn/CoreCANProtocol.py (-0, +699) | History | Source
· /DialityCoreCanProtocol.py (-699, +0) | History | Source | Diff
· /DialysateGenerator.py (-271, +0) | History | Source | Diff
· /Document/Doxyfile (-0, +2503) | History | Source
· /Document/logo.jpg (binary) | History | Source
· /Document/run_documentation_locally.sh (-0, +4) | History | Source
· /HD/DialIn (-0, +1) | History | Source
· /HD/HD_DialOutFlow.py (-0, +164) | History | Source
· /HD/HD_TestScript.py (-0, +59) | History | Source
· /HD/HemodialysisDevice.py (-0, +2731) | History | Source
· /HD_DialOutFlow.py (-164, +0) | History | Source | Diff
· /HemodialysisDevice.py (-2731, +0) | History | Source | Diff
… 11 more files in changeset.
]]> dialin (DEN-12358-sw_dev-sprint-67_mg): Continued refactoring, improved logging Wed, 25 Mar 2020 16:28:37 -0700 Peter Lucia <plucia@diality.com> https://devapps.diality.us/changelog/dialin?cs=b93c9ea734481269f9c7423d15d42d6bf8e2f85a https://devapps.diality.us/changelog/dialin?cs=b93c9ea734481269f9c7423d15d42d6bf8e2f85a Peter Lucia <plucia@diality.com> committed b93c9ea on branch 2020_EOY_DEMO, Calibration_fixes and 297 more in dialin Continued refactoring, improved logging

· /.gitignore (-0, +1) | History | Source | Diff
· /DialityCoreCanProtocol.py (-34, +40) | History | Source | Diff
· /DialysateGenerator.py (-2, +3) | History | Source | Diff
· /HemodialysisDevice.py (-1, +1) | History | Source | Diff
· /Miscellaneous/DG_Firmware_Simulator.py (-39, +0) | History | Source | Diff
· /Miscellaneous/HD_TestScript.py (-62, +0) | History | Source | Diff
· /Scripts/DG_Firmware_Simulator.py (-0, +39) | History | Source
· /Scripts/HD_TestScript.py (-0, +59) | History | Source
]]>