DIALIN-ACK-1 DIALIN-ACK

closed on 19 Oct 23

Author

Moderator

Reviewers

DIALIN-ACK

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 51

dialin 0
- Folder DG 0
  - File DG_Firmware_Simulator.py 6 Remove
  - File DialIn 0 Remove
  - File DialysateGenerator.py 8 Remove
- Folder DialIn 0
  - File CoreCANProtocol.py 5 Remove
- Folder Document 0
  - File Doxyfile 0 Remove
  - File logo.jpg 0 Remove
  - File run_documentation_locally.sh 0 Remove
- Folder HD 0
  - File Alarms.py 0 Remove
  - File Basics.py 0 Remove
  - File BloodFlow.py 0 Remove
  - File Buttons.py 0 Remove
  - File DialIn 0 Remove
  - File DialysateInletFlow.py 0 Remove
  - File DialysateOutletFlow.py 0 Remove
  - File HD_DialOutFlow.py 0 Remove
  - File HD_TestScript.py 3 Remove
  - File HemodialysisDevice.py 0 Remove
  - File PressureOcclusion.py 0 Remove
  - File RTC.py 0 Remove
  - File Treatment.py 0 Remove
  - File UI.py 0 Remove
  - File Watchdog.py 0 Remove
  - File utils.py 0 Remove
- Folder Miscellaneous 0
  - File DG_Firmware_Simulator.py 0 Remove
  - File HD_TestScript.py 0 Remove
- Folder Scripts 0
  - File DG_Firmware_Simulator.py 0 Remove
  - File HD_TestScript.py 0 Remove
- Folder Tools 0
  - File document.sh 0 Remove
  - File setup_canbus.sh 0 Remove
  - File setup_environment.sh 0 Remove
  - File setup_environment_windows.bat 0 Remove
  - File setup_virtual_can.sh 0 Remove
- Folder document 0
  - File Doxyfile 0 Remove
  - File logo.jpg 0 Remove
  - File runDocumentationLocally 0 Remove
- Folder images 0
  - File logo.jpg 0 Remove
- File .gitignore 0 Remove
- File DialityCoreCanProtocol.py 0 Remove
- File DialysateGenerator.py 0 Remove
- File Doxyfile 0 Remove
- File HD_DialOutFlow.py 0 Remove
- File HemodialysisDevice.py 0 Remove
- File README.md 0 Remove
- File activate_environment_windows.bat 0 Remove
- File requirements.txt 0 Remove
- File setup_canbus.sh 0 Remove
- File setup_environment.sh 0 Remove
- File setup_environment_windows.bat 0 Remove
- File setup_virtual_can.sh 0 Remove
- File setupcanbus.sh 0 Remove
- File setupenvironment.sh 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
plucia (deleted user)	Author & Moderator	1h 5m	5	Requested changes are now added
Behrouz NematiPour	Reviewer - Complete	2h 42m	1	I would keep bytearray as one word since it's a python ty...
pmontazemi (deleted user)	Reviewer - Complete	1h 13m	15	RESOLVED.
Total		5h	22

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-ACK-1

DIALIN-ACK

DIALIN-ACK-1 22

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DIALIN-ACK

DIALIN-ACK-1 22

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time