Fisheye on dgfirmware/firmware/App/Modes/ModeDrain.c https://devapps.diality.us/changelog/~br%3DDEN-9906-hd_dev-flow-measurement-changes/dgfirmware/firmware/App/Modes/ModeDrain.c Recent activity in "dgfirmware" under directory /firmware/App/Modes/ModeDrain.c dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Fixed merge conflicts from staging. Fri, 12 Nov 2021 11:04:28 -0800 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=dcd360fb4dc37db2dcbeb7fb14fb327fe68235f4 https://devapps.diality.us/changelog/dgfirmware?cs=dcd360fb4dc37db2dcbeb7fb14fb327fe68235f4 Sean Nash committed dcd360f on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware DEN-9906: Fixed merge conflicts from staging.

· /firmware/App/Controllers/ConcentratePumps.c (-11, +22) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-49, +132) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-450, +454) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-35, +57) | History | Source | Diff
· /firmware/App/DGCommon.h (-8, +10) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-39, +71) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.h (-7, +7) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-10, +14) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-46, +147) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-22, +31) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-27, +65) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-18, +34) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-6, +6) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-6, +6) | History | Source | Diff
· /firmware/App/Services/CommBuffers.c (-6, +6) | History | Source | Diff
… 9 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 11 Nov 2021 10:57:02 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=94a190522ce398399c7b93c59f788d7666ec0060 https://devapps.diality.us/changelog/dgfirmware?cs=94a190522ce398399c7b93c59f788d7666ec0060 Dara Navaei committed 94a1905 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-0, +16) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-0, +16) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.h (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-6, +6) | History | Source | Diff
… 78 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480 addressed the code review comments Sat, 06 Nov 2021 19:24:52 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=622eebf6fb7f1c6c232ffd82bc072dd30a7b3f94 https://devapps.diality.us/changelog/dgfirmware?cs=622eebf6fb7f1c6c232ffd82bc072dd30a7b3f94 Dara Navaei committed 622eebf on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware DEN-9480 addressed the code review comments

· /firmware/App/Controllers/ConductivitySensors.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-6, +10) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-17, +26) | History | Source | Diff
· /firmware/App/Controllers/Switches.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/Thermistors.c (-1, +3) | History | Source | Diff
· /firmware/App/Controllers/UVReactors.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-2, +5) | History | Source | Diff
· /firmware/App/Controllers/Voltages.c (-2, +3) | History | Source | Diff
· /firmware/App/DGCommon.h (-1, +2) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-3, +4) | History | Source | Diff
… 16 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480, DEN-10788 continued working on the heaters control and added code to be able override the drain pump RPM once ... Wed, 03 Nov 2021 21:26:24 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=26f63d0260a3c35277e3e6dbca3573c253775318 https://devapps.diality.us/changelog/dgfirmware?cs=26f63d0260a3c35277e3e6dbca3573c253775318 Dara Navaei committed 26f63d0 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware DEN-9480, DEN-10788 continued working on the heaters control and added code to be able override the drain pump RPM once the pump is in the open loop mode

· /firmware/App/Controllers/DrainPump.c (-36, +99) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-2, +8) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-49, +106) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-0, +4) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-1, +1) | History | Source | Diff
· /firmware/App/DGCommon.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.c (-4, +6) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.h (-1, +8) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-27, +56) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-4, +24) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-3, +3) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-10, +14) | History | Source | Diff
… 3 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480 added the return state to all the modes' transition function Sun, 24 Oct 2021 10:31:36 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=af0faf02f1bd7bffcce083e9b52988a01c343d8e https://devapps.diality.us/changelog/dgfirmware?cs=af0faf02f1bd7bffcce083e9b52988a01c343d8e Dara Navaei committed af0faf0 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware DEN-9480 added the return state to all the modes' transition function

· /firmware/App/Modes/ModeChemicalDisinfect.c (-2, +4) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-2, +4) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-2, +6) | History | Source | Diff
· /firmware/App/Modes/ModeFault.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +3) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-3, +5) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-3, +5) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-2, +4) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-7, +10) | History | Source | Diff
… 9 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480 added events to the firmware Thu, 14 Oct 2021 10:33:39 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=2468e56fbecd26da713bc78535bd727f4b105fe1 https://devapps.diality.us/changelog/dgfirmware?cs=2468e56fbecd26da713bc78535bd727f4b105fe1 Dara Navaei committed 2468e56 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware DEN-9480 added events to the firmware

· /firmware/App/Controllers/Heaters.c (-188, +17) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-14, +16) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-0, +38) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-0, +2) | History | Source | Diff
· /firmware/App/DGCommon.h (-1, +2) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-1, +3) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-35, +73) | History | Source | Diff
· /firmware/App/Modes/ModeFill.h (-1, +4) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-7, +7) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-3, +3) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-0, +10) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-1, +16) | History | Source | Diff
· /firmware/App/Services/FPGA.h (-0, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +35) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +3) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Don't exit fill on integrated volume per flow. Fix RO flow handling when flow is zero. Sun, 26 Sep 2021 16:06:44 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=012ee7b4f72e47aa351eb723abca0e3104ea677b https://devapps.diality.us/changelog/dgfirmware?cs=012ee7b4f72e47aa351eb723abca0e3104ea677b Sean Nash committed 012ee7b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware DEN-9906: Don't exit fill on integrated volume per flow. Fix RO flow handling when flow is zero.

· /firmware/App/Controllers/ROPump.c (-19, +14) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-4, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-3, +12) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480, DEN-10419, DEN-10420 addressed the bugs in the mentioned bugs Sun, 26 Sep 2021 13:35:16 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=2c4dfa08ac8ead07939b4f6aba3b0073e0997706 https://devapps.diality.us/changelog/dgfirmware?cs=2c4dfa08ac8ead07939b4f6aba3b0073e0997706 Dara Navaei committed 2c4dfa0 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware DEN-9480, DEN-10419, DEN-10420 addressed the bugs in the mentioned bugs

· /firmware/App/Controllers/Heaters.c (-33, +37) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-1, +3) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-0, +10) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +4) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-5, +5) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Fixed concentrate pump set speeds over max bug. Thu, 23 Sep 2021 15:51:42 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=9df373d768695a399a141d5224bff88bea4efff5 https://devapps.diality.us/changelog/dgfirmware?cs=9df373d768695a399a141d5224bff88bea4efff5 Sean Nash committed 9df373d on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware DEN-9906: Fixed concentrate pump set speeds over max bug.

· /firmware/App/Modes/ModeDrain.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-2, +4) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Continuously command actuators to safe state in fault mode. Stop and disable drain pump after drain completes... Tue, 21 Sep 2021 08:34:45 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=fd00681acd671946bfb1504d17b6414d6af9e0af https://devapps.diality.us/changelog/dgfirmware?cs=fd00681acd671946bfb1504d17b6414d6af9e0af Sean Nash committed fd00681 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware DEN-9906: Continuously command actuators to safe state in fault mode. Stop and disable drain pump after drain completes in drain mode.

· /firmware/App/Modes/ModeDrain.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-0, +2) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480 merged staging Fri, 03 Sep 2021 17:31:48 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=54e58f64179ea382d2e2c403c8c3b9a15a612636 https://devapps.diality.us/changelog/dgfirmware?cs=54e58f64179ea382d2e2c403c8c3b9a15a612636 Dara Navaei committed 54e58f6 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware DEN-9480 merged staging

· /firmware/App/Controllers/Fans.c (-21, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-484, +38) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-12, +2) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-22, +2) | History | Source | Diff
· /firmware/App/Controllers/Switches.c (-22, +1) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-23, +3) | History | Source | Diff
· /firmware/App/Controllers/Thermistors.c (-22, +1) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-7, +7) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-10, +5) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-16, +18) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-124, +266) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-58, +9) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-0, +239) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-107, +10) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-1, +2) | History | Source | Diff
… 6 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Added rinse concentrate lines state in drain mode Fri, 03 Sep 2021 11:00:24 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=24dd186948c13ae8e1ff88c14cc4f478e739ee0b https://devapps.diality.us/changelog/dgfirmware?cs=24dd186948c13ae8e1ff88c14cc4f478e739ee0b Quang Nguyen <qnguyen@diality.com> committed 24dd186 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware DEN-9906: Added rinse concentrate lines state in drain mode

· /firmware/App/Modes/ModeDrain.c (-7, +74) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-0, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.h (-2, +3) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Added 5 minutes wait time for HD comm timeout before transition back to standby Fri, 27 Aug 2021 14:50:00 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=a1452dc7f16d37db53930c3d73992098709d7915 https://devapps.diality.us/changelog/dgfirmware?cs=a1452dc7f16d37db53930c3d73992098709d7915 Quang Nguyen <qnguyen@diality.com> committed a1452dc on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware DEN-7802: Added 5 minutes wait time for HD comm timeout before transition back to standby

· /firmware/App/Modes/ModeDrain.c (-6, +0) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-6, +0) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +14) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Removed V2 system define Wed, 18 Aug 2021 00:56:17 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=7ed011e79e1338f614cbcc7d3cedf07d359196b7 https://devapps.diality.us/changelog/dgfirmware?cs=7ed011e79e1338f614cbcc7d3cedf07d359196b7 Quang Nguyen <qnguyen@diality.com> committed 7ed011e on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware DEN-7802: Removed V2 system define

· /firmware/App/Controllers/Heaters.c (-6, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-47, +3) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-7, +0) | History | Source | Diff
· /firmware/App/DGCommon.h (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-6, +0) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-52, +1) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-97, +0) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-12, +0) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-6, +0) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Addressed code reviews Thu, 12 Aug 2021 23:04:05 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=51bdd8eedc05856cf35998d1348e3138edecfaf8 https://devapps.diality.us/changelog/dgfirmware?cs=51bdd8eedc05856cf35998d1348e3138edecfaf8 Quang Nguyen <qnguyen@diality.com> committed 51bdd8e on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware DEN-7802: Addressed code reviews

· /firmware/App/Modes/ModeDrain.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/Interrupts.c (-10, +1) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-4, +4) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Refactor re-circ mode to generation idle mode Fri, 06 Aug 2021 14:12:39 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=1c74566ff86f1df5e1929b8715d68715dc21a93b https://devapps.diality.us/changelog/dgfirmware?cs=1c74566ff86f1df5e1929b8715d68715dc21a93b Quang Nguyen <qnguyen@diality.com> committed 1c74566 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware DEN-7802: Refactor re-circ mode to generation idle mode

· /firmware/App/Modes/ModeDrain.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-8, +8) | History | Source | Diff
· /firmware/App/Modes/ModeGenIdle.c (-0, +226) | History | Source
· /firmware/App/Modes/ModeGenIdle.h (-0, +46) | History | Source
· /firmware/App/Modes/ModeRecirculate.c (-256, +0) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.h (-46, +0) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-3, +3) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-11, +11) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-15, +15) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/WatchdogMgmt.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Implemented fill mode with new changes Mon, 19 Jul 2021 16:27:05 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=5d82009d1baa2b52122065934481745bf4de223b https://devapps.diality.us/changelog/dgfirmware?cs=5d82009d1baa2b52122065934481745bf4de223b Quang Nguyen <qnguyen@diality.com> committed 5d82009 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware DEN-7802: Implemented fill mode with new changes

· /firmware/App/Controllers/ConcentratePumps.c (-30, +29) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-18, +0) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-2, +0) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-208, +221) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-0, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-0, +1) | History | Source | Diff
· /firmware/App/Services/Interrupts.c (-5, +5) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Only send alarms message when HD is communicating Thu, 01 Jul 2021 00:18:59 -0700 Quang Nguyen <qnguyen@diality.com> https://devapps.diality.us/changelog/dgfirmware?cs=0a313ac4ec34865255e72089fded191b951b62de https://devapps.diality.us/changelog/dgfirmware?cs=0a313ac4ec34865255e72089fded191b951b62de Quang Nguyen <qnguyen@diality.com> committed 0a313ac on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware DEN-7802: Only send alarms message when HD is communicating

· /firmware/App/Modes/ModeDrain.c (-0, +5) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-0, +5) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-0, +5) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-4, +10) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +0) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-8030 addressed code review comments Thu, 17 Jun 2021 09:56:59 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=cea079b61dbd17b2ddaec99b1124248147d14e72 https://devapps.diality.us/changelog/dgfirmware?cs=cea079b61dbd17b2ddaec99b1124248147d14e72 Dara Navaei committed cea079b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more in dgfirmware DEN-8030 addressed code review comments

· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
· /firmware/App/DGCommon.h (-0, +1) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-17, +18) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-21, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-5, +0) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-13, +27) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.h (-12, +0) | History | Source | Diff
· /firmware/DG.dil (-7, +7) | History | Source | Diff
· /firmware/include/het.h (-4, +4) | History | Source | Diff
· /firmware/source/het.c (-4, +4) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-8030 merged staging Sun, 13 Jun 2021 15:59:06 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=1a5efe97f5f39594b45797fded52cafce92afe80 https://devapps.diality.us/changelog/dgfirmware?cs=1a5efe97f5f39594b45797fded52cafce92afe80 Dara Navaei committed 1a5efe9 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more in dgfirmware DEN-8030 merged staging

· /firmware/.launches/DG.launch (-0, +27) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-4, +109) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-10, +5) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-15, +76) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-0, +1) | History | Source | Diff
· /firmware/App/DGCommon.h (-3, +4) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-19, +69) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-0, +7) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-2, +143) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-13, +44) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-0, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-0, +14) | History | Source | Diff
… 7 more files in changeset.
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-8030 added a more code to the cooling stage of the RO filter in heat disinfect Sun, 13 Jun 2021 14:52:41 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=f656b17f3d8d93b4fca49c9725e096e7eb55acc7 https://devapps.diality.us/changelog/dgfirmware?cs=f656b17f3d8d93b4fca49c9725e096e7eb55acc7 Dara Navaei committed f656b17 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more in dgfirmware DEN-8030 added a more code to the cooling stage of the RO filter in heat disinfect

· /firmware/App/Controllers/Heaters.c (-183, +15) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-2, +0) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-0, +5) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +4) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-69, +130) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-6, +0) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-3, +7) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-8030 tested modes and continued developing chemical disinfect Mon, 31 May 2021 16:33:53 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=8a4182663ef6b12e3fd6414c0c14158943cd4ce1 https://devapps.diality.us/changelog/dgfirmware?cs=8a4182663ef6b12e3fd6414c0c14158943cd4ce1 Dara Navaei committed 8a41826 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more in dgfirmware DEN-8030 tested modes and continued developing chemical disinfect

· /firmware/App/Controllers/Heaters.c (-2, +0) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-6, +53) | History | Source | Diff
· /firmware/App/DGCommon.h (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-137, +342) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h (-2, +8) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-5, +32) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-10, +3) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-0, +4) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-114, +26) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.h (-2, +7) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-14, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +56) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +6) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7605: Addressed code review feedback. Wed, 26 May 2021 10:55:59 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=092b20aaea3defad5e1dbacf5a3f87e67256bd45 https://devapps.diality.us/changelog/dgfirmware?cs=092b20aaea3defad5e1dbacf5a3f87e67256bd45 Sean Nash committed 092b20a on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 214 more in dgfirmware DEN-7605: Addressed code review feedback.

· /firmware/App/Modes/ModeDrain.c (-1, +2) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7605: Added tare state to drain mode to allow time for reservoir to settle first. Fri, 21 May 2021 14:35:34 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=78a138b18328bce8312abac79d76aad9dfe8ea3a https://devapps.diality.us/changelog/dgfirmware?cs=78a138b18328bce8312abac79d76aad9dfe8ea3a Sean Nash committed 78a138b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 214 more in dgfirmware DEN-7605: Added tare state to drain mode to allow time for reservoir to settle first.

· /firmware/App/Modes/ModeDrain.c (-5, +45) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-7, +33) | History | Source | Diff
· /firmware/App/Services/Reservoirs.h (-1, +3) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7605: Added delays to drain mode. Fri, 21 May 2021 08:54:00 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=2e3b3b2034ee5afb52a8630568145c9705afff9f https://devapps.diality.us/changelog/dgfirmware?cs=2e3b3b2034ee5afb52a8630568145c9705afff9f Sean Nash committed 2e3b3b2 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 214 more in dgfirmware DEN-7605: Added delays to drain mode.

· /firmware/App/Controllers/DrainPump.c (-0, +12) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-4, +10) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7605: Pulled in V3 valve changes from chem disinfect branch. Thu, 13 May 2021 17:59:46 -0700 Sean Nash https://devapps.diality.us/changelog/dgfirmware?cs=847478dd75aac2edfe27df454ac5a644b6f30040 https://devapps.diality.us/changelog/dgfirmware?cs=847478dd75aac2edfe27df454ac5a644b6f30040 Sean Nash committed 847478d on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 214 more in dgfirmware DEN-7605: Pulled in V3 valve changes from chem disinfect branch.

· /firmware/App/Controllers/Pressures.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-14, +47) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-36, +42) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-0, +23) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-4, +124) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-0, +3) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +18) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +10) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-8030 changed the drain modes drain pump RPM Wed, 12 May 2021 09:35:20 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=ebd43ef11d75ff69de2eda6aec1142858bc1237e https://devapps.diality.us/changelog/dgfirmware?cs=ebd43ef11d75ff69de2eda6aec1142858bc1237e Dara Navaei committed ebd43ef on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more in dgfirmware DEN-8030 changed the drain modes drain pump RPM

· /firmware/App/Modes/ModeDrain.c (-1, +1) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-8030 made changes in the modes to be able to run on V3 Fri, 07 May 2021 11:37:40 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=654c5598765bb862c00a0175bdac95604c6c9b24 https://devapps.diality.us/changelog/dgfirmware?cs=654c5598765bb862c00a0175bdac95604c6c9b24 Dara Navaei committed 654c559 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more in dgfirmware DEN-8030 made changes in the modes to be able to run on V3

· /firmware/App/DGCommon.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-3, +90) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-11, +5) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-0, +3) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-2, +2) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-8030 continued working on chemical disinfect and added V3 DG valves configuration Wed, 05 May 2021 18:10:24 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=379f78f1fad668d741b3ccf1e78c69f3fccc45b5 https://devapps.diality.us/changelog/dgfirmware?cs=379f78f1fad668d741b3ccf1e78c69f3fccc45b5 Dara Navaei committed 379f78f on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more in dgfirmware DEN-8030 continued working on chemical disinfect and added V3 DG valves configuration

· /firmware/App/Controllers/Valves.c (-21, +54) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-8, +14) | History | Source | Diff
· /firmware/App/DGCommon.h (-2, +3) | History | Source | Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c (-47, +512) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-0, +25) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-0, +10) | History | Source | Diff
· /firmware/App/Modes/ModeFlush.c (-0, +60) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-11, +124) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-0, +3) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +21) | History | Source | Diff
· /firmware/App/Services/Reservoirs.c (-0, +8) | History | Source | Diff
]]> dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-5963 remerged staging Mon, 19 Apr 2021 14:00:50 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=ebbb1f85550a1f9b8f946655f7b2b63f76fbf67d https://devapps.diality.us/changelog/dgfirmware?cs=ebbb1f85550a1f9b8f946655f7b2b63f76fbf67d Dara Navaei committed ebbb1f8 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 216 more in dgfirmware DEN-5963 remerged staging

· /firmware/.launches/DG.launch (-0, +16) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.c (-14, +14) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-2, +13) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-15, +14) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-57, +152) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.h (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/Pressures.c (-1, +3) | History | Source | Diff
· /firmware/App/Controllers/TemperatureSensors.c (-1, +3) | History | Source | Diff
· /firmware/App/DGCommon.h (-3, +9) | History | Source | Diff
· /firmware/App/Modes/ModeDrain.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeRecirculate.c (-3, +7) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-32, +168) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-5, +5) | History | Source | Diff
… 8 more files in changeset.
]]>