Fisheye on dgfirmware/firmware/App/Modes/ModeFill.c

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Fixed merge conflicts from staging.

Sean Nash — Fri, 12 Nov 2021 11:04:28 -0800

Sean Nash committed dcd360f on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

DEN-9906: Fixed merge conflicts from staging.

· /firmware/App/Controllers/ConcentratePumps.c

(-11, +22)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-49, +132)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-450, +454)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-35, +57)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-8, +10)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-39, +71)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.h

(-7, +7)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-10, +14)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-46, +147)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-22, +31)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-27, +65)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-18, +34)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Services/CommBuffers.c

(-6, +6)

| History

| Source

| Diff

… 9 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 11 Nov 2021 10:57:02 -0800

Dara Navaei committed 94a1905 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-6, +6)

| History

| Source

| Diff

… 78 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480 addressed the code review comments

Dara Navaei — Sat, 06 Nov 2021 19:24:52 -0700

Dara Navaei committed 622eebf on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware

DEN-9480 addressed the code review comments

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-6, +10)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-17, +26)

| History

| Source

| Diff

· /firmware/App/Controllers/Switches.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Thermistors.c

(-1, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/UVReactors.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-2, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.c

(-2, +3)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-3, +4)

| History

| Source

| Diff

… 16 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480, DEN-10788 continued working on the heaters control and added code to be able override the drain pump RPM once ...

Dara Navaei — Wed, 03 Nov 2021 21:26:24 -0700

Dara Navaei committed 26f63d0 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware

DEN-9480, DEN-10788 continued working on the heaters control and added code to be able override the drain pump RPM once the pump is in the open loop mode

· /firmware/App/Controllers/DrainPump.c

(-36, +99)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-2, +8)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-49, +106)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-0, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/SafetyShutdown.c

(-4, +6)

| History

| Source

| Diff

· /firmware/App/Drivers/SafetyShutdown.h

(-1, +8)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-4, +4)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-27, +56)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-4, +24)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.h

(-1, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-10, +14)

| History

| Source

| Diff

… 3 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480 added trimmer heater states and implemented the primary heater's efficiency code

Dara Navaei — Tue, 02 Nov 2021 11:46:17 -0700

Dara Navaei committed 03e051e on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware

DEN-9480 added trimmer heater states and implemented the primary heater's efficiency code

· /firmware/App/Controllers/DrainPump.c	(-5, +19)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-44, +43)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-24, +39)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h	(-1, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480 added the return state to all the modes' transition function

Dara Navaei — Sun, 24 Oct 2021 10:31:36 -0700

Dara Navaei committed af0faf0 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware

DEN-9480 added the return state to all the modes' transition function

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-2, +4)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-2, +4)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-2, +6)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-1, +3)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-3, +5)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenIdle.c

(-3, +5)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenIdle.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-2, +4)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-7, +10)

| History

| Source

| Diff

… 9 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480 added events to the firmware

Dara Navaei — Thu, 14 Oct 2021 10:33:39 -0700

Dara Navaei committed 2468e56 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware

DEN-9480 added events to the firmware

· /firmware/App/Controllers/Heaters.c	(-188, +17)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-14, +16)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-0, +38)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-35, +73)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-0, +10)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-1, +16)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +35)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Update fill mode when mixing is disabled. Do not require ACK for general event messages.

Sean Nash — Fri, 08 Oct 2021 09:14:38 -0700

Sean Nash committed 667b78a on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

DEN-9906: Update fill mode when mixing is disabled. Do not require ACK for general event messages.

· /firmware/App/DGCommon.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-8, +11)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480 added a build switch to be able to use the smaller or the normal flow sensors K factor

Dara Navaei — Wed, 06 Oct 2021 11:19:52 -0700

Dara Navaei committed f38051e on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware

DEN-9480 added a build switch to be able to use the smaller or the normal flow sensors K factor

· /firmware/App/Controllers/Heaters.c	(-60, +28)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-7, +8)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-16, +53)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-0, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Added build switch to disable fill mode flow sensor alarm.

Sean Nash — Thu, 30 Sep 2021 17:54:40 -0700

Sean Nash committed 54b7dbe on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

DEN-9906: Added build switch to disable fill mode flow sensor alarm.

· /firmware/App/DGCommon.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-0, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Don't exit fill on integrated volume per flow. Fix RO flow handling when flow is zero.

Sean Nash — Sun, 26 Sep 2021 16:06:44 -0700

Sean Nash committed 012ee7b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

DEN-9906: Don't exit fill on integrated volume per flow. Fix RO flow handling when flow is zero.

· /firmware/App/Controllers/ROPump.c	(-19, +14)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-4, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +12)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480, DEN-10419, DEN-10420 addressed the bugs in the mentioned bugs

Dara Navaei — Sun, 26 Sep 2021 13:35:16 -0700

Dara Navaei committed 2c4dfa0 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware

DEN-9480, DEN-10419, DEN-10420 addressed the bugs in the mentioned bugs

· /firmware/App/Controllers/Heaters.c	(-33, +37)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-0, +10)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-5, +5)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Fixed concentrate pump set speeds over max bug.

Sean Nash — Thu, 23 Sep 2021 15:51:42 -0700

Sean Nash committed 9df373d on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

DEN-9906: Fixed concentrate pump set speeds over max bug.

· /firmware/App/Modes/ModeDrain.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480 Updated the modes for testing

Dara Navaei — Mon, 20 Sep 2021 18:36:34 -0700

Dara Navaei committed d74b98a on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware

DEN-9480 Updated the modes for testing

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-65, +73)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-3, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480 merged staging

Dara Navaei — Fri, 03 Sep 2021 17:31:48 -0700

Dara Navaei committed 54e58f6 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware

DEN-9480 merged staging

· /firmware/App/Controllers/Fans.c

(-21, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-484, +38)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-12, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-22, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Switches.c

(-22, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-23, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Thermistors.c

(-22, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-7, +7)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-10, +5)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-16, +18)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-124, +266)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-58, +9)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenIdle.c

(-0, +239)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-107, +10)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-1, +2)

| History

| Source

| Diff

… 6 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Added 5 minutes wait time for HD comm timeout before transition back to standby

Fri, 27 Aug 2021 14:50:00 -0700

Quang Nguyen committed a1452dc on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Added 5 minutes wait time for HD comm timeout before transition back to standby

· /firmware/App/Modes/ModeDrain.c	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +14)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Fixed out of range check error

Fri, 27 Aug 2021 10:57:13 -0700

Quang Nguyen committed e4a33b5 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Fixed out of range check error

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Turned off concentrate pumps when water is not ready

Thu, 26 Aug 2021 11:35:51 -0700

Quang Nguyen committed 0cd4bdb on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Turned off concentrate pumps when water is not ready

· /firmware/App/Modes/ModeFill.c

(-0, +2)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Renamed re-circ to generation idle

Tue, 24 Aug 2021 16:24:41 -0700

Quang Nguyen committed 24e8fcb on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Renamed re-circ to generation idle

· /firmware/App/Controllers/DrainPump.c	(-9, +8)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-4, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-3, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Addressed code review comments

Thu, 19 Aug 2021 10:13:35 -0700

Quang Nguyen committed c914eb4 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Addressed code review comments

· /firmware/App/Controllers/ConcentratePumps.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-58, +19)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Merge branch 'staging' into DEN-7802-dg_dev-dialysate-generation

Wed, 18 Aug 2021 01:16:52 -0700

Quang Nguyen committed e6f3a63 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

Merge branch 'staging' into DEN-7802-dg_dev-dialysate-generation

· /firmware/App/Controllers/ConcentratePumps.c

(-5, +128)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-5, +108)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-0, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-89, +194)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-49, +56)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-108, +178)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-39, +128)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-100, +109)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-5, +4)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-7, +12)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-16, +41)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenIdle.c

(-32, +33)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-26, +45)

| History

| Source

| Diff

… 7 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Addressed code reviews

Fri, 13 Aug 2021 13:37:20 -0700

Quang Nguyen committed 9b468e9 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Addressed code reviews

· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-4, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-2, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Updated according to lab findings

Thu, 12 Aug 2021 23:50:19 -0700

Quang Nguyen committed a187709 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Updated according to lab findings

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-3, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-26, +40)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Refactor re-circ mode to generation idle mode

Fri, 06 Aug 2021 14:12:39 -0700

Quang Nguyen committed 1c74566 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Refactor re-circ mode to generation idle mode

· /firmware/App/Modes/ModeDrain.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-8, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-0, +226)	\| History	\| Source
· /firmware/App/Modes/ModeGenIdle.h	(-0, +46)	\| History	\| Source
· /firmware/App/Modes/ModeRecirculate.c	(-256, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeRecirculate.h	(-46, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-11, +11)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-15, +15)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/WatchdogMgmt.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Changed according to lab test

Fri, 30 Jul 2021 14:07:33 -0700

Quang Nguyen committed 9779d54 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Changed according to lab test

· /firmware/App/Modes/ModeFill.c	(-13, +18)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Implemented fill mode with new changes

Mon, 19 Jul 2021 16:27:05 -0700

Quang Nguyen committed 5d82009 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Implemented fill mode with new changes

· /firmware/App/Controllers/ConcentratePumps.c	(-30, +29)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-18, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.h	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-208, +221)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeRecirculate.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-5, +5)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9054 updated the code

Dara Navaei — Wed, 14 Jul 2021 10:03:55 -0700

Dara Navaei committed c016036 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more in dgfirmware

DEN-9054 updated the code

· /firmware/App/Controllers/ConcentratePumps.c

(-5, +124)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-3, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-4, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-103, +26)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-91, +197)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-20, +25)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-4, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-15, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-97, +103)

| History

| Source

| Diff

· /firmware/App/Controllers/Thermistors.c

(-90, +22)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-0, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-5, +6)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +5)

| History

| Source

| Diff

… 19 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Only send alarms message when HD is communicating

Thu, 01 Jul 2021 00:18:59 -0700

Quang Nguyen committed 0a313ac on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Only send alarms message when HD is communicating

· /firmware/App/Modes/ModeDrain.c	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeRecirculate.c	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-4, +10)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Refactor conductivity checks

Sat, 26 Jun 2021 01:08:18 -0700

Quang Nguyen committed 4b15ae8 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Refactor conductivity checks

· /firmware/App/Controllers/ConductivitySensors.c	(-35, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.h	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-6, +40)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Merge branch 'staging' into DEN-7802-dg_dev-dialysate-generation

Sat, 26 Jun 2021 00:58:21 -0700

Quang Nguyen committed 037f0ed on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

Merge branch 'staging' into DEN-7802-dg_dev-dialysate-generation

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-215, +87)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-34, +74)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-41, +122)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-36, +41)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-24, +139)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-29, +71)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.h	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-270, +302)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-17, +18)	\| History	\| Source	\| Diff