Fisheye on dgfirmware/firmware/App/Services/Reservoirs.c

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Fixed merge conflicts from staging.

Sean Nash — Fri, 12 Nov 2021 11:04:28 -0800

Sean Nash committed dcd360f on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

DEN-9906: Fixed merge conflicts from staging.

· /firmware/App/Controllers/ConcentratePumps.c

(-11, +22)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-49, +132)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-450, +454)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-35, +57)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-8, +10)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-39, +71)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.h

(-7, +7)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-10, +14)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-46, +147)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-22, +31)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-27, +65)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-18, +34)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Services/CommBuffers.c

(-6, +6)

| History

| Source

| Diff

… 9 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 11 Nov 2021 10:57:02 -0800

Dara Navaei committed 94a1905 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-6, +6)

| History

| Source

| Diff

… 78 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480 updated documentation

Dara Navaei — Thu, 11 Nov 2021 10:51:31 -0800

Dara Navaei committed ddd2e12 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware

DEN-9480 updated documentation

· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9480 addressed the code review comments

Dara Navaei — Sat, 06 Nov 2021 19:24:52 -0700

Dara Navaei committed 622eebf on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more in dgfirmware

DEN-9480 addressed the code review comments

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-6, +10)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-17, +26)

| History

| Source

| Diff

· /firmware/App/Controllers/Switches.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Thermistors.c

(-1, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/UVReactors.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-2, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.c

(-2, +3)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-3, +4)

| History

| Source

| Diff

… 16 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Don't exit fill on integrated volume per flow. Fix RO flow handling when flow is zero.

Sean Nash — Sun, 26 Sep 2021 16:06:44 -0700

Sean Nash committed 012ee7b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

DEN-9906: Don't exit fill on integrated volume per flow. Fix RO flow handling when flow is zero.

· /firmware/App/Controllers/ROPump.c	(-19, +14)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-4, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +12)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Fixed min inlet drain pressure for indicating empty reservoir (sign issue).

Sean Nash — Tue, 14 Sep 2021 15:00:26 -0700

Sean Nash committed 9c523a8 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

DEN-9906: Fixed min inlet drain pressure for indicating empty reservoir (sign issue).

· /firmware/App/Controllers/LoadCell.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Increased load cell drift allowance from one drain tare to the next (DEN-10164). Added check of PRd > 3 PSI b...

Sean Nash — Fri, 10 Sep 2021 16:22:56 -0700

Sean Nash committed dfb6b6f on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

DEN-9906: Increased load cell drift allowance from one drain tare to the next (DEN-10164). Added check of PRd > 3 PSI before declaring a reservoir empty.

· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9906: Added rinse concentrate lines state in drain mode

Fri, 03 Sep 2021 11:00:24 -0700

Quang Nguyen committed 24dd186 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

DEN-9906: Added rinse concentrate lines state in drain mode

· /firmware/App/Modes/ModeDrain.c	(-7, +74)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: DEN-9139: Fixed reservoir tare

Mon, 23 Aug 2021 16:43:53 -0700

Quang Nguyen committed cbcd41e on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: DEN-9139: Fixed reservoir tare

· /firmware/App/Controllers/LoadCell.c	(-3, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-7, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Used test support get override value

Thu, 19 Aug 2021 13:17:41 -0700

Quang Nguyen committed d381928 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Used test support get override value

· /firmware/App/Controllers/ConcentratePumps.c

(-22, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-30, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-22, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-21, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-22, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-21, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-21, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-31, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-30, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Switches.c

(-22, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-22, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Thermistors.c

(-22, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/UVReactors.c

(-30, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-30, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.c

(-28, +2)

| History

| Source

| Diff

… 3 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Merge branch 'staging' into DEN-7802-dg_dev-dialysate-generation

Wed, 18 Aug 2021 01:16:52 -0700

Quang Nguyen committed e6f3a63 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

Merge branch 'staging' into DEN-7802-dg_dev-dialysate-generation

· /firmware/App/Controllers/ConcentratePumps.c

(-5, +128)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-5, +108)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-0, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-89, +194)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-49, +56)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-108, +178)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-39, +128)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-100, +109)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-5, +4)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-7, +12)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-16, +41)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenIdle.c

(-32, +33)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-26, +45)

| History

| Source

| Diff

… 7 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Removed V2 system define

Wed, 18 Aug 2021 00:56:17 -0700

Quang Nguyen committed 7ed011e on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Removed V2 system define

· /firmware/App/Controllers/Heaters.c	(-6, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-47, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-7, +0)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-52, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-97, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-12, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-6, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-8886: Local merge from staging.

Sean Nash — Fri, 13 Aug 2021 15:39:01 -0700

Sean Nash committed 47c4104 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-8886: Local merge from staging.

· /firmware/.launches/DG.launch	(-0, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-20, +42)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeRecirculate.c	(-39, +43)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-96, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +136)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-5, +90)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-7, +21)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-15, +190)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-7, +24)	\| History	\| Source	\| Diff
· /firmware/App/Services/WatchdogMgmt.c	(-3, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Addressed code reviews

Thu, 12 Aug 2021 23:04:05 -0700

Quang Nguyen committed 51bdd8e on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Addressed code reviews

· /firmware/App/Modes/ModeDrain.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-10, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-4, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Refactor re-circ mode to generation idle mode

Fri, 06 Aug 2021 14:12:39 -0700

Quang Nguyen committed 1c74566 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Refactor re-circ mode to generation idle mode

· /firmware/App/Modes/ModeDrain.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-8, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-0, +226)	\| History	\| Source
· /firmware/App/Modes/ModeGenIdle.h	(-0, +46)	\| History	\| Source
· /firmware/App/Modes/ModeRecirculate.c	(-256, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeRecirculate.h	(-46, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-11, +11)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-15, +15)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/WatchdogMgmt.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Send water to drain during re-circ state

Fri, 06 Aug 2021 10:23:48 -0700

Quang Nguyen committed cbc9f2b on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Send water to drain during re-circ state

· /firmware/App/Modes/ModeRecirculate.c	(-9, +9)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-4, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9054 merged stagin

Dara Navaei — Sat, 31 Jul 2021 16:44:35 -0700

Dara Navaei committed 67021fb on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more in dgfirmware

DEN-9054 merged stagin

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-8, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/UVReactors.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Modes/ModeRecirculate.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.h

(-96, +3)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmtSWFaults.h

(-0, +135)

| History

| Source

| Diff

· /firmware/App/Services/FPGA.c

(-1, +13)

| History

| Source

| Diff

· /firmware/App/Services/FPGA.h

(-0, +2)

| History

| Source

| Diff

… 6 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Changed according to lab test

Fri, 30 Jul 2021 14:07:33 -0700

Quang Nguyen committed 9779d54 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Changed according to lab test

· /firmware/App/Modes/ModeFill.c	(-13, +18)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9054 addressed the code review comments

Dara Navaei — Thu, 29 Jul 2021 16:42:46 -0700

Dara Navaei committed c2fe204 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more in dgfirmware

DEN-9054 addressed the code review comments

· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Switches.c	(-9, +17)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Switches.h	(-8, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.h	(-0, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeRecirculate.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-10, +11)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9054 added messaging for service and serial number

Dara Navaei — Fri, 23 Jul 2021 15:50:42 -0700

Dara Navaei committed 1463d83 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more in dgfirmware

DEN-9054 added messaging for service and serial number

· /firmware/App/Services/Reservoirs.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +62)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +6)	\| History	\| Source	\| Diff
· /firmware/dg_build_history.txt	(-0, +10)	\| History	\| Source

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9054 worked on POST functions. Changed the polarity direction of the watchdog expiration pin. Continued testing NV d...

Dara Navaei — Thu, 22 Jul 2021 11:37:36 -0700

Dara Navaei committed 97e0100 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more in dgfirmware

DEN-9054 worked on POST functions. Changed the polarity direction of the watchdog expiration pin. Continued testing NV data mgmt

· /firmware/.launches/DG.launch	(-0, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Fans.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-3, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/CPLD.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-7, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/WatchdogMgmt.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/DG.dil	(-5, +5)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9054 updated the code

Dara Navaei — Wed, 14 Jul 2021 10:03:55 -0700

Dara Navaei committed c016036 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more in dgfirmware

DEN-9054 updated the code

· /firmware/App/Controllers/ConcentratePumps.c

(-5, +124)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-3, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-4, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-103, +26)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-91, +197)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-20, +25)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-4, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-15, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-97, +103)

| History

| Source

| Diff

· /firmware/App/Controllers/Thermistors.c

(-90, +22)

| History

| Source

| Diff

· /firmware/App/Controllers/Voltages.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-0, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-5, +6)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +5)

| History

| Source

| Diff

… 19 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-7802: Added delay to valves state change

Wed, 07 Jul 2021 00:16:14 -0700

Quang Nguyen committed 89259a1 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

DEN-7802: Added delay to valves state change

· /firmware/App/Controllers/LoadCell.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFault.c	(-13, +15)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +8)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-9054 updated some of the drivers with calibration code

Dara Navaei — Tue, 29 Jun 2021 21:21:03 -0700

Dara Navaei committed 6f1f269 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 211 more in dgfirmware

DEN-9054 updated some of the drivers with calibration code

· /firmware/App/Controllers/ConductivitySensors.c	(-7, +97)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-5, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-18, +21)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-111, +191)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-38, +112)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h	(-16, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-16, +41)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.h	(-11, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-15, +27)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeRecirculate.c	(-27, +77)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-9, +57)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Merge branch 'staging' into DEN-7802-dg_dev-dialysate-generation

Sat, 26 Jun 2021 00:58:21 -0700

Quang Nguyen committed 037f0ed on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 208 more in dgfirmware

Merge branch 'staging' into DEN-7802-dg_dev-dialysate-generation

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-215, +87)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-34, +74)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-41, +122)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-36, +41)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-24, +139)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-29, +71)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.h	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-270, +302)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-17, +18)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-8103: Fixed valve state when switch reservoir

Fri, 25 Jun 2021 11:43:11 -0700

Quang Nguyen committed 71a23ba on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 211 more in dgfirmware

DEN-8103: Fixed valve state when switch reservoir

· /firmware/App/Services/Reservoirs.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-8886: Fixed merge conflicts from staging.

Sean Nash — Tue, 22 Jun 2021 12:41:41 -0700

Sean Nash committed 476da1c on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 209 more in dgfirmware

DEN-8886: Fixed merge conflicts from staging.

· /firmware/App/Modes/ModeRecirculate.c	(-3, +10)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-21, +13)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-8030 addressed code review comments

Dara Navaei — Sun, 13 Jun 2021 17:27:51 -0700

Dara Navaei committed 3d13123 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more in dgfirmware

DEN-8030 addressed code review comments

· /firmware/App/Controllers/Heaters.c	(-2, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-6, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-4, +24)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeRecirculate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-28, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-8030 merged staging

Dara Navaei — Sun, 13 Jun 2021 15:59:06 -0700

Dara Navaei committed 1a5efe9 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more in dgfirmware

DEN-8030 merged staging

· /firmware/.launches/DG.launch

(-0, +27)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-4, +109)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-0, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-10, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-15, +76)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-0, +1)

| History

| Source

| Diff

· /firmware/App/DGCommon.h

(-3, +4)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-19, +69)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-0, +7)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-2, +143)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-13, +44)

| History

| Source

| Diff

· /firmware/App/Modes/ModeRecirculate.c

(-0, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-0, +14)

| History

| Source

| Diff

… 7 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-8030 added a more code to the cooling stage of the RO filter in heat disinfect

Dara Navaei — Sun, 13 Jun 2021 14:52:41 -0700

Dara Navaei committed f656b17 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more in dgfirmware

DEN-8030 added a more code to the cooling stage of the RO filter in heat disinfect

· /firmware/App/Controllers/Heaters.c	(-183, +15)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.h	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-0, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-69, +130)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeRecirculate.c	(-3, +7)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	\| History	\| Source	\| Diff