Fisheye on dgfirmware/firmware/App

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 23 Oct 2023 16:24:55 -0700

Dara Navaei committed 7966dd1 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 51 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 23 Oct 2023 16:24:44 -0700

Dara Navaei committed f1dc6eb on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 51 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-116 merged staging

Dara Navaei — Mon, 23 Oct 2023 16:21:40 -0700

Dara Navaei committed 9d1a6f6 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 52 more in dgfirmware

DENBUG-116 merged staging

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-116 changed the transition from service mode to fault mode to be illegal

Dara Navaei — Mon, 23 Oct 2023 15:27:16 -0700

Dara Navaei committed 679310f on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 52 more in dgfirmware

DENBUG-116 changed the transition from service mode to fault mode to be illegal

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-124 added code to reinitialize the drain parameters chemical disinfect, chemical disinfect flush and flush in can...

Dara Navaei — Sat, 21 Oct 2023 13:06:11 -0700

Dara Navaei committed be920d1 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 51 more in dgfirmware

DENBUG-124 added code to reinitialize the drain parameters chemical disinfect, chemical disinfect flush and flush in cancel water path

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-5, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-3, +5)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Sat, 21 Oct 2023 12:54:55 -0700

Dara Navaei committed 276d912 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 52 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Sat, 21 Oct 2023 12:54:48 -0700

Dara Navaei committed 1214da9 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 52 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-116 changed the code to only allow write to service, calibration, and system records when DG is in service mode

Dara Navaei — Fri, 20 Oct 2023 13:39:17 -0700

Dara Navaei committed 9fea55e on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 52 more in dgfirmware

DENBUG-116 changed the code to only allow write to service, calibration, and system records when DG is in service mode

· /firmware/App/Services/SystemCommMessages.c

(-3, +6)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-119 changed the operation modes table to prevent a mode transition from service mode to RO permeate sample mode

Dara Navaei — Fri, 20 Oct 2023 10:54:35 -0700

Dara Navaei committed 09da19b on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 53 more in dgfirmware

DENBUG-119 changed the operation modes table to prevent a mode transition from service mode to RO permeate sample mode

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Fri, 20 Oct 2023 08:27:32 -0700

Dara Navaei committed 1b0d087 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 53 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 20 Oct 2023 08:27:20 -0700

Dara Navaei committed 225be41 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 53 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-112 changed the tare alarm limit in heat disinfect active cool mode

Dara Navaei — Tue, 17 Oct 2023 14:10:38 -0700

Dara Navaei committed f7c6956 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 54 more in dgfirmware

DENBUG-112 changed the tare alarm limit in heat disinfect active cool mode

· /firmware/App/Controllers/LoadCell.c

(-1, +5)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Tue, 17 Oct 2023 10:32:23 -0700

Dara Navaei committed 6216d19 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 54 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 17 Oct 2023 10:32:13 -0700

Dara Navaei committed 4950894 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 54 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446: Address DENBUG-105 to reset concentrate volume used when priming conc lines.

Sean Nash — Mon, 16 Oct 2023 10:26:58 -0700

Sean Nash committed 506f3f5 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 54 more in dgfirmware

DEN-16446: Address DENBUG-105 to reset concentrate volume used when priming conc lines.

· /firmware/App/Modes/ModeFill.c

(-0, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-76 added code to not check the temperature sensors drift until a couple of minutes into R1 to R2

Dara Navaei — Sat, 14 Oct 2023 17:17:03 -0700

Dara Navaei committed 77f5c03 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 54 more in dgfirmware

DENBUG-76 added code to not check the temperature sensors drift until a couple of minutes into R1 to R2

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +10)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 12 Oct 2023 10:39:31 -0700

Dara Navaei committed 2185f5a on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 54 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 11 Oct 2023 22:33:08 -0700

Dara Navaei committed b27441d on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 54 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 11 Oct 2023 22:32:58 -0700

Dara Navaei committed ba9d98d on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 54 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-96: Addressed DENBUG-97.

Sean Nash — Wed, 11 Oct 2023 12:36:08 -0700

Sean Nash committed e6e0513 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 55 more in dgfirmware

DENBUG-96: Addressed DENBUG-97.

· /firmware/App/Modes/ModeGenIdle.c	(-0, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-96: Addressed DENBUG-98.

Sean Nash — Wed, 11 Oct 2023 12:22:01 -0700

Sean Nash committed 6243741 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 55 more in dgfirmware

DENBUG-96: Addressed DENBUG-98.

· /firmware/App/Modes/ModeStandby.c

(-0, +7)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Tue, 10 Oct 2023 15:59:36 -0700

Dara Navaei committed 8f8582c on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 55 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 10 Oct 2023 15:59:22 -0700

Dara Navaei committed 3024adb on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 55 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemCommMessages.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16487 added code to set the dialin expiration time stamp once the user has logged in until the first checkin from di...

Dara Navaei — Tue, 10 Oct 2023 09:09:23 -0700

Dara Navaei committed 46dc653 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 55 more in dgfirmware

DEN-16487 added code to set the dialin expiration time stamp once the user has logged in until the first checkin from dialin is received

· /firmware/App/Services/SystemCommMessages.c

(-0, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 09 Oct 2023 11:24:15 -0700

Dara Navaei committed 0b9c7e1 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 55 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 09 Oct 2023 11:23:57 -0700

Dara Navaei committed d32f890 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 55 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 addressed the code review comments

Dara Navaei — Mon, 09 Oct 2023 09:21:11 -0700

Dara Navaei committed 4c992d2 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 55 more in dgfirmware

DEN-16446 addressed the code review comments

· /firmware/App/Services/SystemCommMessages.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 09 Oct 2023 09:19:06 -0700

Dara Navaei committed 5fe44a7 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 55 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 09 Oct 2023 09:18:53 -0700

Dara Navaei committed dd5df16 on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 55 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16475: code review comments

Michael Garthwaite — Mon, 09 Oct 2023 08:57:32 -0700

Michael Garthwaite committed 630cc5c on branch master, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 56 more in dgfirmware

DEN-16475: code review comments

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff