Fisheye on hdfirmware/firmware/App/Drivers/Battery.h

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 02 Jan 2024 10:53:49 -0800

Dara Navaei committed 736cc5b on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 56 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-3, +3)

| History

| Source

| Diff

… 102 more files in changeset.

HD-DEN-13834-1: closed by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 21:14:51 -0700

Dara Navaei Closed HD-DEN-13834-1

HD-DEN-13834-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Wed, 18 Oct 2023 21:13:46 -0700

Dara Navaei replied to Sean Nash in HD-DEN-13834-1

RESOLVED in CODE WALKTHROUGH

HD-DEN-13834-1: comment by Dara Navaei "RESOLVED IN CODE WALKTHROUGH"

Dara Navaei — Wed, 18 Oct 2023 21:07:43 -0700

Dara Navaei replied to wbracken (deleted user) in HD-DEN-13834-1

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1: comment by Dara Navaei "RESOLVED IN CODE WALKTHROUGH"

Dara Navaei — Wed, 18 Oct 2023 21:07:15 -0700

Dara Navaei replied to wbracken (deleted user) in HD-DEN-13834-1

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1: started by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 21:05:58 -0700

Dara Navaei started review HD-DEN-13834-1

hdfirmware (DEN-16693-institutional-settings-implementation-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 14 Aug 2023 14:05:31 -0700

Dara Navaei committed a56db46 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 151 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Fans.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/Battery.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/Battery.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SelfTests.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

HD-DEN-14815-1: closed by Sean Nash

Sean Nash — Mon, 14 Aug 2023 13:41:35 -0700

Sean Nash Closed HD-DEN-14815-1

HD-DEN-14815-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Fri, 11 Aug 2023 17:06:52 -0700

wbracken (deleted user) replied to Sean Nash in HD-DEN-14815-1

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14815-1: comment by Sean Nash "Done."

Sean Nash — Fri, 11 Aug 2023 16:20:20 -0700

Sean Nash replied to wbracken (deleted user) in HD-DEN-14815-1

Done.

HD-DEN-14815-1: reviewers resumed

Fri, 11 Aug 2023 10:20:36 -0700

Behrouz NematiPour resumed reviewing HD-DEN-14815-1

HD-DEN-14815_Cartridge Removal Screen IS Displayed Prematurely

HD-DEN-14815-1: reviewers joined HD-DEN-14815_Cartridge Removal Screen IS Displayed...

Fri, 11 Aug 2023 04:24:18 -0700

Behrouz NematiPour joined HD-DEN-14815-1

HD-DEN-14815_Cartridge Removal Screen IS Displayed Prematurely

hdfirmware (DEN-16693-institutional-settings-implementation-2): DEN-14815: Switched to new CPLD based AC power loss check function.

Sean Nash — Thu, 10 Aug 2023 16:46:45 -0700

Sean Nash committed e7c4a51 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 152 more in hdfirmware

DEN-14815: Switched to new CPLD based AC power loss check function.

· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Fans.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/Battery.c	(-21, +0)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/Battery.h	(-1, +0)	\| History	\| Source	\| Diff

HD-DEN-14815-1: comment by wbracken "Add currentPostTreatmentState to header"

wbracken — Thu, 10 Aug 2023 09:47:58 -0700

wbracken (deleted user) commented on HD-DEN-14815-1

Add currentPostTreatmentState to header

HD-DEN-14815-1: started by Dara Navaei

Dara Navaei — Wed, 09 Aug 2023 18:04:13 -0700

Dara Navaei started review HD-DEN-14815-1

HD-DEN-15306-3: closed by Dara Navaei

Dara Navaei — Wed, 14 Jun 2023 12:59:39 -0700

Dara Navaei Closed HD-DEN-15306-3

HD-DEN-15306-3: reviewers finished

Wed, 14 Jun 2023 12:57:52 -0700

Sean Nash finished reviewing HD-DEN-15306-3

HD-DEN-15306_HD Fault Valve Position Alarm After Restoring AC Power 4 - Ready

HD-DEN-15306-3: reviewers finished

Tue, 13 Jun 2023 11:48:56 -0700

wbracken (deleted user) finished reviewing HD-DEN-15306-3

HD-DEN-15306_HD Fault Valve Position Alarm After Restoring AC Power 4 - Ready

HD-DEN-15306-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 02 Jun 2023 18:27:34 -0700

Sean Nash replied to jtaylor (deleted user) in HD-DEN-15306-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15306-3: comment by jtaylor "Done."

jtaylor — Fri, 02 Jun 2023 17:54:30 -0700

jtaylor (deleted user) replied to Sean Nash in HD-DEN-15306-3

Done.

HD-DEN-15306-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 02 Jun 2023 17:21:13 -0700

Sean Nash replied to jtaylor (deleted user) in HD-DEN-15306-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15306-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 02 Jun 2023 17:20:43 -0700

Sean Nash replied to jtaylor (deleted user) in HD-DEN-15306-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15306-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 02 Jun 2023 17:20:09 -0700

Sean Nash replied to jtaylor (deleted user) in HD-DEN-15306-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15306-3: comment by jtaylor "Done."

jtaylor — Fri, 02 Jun 2023 17:08:02 -0700

jtaylor (deleted user) replied to Sean Nash in HD-DEN-15306-3

Done.

HD-DEN-15306-3: comment by jtaylor "Oops. DeMorganized and done."

jtaylor — Fri, 02 Jun 2023 17:06:48 -0700

jtaylor (deleted user) replied to Sean Nash in HD-DEN-15306-3

Oops. DeMorganized and done.

HD-DEN-15306-3: comment by jtaylor "Done."

jtaylor — Fri, 02 Jun 2023 16:58:49 -0700

jtaylor (deleted user) replied to Sean Nash in HD-DEN-15306-3

Done.

HD-DEN-15306-3: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 02 Jun 2023 16:53:28 -0700

Sean Nash replied to jtaylor (deleted user) in HD-DEN-15306-3

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15306-3: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Fri, 02 Jun 2023 16:51:40 -0700

wbracken (deleted user) replied to jtaylor (deleted user) in HD-DEN-15306-3

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15306-3: comment by Sean Nash "Remove space between ()."

Sean Nash — Fri, 02 Jun 2023 16:51:00 -0700

Sean Nash commented on HD-DEN-15306-3

Remove space between ().

HD-DEN-15306-3: comment by Sean Nash "Add blank line between declaration and code. ..."

Sean Nash — Fri, 02 Jun 2023 16:43:27 -0700

Sean Nash commented on HD-DEN-15306-3

Add blank line between declaration and code.

Prefer we not assume bool and BOOL are the same. Use if statement and explicit assignment of TRUE to result if all conditions are true.

First condition seems backward.

Second and third conditions seem problematic. You will never trigger an AC power loss alarm. Should remove them I think.