Fisheye on hdfirmware/firmware/checkAlarms.sh https://devapps.diality.us/changelog/~br%3DDENBUG-241-dialysate-flow-rate-cannot-be/hdfirmware/firmware/checkAlarms.sh Recent activity in "hdfirmware" under directory /firmware/checkAlarms.sh HD-DEN-14307-1: closed by Dara Navaei Wed, 21 Dec 2022 14:53:40 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14307-1 https://devapps.diality.us/cru/HD-DEN-14307-1 Dara Navaei Closed HD-DEN-14307-1 ]]> HD-DEN-14307-1: reviewers finished Wed, 21 Dec 2022 14:34:32 -0800 https://devapps.diality.us/cru/HD-DEN-14307-1 https://devapps.diality.us/cru/HD-DEN-14307-1 wbracken  (deleted user) and Sean Nash finished reviewing HD-DEN-14307-1 HD-DEN-14307_DG HD Dev HD DG Dvt Update Part 6 ]]> HD-DEN-14307-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH." Wed, 21 Dec 2022 13:56:09 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15703 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15703 wbracken  (deleted user) replied to Dara Navaei in HD-DEN-14307-1

RESOLVED IN CODE WALKTHROUGH.

]]> HD-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH." Wed, 21 Dec 2022 13:43:20 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15702 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15702 wbracken  (deleted user) replied to Dara Navaei in HD-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

]]> HD-DEN-14307-1: comment by Dara Navaei "Done" Wed, 21 Dec 2022 13:12:02 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14307-1/#c15700 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15700 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-14307-1

Done

]]> HD-DEN-14307-1: comment by Dara Navaei "Data is a local variable but added alarmButtonB..." Wed, 21 Dec 2022 13:07:33 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14307-1/#c15699 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15699 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-14307-1

Data is a local variable but added alarmButtonBlockers

]]> HD-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH." Wed, 21 Dec 2022 12:02:47 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15685 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15685 wbracken  (deleted user) replied to Dara Navaei in HD-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

]]> HD-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH." Wed, 21 Dec 2022 12:01:55 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15684 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15684 wbracken  (deleted user) replied to Dara Navaei in HD-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

]]> HD-DEN-14307-1: comment by wbracken "data and alarmButtonBlockers?" Wed, 21 Dec 2022 11:59:06 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15683 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15683 wbracken  (deleted user) replied to Dara Navaei in HD-DEN-14307-1

data and alarmButtonBlockers?

]]> HD-DEN-14307-1: comment by wbracken "Should alarmButtonBlockers and ALARM_TABLE also..." Wed, 21 Dec 2022 11:57:36 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15682 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15682 wbracken  (deleted user) replied to Dara Navaei in HD-DEN-14307-1

Should alarmButtonBlockers and ALARM_TABLE also be added.

]]> HD-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH." Wed, 21 Dec 2022 11:55:51 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15681 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15681 wbracken  (deleted user) replied to Dara Navaei in HD-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

]]> HD-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH." Wed, 21 Dec 2022 11:55:35 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15680 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15680 wbracken  (deleted user) replied to Dara Navaei in HD-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

]]> HD-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH." Wed, 21 Dec 2022 11:55:14 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15679 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15679 wbracken  (deleted user) replied to wbracken  (deleted user) in HD-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

]]> HD-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 Dec 2022 10:02:56 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14307-1/#c15633 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15633 Sean Nash replied to Dara Navaei in HD-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-14307-1: comment by Dara Navaei "Done" Wed, 21 Dec 2022 09:30:29 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14307-1/#c15622 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15622 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-14307-1

Done

]]> HD-DEN-14307-1: comment by Dara Navaei "Done" Wed, 21 Dec 2022 09:29:26 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14307-1/#c15621 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15621 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-14307-1

Done

]]> HD-DEN-14307-1: comment by Dara Navaei "I think we still want to keep the comment. It h..." Wed, 21 Dec 2022 09:28:40 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14307-1/#c15620 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15620 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-14307-1

I think we still want to keep the comment. It has not been implemented yet.

]]> HD-DEN-14307-1: comment by Dara Navaei "Done" Wed, 21 Dec 2022 09:27:57 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14307-1/#c15619 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15619 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-14307-1

Done

]]> HD-DEN-14307-1: comment by Dara Navaei "Done" Wed, 21 Dec 2022 09:24:14 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14307-1/#c15618 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15618 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-14307-1

Done

]]> HD-DEN-14307-1: comment by Dara Navaei "Done" Wed, 21 Dec 2022 09:21:58 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14307-1/#c15617 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15617 Dara Navaei replied to wbracken  (deleted user) in HD-DEN-14307-1

Done

]]> HD-DEN-14307-1: comment by Dara Navaei "Fixed the setServiceTime function. Thanks." Wed, 21 Dec 2022 09:19:32 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14307-1/#c15615 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15615 Dara Navaei replied to Sean Nash in HD-DEN-14307-1

Fixed the setServiceTime function. Thanks.

]]> HD-DEN-14307-1: comment by Dara Navaei "Done." Wed, 21 Dec 2022 09:17:17 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-14307-1/#c15613 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15613 Dara Navaei replied to Sean Nash in HD-DEN-14307-1

Done.

]]> HD-DEN-14307-1: comment by Sean Nash "Agree, though this comment belongs in NVDataMgm..." Tue, 20 Dec 2022 15:21:52 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14307-1/#c15510 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15510 Sean Nash replied to wbracken  (deleted user) in HD-DEN-14307-1

Agree, though this comment belongs in NVDataMgmt.c where setServiceTime() is lives. That function should return TRUE if successful.

]]> HD-DEN-14307-1: comment by Sean Nash "All of these terms are integers and cast is com..." Tue, 20 Dec 2022 15:14:41 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-14307-1/#c15509 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15509 Sean Nash commented on HD-DEN-14307-1

All of these terms are integers and cast is coming too late (after division). To prevent loss of precision on division, we want to cast both sides of the division as floats.

]]> HD-DEN-14307-1: comment by wbracken "Looks like setServiceTime always returns FALSE." Mon, 19 Dec 2022 14:02:24 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15264 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15264 wbracken  (deleted user) commented on HD-DEN-14307-1

Looks like setServiceTime always returns FALSE.

]]> HD-DEN-14307-1: comment by wbracken "Update function header." Mon, 19 Dec 2022 13:53:42 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15262 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15262 wbracken  (deleted user) commented on HD-DEN-14307-1

Update function header.

]]> HD-DEN-14307-1: comment by wbracken "Update function header." Mon, 19 Dec 2022 13:50:58 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15261 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15261 wbracken  (deleted user) commented on HD-DEN-14307-1

Update function header.

]]> HD-DEN-14307-1: comment by wbracken "Update function header." Mon, 19 Dec 2022 13:50:11 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15260 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15260 wbracken  (deleted user) commented on HD-DEN-14307-1

Update function header.

]]> HD-DEN-14307-1: comment by wbracken "Remove comment?" Mon, 19 Dec 2022 13:49:35 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15259 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15259 wbracken  (deleted user) commented on HD-DEN-14307-1

Remove comment?

]]> HD-DEN-14307-1: comment by wbracken "Update function header." Mon, 19 Dec 2022 13:49:15 -0800 wbracken https://devapps.diality.us/cru/HD-DEN-14307-1/#c15258 https://devapps.diality.us/cru/HD-DEN-14307-1/#c15258 wbracken  (deleted user) commented on HD-DEN-14307-1

Update function header.

]]>