Fisheye on fwcommon/Common.h https://devapps.diality.us/changelog/~br%3DDENBUG-335-air-trap-fill-design-improvem/fwcommon/Common.h Recent activity in "fwcommon" under directory /Common.h fwcommon (staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 11 May 2026 10:13:52 -0700 Dara Navaei https://devapps.diality.us/changelog/fwcommon?cs=d5da2d81f880360fc961b7e734b95fead2f003e0 https://devapps.diality.us/changelog/fwcommon?cs=d5da2d81f880360fc961b7e734b95fead2f003e0 Dara Navaei committed d5da2d8 on branch DENBUG-335-air-trap-fill-design-improvem, staging in fwcommon Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /Accel.c (-1, +1) | History | Source | Diff
· /Accel.h (-1, +1) | History | Source | Diff
· /Common.h (-1, +1) | History | Source | Diff
· /Integrity.c (-1, +1) | History | Source | Diff
· /Integrity.h (-1, +1) | History | Source | Diff
· /MessageSupport.c (-1, +1) | History | Source | Diff
· /MessageSupport.h (-1, +1) | History | Source | Diff
· /NVDataMgmt.c (-1, +1) | History | Source | Diff
· /NVDataMgmt.h (-1, +1) | History | Source | Diff
· /NVDataMgmtDGRecords.h (-1, +1) | History | Source | Diff
· /NVDataMgmtHDRecords.h (-1, +1) | History | Source | Diff
· /PersistentAlarm.c (-1, +1) | History | Source | Diff
· /PersistentAlarm.h (-1, +1) | History | Source | Diff
· /RTC.c (-1, +1) | History | Source | Diff
· /RTC.h (-1, +1) | History | Source | Diff
… 7 more files in changeset.
]]> DG-DEN-17299-1: closed by Dara Navaei Mon, 16 Jun 2025 16:26:20 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17299-1 https://devapps.diality.us/cru/DG-DEN-17299-1 Dara Navaei Closed DG-DEN-17299-1 ]]> DG-DEN-17299-1: reviewers finished Mon, 16 Jun 2025 15:23:32 -0700 https://devapps.diality.us/cru/DG-DEN-17299-1 https://devapps.diality.us/cru/DG-DEN-17299-1 Michael Garthwaite finished reviewing DG-DEN-17299-1 DG-DEN-17299_Release 22 P1B Staging ]]> DG-DEN-17299-1: reviewers finished Fri, 13 Jun 2025 14:33:31 -0700 https://devapps.diality.us/cru/DG-DEN-17299-1 https://devapps.diality.us/cru/DG-DEN-17299-1 Sean Nash finished reviewing DG-DEN-17299-1 DG-DEN-17299_Release 22 P1B Staging ]]> DG-DEN-17299-1: started by Dara Navaei Fri, 13 Jun 2025 09:11:58 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17299-1 https://devapps.diality.us/cru/DG-DEN-17299-1 Dara Navaei started review DG-DEN-17299-1 ]]> DG-DENBUG-318-1: closed by Dara Navaei Thu, 12 Jun 2025 15:01:08 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-318-1 https://devapps.diality.us/cru/DG-DENBUG-318-1 Dara Navaei Closed DG-DENBUG-318-1 ]]> fwcommon (DENBUG-335-air-trap-fill-design-improvem): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 12 Jun 2025 15:01:02 -0700 Dara Navaei https://devapps.diality.us/changelog/fwcommon?cs=2b2282f2c9eae29bf860b3154cabd0289115551b https://devapps.diality.us/changelog/fwcommon?cs=2b2282f2c9eae29bf860b3154cabd0289115551b Dara Navaei committed 2b2282f on branch DENBUG-328-venous-pressure-alarm-did-not-trigger-when-pressure-dropped-to-0-mmHg-STAGING, DENBUG-335-air-trap-fill-design-improvem and 2 more in fwcommon Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /Common.h (-1, +1) | History | Source | Diff
· /NVDataMgmt.c (-1, +1) | History | Source | Diff
· /NVDataMgmt.h (-1, +1) | History | Source | Diff
· /NVDataMgmtHDRecords.h (-1, +1) | History | Source | Diff
]]> DG-DENBUG-318-1: reviewers finished Mon, 09 Jun 2025 09:33:33 -0700 https://devapps.diality.us/cru/DG-DENBUG-318-1 https://devapps.diality.us/cru/DG-DENBUG-318-1 Michael Garthwaite finished reviewing DG-DENBUG-318-1 DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging ]]> DG-DENBUG-318-1: reviewers finished Thu, 05 Jun 2025 16:20:08 -0700 https://devapps.diality.us/cru/DG-DENBUG-318-1 https://devapps.diality.us/cru/DG-DENBUG-318-1 Sean Nash finished reviewing DG-DENBUG-318-1 DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging ]]> DG-DENBUG-318-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 05 Jun 2025 16:19:53 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22161 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22161 Sean Nash replied to Dara Navaei in DG-DENBUG-318-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-318-1: comment by Dara Navaei "Done" Thu, 05 Jun 2025 16:17:10 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22160 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22160 Dara Navaei replied to Sean Nash in DG-DENBUG-318-1

Done

]]> DG-DENBUG-318-1: comment by Sean Nash "hd mode should be >= standby mode. You have it..." Thu, 05 Jun 2025 10:01:26 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22153 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22153 Sean Nash commented on DG-DENBUG-318-1

hd mode should be >= standby mode. You have it backward.

]]> DG-DENBUG-318-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 05 Jun 2025 10:00:01 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22149 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22149 Sean Nash replied to Dara Navaei in DG-DENBUG-318-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-318-1: comment by Dara Navaei "Done." Thu, 05 Jun 2025 09:20:50 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22147 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22147 Dara Navaei replied to Sean Nash in DG-DENBUG-318-1

Done.

]]> DG-DENBUG-318-1: comment by Sean Nash "Should we have before and after values in event..." Thu, 29 May 2025 15:41:18 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22129 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22129 Sean Nash commented on DG-DENBUG-318-1

Should we have before and after values in event data?

]]> fwcommon (DENBUG-335-air-trap-fill-design-improvem): DENBUG-318 changed the RO rejection ration in institutional to percent and min as in integer Tue, 27 May 2025 16:06:09 -0700 Dara Navaei https://devapps.diality.us/changelog/fwcommon?cs=4419915f36401435db029feebcac40a7d5e07b2d https://devapps.diality.us/changelog/fwcommon?cs=4419915f36401435db029feebcac40a7d5e07b2d Dara Navaei committed 4419915 on branch DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging, DENBUG-328-venous-pressure-alarm-did-not-trigger-when-pressure-dropped-to-0-mmHg-STAGING and 3 more in fwcommon DENBUG-318 changed the RO rejection ration in institutional to percent and min as in integer

· /Common.h (-1, +1) | History | Source | Diff
· /NVDataMgmt.c (-13, +9) | History | Source | Diff
· /NVDataMgmt.h (-2, +2) | History | Source | Diff
· /NVDataMgmtHDRecords.h (-1, +1) | History | Source | Diff
]]> DG-DENBUG-318-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 27 May 2025 09:14:02 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22095 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22095 Sean Nash replied to Dara Navaei in DG-DENBUG-318-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-318-1: comment by Dara Navaei "Removed. UI is updated too." Tue, 27 May 2025 09:13:09 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22094 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22094 Dara Navaei replied to Sean Nash in DG-DENBUG-318-1

Removed. UI is updated too.

]]> DG-DENBUG-318-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 27 May 2025 09:08:24 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22093 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22093 Sean Nash replied to Dara Navaei in DG-DENBUG-318-1

RESOLVED in CODE WALKTHROUGH.

]]> fwcommon (DENBUG-335-air-trap-fill-design-improvem): DENBUG-318 added the minimum inlet water conductivity alarm limit to the HD institutional record Thu, 22 May 2025 17:36:00 -0700 Dara Navaei https://devapps.diality.us/changelog/fwcommon?cs=e8ecb7368ebfeb64b8664a06ead7968d408dcba2 https://devapps.diality.us/changelog/fwcommon?cs=e8ecb7368ebfeb64b8664a06ead7968d408dcba2 Dara Navaei committed e8ecb73 on branch DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging, DENBUG-328-venous-pressure-alarm-did-not-trigger-when-pressure-dropped-to-0-mmHg-STAGING and 3 more in fwcommon DENBUG-318 added the minimum inlet water conductivity alarm limit to the HD institutional record

· /Common.h (-0, +7) | History | Source | Diff
· /NVDataMgmt.c (-0, +15) | History | Source | Diff
· /NVDataMgmt.h (-0, +1) | History | Source | Diff
· /NVDataMgmtHDRecords.h (-0, +1) | History | Source | Diff
]]> DG-DENBUG-318-1: comment by Dara Navaei "Done" Thu, 22 May 2025 13:35:26 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22072 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22072 Dara Navaei replied to Sean Nash in DG-DENBUG-318-1

Done

]]> DG-DENBUG-318-1: comment by Sean Nash "It is an input - don't remove flag there. It i..." Thu, 22 May 2025 12:54:23 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22056 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22056 Sean Nash replied to Dara Navaei in DG-DENBUG-318-1

It is an input - don't remove flag there. It is not an output - so remove it there.

]]> DG-DENBUG-318-1: comment by Dara Navaei "Done" Wed, 21 May 2025 15:28:10 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22055 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22055 Dara Navaei replied to Sean Nash in DG-DENBUG-318-1

Done

]]> DG-DENBUG-318-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 May 2025 09:03:06 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22049 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22049 Sean Nash replied to Dara Navaei in DG-DENBUG-318-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-318-1: comment by Sean Nash "I don't see the flag being set in this function..." Wed, 21 May 2025 08:59:45 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22048 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22048 Sean Nash commented on DG-DENBUG-318-1

I don't see the flag being set in this function.

]]> DG-DENBUG-318-1: comment by Sean Nash "Why are we keeping these in the broadcast?" Wed, 21 May 2025 08:55:33 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22047 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22047 Sean Nash commented on DG-DENBUG-318-1

Why are we keeping these in the broadcast?

]]> DG-DENBUG-318-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 21 May 2025 08:53:16 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22046 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22046 Sean Nash replied to Dara Navaei in DG-DENBUG-318-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-318-1: comment by Dara Navaei "Done" Tue, 20 May 2025 13:39:54 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22044 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22044 Dara Navaei replied to Sean Nash in DG-DENBUG-318-1

Done

]]> DG-DENBUG-318-1: comment by Dara Navaei "Done" Tue, 20 May 2025 13:38:53 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22043 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22043 Dara Navaei replied to Sean Nash in DG-DENBUG-318-1

Done

]]> DG-DENBUG-318-1: comment by Sean Nash "Should you do something with the received max r..." Tue, 20 May 2025 13:00:40 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22042 https://devapps.diality.us/cru/DG-DENBUG-318-1/#c22042 Sean Nash commented on DG-DENBUG-318-1

Should you do something with the received max ratio? It's local, so it's just being dropped.

]]>