Fisheye on dgfirmware/firmware/App/Modes/ModeFault.h

DG-DEN-2650-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:42:37 -0700

Dara Navaei Closed DG-DEN-2650-1

DG-DEN-2650-1: reviewers finished

Thu, 19 Oct 2023 08:42:03 -0700

Dara Navaei finished reviewing DG-DEN-2650-1

DG-DEN-2650_DG Firmware Infrastructure

DG-DEN-2650-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:41:49 -0700

Dara Navaei replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-2650-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:41:19 -0700

Dara Navaei started review DG-DEN-2650-1

DG-DEN-7568-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:06:55 -0700

Dara Navaei Closed DG-DEN-7568-1

DG-DEN-7568-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:06:41 -0700

Dara Navaei replied to Sean Nash in DG-DEN-7568-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-7568-1: reviewers resumed

Thu, 19 Oct 2023 08:05:53 -0700

Sean Nash , qnguyen (deleted user) and pmontazemi (deleted user) resumed reviewing DG-DEN-7568-1

DG-DEN-7568_DG Mode Flush

DG-DEN-7568-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:05:49 -0700

Dara Navaei started review DG-DEN-7568-1

DG-DEN-9480-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:05:20 -0700

Dara Navaei Closed DG-DEN-9480-1

DG-DEN-9480-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:05:10 -0700

Dara Navaei replied to Sean Nash in DG-DEN-9480-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-9480-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:03:54 -0700

Dara Navaei started review DG-DEN-9480-1

DG-UCOMMITS-37: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 13:21:06 -0700

Sean Nash Closed DG-UCOMMITS-37

DG-UCOMMITS-37: reviewers finished

Thu, 03 Aug 2023 10:09:19 -0700

Dara Navaei finished reviewing DG-UCOMMITS-37

DG Staging Unreviewed Commits

DG-UCOMMITS-37: reviewers finished

Wed, 02 Aug 2023 16:01:41 -0700

Sean Nash finished reviewing DG-UCOMMITS-37

DG Staging Unreviewed Commits

DG-UCOMMITS-37: started by Dara Navaei

Dara Navaei — Mon, 08 May 2023 09:44:32 -0700

Dara Navaei started review DG-UCOMMITS-37

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 03 Jan 2023 10:10:54 -0800

Dara Navaei committed 6499ea2 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 174 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 84 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 21 Dec 2022 15:02:37 -0800

Dara Navaei committed 81769c6 on branch DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 175 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-2, +2)

| History

| Source

| Diff

… 12 more files in changeset.

DG-DEN-14307-1: closed by Dara Navaei

Dara Navaei — Wed, 21 Dec 2022 15:02:13 -0800

Dara Navaei Closed DG-DEN-14307-1

DG-DEN-14307-1: reviewers finished

Wed, 21 Dec 2022 14:57:24 -0800

wbracken (deleted user) and Sean Nash finished reviewing DG-DEN-14307-1

DG-DEN-14307_DG HD Dev HD DG Dvt Update Part 6

DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODE WALKTRHOUGH."

wbracken — Wed, 21 Dec 2022 14:56:32 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODE WALKTRHOUGH.

DG-DEN-14307-1: comment by Dara Navaei "These two variables are local."

Dara Navaei — Wed, 21 Dec 2022 14:55:29 -0800

Dara Navaei replied to wbracken (deleted user) in DG-DEN-14307-1

These two variables are local.

DG-DEN-14307-1: comment by wbracken "Add concCap and diaCap to header."

wbracken — Wed, 21 Dec 2022 14:52:49 -0800

wbracken (deleted user) commented on DG-DEN-14307-1

Add concCap and diaCap to header.

DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH."

wbracken — Wed, 21 Dec 2022 14:44:32 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

DG-DEN-14307-1: comment by Dara Navaei "Done"

Dara Navaei — Wed, 21 Dec 2022 13:04:50 -0800

Dara Navaei replied to wbracken (deleted user) in DG-DEN-14307-1

Done

DG-DEN-14307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 21 Dec 2022 13:04:04 -0800

Sean Nash replied to Sean Nash in DG-DEN-14307-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH."

wbracken — Wed, 21 Dec 2022 12:13:27 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

DG-DEN-14307-1: comment by wbracken "Should add alarmDetectedPendingTrigger and preF..."

wbracken — Wed, 21 Dec 2022 12:12:19 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14307-1

Should add alarmDetectedPendingTrigger and preFlushState.

DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH."

wbracken — Wed, 21 Dec 2022 12:10:54 -0800

wbracken (deleted user) replied to Dara Navaei in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH."

wbracken — Wed, 21 Dec 2022 12:09:54 -0800

wbracken (deleted user) replied to wbracken (deleted user) in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.

DG-DEN-14307-1: comment by wbracken "RESOLVED IN CODEWALKTHROUGH."

wbracken — Wed, 21 Dec 2022 12:06:24 -0800

wbracken (deleted user) replied to wbracken (deleted user) in DG-DEN-14307-1

RESOLVED IN CODEWALKTHROUGH.