Fisheye on hdfirmware/firmware/App/Controllers/DialInFlow.h https://devapps.diality.us/changelog/~br%3DDIAL-242-air-bubble-sensor-override/hdfirmware/firmware/App/Controllers/DialInFlow.h Recent activity in "hdfirmware" under directory /firmware/App/Controllers/DialInFlow.h HD-DEN-16778-1: closed by Dara Navaei Fri, 26 Sep 2025 14:01:02 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16778-1 https://devapps.diality.us/cru/HD-DEN-16778-1 Dara Navaei Closed HD-DEN-16778-1 ]]> HD-DENBUG-298-2: closed by Dara Navaei Thu, 10 Apr 2025 15:01:07 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-298-2 https://devapps.diality.us/cru/HD-DENBUG-298-2 Dara Navaei Closed HD-DENBUG-298-2 ]]> HD-DENBUG-298-2: reviewers finished Wed, 09 Apr 2025 16:45:04 -0700 https://devapps.diality.us/cru/HD-DENBUG-298-2 https://devapps.diality.us/cru/HD-DENBUG-298-2 Michael Garthwaite and Sean Nash finished reviewing HD-DENBUG-298-2 HD-DENBUG-298_User Unable TO Deliver Saline P1B Staging ]]> HD-DENBUG-298-2: started by Dara Navaei Tue, 08 Apr 2025 14:25:29 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-298-2 https://devapps.diality.us/cru/HD-DENBUG-298-2 Dara Navaei started review HD-DENBUG-298-2 ]]> HD-DENBUG-298-1: closed by Dara Navaei Fri, 04 Apr 2025 14:57:54 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-298-1 https://devapps.diality.us/cru/HD-DENBUG-298-1 Dara Navaei Closed HD-DENBUG-298-1 ]]> HD-DENBUG-298-1: reviewers finished Fri, 04 Apr 2025 13:56:36 -0700 https://devapps.diality.us/cru/HD-DENBUG-298-1 https://devapps.diality.us/cru/HD-DENBUG-298-1 Michael Garthwaite and Sean Nash finished reviewing HD-DENBUG-298-1 HD-DENBUG-298_User Unable TO Deliver Saline Bolus During Alarm Conditions Where The Blood Pump IS Recirculating ]]> HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 04 Apr 2025 12:50:09 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21896 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21896 Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-298-1: comment by Dara Navaei "Done" Fri, 04 Apr 2025 12:47:27 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21895 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21895 Dara Navaei replied to Sean Nash in HD-DENBUG-298-1

Done

]]> HD-DENBUG-298-1: comment by Sean Nash "Bad practice to have two calls to same function..." Fri, 04 Apr 2025 12:37:00 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21894 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21894 Sean Nash commented on HD-DENBUG-298-1

Bad practice to have two calls to same function here. Possible that 2nd call will return different result.
Should call function once to assign value to a local var prior to if statement and then reference the local var in the if statement.

]]> HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 04 Apr 2025 12:26:59 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21892 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21892 Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-298-1: comment by Dara Navaei "Yes. I think we should have these events to inf..." Fri, 04 Apr 2025 10:54:19 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21891 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21891 Dara Navaei replied to Sean Nash in HD-DENBUG-298-1

Yes. I think we should have these events to information.

]]> HD-DENBUG-298-1: comment by Sean Nash "Are these permanent?" Thu, 03 Apr 2025 09:00:58 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21885 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21885 Sean Nash commented on HD-DENBUG-298-1

Are these permanent?

]]> HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 01 Apr 2025 08:34:57 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21858 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21858 Sean Nash replied to Sean Nash in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 31 Mar 2025 09:05:20 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21843 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21843 Sean Nash replied to Sean Nash in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-298-1: comment by Sean Nash "Add comment explaining what we're doing here." Fri, 28 Mar 2025 13:17:43 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21842 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21842 Sean Nash commented on HD-DENBUG-298-1

Add comment explaining what we're doing here.

]]> HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 28 Mar 2025 13:17:14 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21841 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21841 Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-298-1: comment by Dara Navaei "Moved it to OperationModes" Fri, 28 Mar 2025 13:15:45 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21840 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21840 Dara Navaei replied to Sean Nash in HD-DENBUG-298-1

Moved it to OperationModes

]]> HD-DENBUG-298-1: comment by Sean Nash "For other confirmations, an executive (e.g. ala..." Fri, 28 Mar 2025 10:54:16 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21839 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21839 Sean Nash commented on HD-DENBUG-298-1

For other confirmations, an executive (e.g. alarm mgmt monitor or standby mode exec) is responsible for checking confirmation status and we don't call specific handlers from here. Why can't we follow that design pattern for this confirmation?

]]> HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 28 Mar 2025 10:25:17 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21838 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21838 Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-298-1: comment by Dara Navaei "Done" Wed, 26 Mar 2025 17:52:51 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21837 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21837 Dara Navaei replied to Sean Nash in HD-DENBUG-298-1

Done

]]> HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 26 Mar 2025 09:28:16 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21836 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21836 Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-298-1: comment by Sean Nash "2 blank lines above/below test banner." Wed, 26 Mar 2025 09:21:12 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21835 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21835 Sean Nash commented on HD-DENBUG-298-1

2 blank lines above/below test banner.

]]> HD-DENBUG-298-1: comment by Dara Navaei "Done" Tue, 25 Mar 2025 09:41:32 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21831 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21831 Dara Navaei replied to Sean Nash in HD-DENBUG-298-1

Done

]]> HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 25 Mar 2025 09:37:41 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21830 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21830 Sean Nash replied to Sean Nash in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-298-1: comment by Sean Nash "Last condition is wrong (dialysate recirc block..." Tue, 25 Mar 2025 09:36:56 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21829 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21829 Sean Nash commented on HD-DENBUG-298-1

Last condition is wrong (dialysate recirc blocked). Should be no rinseback.

]]> HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 25 Mar 2025 09:33:34 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21828 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21828 Sean Nash replied to Sean Nash in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-298-1: comment by Sean Nash "These alarms we're demoting from HD fault shoul..." Fri, 21 Mar 2025 10:33:33 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21823 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21823 Sean Nash commented on HD-DENBUG-298-1

These alarms we're demoting from HD fault should have their ranks demoted to 110 (like DG faults).

]]> HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 21 Mar 2025 08:53:39 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21822 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21822 Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Fri, 21 Mar 2025 08:50:20 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21821 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21821 Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DENBUG-298-1: comment by Sean Nash "Condition is not right. Blood leak recover is ..." Fri, 21 Mar 2025 08:43:44 -0700 Sean Nash https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21820 https://devapps.diality.us/cru/HD-DENBUG-298-1/#c21820 Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

Condition is not right. Blood leak recover is only relevant in treatment stop state, so we shouldn't care about that state if we're in dialysis.

]]>