Fisheye on dgfirmware/firmware/App/Controllers/FlowSensors.h

Fisheye on dgfirmware/firmware/App/Controllers/FlowSensors.h https://devapps.diality.us/changelog/~br%3DDIAL-281-requesting-heat-disinfect-timer-overrides/dgfirmware/firmware/App/Controllers/FlowSensors.h Recent activity in "dgfirmware" under directory /firmware/App/Controllers/FlowSensors.h DG-DEN-13460-2: closed by Dara Navaei Wed, 18 Oct 2023 21:20:43 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2 https://devapps.diality.us/cru/DG-DEN-13460-2 Dara Navaei Closed DG-DEN-13460-2 ]]> DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:20:31 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2/#c19072 https://devapps.diality.us/cru/DG-DEN-13460-2/#c19072 Dara Navaei replied to Sean Nash in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:19:58 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2/#c19071 https://devapps.diality.us/cru/DG-DEN-13460-2/#c19071 Dara Navaei replied to wbracken (deleted user) in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:19:26 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2/#c19070 https://devapps.diality.us/cru/DG-DEN-13460-2/#c19070 Dara Navaei replied to wbracken (deleted user) in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13460-2: started by Dara Navaei Wed, 18 Oct 2023 21:18:57 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2 https://devapps.diality.us/cru/DG-DEN-13460-2 Dara Navaei started review DG-DEN-13460-2 ]]> DG-DEN-13598-2: closed by Dara Navaei Wed, 18 Oct 2023 21:18:20 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2 https://devapps.diality.us/cru/DG-DEN-13598-2 Dara Navaei Closed DG-DEN-13598-2 ]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:18:08 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19069 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19069 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:18:03 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19068 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19068 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:17:22 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19067 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19067 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:17:11 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19066 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19066 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:16:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19065 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19065 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:16:38 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19064 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19064 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:16:26 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19063 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19063 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:15:44 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2/#c19062 https://devapps.diality.us/cru/DG-DEN-13598-2/#c19062 Dara Navaei replied to Dong Nguyen in DG-DEN-13598-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13598-2: started by Dara Navaei Wed, 18 Oct 2023 21:15:09 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13598-2 https://devapps.diality.us/cru/DG-DEN-13598-2 Dara Navaei started review DG-DEN-13598-2 ]]> DG-DEN-13834-1: closed by Dara Navaei Wed, 18 Oct 2023 21:05:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13834-1 https://devapps.diality.us/cru/DG-DEN-13834-1 Dara Navaei Closed DG-DEN-13834-1 ]]> DG-DEN-13834-1: comment by Dara Navaei "RESOLVED IN CODE WALKTHROUGH" Wed, 18 Oct 2023 21:05:20 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13834-1/#c19058 https://devapps.diality.us/cru/DG-DEN-13834-1/#c19058 Dara Navaei replied to wbracken (deleted user) in DG-DEN-13834-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-13834-1: started by Dara Navaei Wed, 18 Oct 2023 21:03:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13834-1 https://devapps.diality.us/cru/DG-DEN-13834-1 Dara Navaei started review DG-DEN-13834-1 ]]> dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 08 Aug 2023 13:38:26 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=5fc30ce9beec03fad785ce9f9e6602d4b49079fa https://devapps.diality.us/changelog/dgfirmware?cs=5fc30ce9beec03fad785ce9f9e6602d4b49079fa Dara Navaei committed 5fc30ce on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/FlowSensors.c (-2, +2) | History | Source | Diff

· /firmware/App/Controllers/FlowSensors.h (-2, +2) | History | Source | Diff

· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff

· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff

]]> DG-DIAL-273-1: closed by Michael Garthwaite Tue, 08 Aug 2023 13:34:18 -0700 Michael Garthwaite https://devapps.diality.us/cru/DG-DIAL-273-1 https://devapps.diality.us/cru/DG-DIAL-273-1 Michael Garthwaite Closed DG-DIAL-273-1 ]]> DG-DIAL-273-1: reviewers finished Tue, 08 Aug 2023 13:26:41 -0700 https://devapps.diality.us/cru/DG-DIAL-273-1 https://devapps.diality.us/cru/DG-DIAL-273-1 wbracken (deleted user) and Sean Nash finished reviewing DG-DIAL-273-1 DG-DIAL-273_Need Override For Dg.Flow Sensors.Measured Raw Dialysate Flow Lpm ]]> DG-DIAL-273-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Tue, 08 Aug 2023 13:26:32 -0700 wbracken https://devapps.diality.us/cru/DG-DIAL-273-1/#c18500 https://devapps.diality.us/cru/DG-DIAL-273-1/#c18500 wbracken (deleted user) replied to Michael Garthwaite in DG-DIAL-273-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DIAL-273-1: comment by Michael Garthwaite "Fixed. Thanks!" Tue, 08 Aug 2023 13:17:25 -0700 Michael Garthwaite https://devapps.diality.us/cru/DG-DIAL-273-1/#c18499 https://devapps.diality.us/cru/DG-DIAL-273-1/#c18499 Michael Garthwaite replied to wbracken (deleted user) in DG-DIAL-273-1

Fixed. Thanks!

]]> DG-DIAL-273-1: comment by wbracken "Update @param with raw" Thu, 03 Aug 2023 12:33:30 -0700 wbracken https://devapps.diality.us/cru/DG-DIAL-273-1/#c18411 https://devapps.diality.us/cru/DG-DIAL-273-1/#c18411 wbracken (deleted user) commented on DG-DIAL-273-1

Update @param with raw

]]> DG-DIAL-273-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 08 Aug 2023 12:33:10 -0700 Sean Nash https://devapps.diality.us/cru/DG-DIAL-273-1/#c18494 https://devapps.diality.us/cru/DG-DIAL-273-1/#c18494 Sean Nash replied to Michael Garthwaite in DG-DIAL-273-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DIAL-273-1: comment by Michael Garthwaite "Fixed. Thanks!" Tue, 08 Aug 2023 12:00:51 -0700 Michael Garthwaite https://devapps.diality.us/cru/DG-DIAL-273-1/#c18493 https://devapps.diality.us/cru/DG-DIAL-273-1/#c18493 Michael Garthwaite replied to Sean Nash in DG-DIAL-273-1

Fixed. Thanks!

]]> DG-DIAL-273-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 08 Aug 2023 11:28:04 -0700 Sean Nash https://devapps.diality.us/cru/DG-DIAL-273-1/#c18491 https://devapps.diality.us/cru/DG-DIAL-273-1/#c18491 Sean Nash replied to Michael Garthwaite in DG-DIAL-273-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DIAL-273-1: comment by Sean Nash "Remove blank line." Tue, 08 Aug 2023 10:58:53 -0700 Sean Nash https://devapps.diality.us/cru/DG-DIAL-273-1/#c18489 https://devapps.diality.us/cru/DG-DIAL-273-1/#c18489 Sean Nash commented on DG-DIAL-273-1

Remove blank line.

]]> DG-DIAL-273-1: comment by Michael Garthwaite "We're starting seeing a trend where V&V want to..." Mon, 07 Aug 2023 08:48:43 -0700 Michael Garthwaite https://devapps.diality.us/cru/DG-DIAL-273-1/#c18461 https://devapps.diality.us/cru/DG-DIAL-273-1/#c18461 Michael Garthwaite replied to Sean Nash in DG-DIAL-273-1

We're starting seeing a trend where V&V want to override pre-calibrated values ( like the LC structure above ). I followed the LC override style since it has similar behavior. I have no issue splitting

]]> DG-DIAL-273-1: comment by Sean Nash "This is non-standard override record and approa..." Fri, 04 Aug 2023 10:11:27 -0700 Sean Nash https://devapps.diality.us/cru/DG-DIAL-273-1/#c18442 https://devapps.diality.us/cru/DG-DIAL-273-1/#c18442 Sean Nash commented on DG-DIAL-273-1

This is non-standard override record and approach. Is there any reason why you didn't just create a separate override command and message to override raw flow?

]]>