Fisheye on dgfirmware/firmware/App/Modes/ModeFill.c

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 30 Aug 2023 15:48:53 -0700

Dara Navaei committed 16c0f81 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16093 fixed code review comments

Vinayakam Mani — Fri, 25 Aug 2023 14:50:00 -0700

Vinayakam Mani committed 6e49f49 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more in dgfirmware

DEN-16093 fixed code review comments

· /firmware/App/Modes/ModeFill.c

(-2, +5)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16093-Increased conductivity percentage check and time out values

Vinayakam Mani — Fri, 25 Aug 2023 13:21:15 -0700

Vinayakam Mani committed ed367cb on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more in dgfirmware

DEN-16093-Increased conductivity percentage check and time out values

· /firmware/App/Modes/ModeFill.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): take latest changes from staging

Vinayakam Mani — Fri, 25 Aug 2023 13:06:48 -0700

Vinayakam Mani committed 4b528a5 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more in dgfirmware

take latest changes from staging

· /firmware/App/Modes/ModeFill.c	(-5, +13)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-4, +58)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-5, +69)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +7)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16093-changed prime Max time and conductivity poercent check

Vinayakam Mani — Wed, 23 Aug 2023 10:21:01 -0700

Vinayakam Mani committed 2de5552 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more in dgfirmware

DEN-16093-changed prime Max time and conductivity poercent check

· /firmware/App/Modes/ModeFill.c

(-5, +5)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 18 Aug 2023 13:50:28 -0700

Dara Navaei committed b766ff8 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 75 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Drivers/SafetyShutdown.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/WatchdogMgmt.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-16250 updated doxygen comment

Dara Navaei — Fri, 18 Aug 2023 13:45:31 -0700

Dara Navaei committed 5bf4b57 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 76 more in dgfirmware

DEN-16250 updated doxygen comment

· /firmware/App/Modes/ModeFill.c

(-2, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15250 addressed alarm 207

Dara Navaei — Thu, 17 Aug 2023 14:50:39 -0700

Dara Navaei committed bcd5068 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 76 more in dgfirmware

DEN-15250 addressed alarm 207

· /firmware/App/Modes/ModeFill.c

(-5, +13)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-16250 added the FMP check flag to state transition function in mode fill

Dara Navaei — Thu, 17 Aug 2023 09:48:03 -0700

Dara Navaei committed 2c23724 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 76 more in dgfirmware

DEN-16250 added the FMP check flag to state transition function in mode fill

· /firmware/App/Modes/ModeFill.c

(-1, +2)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Aug 2023 11:30:57 -0700

Dara Navaei committed 7f64bdb on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 79 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-16215 addressed the code review comments

Dara Navaei — Wed, 16 Aug 2023 10:28:37 -0700

Dara Navaei committed d3e1ad2 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

DEN-16215 addressed the code review comments

· /firmware/App/Modes/ModeFill.c

(-0, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-16215 removed the start state from mode fill

Dara Navaei — Wed, 16 Aug 2023 10:20:10 -0700

Dara Navaei committed 6919275 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

DEN-16215 removed the start state from mode fill

· /firmware/App/Modes/ModeFill.c

(-8, +2)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 10 Aug 2023 08:36:36 -0700

Dara Navaei committed 1a21988 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 84 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeDrain.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

Michael Garthwaite — Thu, 10 Aug 2023 08:15:41 -0700

Michael Garthwaite committed cfcb924 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

· /firmware/App/Modes/ModeFill.c	(-22, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-5, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 09 Aug 2023 17:36:10 -0700

Dara Navaei committed 8ebab81 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-16125 updated the concentrate pumps code to set the direction speed of the concentrate pumps when the measured speed...

Dara Navaei — Wed, 09 Aug 2023 16:44:24 -0700

Dara Navaei committed 56b1e41 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more in dgfirmware

DEN-16125 updated the concentrate pumps code to set the direction speed of the concentrate pumps when the measured speed is called

· /firmware/App/Controllers/ConcentratePumps.c	(-8, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/FlowSensors.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15125 addressed the compiler warnings

Dara Navaei — Wed, 09 Aug 2023 13:33:55 -0700

Dara Navaei committed e7456f2 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more in dgfirmware

DEN-15125 addressed the compiler warnings

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-8, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-19, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15634: code review comments

Michael Garthwaite — Tue, 08 Aug 2023 13:37:50 -0700

Michael Garthwaite committed 8a9d78a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

DEN-15634: code review comments

· /firmware/App/Modes/ModeFill.c

(-1, +2)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15634: implemented bad fill signal on fill and drain modes. Implemented drain mode broadcast

Michael Garthwaite — Mon, 07 Aug 2023 16:13:09 -0700

Michael Garthwaite committed 7295613 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more in dgfirmware

DEN-15634: implemented bad fill signal on fill and drain modes. Implemented drain mode broadcast

· /firmware/App/Modes/ModeDrain.c	(-2, +36)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.h	(-1, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-0, +13)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 26 Jul 2023 11:39:37 -0700

Dara Navaei committed 9b8889b on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 92 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15921 changed the active cool to transition to cancel water path instead of basic path when caps are not on

Dara Navaei — Mon, 24 Jul 2023 15:07:01 -0700

Dara Navaei committed f62ad14 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

DEN-15921 changed the active cool to transition to cancel water path instead of basic path when caps are not on

· /firmware/App/Modes/ModeFill.c	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 13 Jul 2023 11:30:03 -0700

Dara Navaei committed 39c8361 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 98 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/TemperatureSensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15660 addressed the code review comments

Dara Navaei — Wed, 12 Jul 2023 10:47:52 -0700

Dara Navaei committed 965a35a on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 98 more in dgfirmware

DEN-15660 addressed the code review comments

· /firmware/App/Controllers/TemperatureSensors.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-21, +24)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeDrain.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-12, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-28, +16)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.h	(-2, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15809 added code to clear the dialysate generation alarm 147

Dara Navaei — Tue, 11 Jul 2023 15:11:00 -0700

Dara Navaei committed eca8d32 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 98 more in dgfirmware

DEN-15809 added code to clear the dialysate generation alarm 147

· /firmware/App/Modes/ModeFill.c	(-0, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.c	(-1, +13)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenIdle.h	(-0, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15660, DEN-15781, added code to not check the dialysate temperature sensorswhen the dialysate flow is zero. DEN-1580...

Dara Navaei — Tue, 11 Jul 2023 08:52:41 -0700

Dara Navaei committed 59b7b1c on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 98 more in dgfirmware

DEN-15660, DEN-15781, added code to not check the dialysate temperature sensorswhen the dialysate flow is zero. DEN-15808, Added code to process the empty jug alarm

· /firmware/App/Controllers/TemperatureSensors.c	(-6, +10)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 15 Jun 2023 17:09:43 -0700

Dara Navaei committed a683ad9 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 105 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15571, DEN-15398 changed the fill mode full speed prime time from 8 seconds to 7 seconds

Dara Navaei — Thu, 15 Jun 2023 16:24:36 -0700

Dara Navaei committed 47e9d94 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 106 more in dgfirmware

DEN-15571, DEN-15398 changed the fill mode full speed prime time from 8 seconds to 7 seconds

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 14 Jun 2023 09:57:02 -0700

Dara Navaei committed d325999 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 106 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c

(-1, +1)

| History

| Source

| Diff

… 11 more files in changeset.

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-15367 addressed the code review comments

Dara Navaei — Tue, 13 Jun 2023 10:37:58 -0700

Dara Navaei committed fab0257 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 107 more in dgfirmware

DEN-15367 addressed the code review comments

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-7, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-3, +14)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): -DEN-15367 fixed the transition to cancel water path in RO permeate sample mode -DEN-14004 changed the request message I...

Dara Navaei — Sun, 11 Jun 2023 14:24:32 -0700

Dara Navaei committed 66fe4aa on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 107 more in dgfirmware

-DEN-15367 fixed the transition to cancel water path in RO permeate sample mode -DEN-14004 changed the request message ID to 0x89 from UI to send the DG service record -DEN-15192 changed the concentrate pumps low speed check threshold -DEN-15509 changed the reservoir full threshold from 1700 mL to 1850 mL.

· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-8, +43)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +4)	\| History	\| Source	\| Diff