Fisheye on ro-firmware/firmware/App/Modes

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1809 Resolved conflicts while merging staging

Raghu Kallala — Thu, 04 Sep 2025 13:19:55 -0700

Raghu Kallala committed 60df6fd on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

LDT-1809 Resolved conflicts while merging staging

· /firmware/App/Controllers/ROPump.c	(-16, +35)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): LDT-1735: fixed merge conflicts.

Wed, 03 Sep 2025 14:28:04 -0700

Shyam Kumar Mathamala committed d5f58f8 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 4 more in ro-firmware

LDT-1735: fixed merge conflicts.

· /firmware/App/Modes/InletPressureCheck.c	(-0, +368)	\| History	\| Source
· /firmware/App/Services/Messaging.c	(-0, +3)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: code review comments. comment aligning. fix ro pump control calling set pwm pct when it should have been pwm c...

Michael Garthwaite — Wed, 03 Sep 2025 09:44:56 -0700

Michael Garthwaite committed 30c175a on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: code review comments. comment aligning. fix ro pump control calling set pwm pct when it should have been pwm cnt

· /firmware/App/Controllers/PermeateTank.c	(-8, +11)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-11, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/InletPressureCheck.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Merge branch 'staging' into LDT-1242-iofp-finalize-permeate-tank

Michael Garthwaite — Wed, 03 Sep 2025 08:49:43 -0700

Michael Garthwaite committed c0fe2ab on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

Merge branch 'staging' into LDT-1242-iofp-finalize-permeate-tank

· /firmware/App/Modes/ModePreGenPermeate.c

(-1, +8)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: added TODO for condition check when P7 is no longer available.

Michael Garthwaite — Wed, 03 Sep 2025 08:42:14 -0700

Michael Garthwaite committed 85ec68b on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: added TODO for condition check when P7 is no longer available.

· /firmware/App/Modes/FlushConcentrate.c

(-2, +2)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1809 latest from staging

Raghu Kallala — Tue, 02 Sep 2025 11:10:25 -0700

Raghu Kallala committed 62c5b1e on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

LDT-1809 latest from staging

· /firmware/App/Modes/ModePreGenPermeate.c

(-1, +8)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: updates to pre gen mode timeouts

Michael Garthwaite — Fri, 29 Aug 2025 09:14:37 -0700

Michael Garthwaite committed d163e3c on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: updates to pre gen mode timeouts

· /firmware/App/Modes/FlushPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Updated ToDo check for inletpressurecheck init call

Raghu Kallala — Thu, 28 Aug 2025 13:40:10 -0700

Raghu Kallala committed c97730c on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Updated ToDo check for inletpressurecheck init call

· /firmware/App/Modes/ModePreGenPermeate.c

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: updated flow control curve. Renamed fp def op modes. Closing P39 on TANK FULL state

Michael Garthwaite — Thu, 28 Aug 2025 08:51:16 -0700

Michael Garthwaite committed af6229d on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: updated flow control curve. Renamed fp def op modes. Closing P39 on TANK FULL state

· /firmware/App/Controllers/PermeateTank.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPOperationModes.c	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Addressed review comment to remove flag assignment in paused state.

Raghu Kallala — Wed, 27 Aug 2025 08:16:33 -0700

Raghu Kallala committed f31d172 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Addressed review comment to remove flag assignment in paused state.

· /firmware/App/Modes/InletPressureCheck.c

(-1, +0)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

Raghu Kallala — Tue, 26 Aug 2025 10:37:51 -0700

Raghu Kallala committed ba9341b on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

· /firmware/App/Controllers/ROPump.c	(-100, +62)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Addressed review comments.

Raghu Kallala — Wed, 20 Aug 2025 06:31:28 -0700

Raghu Kallala committed e91ecdf on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Addressed review comments.

· /firmware/App/Modes/InletPressureCheck.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/InletPressureCheck.h	(-4, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-2, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Addressed review comments to remove unwanted code lines and handled state assignment.

Raghu Kallala — Tue, 19 Aug 2025 10:24:42 -0700

Raghu Kallala committed 44b3345 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Addressed review comments to remove unwanted code lines and handled state assignment.

· /firmware/App/Modes/InletPressureCheck.c	(-4, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/InletPressureCheck.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-0, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-566: increased permeate flush timer to 5 minutes to support conductivity testing.

Michael Garthwaite — Wed, 13 Aug 2025 15:41:23 -0700

Michael Garthwaite committed 684099b on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 4 more in ro-firmware

LDT-566: increased permeate flush timer to 5 minutes to support conductivity testing.

· /firmware/App/Modes/FlushPermeate.c

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-566: moved valve enum from ro firmware repo to common repo

Michael Garthwaite — Wed, 13 Aug 2025 12:34:01 -0700

Michael Garthwaite committed e8d9c00 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

LDT-566: moved valve enum from ro firmware repo to common repo

· /firmware/App/Controllers/Valves.c	(-20, +20)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-21, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeFault.c	(-2, +2)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-566: moved valve enum from ro firmware repo to common repo

Michael Garthwaite — Wed, 13 Aug 2025 12:34:01 -0700

Michael Garthwaite committed 014dc3d on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 4 more in ro-firmware

LDT-566: moved valve enum from ro firmware repo to common repo

· /firmware/App/Controllers/Valves.c	(-20, +20)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-21, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeFault.c	(-2, +2)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Implemented Inlet Pressure check functionality with Boost Pump

Raghu Kallala — Wed, 13 Aug 2025 07:58:53 -0700

Raghu Kallala committed bdf1e3a on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Implemented Inlet Pressure check functionality with Boost Pump

· /firmware/App/Modes/InletPressureCheck.c	(-0, +371)	\| History	\| Source
· /firmware/App/Modes/InletPressureCheck.h	(-0, +53)	\| History	\| Source
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-0, +2)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments

Michael Garthwaite — Fri, 01 Aug 2025 15:56:30 -0700

Michael Garthwaite committed 6d85a90 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: code review comments

· /firmware/App/Controllers/PermeateTank.c	(-8, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeStandby.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Pressure.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Temperature.c	(-4, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtFP.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaFP.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-4, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommFP.c	(-1, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments.

Michael Garthwaite — Fri, 01 Aug 2025 12:22:15 -0700

Michael Garthwaite committed 9b91228 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: code review comments.

· /firmware/App/Drivers/ConductivitySensor.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.h	(-7, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c	(-4, +8)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.h	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-2, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check ...

Michael Garthwaite — Fri, 01 Aug 2025 12:08:14 -0700

Michael Garthwaite committed 3a5cc58 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check for boost pump.

· /firmware/App/Controllers/BoostPump.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/ConductivitySensor.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PressureSensor.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/PressureCheck.c	(-0, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/PressureCheck.h	(-15, +0)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/WaterQualityMonitor.c	(-5, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes

Michael Garthwaite — Thu, 31 Jul 2025 11:49:31 -0700

Michael Garthwaite committed b92c26d on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes

· /firmware/App/Controllers/BoostPump.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PermeateTank.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-4, +5)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments.

Michael Garthwaite — Wed, 30 Jul 2025 13:30:55 -0700

Michael Garthwaite committed 2652d50 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: code review comments.

· /firmware/App/Controllers/BoostPump.c

(-11, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-650, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-60, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-18, +20)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-3, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-399, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.h

(-59, +0)

| History

| Source

| Diff

· /firmware/App/Modes/FPModeStandby.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-19, +24)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.h

(-2, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FlushFilter.c

(-10, +11)

| History

| Source

| Diff

· /firmware/App/Modes/FlushPermeate.c

(-9, +13)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.c

(-30, +13)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.h

(-9, +4)

| History

| Source

| Diff

· /firmware/App/Monitors/Conductivity.c

(-1, +0)

| History

| Source

| Diff

… 5 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and c...

Michael Garthwaite — Wed, 30 Jul 2025 11:24:46 -0700

Michael Garthwaite committed 6dd382e on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and clear alarm overrides. Reworked temperature monitor to only publish.

· /firmware/App/Controllers/PermeateTank.c

(-5, +350)

| History

| Source

| Diff

· /firmware/App/Controllers/PermeateTank.h

(-7, +10)

| History

| Source

| Diff

· /firmware/App/Modes/FPModeFault.c

(-9, +7)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-5, +6)

| History

| Source

| Diff

· /firmware/App/Modes/FlushFilter.c

(-6, +5)

| History

| Source

| Diff

· /firmware/App/Modes/FlushPermeate.c

(-7, +8)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.c

(-123, +11)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeateDefeatured.c

(-4, +4)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreGenPermeate.c

(-24, +25)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreGenPermeateDefeatured.c

(-12, +12)

| History

| Source

| Diff

· /firmware/App/Monitors/Temperature.c

(-1, +66)

| History

| Source

| Diff

· /firmware/App/Monitors/Temperature.h

(-0, +20)

| History

| Source

| Diff

· /firmware/App/Monitors/WaterQualityMonitor.c

(-76, +0)

| History

| Source

| Diff

· /firmware/App/Monitors/WaterQualityMonitor.h

(-19, +0)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmtFP.c

(-18, +26)

| History

| Source

| Diff

… 6 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Implemented FP fault mode. Removed math includes from flush modes.

Michael Garthwaite — Tue, 29 Jul 2025 13:05:57 -0700

Michael Garthwaite committed f79d373 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: Implemented FP fault mode. Removed math includes from flush modes.

· /firmware/App/Controllers/PermeateTank.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeFault.c	(-19, +245)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeFault.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushFilter.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtFP.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: FP Safety shutdown override. fixed includes.

Michael Garthwaite — Tue, 29 Jul 2025 12:15:18 -0700

Michael Garthwaite committed 8e72441 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: FP Safety shutdown override. fixed includes.

· /firmware/App/Controllers/PermeateTank.c	(-0, +52)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PermeateTank.h	(-0, +65)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PAL.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PAL.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-39, +22)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.h	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeFault.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeFault.h	(-3, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeInitPOST.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeStandby.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPOperationModes.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-1, +3)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): WIP on develop...

Michael Garthwaite — Tue, 29 Jul 2025 10:06:32 -0700

Michael Garthwaite committed dfec1cd on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

WIP on develop

LDT-566: develop fixes

· /firmware/App/Modes/FlushConcentrate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushFilter.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c	(-3, +3)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): WIP on develop...

Michael Garthwaite — Tue, 29 Jul 2025 09:58:35 -0700

Michael Garthwaite committed 94d9379 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

WIP on develop

LDT-566: code review comments. updated common naming to have a FP prefix.

· /firmware/App/Controllers/BoostPump.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Drivers/PressureSensor.c

(-12, +11)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensor.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/FPModeFault.c

(-0, +88)

| History

| Source

· /firmware/App/Modes/FPModeFault.h

(-0, +40)

| History

| Source

· /firmware/App/Modes/FPModeInitPOST.c

(-0, +66)

| History

| Source

· /firmware/App/Modes/FPModeInitPOST.h

(-0, +44)

| History

| Source

· /firmware/App/Modes/FPModeStandby.c

(-0, +149)

| History

| Source

· /firmware/App/Modes/FPModeStandby.h

(-0, +47)

| History

| Source

· /firmware/App/Modes/FPOperationModes.c

(-0, +475)

| History

| Source

· /firmware/App/Modes/FPOperationModes.h

(-0, +62)

| History

| Source

· /firmware/App/Modes/FlushConcentrate.c

(-1, +2)

| History

| Source

| Diff

… 25 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: partial rework of alarm monitoring for water quality based on code review. updated valves to be in sync with la...

Michael Garthwaite — Fri, 25 Jul 2025 08:28:53 -0700

Michael Garthwaite committed 337136f on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: partial rework of alarm monitoring for water quality based on code review. updated valves to be in sync with latest HDD

· /firmware/App/Controllers/Valves.c

(-1, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-1, +4)

| History

| Source

| Diff

· /firmware/App/Modes/FlushConcentrate.c

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Modes/FlushFilter.c

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Modes/FlushPermeate.c

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeate.c

(-0, +7)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenPermeateDefeatured.c

(-0, +6)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreGenPermeate.c

(-0, +3)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreGenPermeateDefeatured.c

(-0, +9)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-0, +3)

| History

| Source

| Diff

· /firmware/App/Monitors/Conductivity.c

(-25, +125)

| History

| Source

| Diff

· /firmware/App/Monitors/Conductivity.h

(-0, +1)

| History

| Source

| Diff

· /firmware/App/Monitors/Pressure.c

(-167, +2)

| History

| Source

| Diff

· /firmware/App/Monitors/Temperature.c

(-308, +2)

| History

| Source

| Diff

… 6 more files in changeset.

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): WIP on develop...

Michael Garthwaite — Tue, 22 Jul 2025 14:51:23 -0700

Michael Garthwaite committed 30d20b2 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

WIP on develop

LDT-566: LDT-676: Removed M7 and P20 valves.

· /firmware/App/Controllers/Valves.h	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: removed unneeded defines. Added percentage values for pwm to RO and boost broadcasts. Removed X5 from pressure ...

Michael Garthwaite — Thu, 17 Jul 2025 15:47:48 -0700

Michael Garthwaite committed 311c75c on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware

LDT-566: removed unneeded defines. Added percentage values for pwm to RO and boost broadcasts. Removed X5 from pressure sensors. Fixed Pre-Generate mode rushing through sub states.

· /firmware/App/Controllers/BoostPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BoostPump.h	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-3, +5)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PressureSensor.c	(-3, +0)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PressureSensor.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-17, +12)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Pressure.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Pressure.h	(-3, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtFP.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-0, +2)	\| History	\| Source	\| Diff