Fisheye on ro-firmware/firmware

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1809 Resolved conflicts while merging staging

Raghu Kallala — Thu, 04 Sep 2025 13:19:55 -0700

Raghu Kallala committed 60df6fd on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

LDT-1809 Resolved conflicts while merging staging

· /firmware/App/Controllers/ROPump.c	(-16, +35)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Dara Navaei — Thu, 04 Sep 2025 09:06:43 -0700

Dara Navaei committed f3ce909 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

· /firmware/App/FPCommon.h

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Dara Navaei — Wed, 03 Sep 2025 14:48:41 -0700

Dara Navaei committed dab0454 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

· /firmware/App/FPCommon.h

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): LDT-1735: fixed merge conflicts.

Wed, 03 Sep 2025 14:28:04 -0700

Shyam Kumar Mathamala committed d5f58f8 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 4 more in ro-firmware

LDT-1735: fixed merge conflicts.

· /firmware/App/Modes/InletPressureCheck.c	(-0, +368)	\| History	\| Source
· /firmware/App/Services/Messaging.c	(-0, +3)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: code review comments. comment aligning. fix ro pump control calling set pwm pct when it should have been pwm c...

Michael Garthwaite — Wed, 03 Sep 2025 09:44:56 -0700

Michael Garthwaite committed 30c175a on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: code review comments. comment aligning. fix ro pump control calling set pwm pct when it should have been pwm cnt

· /firmware/App/Controllers/PermeateTank.c	(-8, +11)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-11, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/InletPressureCheck.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Merge branch 'staging' into LDT-1242-iofp-finalize-permeate-tank

Michael Garthwaite — Wed, 03 Sep 2025 08:49:43 -0700

Michael Garthwaite committed c0fe2ab on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

Merge branch 'staging' into LDT-1242-iofp-finalize-permeate-tank

· /firmware/App/Modes/ModePreGenPermeate.c

(-1, +8)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: reverted RO controller publishing to no longer contain controller debug data

Michael Garthwaite — Wed, 03 Sep 2025 08:49:21 -0700

Michael Garthwaite committed e612f51 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: reverted RO controller publishing to no longer contain controller debug data

· /firmware/App/Controllers/ROPump.c

(-5, +5)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: added TODO for condition check when P7 is no longer available.

Michael Garthwaite — Wed, 03 Sep 2025 08:42:14 -0700

Michael Garthwaite committed 85ec68b on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: added TODO for condition check when P7 is no longer available.

· /firmware/App/Modes/FlushConcentrate.c

(-2, +2)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1809 latest from staging

Raghu Kallala — Tue, 02 Sep 2025 11:10:25 -0700

Raghu Kallala committed 62c5b1e on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

LDT-1809 latest from staging

· /firmware/App/Modes/ModePreGenPermeate.c

(-1, +8)

| History

| Source

| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Dara Navaei — Tue, 02 Sep 2025 11:10:24 -0700

Dara Navaei committed 83a6861 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 4 more in ro-firmware

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

· /firmware/App/FPCommon.h

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: updated pressure sensors to reflect what is inside on alpha units

Michael Garthwaite — Tue, 02 Sep 2025 09:33:30 -0700

Michael Garthwaite committed ce8184d on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: updated pressure sensors to reflect what is inside on alpha units

· /firmware/App/Drivers/PressureSensor.c

(-2, +2)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: updates to pre gen mode timeouts

Michael Garthwaite — Fri, 29 Aug 2025 09:14:37 -0700

Michael Garthwaite committed d163e3c on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: updates to pre gen mode timeouts

· /firmware/App/Modes/FlushPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: updated tank full timing

Michael Garthwaite — Fri, 29 Aug 2025 09:12:06 -0700

Michael Garthwaite committed 37ffdfd on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: updated tank full timing

· /firmware/App/Controllers/PermeateTank.c

(-2, +2)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: reverted flow control output for develop builds as pwm output requires tuning

Michael Garthwaite — Fri, 29 Aug 2025 08:56:43 -0700

Michael Garthwaite committed 85c2344 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: reverted flow control output for develop builds as pwm output requires tuning

· /firmware/App/Controllers/ROPump.c

(-7, +9)

| History

| Source

| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Updated ToDo check for inletpressurecheck init call

Raghu Kallala — Thu, 28 Aug 2025 13:40:10 -0700

Raghu Kallala committed c97730c on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Updated ToDo check for inletpressurecheck init call

· /firmware/App/Modes/ModePreGenPermeate.c

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: opening P34 on tank full state.

Michael Garthwaite — Thu, 28 Aug 2025 09:39:25 -0700

Michael Garthwaite committed 78ae224 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: opening P34 on tank full state.

· /firmware/App/Controllers/PermeateTank.c

(-2, +2)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: converted RO flow control back to outputting PWM percentages instead of target mL/min.

Michael Garthwaite — Thu, 28 Aug 2025 09:30:22 -0700

Michael Garthwaite committed 66880a5 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: converted RO flow control back to outputting PWM percentages instead of target mL/min.

· /firmware/App/Controllers/ROPump.c

(-13, +12)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: updated flow control curve. Renamed fp def op modes. Closing P39 on TANK FULL state

Michael Garthwaite — Thu, 28 Aug 2025 08:51:16 -0700

Michael Garthwaite committed af6229d on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: updated flow control curve. Renamed fp def op modes. Closing P39 on TANK FULL state

· /firmware/App/Controllers/PermeateTank.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPOperationModes.c	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Fixed indentation and review comments

Raghu Kallala — Wed, 27 Aug 2025 14:54:27 -0700

Raghu Kallala committed 98b3a57 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

Fixed indentation and review comments

· /firmware/App/Controllers/ROPump.c

(-18, +18)

| History

| Source

| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Addressed review comment to remove flag assignment in paused state.

Raghu Kallala — Wed, 27 Aug 2025 08:16:33 -0700

Raghu Kallala committed f31d172 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Addressed review comment to remove flag assignment in paused state.

· /firmware/App/Modes/InletPressureCheck.c

(-1, +0)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): fixed review comments

Raghu Kallala — Tue, 26 Aug 2025 14:54:23 -0700

Raghu Kallala committed 71ea7fe on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

fixed review comments

· /firmware/App/Controllers/ROPump.c	(-30, +53)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.c	(-0, +55)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.h	(-0, +2)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

Raghu Kallala — Tue, 26 Aug 2025 10:37:51 -0700

Raghu Kallala committed ba9341b on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

· /firmware/App/Controllers/ROPump.c	(-100, +62)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): LDT-1735:Added Dialin Test Config Support

Mon, 25 Aug 2025 16:52:08 -0700

Shyam Kumar Mathamala committed 052b4a3 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 4 more in ro-firmware

LDT-1735:Added Dialin Test Config Support

· /firmware/App/Services/Messaging.c	(-2, +86)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.h	(-0, +4)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-566: updated RO pwm flow curve from linear to logarithmic.

Michael Garthwaite — Mon, 25 Aug 2025 12:40:16 -0700

Michael Garthwaite committed 617a2fa on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-566: updated RO pwm flow curve from linear to logarithmic.

· /firmware/App/Controllers/ROPump.c

(-6, +7)

| History

| Source

| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): LDT-1735: Added support for Dialin command to set beta h/w.

Mon, 25 Aug 2025 12:13:11 -0700

Shyam Kumar Mathamala committed ea46320 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 4 more in ro-firmware

LDT-1735: Added support for Dialin command to set beta h/w.

· /firmware/App/Drivers/PressureSensor.c

(-9, +16)

| History

| Source

| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Dara Navaei — Fri, 22 Aug 2025 15:21:24 -0700

Dara Navaei committed 77f9dd6 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

· /firmware/App/FPCommon.h

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): removed commented code per review comments

Raghu Kallala — Wed, 20 Aug 2025 08:59:24 -0700

Raghu Kallala committed ff3e2e3 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

removed commented code per review comments

· /firmware/App/Controllers/ROPump.c

(-1, +0)

| History

| Source

| Diff

ro-firmware (LDT-828-stop-state-fp): LDT-828: fixed pressure sensor conversions for alpha units

Michael Garthwaite — Wed, 20 Aug 2025 08:21:51 -0700

Michael Garthwaite committed bbdf8f6 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 6 more in ro-firmware

LDT-828: fixed pressure sensor conversions for alpha units

· /firmware/App/Drivers/PressureSensor.c

(-7, +8)

| History

| Source

| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Addressed review comments.

Raghu Kallala — Wed, 20 Aug 2025 06:31:28 -0700

Raghu Kallala committed e91ecdf on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Addressed review comments.

· /firmware/App/Modes/InletPressureCheck.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/InletPressureCheck.h	(-4, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-2, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Addressed review comments to remove unwanted code lines and handled state assignment.

Raghu Kallala — Tue, 19 Aug 2025 10:24:42 -0700

Raghu Kallala committed 44b3345 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Addressed review comments to remove unwanted code lines and handled state assignment.

· /firmware/App/Modes/InletPressureCheck.c	(-4, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/InletPressureCheck.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-0, +1)	\| History	\| Source	\| Diff