Removed

Removed

updated

added

Added

Removed

Updated

Not necessary

This command should be given once on way out of prior state instead of every 50ms while in this state.
We also need to zero the timer counter at same time so the timeout check below works.

Response needs to be sent immediately (in message handler function). This is too late.

We shouldn't need to do this door check if you've required door be closed for the state.
Call the doorClosedRequired( TRUE ) function on transition into a state that requires the door to be closed and call with ( FALSE ) on transition into a state that doesn't require door to be closed. When required = TRUE, the switch monitor will trigger the door open alarm for you.

Same organization comment that I had for post-tx mode. Let's keep functions related to each pre-tx state together separated by some kind of comment banner.

Remove extra blank line.

Looks like there's plans for 4 post-tx states and we only have your auto eject state implemented here below.
Since all of these 4 states will be implemented in this file, maybe we should organize them - keep functions related to each state together separated by some kind of comment banner.

Not necessary if you give retract command on way out of prior state.

I don't think this if statement is necessary. We wouldn't be in this state if the ejector didn't extend already.
I think we just want to see if BP is home again (completed 1 revolution) so we know when to stop and go to next state.

Give ejector retract command and zero timer counter here too.

Not needed if you do this on way out of prior state.

Start BP and zero timer counter here.

Not necessary if fault property of alarm is TRUE.

Not necessary if you do this on way out of prior state.

Remove ejector homed stuff. Not needed.

Give eject cmd and zero timer counter here.

give BP home command and zero timer counter here.

Not necessary. Just make alarm have fault property = TRUE.

Again, ejector should have been retracted way back in pre-treatment mode. We shouldn't need to do it again.