Fisheye on ro-firmware/firmware/App/Controllers

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): Merge branch 'staging' into LDT-2116-iofp-evaluate-closing-p39

Michael Garthwaite — Thu, 18 Dec 2025 10:59:13 -0800

Michael Garthwaite committed 44dbba5 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

Merge branch 'staging' into LDT-2116-iofp-evaluate-closing-p39

· /firmware/App/Controllers/PermeateTank.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeStandby.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushFilter.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/WaterQualityMonitor.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/WaterQualityMonitor.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-5, +5)	\| History	\| Source	\| Diff

ro-firmware (staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 18 Dec 2025 10:27:26 -0800

Dara Navaei committed ca95dc7 on branch LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BoostPump.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/BoostPump.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/PermeateTank.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/PermeateTank.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-4, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-4, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.h

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Drivers/InternalADC.c

(-0, +16)

| History

| Source

| Diff

… 67 more files in changeset.

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116 addressed rewview comments

Raghu Kallala — Sat, 22 Nov 2025 12:54:01 -0800

Raghu Kallala committed b110edb on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116 addressed rewview comments

· /firmware/App/Controllers/PermeateTank.c	(-5, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushFilter.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-1, +2)	\| History	\| Source	\| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): Fixed reset during fill and full. Adjusted samples for duty cycle average calculation.

Raghu Kallala — Thu, 20 Nov 2025 14:43:18 -0800

Raghu Kallala committed bb1b586 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

Fixed reset during fill and full. Adjusted samples for duty cycle average calculation.

· /firmware/App/Controllers/ROPump.c	(-2, +10)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-6, +3)	\| History	\| Source	\| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116: pushed new closed loop coefficients for tgt flow of 750mL

Michael Garthwaite — Tue, 18 Nov 2025 12:57:35 -0800

Michael Garthwaite committed e706d20 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116: pushed new closed loop coefficients for tgt flow of 750mL

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116 changed Gen logic to go open loop for 3 sec and transition to closed loop.

Raghu Kallala — Mon, 10 Nov 2025 13:30:25 -0800

Raghu Kallala committed 3475e61 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116 changed Gen logic to go open loop for 3 sec and transition to closed loop.

· /firmware/App/Controllers/PermeateTank.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-1, +105)	\| History	\| Source	\| Diff

ro-firmware (staging): LDT-1773: code review comments.

Michael Garthwaite — Mon, 03 Nov 2025 09:13:25 -0800

Michael Garthwaite committed d9204dd on branch LDT-1773-iofp-valve-pwm, LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware

LDT-1773: code review comments.

· /firmware/App/Controllers/Valves.c

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116: code review updates. Change target flow rate from 700 to 750 per system spec. Reverted debugging broadcast for...

Michael Garthwaite — Mon, 03 Nov 2025 09:10:13 -0800

Michael Garthwaite committed 6a318f2 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116: code review updates. Change target flow rate from 700 to 750 per system spec. Reverted debugging broadcast for RO Pump.

· /firmware/App/Controllers/PermeateTank.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-10, +10)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116 added private def for RO pump target flow

Raghu Kallala — Fri, 31 Oct 2025 08:49:33 -0700

Raghu Kallala committed b112f6c on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116 added private def for RO pump target flow

· /firmware/App/Controllers/PermeateTank.c

(-1, +2)

| History

| Source

| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116: possible fix for open loop to target flow transition.

Michael Garthwaite — Tue, 21 Oct 2025 09:46:01 -0700

Michael Garthwaite committed 288bfd7 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116: possible fix for open loop to target flow transition.

· /firmware/App/Controllers/ROPump.c

(-1, +2)

| History

| Source

| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116: updates to ro pump coefficients. updates to permeate tank control while P39 is closed.

Michael Garthwaite — Mon, 20 Oct 2025 20:35:56 -0700

Michael Garthwaite committed 7957cce on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116: updates to ro pump coefficients. updates to permeate tank control while P39 is closed.

· /firmware/App/Controllers/PermeateTank.c	(-2, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-15, +13)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (staging): LDT-1773: updated comments for fpga interface. changed valve pwm period to correct value

Michael Garthwaite — Mon, 29 Sep 2025 14:14:55 -0700

Michael Garthwaite committed 0362e43 on branch LDT-1773-iofp-valve-pwm, LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware

LDT-1773: updated comments for fpga interface. changed valve pwm period to correct value

· /firmware/App/Controllers/Valves.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaFP.c	(-5, +43)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaFP.h	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (staging): LDT-1773: implemented FPGA interface for valve PWM. implemented in valves module

Michael Garthwaite — Fri, 19 Sep 2025 08:58:03 -0700

Michael Garthwaite committed cf82e0c on branch LDT-1773-iofp-valve-pwm, LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware

LDT-1773: implemented FPGA interface for valve PWM. implemented in valves module

· /firmware/App/Controllers/Valves.c	(-0, +12)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaFP.c	(-0, +33)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaFP.h	(-0, +5)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1809 Resolved conflicts while merging staging

Raghu Kallala — Thu, 04 Sep 2025 13:19:55 -0700

Raghu Kallala committed 60df6fd on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

LDT-1809 Resolved conflicts while merging staging

· /firmware/App/Controllers/ROPump.c	(-16, +35)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: code review comments. comment aligning. fix ro pump control calling set pwm pct when it should have been pwm c...

Michael Garthwaite — Wed, 03 Sep 2025 09:44:56 -0700

Michael Garthwaite committed 30c175a on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: code review comments. comment aligning. fix ro pump control calling set pwm pct when it should have been pwm cnt

· /firmware/App/Controllers/PermeateTank.c	(-8, +11)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-11, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/InletPressureCheck.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: reverted RO controller publishing to no longer contain controller debug data

Michael Garthwaite — Wed, 03 Sep 2025 08:49:21 -0700

Michael Garthwaite committed e612f51 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: reverted RO controller publishing to no longer contain controller debug data

· /firmware/App/Controllers/ROPump.c

(-5, +5)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: updated tank full timing

Michael Garthwaite — Fri, 29 Aug 2025 09:12:06 -0700

Michael Garthwaite committed 37ffdfd on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: updated tank full timing

· /firmware/App/Controllers/PermeateTank.c

(-2, +2)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: reverted flow control output for develop builds as pwm output requires tuning

Michael Garthwaite — Fri, 29 Aug 2025 08:56:43 -0700

Michael Garthwaite committed 85c2344 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: reverted flow control output for develop builds as pwm output requires tuning

· /firmware/App/Controllers/ROPump.c

(-7, +9)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: opening P34 on tank full state.

Michael Garthwaite — Thu, 28 Aug 2025 09:39:25 -0700

Michael Garthwaite committed 78ae224 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: opening P34 on tank full state.

· /firmware/App/Controllers/PermeateTank.c

(-2, +2)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: converted RO flow control back to outputting PWM percentages instead of target mL/min.

Michael Garthwaite — Thu, 28 Aug 2025 09:30:22 -0700

Michael Garthwaite committed 66880a5 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: converted RO flow control back to outputting PWM percentages instead of target mL/min.

· /firmware/App/Controllers/ROPump.c

(-13, +12)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: updated flow control curve. Renamed fp def op modes. Closing P39 on TANK FULL state

Michael Garthwaite — Thu, 28 Aug 2025 08:51:16 -0700

Michael Garthwaite committed af6229d on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: updated flow control curve. Renamed fp def op modes. Closing P39 on TANK FULL state

· /firmware/App/Controllers/PermeateTank.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPOperationModes.c	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Fixed indentation and review comments

Raghu Kallala — Wed, 27 Aug 2025 14:54:27 -0700

Raghu Kallala committed 98b3a57 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

Fixed indentation and review comments

· /firmware/App/Controllers/ROPump.c

(-18, +18)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): fixed review comments

Raghu Kallala — Tue, 26 Aug 2025 14:54:23 -0700

Raghu Kallala committed 71ea7fe on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

fixed review comments

· /firmware/App/Controllers/ROPump.c	(-30, +53)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.c	(-0, +55)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.h	(-0, +2)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

Raghu Kallala — Tue, 26 Aug 2025 10:37:51 -0700

Raghu Kallala committed ba9341b on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

· /firmware/App/Controllers/ROPump.c	(-100, +62)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-566: updated RO pwm flow curve from linear to logarithmic.

Michael Garthwaite — Mon, 25 Aug 2025 12:40:16 -0700

Michael Garthwaite committed 617a2fa on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-566: updated RO pwm flow curve from linear to logarithmic.

· /firmware/App/Controllers/ROPump.c

(-6, +7)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): removed commented code per review comments

Raghu Kallala — Wed, 20 Aug 2025 08:59:24 -0700

Raghu Kallala committed ff3e2e3 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

removed commented code per review comments

· /firmware/App/Controllers/ROPump.c

(-1, +0)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): declared result at the top of the scope for test functions

Raghu Kallala — Tue, 19 Aug 2025 10:14:41 -0700

Raghu Kallala committed 4dec0c9 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

declared result at the top of the scope for test functions

· /firmware/App/Controllers/ROPump.c

(-3, +6)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: updated permeate tank control to change based on low level.

Michael Garthwaite — Tue, 19 Aug 2025 09:42:22 -0700

Michael Garthwaite committed 7e4bcfd on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: updated permeate tank control to change based on low level.

· /firmware/App/Controllers/PermeateTank.c	(-6, +10)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PressureSensor.c	(-3, +4)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-566: reverted publishing change for fine tuning.

Michael Garthwaite — Thu, 14 Aug 2025 13:08:58 -0700

Michael Garthwaite committed 73fb203 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 4 more in ro-firmware

LDT-566: reverted publishing change for fine tuning.

· /firmware/App/Controllers/ROPump.c

(-5, +5)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-566: fixed RO Pump publishing to no longer have debug data for PI control

Michael Garthwaite — Thu, 14 Aug 2025 13:07:41 -0700

Michael Garthwaite committed a4ca1bc on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 4 more in ro-firmware

LDT-566: fixed RO Pump publishing to no longer have debug data for PI control

· /firmware/App/Controllers/ROPump.c

(-5, +5)

| History

| Source

| Diff