Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Done.

Done.

· /firmware/App/Controllers/BalancingChamber.c	(-23, +218)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-11, +21)	| History	| Source	| Diff

]]> Fri, 10 Apr 2026 11:44:22 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28291 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28291 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3749-2

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Fri, 10 Apr 2026 11:44:35 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=6d0bd19fb192dcd272fa773e8833862cc8a8f750 https://devapps.diality.us/changelog/dd-firmware?cs=6d0bd19fb192dcd272fa773e8833862cc8a8f750 Dara Navaei committed 6d0bd19 on branch LDT-3103-closed-loop-control-pressure-threshold-fix, staging in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePostGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeService.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-2, +2)	| History	| Source	| Diff

]]> Fri, 10 Apr 2026 11:38:33 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-1195-2 LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F) ]]> Fri, 10 Apr 2026 10:39:20 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3677-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3677-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3677-1 ]]> Fri, 10 Apr 2026 10:38:49 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=e2f19f2fbe7f211de357ce0ed7f23163695c27ca https://devapps.diality.us/changelog/dd-firmware?cs=e2f19f2fbe7f211de357ce0ed7f23163695c27ca Dara Navaei committed e2f19f2 on branch LDT-3103-closed-loop-control-pressure-threshold-fix, staging in dd-firmware Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Fri, 10 Apr 2026 10:38:22 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=6c1e038c32aae95cd5649320d12c1d7239834425 https://devapps.diality.us/changelog/dd-firmware?cs=6c1e038c32aae95cd5649320d12c1d7239834425 Dara Navaei committed 6c1e038 on branch LDT-3103-closed-loop-control-pressure-threshold-fix, staging in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/FPModes/FPOperationModes.c

(-1, +1)

| History

| Source

| Diff

]]> Fri, 10 Apr 2026 10:25:29 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28290 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28290 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

its auto generated . should not change it manually. any way when merging its added correct value

Now we don't need this macro ?

now we are initializing sensor simultaneously?

comments missing

comments missing

This is not clear- please give a detailed description for this variable

use capital for starting letter

please align the comments

please Alignment the comments

Why the order is important here ? please document it

· /firmware/App/Controllers/BalancingChamber.c	(-2, +24)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-4, +18)	| History	| Source	| Diff

]]> Fri, 10 Apr 2026 10:06:32 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 Vendor - TEL - Sameer Poyil joined LEAHI-DD-FIRMWARE-LDT-2008-1 LEAHI-DD-FIRMWARE-LDT-2008_Dialysate Composition - DD - 04: DEV - Feature Implementation ]]> Fri, 10 Apr 2026 10:06:03 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28280 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1/#c28280 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-2008-1

do we need bracket here ? all text should start with capital