]]> Wed, 06 May 2026 09:47:09 -0700 Vinayakam Mani https://devapps.diality.us/changelog/leahi-fwcommon?cs=53385f8d1d2a7ed4108d7973490455ebb0567a80 https://devapps.diality.us/changelog/leahi-fwcommon?cs=53385f8d1d2a7ed4108d7973490455ebb0567a80 Vinayakam Mani committed 53385f8 on branch LDT-3910-request-add-td-config-flag-so, LDT-3958-dialysate-temperature---fw-impl, staging in leahi-fwcommon LDT-872 heater control update

· /PIControllers.c	(-2, +3)	| History	| Source	| Diff
· /PIControllers.h	(-0, +1)	| History	| Source	| Diff

]]> Tue, 05 May 2026 15:58:48 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28924 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28924 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

no need to respond.

don't need response to a response.

don't need this if statement either and don't need what's inside the if.

Don't need this if statement or flag.

use separate time than stability (even if same right now).

Move to transition function and remove this if statement.

do 2 data with the p1 and p2 pressures.

Remove extra blank line.

Remove if statement. Always set valve to pos A.

Want to stop air pump, not end air trap control.

Don't want to start air trap control. Want to turn on the air pump at max power (100.0%)

Put this stuff in transition function for this state. Remove venousSetupStateEntered flag.

change flag to tubeSetLeakChecksStarted

Shouldn't this be the pressure sensor normal setup state?

initialize start time for next state. Should we set a flag indicating we completed the tube set checks?

Call your transition function for new state here.

state removed.

Don't need this flag or this if statement.

Think about including data.

Needed?

Still need cmd to barcode reader to scan.

Not a CAN msg to UI. It's a command to barcode reader via fpga. Not implement yet, so TODO comment.

remove if statement. No occlusion sensor

DrySelfTests

move to a private publish function.

dry self-tests

barcode scan request is made by TD to h/w via fpga. So not needed.