Missing comment.

update comment. next one as well.

blank line after the banner and maintain alphabetical order of include files.

· /firmware/App/Controllers/SubstitutionPump.c	(-34, +56)	| History	| Source	| Diff
· /firmware/App/Controllers/SubstitutionPump.h	(-9, +8)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +4)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-1, +1)	| History	| Source	| Diff

]]> Fri, 29 May 2026 11:02:02 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4001-1 ]]> Fri, 29 May 2026 10:58:07 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1/#c29523 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1/#c29523 Vinayakam Mani replied to Vendor - TEL - Jashwant Gantyada in LEAHI-DD-FIRMWARE-LDT-3958-1

Done.

· /firmware/App/Controllers/RinsePump.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/SubstitutionPump.h	(-0, +73)	| History	| Source
· /firmware/App/Monitors/Conductivity.c	(-6, +0)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.h	(-0, +4)	| History	| Source	| Diff
· /firmware/App/Services/TDInterface.c	(-0, +2)	| History	| Source	| Diff

]]> Fri, 29 May 2026 10:13:09 -0700 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=fc63fb0998e49133a69660c3eccf63fd0aba9413 https://devapps.diality.us/changelog/dd-firmware?cs=fc63fb0998e49133a69660c3eccf63fd0aba9413 Michael Garthwaite committed fc63fb0 on branch LDT-4001-hdf-fw-implementation-2-4 in dd-firmware LDT-4000: changed beta 2.0 test config to beta 1.9 test config

· /firmware/App/Controllers/Heaters.c	(-7, +7)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-9, +4)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-24, +22)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-12, +12)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-27, +93)	| History	| Source	| Diff

]]> Fri, 29 May 2026 10:07:12 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1 Vendor - TEL - Jashwant Gantyada joined LEAHI-DD-FIRMWARE-LDT-3958-1 LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2: ]]> Fri, 29 May 2026 10:05:59 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1/#c29522 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3958-1/#c29522 Vendor - TEL - Jashwant Gantyada commented on LEAHI-DD-FIRMWARE-LDT-3958-1

I think we also need this to be uncommented, as we were running into an alarm because of this.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

Done.

Done.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Wed, 27 May 2026 15:43:15 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=5f1b50a1d9a7bd6ea17bb666e28ccfeafe56432c https://devapps.diality.us/changelog/dd-firmware?cs=5f1b50a1d9a7bd6ea17bb666e28ccfeafe56432c Dara Navaei committed 5f1b50a on branch LDT-3958-dialysate-temperature---fw-impl, LDT-3975-water-treatment-and-degassing-- and 3 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeUpdate.c	(-0, +16)	| History	| Source	| Diff
· /firmware/App/Modes/ModeUpdate.h	(-0, +16)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommDD.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommDD.h	(-2, +2)	| History	| Source	| Diff

]]> Wed, 27 May 2026 15:39:56 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=5843d3c98be2fa2befac42f37f6673ae44284b93 https://devapps.diality.us/changelog/dd-firmware?cs=5843d3c98be2fa2befac42f37f6673ae44284b93 Dara Navaei committed 5843d3c on branch LDT-3958-dialysate-temperature---fw-impl, LDT-3975-water-treatment-and-degassing-- and 3 more in dd-firmware Merged LDT-3272

]]> Wed, 27 May 2026 15:38:22 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3272-1 Vendor - TEL - Jashwant Gantyada and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3272-1 LEAHI-DD-FIRMWARE-LDT-3272_Software Update - DD ]]> Wed, 27 May 2026 14:15:45 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4002-1/#c29429 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4002-1/#c29429 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4002-1

On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop similar to UF pump.
GenDialysate mode will have an HDF sub-state that signals this controller from Off to On and would also call separate controller for heater and separate (Switches) monitor for door sensors.

With all of that in mind, I think this unit should have a simpler name like SubPump.

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch state(s) (e.g. while in HDF state, we would expect the cap to be open and stowed and we would want to alarm if that was not the case).

Remove extra blank line.

· /firmware/App/Services/Messaging.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommDD.h	(-16, +0)	| History	| Source	| Diff
· /firmware/DD.dil	(-16, +16)	| History	| Source	| Diff
· /firmware/source/can.c	(-10, +10)	| History	| Source	| Diff

]]> Wed, 27 May 2026 14:31:35 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4002-1/#c29435 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4002-1/#c29435 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4002-1

Where is call to HDF controller?

Monitors should come before mode mgmt above.

What about HemoDiaFiltration.h?

What about initHDF?

Where is HemoDiaFiltration.h?