restored

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Should be #ifndef

Should be #ifndef I think.

Can we make these low priority and 999 rank?

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

]]> Wed, 20 May 2026 10:39:35 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=5514c6bf48facd532e58b0790d9f02aaa6776b28 https://devapps.diality.us/changelog/dd-firmware?cs=5514c6bf48facd532e58b0790d9f02aaa6776b28 Dara Navaei committed 5514c6b on branch LDT-3272-software-update---dd-firmware, LDT-3972-water-treatment-and-degassing-1 and 6 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/RinsePump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/FPOperationModes.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeate.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c	(-1, +1)	| History	| Source	| Diff

]]> Wed, 20 May 2026 10:36:51 -0700 Raghu Kallala https://devapps.diality.us/changelog/dd-firmware?cs=0355e72b361015cf6493826b977cb1f93faac2a7 https://devapps.diality.us/changelog/dd-firmware?cs=0355e72b361015cf6493826b977cb1f93faac2a7 Raghu Kallala committed 0355e72 on branch LDT-3272-software-update---dd-firmware, LDT-3972-water-treatment-and-degassing-1 and 6 more in dd-firmware LDT-4413 merge latest into staging

]]> Tue, 19 May 2026 17:50:18 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4413-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4413-1 Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-4413-1 LEAHI-DD-FIRMWARE-LDT-4413_Synchronize the Change events content ]]> Tue, 19 May 2026 14:19:16 -0700 Raghu Kallala https://devapps.diality.us/changelog/dd-firmware?cs=14998cd05a5b439a1e4a01ab11ad5e65c259ee3c https://devapps.diality.us/changelog/dd-firmware?cs=14998cd05a5b439a1e4a01ab11ad5e65c259ee3c Raghu Kallala committed 14998cd on branch LDT-3272-software-update---dd-firmware, LDT-3972-water-treatment-and-degassing-1 and 7 more in dd-firmware Fixed broadcast issue for rinse pump PWM

· /firmware/App/Controllers/RinsePump.c

(-6, +10)

| History

| Source

| Diff

]]> Mon, 18 May 2026 14:59:30 -0700 Raghu Kallala https://devapps.diality.us/changelog/dd-firmware?cs=acac329c455014a27d247538bce6717a76e9c76c https://devapps.diality.us/changelog/dd-firmware?cs=acac329c455014a27d247538bce6717a76e9c76c Raghu Kallala committed acac329 on branch LDT-3272-software-update---dd-firmware, LDT-3972-water-treatment-and-degassing-1 and 7 more in dd-firmware LDT-4414 added fix to update the pwm value in broadcast and changed setpwm from count to percentage

· /firmware/App/Controllers/RinsePump.c

(-10, +15)

| History

| Source

| Diff

]]> Sun, 17 May 2026 23:33:51 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29160 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29160 Sean Nash replied to Vendor - TEL - Jashwant Gantyada in LEAHI-DD-FIRMWARE-LDT-3963-1

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

Details looks weird. Where is inputs and outputs like other function headers?

Add a blank line after banner.

Please restore before you merge to staging.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

There is a #define for BAL_CHAMBER_FILL_VOLUME_ML in BalancingChamber.h. Why can't we just use that instead of redefining it here?

Should we set this flag to FALSE at top of loop?

Should we just set this flag to FALSE at top of loop?

These P being so much bigger than I are going to be very volatile (lots of big ups and downs). I think these should all be primarily I with much smaller P coefficients.

Update comment.

Is this eventually going to be d1Temp?