Remove blank line.

Move this transition function call to the transitionToPostTreatmentMode function below.

Invalid payload length shouldn't be a reject reason, it should cause a s/w fault (because it suggests the UI and TD software are not compatible versions).

Still not what I had in mind. Let's discuss this.

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

These are already in TxParams I believe.

Should these be moved to Services\TxParams?

Change 1 to TRUE

Agree with name change, but I think BOOL was the correct type. And BOOL is equivalent to U32 anyway so compiler won't care.

I think these message handlers for editing treatment parameters should be moved to Services\TxParams.

These should probably be moved to Services\TxParams.h because Messaging.c does not use them.

See if we have already defined this stuff in Services\TxParams. TxParams may also have get function(s) for min/max values that you can use.

Removed

Removed

updated

added

Added

Removed

Updated

Not necessary

This command should be given once on way out of prior state instead of every 50ms while in this state.
We also need to zero the timer counter at same time so the timeout check below works.

Response needs to be sent immediately (in message handler function). This is too late.

We shouldn't need to do this door check if you've required door be closed for the state.
Call the doorClosedRequired( TRUE ) function on transition into a state that requires the door to be closed and call with ( FALSE ) on transition into a state that doesn't require door to be closed. When required = TRUE, the switch monitor will trigger the door open alarm for you.

Same organization comment that I had for post-tx mode. Let's keep functions related to each pre-tx state together separated by some kind of comment banner.

Remove extra blank line.

Looks like there's plans for 4 post-tx states and we only have your auto eject state implemented here below.
Since all of these 4 states will be implemented in this file, maybe we should organize them - keep functions related to each state together separated by some kind of comment banner.

Not necessary if you give retract command on way out of prior state.

I don't think this if statement is necessary. We wouldn't be in this state if the ejector didn't extend already.
I think we just want to see if BP is home again (completed 1 revolution) so we know when to stop and go to next state.

Give ejector retract command and zero timer counter here too.