I think that's what is usually shown, the first 7 char, but in this case it might have been a typo

Was it a regulatory requirement before to have 7 characters from commit ID or something we implemented?

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update.

For more information check LDT-5205 CR, file: utils\ enum_updater.py

In FW we pre-populated Alarm IDs up to 300 to help with the reservation process. Would this also benefit dialin if we reserve up to 300?

· /leahi_dialin/common/dd_defs.py	(-2, +2)	| History	| Source	| Diff
· /leahi_dialin/common/dd_defs_proxy.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/common/td_defs.py	(-23, +28)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/events.py	(-2, +37)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/substitution_pump.py	(-1, +2)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/events.py	(-2, +42)	| History	| Source	| Diff
· /leahi_dialin/td/modules/air_pump.py	(-0, +24)	| History	| Source	| Diff
· /leahi_dialin/td/modules/alarms.py	(-5, +6)	| History	| Source	| Diff
· /leahi_dialin/td/modules/buttons.py	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/td/modules/dry_self_test.py	(-0, +154)	| History	| Source
· /leahi_dialin/td/modules/events.py	(-4, +55)	| History	| Source	| Diff
· /leahi_dialin/td/modules/syringe_pump.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/td/proxies/ui_proxy.py	(-0, +32)	| History	| Source	| Diff
· /leahi_dialin/td/treatment_delivery.py	(-0, +2)	| History	| Source	| Diff

]]> Wed, 05 Aug 2026 15:02:58 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-4484-1 ]]> Wed, 05 Aug 2026 08:34:10 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1 Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-4484-1 LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin ]]> Wed, 29 Jul 2026 15:20:31 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1 Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-4484-1 LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin ]]> Tue, 21 Jul 2026 09:13:52 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=3f4937e339925dde0b95f08e49969f8983c5cba4 https://devapps.diality.us/changelog/leahi-dialin?cs=3f4937e339925dde0b95f08e49969f8983c5cba4 Zoltan Miskolci committed 3f4937e on branch LDT-5152-handler_refactor, LDT-5205-dd_nvm_update and 4 more in leahi-dialin Refactor changes #1

· /leahi_dialin/common/msg_defs.py	(-152, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/dialysate_delivery.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/alarms.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/balancing_chamber.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/blood_leak.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/concentrate_pump.py	(-2, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/conductivity_sensors.py	(-2, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/dd_test_configs.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/dialysate_pump.py	(-2, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/drybicart.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/events.py	(-142, +109)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/gen_dialysate.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/heaters.py	(-2, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/levels.py	(-2, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/mixing_cntrl.py	(-1, +1)	| History	| Source	| Diff
… 49 more files in changeset.

]]> Mon, 20 Jul 2026 12:34:32 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-5152-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-5152-1 Dara Navaei started review LEAHI-DIALIN-LDT-5152-1 ]]> Sun, 12 Jul 2026 23:43:02 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1/#c30436 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4484-1/#c30436 Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

Zoltan and I had a meeting, and the counter solution he provided works better than mine.
He explained to me that my proposed solution has flaws.
RESOLVED.

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility.
1. The conversion module's bytearray to value methods work, but they require manual logistic around the indexing. It's the user's responsibility to handle where the reading starts and you need to code the handler for that (previous approach with MsgFieldPositions), It's inflating the method. I worked hard to remove the need for indexing where the value starts. Instead of the previous struct.unpack approach, where you needed to maintain the type, you will be needing to maintain the conversion methods that are being called, so it would be the same as before, you still need to mind the indexing, which was the main reason of changing from this approach.

2. In the current approach, you declare the type and pass it to a processor that dynamically handling the unpack type (based on the set datatype) and the indexing for that. This works much better and easier to maintain, as you can just insert a new value when it's added to the FW, and don't need to adjust all your indexes for the reading.

Example #1, changing build type from U16 to U08:

• with the conversion approach, you need to change the function used, and update the starting index for all the following methods.
• with the current approach you change the Datatype.U16 to Datatype.U08 and that's all you need to do.

Example #2: adding a new variable fpga_micro after fpga_minor, with U08 type:

• with the conversion approach, you add the bytearray_to_byte, update the indexes for all the following reads.
• with the current approach you insert an element after the fpga_minor with a value ('fpga_micro', Datatype.U08), and nothing more needed

RESOLVED for now.

I would not do that because the function names and messages for each project should be different to avoid confusion.
I think that is fine for now.

RESOLVED.

So the same channels are used for both the Leahi and Denali?
I am not talking about how collisions are handled; that is handled by the CAN driver, not the FW or SW.
My point is that the CAN Channels by themselves do not have the meaning we want; they are only a priority.
As we defined them, we gave them a meaning as a category; therefore, it is better to name them the Denali/Leahi Channels rather than the CAN Channels.

RESOLVED.

Being generic is the whole point of it.
It was renamed because this is a dialin dedicated to Leahi unit and calling the messages DenaliMessage is misleading.
It was renamed to CanMessage for 2 reason:
1. This is a Leahi only dialin, so there is no need to differentiate between different type of Can Messages as there would be only 1 type
2. Calling it CanMessage will make it more future compatible when the dialin get copied over for a new unit development (unlikely in the foreseeable future but possible), removing the need to rename it again

There is no Leahi or Denali CANChannels.
There are CAN channels and the naming is what that channel is being used for.
The collision occurs in the FW and the FW handles it before sending out a message.
When reading a CAN, there are no collisions, so there are no priorities. So I have no clue what you want here.

done

I have no idea what you are referring to as the link is not working.
The need to define the type and the name of the data being read is necessary, so if it's not here it will be somewhere else, that we can't escape.
Exporting that to different files won't serve a purpose and will only increase complexity as when debugging you will need to reference a separate file.
For the defs it made sense as they are used multiple places, but what a message contains is a single use place, so storing it separately is meaningless as it won't have any use outside of this single function.

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

Please add a docstring for the function.
including the intention and parameters with their intentions.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

updated