Fisheye on leahi-dialin/leahi_dialin/td/modules/events.py

LEAHI-DIALIN-LDT-5205-2: reviewers finished

Tue, 18 Aug 2026 11:45:09 -0700

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-5205-2

LEAHI-DIALIN-LDT-5205_[DD] Update NVM records architecture in Dialin

LEAHI-DIALIN-LDT-5482-1: reviewers finished

Thu, 13 Aug 2026 13:21:20 -0700

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-5482-1

LEAHI-DIALIN-LDT-5482_[Dry Self Test] Update the module to match the current dev changes

LEAHI-DIALIN-LDT-5482-1: comment by Zoltan Miskolci "We will need to get the event_id first, to know..."

Zoltan Miskolci — Thu, 13 Aug 2026 10:41:15 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-5482-1

We will need to get the event_id first, to know how to process the content as Operation status content is different from rest.

So this line is just for getting the event id, and based on the result, process the rest into the correct variables

LEAHI-DIALIN-LDT-5482-1: comment by Zoltan Miskolci "removed"

Zoltan Miskolci — Thu, 13 Aug 2026 10:40:20 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-5482-1

removed

LEAHI-DIALIN-LDT-5205-2: comment by Zoltan Miskolci "fixed"

Zoltan Miskolci — Thu, 13 Aug 2026 10:37:46 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-5205-2

fixed

LEAHI-DIALIN-LDT-5482-1: comment by Raghu Kallala "remove if we are sure about the message ID"

Raghu Kallala — Thu, 13 Aug 2026 10:05:49 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-5482-1

remove if we are sure about the message ID

LEAHI-DIALIN-LDT-5482-1: comment by Raghu Kallala "Will we need this after adding the below code?"

Raghu Kallala — Thu, 13 Aug 2026 10:01:46 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-5482-1

Will we need this after adding the below code?

LEAHI-DIALIN-LDT-5205-2: comment by Raghu Kallala "Fix typo"

Raghu Kallala — Thu, 13 Aug 2026 09:57:08 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-5205-2

Fix typo

LEAHI-DIALIN-LDT-5482-1: started by Dara Navaei

Dara Navaei — Wed, 12 Aug 2026 13:29:24 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-5482-1

LEAHI-DIALIN-LDT-5205-2: started by Dara Navaei

Dara Navaei — Tue, 11 Aug 2026 14:59:55 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-5205-2

LEAHI-DIALIN-LDT-5152-1: closed by Zoltan Miskolci

Zoltan Miskolci — Tue, 11 Aug 2026 09:34:58 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-5152-1

leahi-dialin (LDT-5615-priming): Merge branch 'LDT-5152-handler_refactor' into staging

Zoltan Miskolci — Tue, 11 Aug 2026 09:25:42 -0700

Zoltan Miskolci committed 2cd5cb7 on branch LDT-5205-dd_nvm_update, LDT-5409-dd-balancing-chamber-stops-duri and 4 more in leahi-dialin

Merge branch 'LDT-5152-handler_refactor' into staging

· /.gitignore	(-0, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/events.py	(-141, +108)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/records.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/events.py	(-141, +108)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/events.py	(-137, +108)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/records.py	(-1, +1)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-5152-1: comment by Zoltan Miskolci "I think that's what is usually shown, the first..."

Zoltan Miskolci — Mon, 10 Aug 2026 15:35:30 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-5152-1

I think that's what is usually shown, the first 7 char, but in this case it might have been a typo

LEAHI-DIALIN-LDT-5152-1: reviewers finished

Mon, 10 Aug 2026 15:07:00 -0700

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-5152-1

LEAHI-DIALIN-LDT-5152_[Dialin] Handler architecture refactor

LEAHI-DIALIN-LDT-5152-1: comment by Raghu Kallala "Was it a regulatory requirement before to have ..."

Raghu Kallala — Mon, 10 Aug 2026 14:29:02 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-5152-1

Was it a regulatory requirement before to have 7 characters from commit ID or something we implemented?

LEAHI-DIALIN-LDT-5152-1: comment by Zoltan Miskolci "No need, in a different CR I have a module that..."

Zoltan Miskolci — Fri, 07 Aug 2026 15:48:20 -0700

Zoltan Miskolci replied to Michael Garthwaite in LEAHI-DIALIN-LDT-5152-1

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update.

For more information check LDT-5205 CR, file: utils\ enum_updater.py

leahi-dialin (LDT-5615-priming): fixing msg ids and enums

Zoltan Miskolci — Fri, 07 Aug 2026 11:10:15 -0700

Zoltan Miskolci committed f6b74a9 on branch LDT-5205-dd_nvm_update, LDT-5409-dd-balancing-chamber-stops-duri and 4 more in leahi-dialin

fixing msg ids and enums

· /leahi-common	(-0, +1)	\| History	\| Source
· /leahi_dialin/dd/modules/events.py	(-8, +16)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/records.py	(-53, +53)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/events.py	(-8, +17)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/events.py	(-9, +17)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/records.py	(-24, +24)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-5152-1: reviewers finished

Thu, 06 Aug 2026 22:21:37 -0700

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-5152-1

LEAHI-DIALIN-LDT-5152_[Dialin] Handler architecture refactor

LEAHI-DIALIN-LDT-5152-1: comment by Michael Garthwaite "In FW we pre-populated Alarm IDs up to 300 to h..."

Michael Garthwaite — Thu, 06 Aug 2026 22:08:47 -0700

Michael Garthwaite commented on LEAHI-DIALIN-LDT-5152-1

In FW we pre-populated Alarm IDs up to 300 to help with the reservation process. Would this also benefit dialin if we reserve up to 300?

leahi-dialin (LDT-5615-priming): Merge branch 'staging' into LDT-5152-handler_refactor

Zoltan Miskolci — Wed, 05 Aug 2026 16:19:55 -0700

Zoltan Miskolci committed 862daa5 on branch LDT-5152-handler_refactor, LDT-5205-dd_nvm_update and 5 more in leahi-dialin

Merge branch 'staging' into LDT-5152-handler_refactor

· /leahi_dialin/common/dd_defs.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/common/dd_defs_proxy.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/common/td_defs.py	(-23, +28)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/events.py	(-2, +37)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/substitution_pump.py	(-1, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/events.py	(-2, +42)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/air_pump.py	(-0, +24)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/alarms.py	(-5, +6)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/buttons.py	(-0, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/dry_self_test.py	(-0, +154)	\| History	\| Source
· /leahi_dialin/td/modules/events.py	(-4, +55)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/syringe_pump.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/td/proxies/ui_proxy.py	(-0, +32)	\| History	\| Source	\| Diff
· /leahi_dialin/td/treatment_delivery.py	(-0, +2)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-5214-1: closed by Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Vendor - TEL - Santhoshkumar Reddy Alasandagutti — Wed, 05 Aug 2026 15:12:32 -0700

Vendor - TEL - Santhoshkumar Reddy Alasandagutti Closed LEAHI-DIALIN-LDT-5214-1

leahi-dialin (LDT-5615-priming): Merge branch 'LDT-5214-override_air_pump_rpm' into staging

Zoltan Miskolci — Wed, 05 Aug 2026 15:09:24 -0700

Zoltan Miskolci committed 9fd2851 on branch LDT-5152-handler_refactor, LDT-5205-dd_nvm_update and 6 more in leahi-dialin

Merge branch 'LDT-5214-override_air_pump_rpm' into staging

· /leahi_dialin/common/dd_defs_proxy.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/common/msg_ids.py	(-0, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/air_pump.py	(-0, +24)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/events.py	(-6, +55)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4484-1: closed by Zoltan Miskolci

Zoltan Miskolci — Wed, 05 Aug 2026 15:02:58 -0700

Zoltan Miskolci Closed LEAHI-DIALIN-LDT-4484-1

LEAHI-DIALIN-LDT-4484-1: reviewers finished

Wed, 05 Aug 2026 08:34:10 -0700

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-4484-1

LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin

LEAHI-DIALIN-LDT-5214-1: reviewers finished

Wed, 05 Aug 2026 08:31:27 -0700

Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-5214-1

LEAHI-DIALIN-LDT-5214_[FW+Dialin] New override for Air Pump RPM parameter

LEAHI-DIALIN-LDT-5214-1: reviewers finished

Wed, 29 Jul 2026 16:29:51 -0700

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-5214-1

LEAHI-DIALIN-LDT-5214_[FW+Dialin] New override for Air Pump RPM parameter

LEAHI-DIALIN-LDT-5214-1: comment by Zoltan Miskolci "Fixed in all 3 file"

Zoltan Miskolci — Wed, 29 Jul 2026 15:33:10 -0700

Zoltan Miskolci replied to Raghu Kallala in LEAHI-DIALIN-LDT-5214-1

Fixed in all 3 file

leahi-dialin (LDT-5214-override_air_pump_rpm): fixed comment typo

Zoltan Miskolci — Wed, 29 Jul 2026 15:32:43 -0700

Zoltan Miskolci committed dd92f40 on branch LDT-5152-handler_refactor, LDT-5205-dd_nvm_update and 7 more in leahi-dialin

fixed comment typo

· /leahi_dialin/dd/modules/events.py	(-3, +3)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/events.py	(-3, +3)	\| History	\| Source	\| Diff
· /leahi_dialin/td/modules/events.py	(-3, +3)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4484-1: reviewers finished

Wed, 29 Jul 2026 15:20:31 -0700

Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-4484-1

LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin

LEAHI-DIALIN-LDT-5214-1: comment by Raghu Kallala "same typo"

Raghu Kallala — Wed, 29 Jul 2026 15:16:53 -0700

Raghu Kallala commented on LEAHI-DIALIN-LDT-5214-1

same typo