updated

APPROVED.

RESOLVED.
Added another comment regarding the same.

Nicholas Ramirez
Thanks for the change to the ok and result.

• To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
• Also move the:

  ; if ( ! ok ) { goto invalid; }
  

  on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

APPROVED

updated

updated

updated

remove the ok and just check result and if any fails goto invalid

see if you can use payloadLen from MessageGlobals.h

double check

removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

remove from prime // priming - TODO check if needed. may not need

· /leahi.pro	(-4, +12)	| History	| Source	| Diff
· /leahi.qrc	(-0, +3)	| History	| Source	| Diff
· /sources/canbus/MessageDispatcher.cpp	(-0, +16)	| History	| Source	| Diff
· /sources/canbus/MessageDispatcher.h	(-0, +1)	| History	| Source	| Diff
· /sources/canbus/MessageGlobals.h	(-1, +6)	| History	| Source	| Diff
· /sources/canbus/MessageInterpreter.cpp	(-1, +4)	| History	| Source	| Diff
· /sources/gui/GuiGlobals.cpp	(-1, +3)	| History	| Source	| Diff
· /sources/gui/GuiGlobals.h	(-3, +8)	| History	| Source	| Diff
· /sources/gui/qml/main.qml	(-2, +7)	| History	| Source	| Diff
· /sources/model/MModel.h	(-5, +20)	| History	| Source	| Diff
· /sources/model/hd/adjustment/treatment/MTreatmentAdjustRequests.h	(-1, +26)	| History	| Source	| Diff
· /sources/view/VView.h	(-1, +3)	| History	| Source	| Diff

]]> Thu, 06 Aug 2026 16:12:28 -0700 Behrouz NematiPour https://devapps.diality.us/changelog/leahi-application?cs=29f591c2ce9d6977f776a1b1925f7f492f217744 https://devapps.diality.us/changelog/leahi-application?cs=29f591c2ce9d6977f776a1b1925f7f492f217744 Behrouz NematiPour committed 29f591c on branch LDT-5485-sw-misc-enhc---sw---01--asn---iso-uf, LDT-5618-sw-misc-enhc-sw-board-freeze and 12 more in leahi-application Merge branch 'feature/LDT-5232-hdf' into staging

· /leahi.pro	(-0, +16)	| History	| Source	| Diff
· /sources/canbus/MessageDispatcher.cpp	(-0, +40)	| History	| Source	| Diff
· /sources/canbus/MessageDispatcher.h	(-0, +3)	| History	| Source	| Diff
· /sources/canbus/MessageGlobals.h	(-0, +9)	| History	| Source	| Diff
· /sources/canbus/MessageInterpreter.cpp	(-0, +8)	| History	| Source	| Diff
· /sources/gui/GuiGlobals.cpp	(-0, +4)	| History	| Source	| Diff
· /sources/gui/GuiGlobals.h	(-1, +13)	| History	| Source	| Diff
· /sources/gui/qml/main.qml	(-0, +8)	| History	| Source	| Diff
· /sources/gui/qml/pages/treatment/TreatmentStack.qml	(-1, +40)	| History	| Source	| Diff
· /sources/gui/qml/pages/treatment/sections/TreatmentHDFComponent.qml	(-42, +28)	| History	| Source	| Diff
· /sources/model/MModel.h	(-0, +35)	| History	| Source	| Diff
· /sources/model/hd/adjustment/treatment/MTreatmentAdjustRequests.h	(-0, +82)	| History	| Source	| Diff
· /sources/view/VView.h	(-0, +4)	| History	| Source	| Diff
· /sources/view/td/data/treatment/VTDTreatmentStatesData.cpp	(-1, +1)	| History	| Source	| Diff

]]> Thu, 06 Aug 2026 16:08:55 -0700 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5232-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5232-1 Stephen Quong and Behrouz NematiPour finished reviewing LEAHI-APPLICATION-LDT-5232-1 LEAHI-APPLICATION-LDT-5232_HDF - SW - 01 - HDF - Messaging & Models - R&I ]]> Thu, 06 Aug 2026 16:07:28 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-4767-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-4767-1 Nicholas Ramirez Closed LEAHI-APPLICATION-LDT-4767-1 ]]> Thu, 06 Aug 2026 15:33:44 -0700 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-4767-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-4767-1 Stephen Quong and Behrouz NematiPour finished reviewing LEAHI-APPLICATION-LDT-4767-1 LEAHI-APPLICATION-LDT-4767_NON-FEATURE: SW Misc & Enhc - SW - 01 - Isolated UF - R&I ]]> Thu, 06 Aug 2026 15:12:34 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-4767-1/#c31091 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-4767-1/#c31091 Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-4767-1

BN approves

BN approves

updated

updated

update to use Pre -tx iso state enum FW

update to use FW enum