Fisheye on dd-firmware/firmware/App/Controllers/PistonPumpControl.c

dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): Code review udpate

Vinayakam Mani — Mon, 24 Feb 2025 11:30:03 -0800

Vinayakam Mani committed 5126b79 on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 97 more in dd-firmware

Code review udpate

· /firmware/App/Controllers/BalancingChamber.c	(-23, +14)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialysatePumps.c	(-32, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PistonPumpControl.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/DDCommon.h	(-4, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-14, +4)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Level.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Pressure.c	(-14, +0)	\| History	\| Source	\| Diff

dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): GenD mode state update

Vinayakam Mani — Wed, 19 Feb 2025 17:41:56 -0800

Vinayakam Mani committed 5e92cbb on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 97 more in dd-firmware

GenD mode state update

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialysatePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PistonPumpControl.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-0, +58)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-0, +2)	\| History	\| Source	\| Diff

dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): test command update

Vinayakam Mani — Fri, 14 Feb 2025 14:52:53 -0800

Vinayakam Mani committed 6bbe6e3 on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 97 more in dd-firmware

test command update

· /firmware/App/Controllers/BalancingChamber.c	(-5, +52)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-15, +17)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PistonPumpControl.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-0, +4)	\| History	\| Source	\| Diff

dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): piston pump testing update

Vinayakam Mani — Fri, 14 Feb 2025 10:32:24 -0800

Vinayakam Mani committed e0fc678 on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 97 more in dd-firmware

piston pump testing update

· /firmware/App/Controllers/BalancingChamber.c	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-22, +22)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialysatePumps.c	(-10, +10)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PistonPumpControl.c	(-50, +123)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/PistonPumpControl.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/DDCommon.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Level.c	(-0, +31)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Level.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Pressure.c	(-8, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-0, +2)	\| History	\| Source	\| Diff

dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): Refactoring Code review comments fix

Vinayakam Mani — Tue, 28 Jan 2025 17:21:29 -0800

Vinayakam Mani committed 322747d on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 98 more in dd-firmware

Refactoring Code review comments fix

· /firmware/App/Controllers/ConcentratePumps.c

(-59, +55)

| History

| Source

| Diff

· /firmware/App/Controllers/DialysatePumps.c

(-15, +17)

| History

| Source

| Diff

· /firmware/App/Controllers/DialysatePumps.h

(-3, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-49, +37)

| History

| Source

| Diff

· /firmware/App/Controllers/PistonPumpControl.c

(-1, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/PistonPumpControl.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-5, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-1, +0)

| History

| Source

| Diff

· /firmware/App/DDCommon.h

(-3, +6)

| History

| Source

| Diff

· /firmware/App/Drivers/BalancingChamber.c

(-790, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/BalancingChamber.h

(-74, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/PressureSensor.c

(-2, +0)

| History

| Source

| Diff

· /firmware/App/Drivers/TemperatureSensors.c

(-5, +4)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenDialysate.c

(-79, +46)

| History

| Source

| Diff

· /firmware/App/Modes/ModeGenDialysate.h

(-2, +2)

| History

| Source

| Diff

… 8 more files in changeset.

dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): merge changes from develop

Vinayakam Mani — Thu, 23 Jan 2025 10:42:40 -0800

Vinayakam Mani committed 289ff65 on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 98 more in dd-firmware

merge changes from develop

· /firmware/App/Controllers/PistonPumpControl.c	(-0, +535)	\| History	\| Source
· /firmware/App/Controllers/PistonPumpControl.h	(-0, +74)	\| History	\| Source