Fisheye on ro-firmware/firmware/App/Controllers/ROPump.c https://devapps.diality.us/changelog/~br%3DLDT-828-stop-state-fp/ro-firmware/firmware/App/Controllers/ROPump.c Recent activity in "ro-firmware" under directory /firmware/App/Controllers/ROPump.c ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments Fri, 01 Aug 2025 15:56:30 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=6d85a90d2325163e936055a620a8b6aa1a6db65a https://devapps.diality.us/changelog/ro-firmware?cs=6d85a90d2325163e936055a620a8b6aa1a6db65a Michael Garthwaite committed 6d85a90 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: code review comments

· /firmware/App/Controllers/PermeateTank.c (-8, +7) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-3, +0) | History | Source | Diff
· /firmware/App/Modes/FPModeStandby.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.h (-1, +0) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-1, +0) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-4, +0) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.h (-1, +0) | History | Source | Diff
· /firmware/App/Services/DDInterface.c (-6, +0) | History | Source | Diff
· /firmware/App/Services/DDInterface.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/FpgaFP.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-4, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommFP.c (-1, +0) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check ... Fri, 01 Aug 2025 12:08:14 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=3a5cc585b69ffa194e3601a005915d23b48bd865 https://devapps.diality.us/changelog/ro-firmware?cs=3a5cc585b69ffa194e3601a005915d23b48bd865 Michael Garthwaite committed 3a5cc58 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check for boost pump.

· /firmware/App/Controllers/BoostPump.c (-1, +3) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-4, +6) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-3, +3) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/PressureCheck.c (-0, +0) | History | Source | Diff
· /firmware/App/Modes/PressureCheck.h (-15, +0) | History | Source | Diff
· /firmware/App/Monitors/WaterQualityMonitor.c (-5, +0) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: fixed macro calls Thu, 31 Jul 2025 11:51:36 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=27566fb95c3865851e3b0b4bd4668474bfdbfcde https://devapps.diality.us/changelog/ro-firmware?cs=27566fb95c3865851e3b0b4bd4668474bfdbfcde Michael Garthwaite committed 27566fb on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: fixed macro calls

· /firmware/App/Controllers/ROPump.c (-4, +4) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes Thu, 31 Jul 2025 11:49:31 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=b92c26da32bed791d9836391080eacf19f221de6 https://devapps.diality.us/changelog/ro-firmware?cs=b92c26da32bed791d9836391080eacf19f221de6 Michael Garthwaite committed b92c26d on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes

· /firmware/App/Controllers/BoostPump.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-7, +7) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-1, +1) | History | Source | Diff
· /firmware/source/sys_main.c (-4, +5) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments. Wed, 30 Jul 2025 13:30:55 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=2652d50bbc5e78ed6fe3ad9ccbca0be6f802f1ff https://devapps.diality.us/changelog/ro-firmware?cs=2652d50bbc5e78ed6fe3ad9ccbca0be6f802f1ff Michael Garthwaite committed 2652d50 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: code review comments.

· /firmware/App/Controllers/BoostPump.c (-11, +5) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-650, +0) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-60, +0) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-18, +20) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-3, +0) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.c (-399, +0) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.h (-59, +0) | History | Source | Diff
· /firmware/App/Modes/FPModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-19, +24) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.h (-2, +1) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-10, +11) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-9, +13) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-30, +13) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.h (-9, +4) | History | Source | Diff
· /firmware/App/Monitors/Conductivity.c (-1, +0) | History | Source | Diff
… 5 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: FP Safety shutdown override. fixed includes. Tue, 29 Jul 2025 12:15:18 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=8e72441bc5cd51272b1dc6b14d6c95b4888d6301 https://devapps.diality.us/changelog/ro-firmware?cs=8e72441bc5cd51272b1dc6b14d6c95b4888d6301 Michael Garthwaite committed 8e72441 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: FP Safety shutdown override. fixed includes.

· /firmware/App/Controllers/PermeateTank.c (-0, +52) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.h (-0, +65) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-3, +2) | History | Source | Diff
· /firmware/App/Drivers/PAL.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/PAL.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.c (-39, +22) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.h (-2, +1) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.h (-3, +6) | History | Source | Diff
· /firmware/App/Modes/FPModeInitPOST.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/FPModeStandby.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/FPOperationModes.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-1, +3) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): WIP on develop... Tue, 29 Jul 2025 09:58:35 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=94d93795b2a516b3bdd7fc7030eb5eac933bfcd0 https://devapps.diality.us/changelog/ro-firmware?cs=94d93795b2a516b3bdd7fc7030eb5eac933bfcd0 Michael Garthwaite committed 94d9379 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware WIP on develop

LDT-566: code review comments. updated common naming to have a FP prefix.

· /firmware/App/Controllers/BoostPump.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-1, +2) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-12, +11) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.c (-0, +88) | History | Source
· /firmware/App/Modes/FPModeFault.h (-0, +40) | History | Source
· /firmware/App/Modes/FPModeInitPOST.c (-0, +66) | History | Source
· /firmware/App/Modes/FPModeInitPOST.h (-0, +44) | History | Source
· /firmware/App/Modes/FPModeStandby.c (-0, +149) | History | Source
· /firmware/App/Modes/FPModeStandby.h (-0, +47) | History | Source
· /firmware/App/Modes/FPOperationModes.c (-0, +475) | History | Source
· /firmware/App/Modes/FPOperationModes.h (-0, +62) | History | Source
· /firmware/App/Modes/FlushConcentrate.c (-1, +2) | History | Source | Diff
… 25 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: removed unneeded defines. Added percentage values for pwm to RO and boost broadcasts. Removed X5 from pressure ... Thu, 17 Jul 2025 15:47:48 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=311c75cc5ac41b4b9ca4983df84e43af910f9be4 https://devapps.diality.us/changelog/ro-firmware?cs=311c75cc5ac41b4b9ca4983df84e43af910f9be4 Michael Garthwaite committed 311c75c on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: removed unneeded defines. Added percentage values for pwm to RO and boost broadcasts. Removed X5 from pressure sensors. Fixed Pre-Generate mode rushing through sub states.

· /firmware/App/Controllers/BoostPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-1, +3) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-3, +5) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.h (-3, +3) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-3, +0) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.h (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-17, +12) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-2, +0) | History | Source | Diff
· /firmware/App/Monitors/Pressure.h (-3, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.c (-1, +1) | History | Source | Diff
· /firmware/source/sys_main.c (-0, +2) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Implemented hard stop commands for water pumps. Added valve actuation for RO recovery settings in gen permeate,... Tue, 15 Jul 2025 16:31:10 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=f4870116c87345ee0ea062df5b30187e1e113ddc https://devapps.diality.us/changelog/ro-firmware?cs=f4870116c87345ee0ea062df5b30187e1e113ddc Michael Garthwaite committed f487011 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: Implemented hard stop commands for water pumps. Added valve actuation for RO recovery settings in gen permeate, set to med.

· /firmware/App/Controllers/BoostPump.c (-3, +22) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-0, +19) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-0, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-0, +5) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-4, +10) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-0, +2) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: transitioning to standby mode and fault mode will now shut off pumps and close valves. updates in naming. fixed... Tue, 15 Jul 2025 15:54:42 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=1cf11f4c1f6a1f1fd40270889723fbec040fc7ec https://devapps.diality.us/changelog/ro-firmware?cs=1cf11f4c1f6a1f1fd40270889723fbec040fc7ec Michael Garthwaite committed 1cf11f4 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: transitioning to standby mode and fault mode will now shut off pumps and close valves. updates in naming. fixed pre-gen transitioning. removed some checks for when gen water request it received.

· /firmware/App/Controllers/BoostPump.c (-45, +84) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-59, +88) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-0, +11) | History | Source | Diff
· /firmware/App/FPCommon.h (-15, +25) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-2, +21) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-12, +23) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-1, +2) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-0, +21) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/DDInterface.c (-21, +8) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-5, +50) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: generate water modes both defeatured and ro featured Wed, 09 Jul 2025 14:14:26 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=8d272582cbd2cb5fc0c6af0fead2867ce02658b0 https://devapps.diality.us/changelog/ro-firmware?cs=8d272582cbd2cb5fc0c6af0fead2867ce02658b0 Michael Garthwaite committed 8d27258 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: generate water modes both defeatured and ro featured

· /firmware/App/Controllers/BoostPump.c (-4, +31) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-1, +5) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +28) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-1, +5) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.c (-1, +15) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.h (-0, +1) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.c (-39, +0) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-0, +395) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.h (-7, +48) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-0, +6) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-5, +17) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-21, +121) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.h (-0, +4) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c (-5, +299) | History | Source | Diff
… 14 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush imple... Wed, 02 Jul 2025 12:04:36 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=410afd26b3ae5e372310c696c82f58c59235e10d https://devapps.diality.us/changelog/ro-firmware?cs=410afd26b3ae5e372310c696c82f58c59235e10d Michael Garthwaite committed 410afd2 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush implemented.

· /firmware/App/Controllers/BoostPump.c (-30, +34) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FilterFlush.c (-139, +0) | History | Source | Diff
· /firmware/App/Modes/FilterFlush.h (-51, +0) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-0, +0) | History | Source
· /firmware/App/Modes/FlushConcentrate.h (-0, +15) | History | Source
· /firmware/App/Modes/FlushFilter.c (-0, +365) | History | Source
… 56 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments. S32 override implementations. Changed flow rates from FPGA to S32 Mon, 30 Jun 2025 13:24:36 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=863f8f88c73ee5dd285242f6e131a14862b4f5c4 https://devapps.diality.us/changelog/ro-firmware?cs=863f8f88c73ee5dd285242f6e131a14862b4f5c4 Michael Garthwaite committed 863f8f8 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware LDT-566: code review comments. S32 override implementations. Changed flow rates from FPGA to S32

· /firmware/App/Controllers/BoostPump.c (-27, +27) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-7, +7) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-28, +28) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-5, +5) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensor.c (-3, +2) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.c (-10, +10) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.h (-1, +4) | History | Source | Diff
· /firmware/App/Monitors/Flow.c (-1, +1) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: implemented RO and boost control states between target pressure and target flow Wed, 25 Jun 2025 14:50:03 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=2506bb824f04982d4cf6ad3d81853f863b2f9c11 https://devapps.diality.us/changelog/ro-firmware?cs=2506bb824f04982d4cf6ad3d81853f863b2f9c11 Michael Garthwaite committed 2506bb8 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware LDT-566: implemented RO and boost control states between target pressure and target flow

· /firmware/App/Controllers/BoostPump.c (-6, +31) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-4, +28) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments. addressed formatting Wed, 25 Jun 2025 11:25:47 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=5e5ece62c01bc4576acd936fb4b200e8a336f2c2 https://devapps.diality.us/changelog/ro-firmware?cs=5e5ece62c01bc4576acd936fb4b200e8a336f2c2 Michael Garthwaite committed 5e5ece6 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware LDT-566: code review comments. addressed formatting

· /firmware/App/Controllers/BoostPump.c (-31, +31) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-29, +29) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments. Wed, 25 Jun 2025 11:10:49 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=a80e7b6bee41fed2e5246332c577c5a29de1d8dc https://devapps.diality.us/changelog/ro-firmware?cs=a80e7b6bee41fed2e5246332c577c5a29de1d8dc Michael Garthwaite committed a80e7b6 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware LDT-566: code review comments.

· /firmware/App/Controllers/ROPump.c (-8, +6) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments Wed, 25 Jun 2025 11:01:08 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=3f5c0e277e979078c3153421274c660258e8a68b https://devapps.diality.us/changelog/ro-firmware?cs=3f5c0e277e979078c3153421274c660258e8a68b Michael Garthwaite committed 3f5c0e2 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware LDT-566: code review comments

· /firmware/App/Controllers/BoostPump.c (-5, +4) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-11, +8) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments Wed, 25 Jun 2025 10:56:28 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=e6c6e39765c3f993b6a2b965188e7c13e93ffa92 https://devapps.diality.us/changelog/ro-firmware?cs=e6c6e39765c3f993b6a2b965188e7c13e93ffa92 Michael Garthwaite committed e6c6e39 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware LDT-566: code review comments

· /firmware/App/Controllers/BoostPump.c (-29, +32) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-28, +30) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: reflect changes from boost pump to ro pump Wed, 25 Jun 2025 10:36:30 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=c71fc505053e922b9865f1e241d01e144d8d68cd https://devapps.diality.us/changelog/ro-firmware?cs=c71fc505053e922b9865f1e241d01e144d8d68cd Michael Garthwaite committed c71fc50 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware LDT-566: reflect changes from boost pump to ro pump

· /firmware/App/Controllers/ROPump.c (-11, +9) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Fluid Pump controllers. Renamed RO common to FP common to be in line of subsystem naming. Wed, 18 Jun 2025 15:20:51 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=17a448770daa138ebeb6ce79974966e650828f25 https://devapps.diality.us/changelog/ro-firmware?cs=17a448770daa138ebeb6ce79974966e650828f25 Michael Garthwaite committed 17a4487 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware LDT-566: Fluid Pump controllers. Renamed RO common to FP common to be in line of subsystem naming.

· /firmware/App/Controllers/BoostPump.c (-0, +648) | History | Source
· /firmware/App/Controllers/BoostPump.h (-0, +75) | History | Source
· /firmware/App/Controllers/ROPump.c (-110, +486) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-7, +23) | History | Source | Diff
· /firmware/App/Drivers/BoostPump.c (-304, +0) | History | Source | Diff
· /firmware/App/Drivers/BoostPump.h (-61, +0) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.c (-0, +363) | History | Source
· /firmware/App/Drivers/FluidPump.h (-0, +69) | History | Source
· /firmware/App/FPCommon.h (-0, +62) | History | Source
· /firmware/App/ROCommon.h (-92, +0) | History | Source | Diff
· /firmware/App/Services/FpgaRO.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/FpgaRO.h (-1, +1) | History | Source | Diff
· /firmware/source/sys_main.c (-8, +39) | History | Source | Diff
]]> ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAH-1972: Addressed code review comments. Wed, 22 Jan 2025 09:37:17 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=2ac0ed667ccf0d77a65905157af9badbd19007cd https://devapps.diality.us/changelog/ro-firmware?cs=2ac0ed667ccf0d77a65905157af9badbd19007cd Sean Nash committed 2ac0ed6 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 14 more in ro-firmware LEAH-1972: Addressed code review comments.

· /firmware/App/Controllers/ROPump.c (-8, +8) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-8, +8) | History | Source | Diff
]]> ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAH-1972: Refactored component names. Tue, 21 Jan 2025 16:23:18 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=3241c6b7f66889b6443e377ab1f5ecf2cedd2602 https://devapps.diality.us/changelog/ro-firmware?cs=3241c6b7f66889b6443e377ab1f5ecf2cedd2602 Sean Nash committed 3241c6b on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 14 more in ro-firmware LEAH-1972: Refactored component names.

· /firmware/App/Controllers/Heaters.c (-15, +7) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-9, +5) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-8, +8) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-10, +10) | History | Source | Diff
· /firmware/App/Drivers/BoostPump.c (-9, +9) | History | Source | Diff
· /firmware/App/Drivers/BoostPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensors.c (-52, +52) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensors.h (-3, +3) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.c (-4, +4) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.h (-30, +30) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-25, +25) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.h (-8, +8) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.c (-23, +42) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.h (-3, +7) | History | Source | Diff
· /firmware/App/Monitors/Conductivity.c (-4, +2) | History | Source | Diff
… 11 more files in changeset.
]]> ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAH-250: Addressed code review comments. Tue, 19 Nov 2024 17:30:51 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=d4d21b42ee8bd292a6d9f7966fe37abe0271dfda https://devapps.diality.us/changelog/ro-firmware?cs=d4d21b42ee8bd292a6d9f7966fe37abe0271dfda Sean Nash committed d4d21b4 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 16 more in ro-firmware LEAH-250: Addressed code review comments.

· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/BoostPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-14, +1) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.c (-25, +8) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.h (-7, +2) | History | Source | Diff
· /firmware/App/Monitors/Level.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/FpgaRO.c (-21, +165) | History | Source | Diff
· /firmware/App/Services/FpgaRO.h (-1, +1) | History | Source | Diff
]]> ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAH-250: Added RO pumps driver and controller units. Fri, 15 Nov 2024 13:13:13 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=0d2351b8e47e40fdcd706ed7b7ac1379b69a20ef https://devapps.diality.us/changelog/ro-firmware?cs=0d2351b8e47e40fdcd706ed7b7ac1379b69a20ef Sean Nash committed 0d2351b on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 16 more in ro-firmware LEAH-250: Added RO pumps driver and controller units.

· /firmware/App/Controllers/ROPump.c (-0, +272) | History | Source
· /firmware/App/Controllers/ROPump.h (-0, +59) | History | Source
· /firmware/App/Controllers/Valves.c (-11, +16) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-4, +5) | History | Source | Diff
· /firmware/App/Drivers/BoostPump.c (-0, +295) | History | Source
· /firmware/App/Drivers/BoostPump.h (-0, +61) | History | Source
· /firmware/App/Services/AlarmMgmtSWFaults.h (-0, +6) | History | Source | Diff
· /firmware/App/Services/FpgaRO.c (-30, +65) | History | Source | Diff
· /firmware/App/Services/FpgaRO.h (-2, +9) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-2, +10) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.c (-0, +4) | History | Source | Diff
· /firmware/source/sys_main.c (-0, +2) | History | Source | Diff
]]>