else shouldn't we go back to waiting for an update or something? Seems wrong to just get stuck here.

Is Noe never going to change these IDs? I think he has already changed DD fpga ID for beta 2.0. If these IDs are not fixed forever, we cannot hardcode them here in the bootloader code.

We can't jump to app if fpga ID is bad? Why not?

Where is this function defined?

Align comments

Why 2 conditions? Are there 2 ways to initiate an update?

And why isn't this check done in the CHECK_FOR_UPDATE_STATE?

· /firmware/App/Modes/ModeStandby.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-7, +9)	| History	| Source	| Diff
· /firmware/App/Services/FPGA.c	(-11, +10)	| History	| Source	| Diff
· /firmware/source/sys_startup.c	(-2, +2)	| History	| Source	| Diff

]]> Tue, 20 Jan 2026 14:40:46 -0800 Sean Nash https://devapps.diality.us/cru/BOOTLOADER-LEAH-1415-1/#c26480 https://devapps.diality.us/cru/BOOTLOADER-LEAH-1415-1/#c26480 Sean Nash replied to Dara Navaei in BOOTLOADER-LEAH-1415-1

TODO

TODO

TODO should be all caps.

TODO should be all caps for consistency (so we know what to search for).

I think it should be restored even if it's not used anywhere yet.

Do we need an end of group marker down here?

Can you capture intent to resolve my comment in a TODO so we don't lose track of it? (General recommendation for all comments that we are postponing resolution for).

Can we put test code inside of #ifdef TEST_CODE_ENABLED or something so that it is easy to remove later?

· /firmware/App/Modes/ModeStandby.c	(-18, +10)	| History	| Source	| Diff
· /firmware/App/Modes/ModeUpdate.c	(-5, +7)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-4, +6)	| History	| Source	| Diff
· /firmware/App/Services/Comm.c	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Services/CommBuffers.c	(-10, +7)	| History	| Source	| Diff
· /firmware/App/Services/Download.c	(-8, +3)	| History	| Source	| Diff
· /firmware/App/Services/FPGA.c	(-2, +3)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskBG.c	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskPriority.c	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskPriority.h	(-0, +2)	| History	| Source	| Diff
· /firmware/source/sys_main.c	(-0, +5)	| History	| Source	| Diff

]]> Sat, 17 Jan 2026 16:30:28 -0800 Dara Navaei https://devapps.diality.us/cru/BOOTLOADER-LEAH-1415-1/#c26399 https://devapps.diality.us/cru/BOOTLOADER-LEAH-1415-1/#c26399 Dara Navaei replied to Sean Nash in BOOTLOADER-LEAH-1415-1

It will be implemented in the new branch.

Done

Done

Done

Done

Removed the variable.

Removed the TODO.

Removed the interrupt.

Done

The new update request is checked on top of the mode update exec function. If there is a new update, it will request a transition otherwise, this is a terminal state.

It is the update mode re-initialized. The initialization is done using other functions that have their own doxygen comments. Do I need to add more here?

Added the return of a value.