Fisheye on dd-firmware/firmware/App/Controllers/Valves.c https://devapps.diality.us/changelog/~br%3DLEAH-1971-dd-integration-changes-1/dd-firmware/firmware/App/Controllers/Valves.c Recent activity in "dd-firmware" under directory /firmware/App/Controllers/Valves.c dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): Refactoring Code review comments fix Tue, 28 Jan 2025 17:21:29 -0800 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=322747d530c1b8205be257557e53dcfe9caad50a https://devapps.diality.us/changelog/dd-firmware?cs=322747d530c1b8205be257557e53dcfe9caad50a Vinayakam Mani committed 322747d on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 97 more in dd-firmware Refactoring Code review comments fix

· /firmware/App/Controllers/ConcentratePumps.c (-59, +55) | History | Source | Diff
· /firmware/App/Controllers/DialysatePumps.c (-15, +17) | History | Source | Diff
· /firmware/App/Controllers/DialysatePumps.h (-3, +6) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-49, +37) | History | Source | Diff
· /firmware/App/Controllers/PistonPumpControl.c (-1, +3) | History | Source | Diff
· /firmware/App/Controllers/PistonPumpControl.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-5, +0) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-1, +0) | History | Source | Diff
· /firmware/App/DDCommon.h (-3, +6) | History | Source | Diff
· /firmware/App/Drivers/BalancingChamber.c (-790, +0) | History | Source | Diff
· /firmware/App/Drivers/BalancingChamber.h (-74, +0) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-2, +0) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.c (-5, +4) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.c (-79, +46) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.h (-2, +2) | History | Source | Diff
… 8 more files in changeset.
]]> dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): merge changes from develop Thu, 23 Jan 2025 09:51:56 -0800 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=ed39129abdca4ec343369d83494530b23621e052 https://devapps.diality.us/changelog/dd-firmware?cs=ed39129abdca4ec343369d83494530b23621e052 Vinayakam Mani committed ed39129 on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 97 more in dd-firmware merge changes from develop

· /firmware/App/Controllers/ConcentratePumps.c (-114, +257) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-22, +29) | History | Source | Diff
· /firmware/App/Controllers/DialysatePumps.c (-173, +218) | History | Source | Diff
· /firmware/App/Controllers/DialysatePumps.h (-26, +26) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-102, +167) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-12, +13) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-161, +193) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-56, +70) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensors.c (-183, +183) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensors.h (-5, +6) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-141, +141) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.h (-31, +31) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-67, +72) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.h (-39, +39) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.c (-45, +74) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.h (-8, +8) | History | Source | Diff
]]> dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): LEAH-215 RO interface code commit Thu, 21 Nov 2024 17:19:23 -0800 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=9102c5da21a15bdaf4bb3bc38795ceb064e3c443 https://devapps.diality.us/changelog/dd-firmware?cs=9102c5da21a15bdaf4bb3bc38795ceb064e3c443 Vinayakam Mani committed 9102c5d on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 98 more in dd-firmware LEAH-215 RO interface code commit

· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-1, +1) | History | Source | Diff
· /firmware/App/DDCommon.h (-20, +20) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-3, +3) | History | Source | Diff
· /firmware/App/Modes/BalancingChamber.c (-4, +8) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.c (-1, +4) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-7, +7) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/FpgaDD.c (-21, +45) | History | Source | Diff
· /firmware/App/Services/FpgaDD.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-3, +6) | History | Source | Diff
· /firmware/App/Services/ROInterface.c (-0, +227) | History | Source
· /firmware/App/Services/ROInterface.h (-0, +53) | History | Source
· /firmware/App/Services/SystemCommDD.c (-12, +88) | History | Source | Diff
… 4 more files in changeset.
]]> dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): LEAH-236 addressing code review comments Thu, 14 Nov 2024 15:34:55 -0800 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=bce6e6d1cfb6e8a0b186419416460ead3a44e5e1 https://devapps.diality.us/changelog/dd-firmware?cs=bce6e6d1cfb6e8a0b186419416460ead3a44e5e1 Vinayakam Mani committed bce6e6d on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 99 more in dd-firmware LEAH-236 addressing code review comments

· /firmware/App/Controllers/Valves.c (-4, +4) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.c (-50, +72) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.h (-8, +10) | History | Source | Diff
· /firmware/App/Monitors/Level.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/FpgaDD.c (-2, +7) | History | Source | Diff
· /firmware/App/Services/FpgaDD.h (-4, +4) | History | Source | Diff
· /firmware/App/Services/TDInterface.c (-11, +25) | History | Source | Diff
· /firmware/App/Services/TDInterface.h (-13, +8) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-0, +4) | History | Source | Diff
]]> dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): LEAH-236 addressing code review comments Wed, 13 Nov 2024 17:45:16 -0800 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=6679a2cd813b21a8cb4c58b3eeb721e0eef9a10b https://devapps.diality.us/changelog/dd-firmware?cs=6679a2cd813b21a8cb4c58b3eeb721e0eef9a10b Vinayakam Mani committed 6679a2c on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 99 more in dd-firmware LEAH-236 addressing code review comments

· /firmware/App/Controllers/Valves.c (-0, +38) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-0, +2) | History | Source | Diff
· /firmware/App/Modes/BalancingChamber.c (-130, +36) | History | Source | Diff
· /firmware/App/Modes/BalancingChamber.h (-3, +2) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.c (-21, +160) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.h (-0, +4) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-16, +0) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-1, +0) | History | Source | Diff
· /firmware/App/Monitors/Level.c (-2, +4) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-52, +1) | History | Source | Diff
· /firmware/App/Services/Messaging.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/TDInterface.c (-1, +56) | History | Source | Diff
· /firmware/App/Services/TDInterface.h (-1, +2) | History | Source | Diff
]]> dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): LEAH-236-fw-dd-operation-modes Wed, 06 Nov 2024 15:29:23 -0800 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=48ca7fd644c67920acc29a80b7af379d0a134d1a https://devapps.diality.us/changelog/dd-firmware?cs=48ca7fd644c67920acc29a80b7af379d0a134d1a Vinayakam Mani committed 48ca7fd on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 99 more in dd-firmware LEAH-236-fw-dd-operation-modes

· /firmware/App/Controllers/ConcentratePumps.c (-3, +48) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +3) | History | Source | Diff
· /firmware/App/Controllers/DialysatePumps.c (-0, +83) | History | Source | Diff
· /firmware/App/Controllers/DialysatePumps.h (-0, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-0, +84) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-0, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-0, +43) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-26, +27) | History | Source | Diff
· /firmware/App/Modes/BalancingChamber.c (-0, +706) | History | Source
· /firmware/App/Modes/BalancingChamber.h (-0, +66) | History | Source
· /firmware/App/Modes/ModeFault.c (-8, +13) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.c (-0, +573) | History | Source
· /firmware/App/Modes/ModeGenDialysate.h (-0, +60) | History | Source
· /firmware/App/Modes/ModeInitPOST.c (-17, +11) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.h (-1, +1) | History | Source | Diff
… 12 more files in changeset.
]]> dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): LEAH-225 inlet water control added Tue, 15 Oct 2024 17:37:23 -0700 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=48c75a394c56b82886760e9a136b638edecf7572 https://devapps.diality.us/changelog/dd-firmware?cs=48c75a394c56b82886760e9a136b638edecf7572 Vinayakam Mani committed 48c75a3 on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 100 more in dd-firmware LEAH-225 inlet water control added

· /firmware/App/Controllers/Valves.c (-3, +4) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-0, +16) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.h (-2, +4) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-2, +102) | History | Source | Diff
· /firmware/App/Monitors/Pressure.h (-0, +5) | History | Source | Diff
· /firmware/App/Services/FpgaDD.c (-121, +240) | History | Source | Diff
· /firmware/App/Services/FpgaDD.h (-0, +10) | History | Source | Diff
]]> dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): LEAH-227 code review comments incorporation Wed, 02 Oct 2024 10:06:58 -0700 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=e7fe0454b5b2d39009dc784dc8c156856df8bc86 https://devapps.diality.us/changelog/dd-firmware?cs=e7fe0454b5b2d39009dc784dc8c156856df8bc86 Vinayakam Mani committed e7fe045 on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 101 more in dd-firmware LEAH-227 code review comments incorporation

· /firmware/App/Controllers/ConcentratePumps.c (-151, +26) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-78, +3) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensors.c (-112, +5) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-49, +36) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.h (-26, +13) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-112, +5) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.c (-0, +70) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.h (-0, +5) | History | Source | Diff
· /firmware/App/Monitors/Conductivity.c (-22, +1) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-78, +3) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-0, +18) | History | Source | Diff
· /firmware/App/Monitors/Temperature.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-10, +21) | History | Source | Diff
]]> dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): updated code review comments Fri, 30 Aug 2024 16:27:10 -0700 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=f7c714a1a09b10d85a8b013712532d37b4d7b97a https://devapps.diality.us/changelog/dd-firmware?cs=f7c714a1a09b10d85a8b013712532d37b4d7b97a Vinayakam Mani committed f7c714a on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 103 more in dd-firmware updated code review comments

· /firmware/App/Controllers/Valves.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PAL.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFault.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeService.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeService.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-2, +2) | History | Source | Diff
… 19 more files in changeset.
]]> dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): review comments update Thu, 29 Aug 2024 11:08:12 -0700 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=a570e1827563618b8d26082eb63994f9f65adc17 https://devapps.diality.us/changelog/dd-firmware?cs=a570e1827563618b8d26082eb63994f9f65adc17 Vinayakam Mani committed a570e18 on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 103 more in dd-firmware review comments update

· /firmware/App/Controllers/Valves.c (-128, +110) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-20, +25) | History | Source | Diff
]]> dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): updated Valve code Mon, 26 Aug 2024 15:54:57 -0700 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=24bf8d1d7a248f907a5c60496a764ae1ef9876f6 https://devapps.diality.us/changelog/dd-firmware?cs=24bf8d1d7a248f907a5c60496a764ae1ef9876f6 Vinayakam Mani committed 24bf8d1 on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 103 more in dd-firmware updated Valve code

· /firmware/App/Controllers/Valves.c (-0, +584) | History | Source
· /firmware/App/Controllers/Valves.h (-0, +101) | History | Source
]]>