Updated

Updated

Changed

Changed the comments

Updated

Updated

Add blank line before return statement.

Add blank line before return statement.

These are treatment parameters that happen to be overrideable. Change comment to "Initialize treatment parameters from TD."

In comments, we don't need to call attention to the fact that these can be overridden. Their primary purpose is to be the TD supplied treatment parameters. The fact that they can be overridden by Dialin is just an extra. Just write a normal comment.

Even though we are giving the type a name at the bottom of the enum, we typically still want to give the enum a name up top here. See other enums throughout code for examples.

Typically we name this last one starting with "NUM_OF_" to help differentiate from the real enums (i.e. this one is just a count).

Removed

Removed

Updated

Noted.

Changed this section and rewritten

Updated

Yeah, I removed this.

Yes, I used MSG_ID_AVAILABLE_2.

Done.

Noted.

Noted.

There are a few available messages at the top. Like MSG_ID_AVAILABLE_1. Could you please use one them?

You don't need the if statement. The override function will check it automatically.

( TRUE == isTestingActivated() ) && ( ovType != OVERRIDE_INVALID ) && ( ovType < NUM_OF_OVERRIDE_TYPES ) conditions are not needed because the override functions check them already.