Fisheye on dd-firmware/firmware/App/Controllers https://devapps.diality.us/changelog/~br%3DLEAH-210-fw-dd-fpga-interface/dd-firmware/firmware/App/Controllers Recent activity in "dd-firmware" under directory /firmware/App/Controllers LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conduc... Thu, 23 Apr 2026 14:59:17 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "instead of 0, we can use the level Enum 'LVL_ST..." Thu, 23 Apr 2026 14:56:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "lower? and change the D98 level sensor comment ..." Thu, 23 Apr 2026 14:49:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

lower? and change the D98 level sensor comment as well.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Remove empty line" Thu, 23 Apr 2026 14:47:11 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove empty line

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space before LVL_STATE_LOW" Thu, 23 Apr 2026 14:45:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space before LVL_STATE_LOW

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "space inside array index." Thu, 23 Apr 2026 14:43:35 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

space inside array index.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space inside parenthesis." Thu, 23 Apr 2026 14:41:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space inside parenthesis.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Change this to LEVEL_T enum." Thu, 23 Apr 2026 14:39:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Change this to LEVEL_T enum.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Is this macro still being used? if not, delete ..." Thu, 23 Apr 2026 14:38:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Is this macro still being used? if not, delete it.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: started by Dara Navaei Thu, 23 Apr 2026 07:47:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3978-1 ]]> LEAHI-DD-FIRMWARE-LDT-3980-1: reviewers finished Wed, 22 Apr 2026 14:11:04 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3980-1 LEAHI-DD-FIRMWARE-LDT-3980_Dialysate Composition - FW Implementation (Dry Bicarbonate) - 1/1: ]]> LEAHI-DD-FIRMWARE-LDT-3980-1: comment by Vendor - TEL - Sameer Poyil "control interval is different. Control interval..." Tue, 21 Apr 2026 13:01:19 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28564 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28564 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3980-1

control interval is different. Control interval must be separated else we don't get finer control on bicarb conductivity. also the dead band is different. need to figure out whether we can combine or not

]]> LEAHI-DD-FIRMWARE-LDT-3980-1: comment by Sean Nash "This code looks very similar to bicarb code abo..." Tue, 21 Apr 2026 09:02:25 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28559 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28559 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3980-1

This code looks very similar to bicarb code above. Do we really need separate handling?

]]> LEAHI-DD-FIRMWARE-LDT-3980-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3980_Dialysate Composition -... Mon, 20 Apr 2026 17:31:56 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 Sean Nash added Michael Garthwaite , Vendor - TEL - Arpita Srivastava and 2 others to LEAHI-DD-FIRMWARE-LDT-3980-1 LEAHI-DD-FIRMWARE-LDT-3980_Dialysate Composition - FW Implementation (Dry Bicarbonate) - 1/1: ]]> LEAHI-DD-FIRMWARE-LDT-3980-1: comment by Sean Nash "Remove extra blank line." Mon, 20 Apr 2026 17:31:13 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28557 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28557 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3980-1

Remove extra blank line.

]]> LEAHI-DD-FIRMWARE-LDT-3980-1: comment by Sean Nash "Add unit of measure to definition name (e.g. _P..." Mon, 20 Apr 2026 14:06:44 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28556 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28556 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3980-1

Add unit of measure to definition name (e.g. _PSI). Should be done for all definitions w/ a unit of measure to prevent unit errors.

]]> LEAHI-DD-FIRMWARE-LDT-3980-1: started by Dara Navaei Mon, 20 Apr 2026 11:30:47 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3980-1 ]]> LEAHI-DD-FIRMWARE-LDT-3984-1: closed by Dara Navaei Mon, 20 Apr 2026 09:51:13 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Dara Navaei Closed LEAHI-DD-FIRMWARE-LDT-3984-1 ]]> LEAHI-DD-FIRMWARE-LDT-3984-1: reviewers finished Mon, 20 Apr 2026 09:23:14 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Vinayakam Mani and Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-3984-1 LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: closed by Vendor - TEL - Sameer Poyil Mon, 20 Apr 2026 08:17:53 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-2004-9 ]]> LEAHI-DD-FIRMWARE-LDT-3984-1: comment by Michael Garthwaite "fixed" Mon, 20 Apr 2026 06:52:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28540 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28540 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3984-1

fixed

]]> LEAHI-DD-FIRMWARE-LDT-3984-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 wi... Fri, 17 Apr 2026 18:02:29 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Sean Nash added Vendor - TEL - Jashwant Gantyada and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3984-1 LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber ]]> LEAHI-DD-FIRMWARE-LDT-3984-1: comment by Vinayakam Mani "Align the comments." Fri, 17 Apr 2026 17:17:01 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28539 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28539 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3984-1

Align the comments.

]]> LEAHI-DD-FIRMWARE-LDT-3984-1: started by Dara Navaei Fri, 17 Apr 2026 17:13:47 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3984-1 ]]> LEAHI-DD-FIRMWARE-LDT-3352-1: closed by Vinayakam Mani Fri, 17 Apr 2026 09:54:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Vinayakam Mani Closed LEAHI-DD-FIRMWARE-LDT-3352-1 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: reviewers finished Thu, 16 Apr 2026 23:17:41 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-2004-9 LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: started by Sean Nash Thu, 16 Apr 2026 23:13:27 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Sean Nash started review LEAHI-DD-FIRMWARE-LDT-2004-9 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: started by Vendor - TEL - Sameer Poyil Thu, 16 Apr 2026 16:23:22 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Vendor - TEL - Sameer Poyil started review LEAHI-DD-FIRMWARE-LDT-2004-9 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "Its static function and not used by external AP..." Thu, 16 Apr 2026 14:28:01 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28452 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28452 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-9

Its static function and not used by external API to pass the wrong id.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: closed by Michael Garthwaite Thu, 16 Apr 2026 08:15:43 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-3218-4 ]]>