Fisheye on leahi-fwcommon/ https://devapps.diality.us/changelog/~br%3DLEAH-210-fw-dd-fpga-interface/leahi-fwcommon Recent activity in "leahi-fwcommon" under directory / LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Again, I don't like these oriented this way. P..." Fri, 08 May 2026 13:21:48 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29065 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29065 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "If BC switching period is Zero, I would expect ..." Fri, 08 May 2026 13:17:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29064 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29064 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "We shouldn't require something to be defined to..." Fri, 08 May 2026 13:08:00 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29062 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29062 Sean Nash replied to Vendor - TEL - Arpita Srivastava in LEAHI-DD-FIRMWARE-LDT-3963-1

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

]]> LEAHI-TD-FIRMWARE-LDT-4188-1: reviewers resumed Thu, 07 May 2026 15:20:48 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4188-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4188-1 Michael Garthwaite resumed reviewing LEAHI-TD-FIRMWARE-LDT-4188-1 LEAHI-TD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI ]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Remove start state." Thu, 07 May 2026 11:12:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28988 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28988 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Remove start state.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated" Thu, 07 May 2026 10:30:01 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28987 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28987 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Updated

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "updated" Thu, 07 May 2026 10:29:33 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28986 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28986 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

updated

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Yes, removed" Thu, 07 May 2026 10:29:22 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28985 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28985 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Yes, removed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Removed" Thu, 07 May 2026 10:29:02 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28984 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28984 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Removed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "yes, removed" Thu, 07 May 2026 10:28:54 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28983 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28983 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

yes, removed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Changed" Thu, 07 May 2026 10:28:38 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28982 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28982 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Changed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Removed" Thu, 07 May 2026 10:28:29 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28981 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28981 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Removed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Removed" Thu, 07 May 2026 10:28:22 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28980 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28980 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Removed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Removed" Thu, 07 May 2026 10:27:58 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28979 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28979 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Removed

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Added" Thu, 07 May 2026 10:27:50 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28978 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28978 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Added

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Added" Thu, 07 May 2026 10:27:32 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28977 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28977 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Added

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated" Thu, 07 May 2026 10:27:19 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28976 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28976 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Updated

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated" Thu, 07 May 2026 10:27:14 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28975 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28975 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Updated

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Added" Thu, 07 May 2026 10:27:05 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28974 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28974 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Added

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated" Thu, 07 May 2026 10:26:29 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28973 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28973 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Updated

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated" Thu, 07 May 2026 10:25:29 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28972 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28972 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-2240-1

Updated

]]> LEAHI-FWCOMMON-LDT-3910-1: closed by Vendor - TEL - Varshini Nagabooshanam Wed, 06 May 2026 22:30:52 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-FWCOMMON-LDT-3910-1 https://devapps.diality.us/cru/LEAHI-FWCOMMON-LDT-3910-1 Vendor - TEL - Varshini Nagabooshanam Closed LEAHI-FWCOMMON-LDT-3910-1 ]]> LEAHI-FWCOMMON-LDT-3910-1: reviewers resumed Wed, 06 May 2026 10:23:59 -0700 https://devapps.diality.us/cru/LEAHI-FWCOMMON-LDT-3910-1 https://devapps.diality.us/cru/LEAHI-FWCOMMON-LDT-3910-1 Sean Nash resumed reviewing LEAHI-FWCOMMON-LDT-3910-1 LEAHI-FWCOMMON-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode ]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "no need to respond." Tue, 05 May 2026 15:58:48 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28924 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28924 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

no need to respond.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "don't need response to a response." Tue, 05 May 2026 15:58:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28923 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28923 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

don't need response to a response.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "don't need this if statement either and don't n..." Tue, 05 May 2026 15:54:59 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28917 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28917 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

don't need this if statement either and don't need what's inside the if.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Don't need this if statement or flag." Tue, 05 May 2026 15:49:47 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28916 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28916 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Don't need this if statement or flag.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "use separate time than stability (even if same ..." Tue, 05 May 2026 15:46:47 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28915 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28915 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

use separate time than stability (even if same right now).

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "Move to transition function and remove this if ..." Tue, 05 May 2026 15:42:22 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28914 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28914 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Move to transition function and remove this if statement.

]]> LEAHI-TD-FIRMWARE-LDT-2240-1: comment by Sean Nash "do 2 data with the p1 and p2 pressures." Tue, 05 May 2026 15:40:59 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28913 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28913 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

do 2 data with the p1 and p2 pressures.

]]>