Fisheye on dd-firmware/firmware https://devapps.diality.us/changelog/~br%3DLEAH-215-fw-dd-ro-interface/dd-firmware/firmware Recent activity in "dd-firmware" under directory /firmware LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Shouldn't we be assigning dryBicartState instea..." Tue, 14 Apr 2026 14:26:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28335 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28335 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Why do we need this?" Tue, 14 Apr 2026 14:26:00 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28334 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28334 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Why do we need this?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove extra blank line." Tue, 14 Apr 2026 14:24:05 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28333 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28333 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove extra blank line.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Remove extra blank line." Tue, 14 Apr 2026 14:23:28 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28332 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28332 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Remove extra blank line.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Not clear what GENMASK is doing. What do h and..." Tue, 14 Apr 2026 14:19:37 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28331 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28331 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Is this for 64 bit unsigned integer? If not, t..." Tue, 14 Apr 2026 14:15:49 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28330 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28330 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above.
What does nr stand for?

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Sean Nash "Let's remove this commented line." Tue, 14 Apr 2026 14:14:06 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28329 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28329 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Let's remove this commented line.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Add blank line before return." Tue, 14 Apr 2026 14:08:22 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28328 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28328 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Add blank line before return.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Add blank line after declarations." Tue, 14 Apr 2026 14:07:02 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28327 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28327 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Add blank line after declarations.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Why U32? Why not RECOVER_STATE_T?" Tue, 14 Apr 2026 14:05:42 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28326 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28326 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Why U32? Why not RECOVER_STATE_T?

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Lower case x" Tue, 14 Apr 2026 14:04:13 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28325 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28325 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Lower case x

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Is blood flow in need of a PID controller too?" Tue, 14 Apr 2026 14:02:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28324 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28324 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Is blood flow in need of a PID controller too?

]]> LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Sean Nash "2 blank lines before test support banner" Tue, 14 Apr 2026 13:46:52 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28323 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28323 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3777-1

2 blank lines before test support banner

]]> LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Sean Nash "Add blank line before return." Tue, 14 Apr 2026 13:46:34 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28322 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28322 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3777-1

Add blank line before return.

]]> LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Sean Nash "Add blank line before return." Tue, 14 Apr 2026 13:46:16 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28321 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28321 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3777-1

Add blank line before return.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: reviewers finished Tue, 14 Apr 2026 13:21:29 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3352-1 LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "I don't need to edit this file. I will check wi..." Tue, 14 Apr 2026 11:18:24 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28319 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28319 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-9

I don't need to edit this file. I will check with Dara to exclude this file from code review.

]]> LEAHI-DD-FIRMWARE-LDT-3904-1: started by Dara Navaei Tue, 14 Apr 2026 11:17:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3904-1 ]]> LEAHI-DD-FIRMWARE-LDT-3777-1: reviewers finished Tue, 14 Apr 2026 11:17:14 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1 Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-3777-1 LEAHI-DD-FIRMWARE-LDT-3777_Sprint 25 fixes. ]]> LEAHI-DD-FIRMWARE-LDT-3777-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-3777_Sprint 25 fixes. Tue, 14 Apr 2026 11:16:44 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1 Vendor - TEL - Jashwant Gantyada joined LEAHI-DD-FIRMWARE-LDT-3777-1 LEAHI-DD-FIRMWARE-LDT-3777_Sprint 25 fixes. ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "only maximum 30 float data is allowed. If that ..." Tue, 14 Apr 2026 11:09:50 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28318 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28318 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-9

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals.
need to split it or need two message id.

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "Its a problem . Vinay has to decide it" Tue, 14 Apr 2026 11:08:49 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28317 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28317 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2004-9

Its a problem . Vinay has to decide it

]]> LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Michael Garthwaite "fixed" Tue, 14 Apr 2026 11:03:26 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28316 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28316 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3777-1

fixed

]]> LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Michael Garthwaite "good catch. This needed to be reverted back to ..." Tue, 14 Apr 2026 10:23:02 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28315 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28315 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3777-1

good catch. This needed to be reverted back to normal publishing.

]]> LEAHI-DD-FIRMWARE-LDT-1195-2: closed by Vendor - TEL - Arpita Srivastava Tue, 14 Apr 2026 10:57:43 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 Vendor - TEL - Arpita Srivastava Closed LEAHI-DD-FIRMWARE-LDT-1195-2 ]]> LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Michael Garthwaite "fixed." Tue, 14 Apr 2026 10:22:34 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28314 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28314 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3777-1

fixed.

]]> LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Michael Garthwaite "fixed." Tue, 14 Apr 2026 10:22:29 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28313 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28313 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3777-1

fixed.

]]> LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Michael Garthwaite "no longer needed. removed" Tue, 14 Apr 2026 10:22:22 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28312 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28312 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3777-1

no longer needed. removed

]]> LEAHI-DD-FIRMWARE-LDT-3777-1: comment by Michael Garthwaite "updated sampling to be determined on read count..." Tue, 14 Apr 2026 10:22:07 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28311 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3777-1/#c28311 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3777-1

updated sampling to be determined on read count rather than fixed timer.

]]> LEAHI-DD-FIRMWARE-LDT-2008-1: closed by Michael Garthwaite Tue, 14 Apr 2026 09:24:59 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2008-1 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-2008-1 ]]>