Fisheye on fwcommon/Timers.h https://devapps.diality.us/changelog/~br%3DSprint23/fwcommon/Timers.h Recent activity in "fwcommon" under directory /Timers.h HD-DEN-4211-1: closed by Dara Navaei Mon, 14 Sep 2020 15:10:38 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-4211-1 https://devapps.diality.us/cru/HD-DEN-4211-1 Dara Navaei Closed HD-DEN-4211-1 ]]> HD-DEN-4211-1: reviewers finished Mon, 14 Sep 2020 14:42:05 -0700 https://devapps.diality.us/cru/HD-DEN-4211-1 https://devapps.diality.us/cru/HD-DEN-4211-1 pmontazemi  (deleted user) , qnguyen  (deleted user) and Dara Navaei finished reviewing HD-DEN-4211-1 HD-DEN-4211_HD Treatment Parameters Mode ]]> HD-DEN-4211-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Mon, 14 Sep 2020 14:37:58 -0700 pmontazemi https://devapps.diality.us/cru/HD-DEN-4211-1/#c4689 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4689 pmontazemi  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Mon, 14 Sep 2020 14:37:43 -0700 pmontazemi https://devapps.diality.us/cru/HD-DEN-4211-1/#c4688 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4688 pmontazemi  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by Sean Nash "This is from Dara's HD valves branch. I pulled..." Wed, 09 Sep 2020 16:05:31 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-4211-1/#c4675 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4675 Sean Nash replied to pmontazemi  (deleted user) in HD-DEN-4211-1

This is from Dara's HD valves branch. I pulled his FPGA module because he did the last update for register alignment with latest FPGA version, but now that I'm trying to wrap up dev testing, I don't want to duplicate effort to test these functions. All I really needed from the pull was the register map - should have deleted these right after the pull.

]]> HD-DEN-4211-1: comment by pmontazemi "Why did get this section deleted?" Wed, 09 Sep 2020 15:32:11 -0700 pmontazemi https://devapps.diality.us/cru/HD-DEN-4211-1/#c4672 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4672 pmontazemi  (deleted user) commented on HD-DEN-4211-1

Why did get this section deleted?

]]> HD-DEN-4211-1: comment by Sean Nash "Done." Wed, 09 Sep 2020 15:25:21 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-4211-1/#c4669 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4669 Sean Nash replied to pmontazemi  (deleted user) in HD-DEN-4211-1

Done.

]]> HD-DEN-4211-1: comment by pmontazemi "Indent everything to align." Wed, 09 Sep 2020 14:51:34 -0700 pmontazemi https://devapps.diality.us/cru/HD-DEN-4211-1/#c4664 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4664 pmontazemi  (deleted user) commented on HD-DEN-4211-1

Indent everything to align.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Tue, 08 Sep 2020 10:34:53 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4427 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4427 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by Sean Nash "Result no longer same." Wed, 02 Sep 2020 17:32:50 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-4211-1/#c4384 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4384 Sean Nash replied to qnguyen  (deleted user) in HD-DEN-4211-1

Result no longer same.

]]> HD-DEN-4211-1: comment by qnguyen "Suggesting move result assignment out since the..." Wed, 02 Sep 2020 15:54:26 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4383 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4383 qnguyen  (deleted user) commented on HD-DEN-4211-1

Suggesting move result assignment out since the result is same for all cases.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Mon, 31 Aug 2020 16:19:10 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4352 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4352 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Mon, 31 Aug 2020 16:18:57 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4351 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4351 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Mon, 31 Aug 2020 16:18:42 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4350 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4350 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Mon, 31 Aug 2020 16:18:24 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4349 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4349 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by Sean Nash "Done" Fri, 28 Aug 2020 16:57:06 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-4211-1/#c4301 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4301 Sean Nash replied to qnguyen  (deleted user) in HD-DEN-4211-1

Done

]]> HD-DEN-4211-1: comment by Sean Nash "Done" Fri, 28 Aug 2020 16:55:42 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-4211-1/#c4299 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4299 Sean Nash replied to qnguyen  (deleted user) in HD-DEN-4211-1

Done

]]> HD-DEN-4211-1: comment by Sean Nash "Done" Fri, 28 Aug 2020 16:55:28 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-4211-1/#c4298 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4298 Sean Nash replied to qnguyen  (deleted user) in HD-DEN-4211-1

Done

]]> HD-DEN-4211-1: comment by Sean Nash "Done" Fri, 28 Aug 2020 16:55:17 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-4211-1/#c4297 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4297 Sean Nash replied to qnguyen  (deleted user) in HD-DEN-4211-1

Done

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:52:21 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4292 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4292 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:52:04 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4291 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4291 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:51:53 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4290 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4290 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:51:36 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4289 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4289 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:51:23 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4288 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4288 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:51:09 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4287 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4287 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:50:55 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4286 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4286 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:50:46 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4285 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4285 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:50:18 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4284 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4284 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:50:11 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4283 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4283 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-4211-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Fri, 28 Aug 2020 16:50:02 -0700 qnguyen https://devapps.diality.us/cru/HD-DEN-4211-1/#c4282 https://devapps.diality.us/cru/HD-DEN-4211-1/#c4282 qnguyen  (deleted user) replied to Sean Nash in HD-DEN-4211-1

RESOLVED in CODE WALKTHROUGH.

]]>