Fisheye on dialin/tools/build_common_defs.py

DIALIN-DEN-8647-1: closed by plucia

plucia — Thu, 24 Jun 2021 10:27:12 -0700

plucia (deleted user) Closed DIALIN-DEN-8647-1

DIALIN-DEN-8647-1: reviewers finished

Thu, 24 Jun 2021 08:13:08 -0700

pmontazemi (deleted user) finished reviewing DIALIN-DEN-8647-1

DIALIN-DEN-8647_Sprint 46

DIALIN-DEN-8462-1: closed by plucia

plucia — Tue, 22 Jun 2021 13:42:04 -0700

plucia (deleted user) Closed DIALIN-DEN-8462-1

DIALIN-DEN-8462-1: reviewers finished

Tue, 22 Jun 2021 13:41:19 -0700

Sean Nash and qnguyen (deleted user) finished reviewing DIALIN-DEN-8462-1

DIALIN-DEN-8462_Sprint 45

DIALIN-DEN-8647-1: reviewers finished

Tue, 22 Jun 2021 13:39:52 -0700

qnguyen (deleted user) finished reviewing DIALIN-DEN-8647-1

DIALIN-DEN-8647_Sprint 46

DIALIN-DEN-8462-1: comment by qnguyen "RESOLVED."

qnguyen — Tue, 22 Jun 2021 13:39:21 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8462-1

RESOLVED.

DIALIN-DEN-8462-1: comment by plucia "That's a good idea and I think we should do so...."

plucia — Tue, 22 Jun 2021 13:25:57 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8462-1

That's a good idea and I think we should do so. Since this code review is quite old I will make that change in my latest branch

DIALIN-DEN-7605-1: closed by Sean Nash

Sean Nash — Thu, 10 Jun 2021 15:28:27 -0700

Sean Nash Closed DIALIN-DEN-7605-1

DIALIN-DEN-7605-1: reviewers finished

Thu, 10 Jun 2021 15:26:22 -0700

plucia (deleted user) and pmontazemi (deleted user) finished reviewing DIALIN-DEN-7605-1

DIALIN-DEN-7605_HD DG Self Tests

DIALIN-DEN-8647-1: started by plucia

plucia — Wed, 09 Jun 2021 15:19:41 -0700

plucia (deleted user) started review DIALIN-DEN-8647-1

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-8647: Fixed alarm ordering, removed unneeded dialin-only messages, removed unneeded packages in build_common_defs.py...

Wed, 09 Jun 2021 15:17:39 -0700

Peter Lucia committed 817f108 on branch DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime, DEN-10602_UI_DEV_PatientID and 210 more in dialin

DEN-8647: Fixed alarm ordering, removed unneeded dialin-only messages, removed unneeded packages in build_common_defs.py

· /dialin/common/msg_defs.py	(-2, +0)	\| History	\| Source	\| Diff
· /dialin/hd/alarms.py	(-7, +7)	\| History	\| Source	\| Diff
· /dialin/ui/dg_simulator.py	(-1, +1)	\| History	\| Source	\| Diff
· /dialin/ui/hd_simulator.py	(-1, +1)	\| History	\| Source	\| Diff
· /tools/build_common_defs.py	(-2, +0)	\| History	\| Source	\| Diff

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

plucia — Thu, 03 Jun 2021 09:54:56 -0700

plucia (deleted user) replied to Sean Nash in DIALIN-DEN-7605-1

RESOLVED

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

plucia — Thu, 03 Jun 2021 09:54:50 -0700

plucia (deleted user) replied to Sean Nash in DIALIN-DEN-7605-1

RESOLVED

DIALIN-DEN-7605-1: comment by Sean Nash "Fixed."

Sean Nash — Thu, 03 Jun 2021 09:52:21 -0700

Sean Nash replied to plucia (deleted user) in DIALIN-DEN-7605-1

Fixed.

DIALIN-DEN-7605-1: comment by Sean Nash "This is Dara's code. Dara will fix in his DIAL..."

Sean Nash — Thu, 03 Jun 2021 09:32:07 -0700

Sean Nash replied to plucia (deleted user) in DIALIN-DEN-7605-1

This is Dara's code. Dara will fix in his DIALIN-DEN-8030 branch.

DIALIN-DEN-8462-1: comment by qnguyen "should we create dg_defs file?"

qnguyen — Thu, 03 Jun 2021 00:16:18 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8462-1

should we create dg_defs file?

DIALIN-DEN-8462-1: started by plucia

plucia — Wed, 02 Jun 2021 13:26:29 -0700

plucia (deleted user) started review DIALIN-DEN-8462-1

DIALIN-DEN-7605-1: comment by plucia "Is there a problem with crc_16? Or, what needs ..."

plucia — Tue, 01 Jun 2021 10:49:46 -0700

plucia (deleted user) commented on DIALIN-DEN-7605-1

Is there a problem with crc_16? Or, what needs to be fixed still?

DIALIN-DEN-7605-1: comment by plucia "In init.py you should add from .checks impo..."

plucia — Tue, 01 Jun 2021 10:47:37 -0700

plucia (deleted user) commented on DIALIN-DEN-7605-1

In _init_.py you should add from .checks import * so that someone can import the check from utils without having to know which file it is in

dialin (DEN-12358-sw_dev-sprint-67_mg): Merge staging into DEN-8462_Sprint_45

Mon, 24 May 2021 14:54:30 -0700

Peter Lucia committed 0514a69 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 218 more in dialin

Merge staging into DEN-8462_Sprint_45

· /dialin/common/msg_ids.py	(-2, +2)	\| History	\| Source	\| Diff
· /dialin/dg/dialysate_generator.py	(-1, +2)	\| History	\| Source	\| Diff
· /dialin/dg/fluid_leak.py	(-5, +5)	\| History	\| Source	\| Diff
· /dialin/dg/hd_proxy.py	(-40, +62)	\| History	\| Source	\| Diff
· /dialin/dg/heat_disinfect.py	(-35, +3)	\| History	\| Source	\| Diff
· /dialin/dg/heaters.py	(-9, +34)	\| History	\| Source	\| Diff
· /dialin/dg/ro_pump.py	(-5, +9)	\| History	\| Source	\| Diff
· /dialin/dg/temperature_sensors.py	(-1, +33)	\| History	\| Source	\| Diff
· /dialin/dg/uv_reactors.py	(-6, +8)	\| History	\| Source	\| Diff
· /dialin/hd/fluid_leak.py	(-5, +5)	\| History	\| Source	\| Diff
· /dialin/hd/ui_proxy.py	(-7, +13)	\| History	\| Source	\| Diff
· /dialin/ui/hd_simulator.py	(-6, +279)	\| History	\| Source	\| Diff
· /tools/build_common_defs.py	(-1, +1)	\| History	\| Source	\| Diff

dialin (DEN-12358-sw_dev-sprint-67_mg): Merging DEN-8462_Sprint_45 into develop

Tue, 18 May 2021 16:08:37 -0700

Peter Lucia committed 5aea950 on branch DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime, DEN-10602_UI_DEV_PatientID and 210 more in dialin

Merging DEN-8462_Sprint_45 into develop

· /dialin/common/alarm_defs.py

(-2, +3)

| History

| Source

| Diff

· /dialin/common/msg_defs.py

(-1, +1)

| History

| Source

| Diff

· /dialin/common/msg_ids.py

(-23, +22)

| History

| Source

| Diff

· /dialin/dg/accelerometer.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/concentrate_pumps.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/conductivity_sensors.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/dialysate_generator.py

(-6, +4)

| History

| Source

| Diff

· /dialin/dg/drain_pump.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/fans.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/fluid_leak.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/heat_disinfect.py

(-3, +1)

| History

| Source

| Diff

· /dialin/dg/heaters.py

(-4, +6)

| History

| Source

| Diff

· /dialin/dg/load_cells.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/pressures.py

(-7, +7)

| History

| Source

| Diff

· /dialin/dg/ro_pump.py

(-5, +12)

| History

| Source

| Diff

… 6 more files in changeset.

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-8462: Updated build_common_defs.py

Fri, 14 May 2021 09:49:36 -0700

Peter Lucia committed afcc17e on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 218 more in dialin

DEN-8462: Updated build_common_defs.py

· /dialin/common/alarm_defs.py	(-8, +41)	\| History	\| Source	\| Diff
· /dialin/common/msg_ids.py	(-20, +30)	\| History	\| Source	\| Diff
· /tools/build_common_defs.py	(-3, +2)	\| History	\| Source	\| Diff

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

plucia — Tue, 11 May 2021 12:25:46 -0700

plucia (deleted user) replied to Sean Nash in DIALIN-DEN-7605-1

RESOLVED

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

plucia — Tue, 11 May 2021 12:25:33 -0700

plucia (deleted user) replied to Sean Nash in DIALIN-DEN-7605-1

RESOLVED

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

plucia — Tue, 11 May 2021 12:25:23 -0700

plucia (deleted user) replied to Sean Nash in DIALIN-DEN-7605-1

RESOLVED

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

plucia — Tue, 11 May 2021 12:25:12 -0700

plucia (deleted user) replied to Sean Nash in DIALIN-DEN-7605-1

RESOLVED

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

plucia — Tue, 11 May 2021 12:24:59 -0700

plucia (deleted user) replied to Sean Nash in DIALIN-DEN-7605-1

RESOLVED

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

plucia — Tue, 11 May 2021 12:24:47 -0700

plucia (deleted user) replied to Sean Nash in DIALIN-DEN-7605-1

RESOLVED

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

plucia — Tue, 11 May 2021 12:24:21 -0700

plucia (deleted user) replied to Sean Nash in DIALIN-DEN-7605-1

RESOLVED

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

plucia — Tue, 11 May 2021 12:24:10 -0700

plucia (deleted user) replied to Sean Nash in DIALIN-DEN-7605-1

RESOLVED

Fisheye on dialin/tools/build_common_defs.py

DIALIN-DEN-8647-1: closed by plucia

DIALIN-DEN-8647-1: reviewers finished

DIALIN-DEN-8462-1: closed by plucia

DIALIN-DEN-8462-1: reviewers finished

DIALIN-DEN-8647-1: reviewers finished

DIALIN-DEN-8462-1: comment by qnguyen "RESOLVED."

DIALIN-DEN-8462-1: comment by plucia "That's a good idea and I think we should do so...."

DIALIN-DEN-7605-1: closed by Sean Nash

DIALIN-DEN-7605-1: reviewers finished

DIALIN-DEN-8647-1: started by plucia

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-8647: Fixed alarm ordering, removed unneeded dialin-only messages, removed unneeded packages in build_common_defs.py...

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

DIALIN-DEN-7605-1: comment by Sean Nash "Fixed."

DIALIN-DEN-7605-1: comment by Sean Nash "This is Dara's code. Dara will fix in his DIAL..."

DIALIN-DEN-8462-1: comment by qnguyen "should we create dg_defs file?"

DIALIN-DEN-8462-1: started by plucia

DIALIN-DEN-7605-1: comment by plucia "Is there a problem with crc_16? Or, what needs ..."

DIALIN-DEN-7605-1: comment by plucia "In __init__.py you should add from .checks impo..."

dialin (DEN-12358-sw_dev-sprint-67_mg): Merge staging into DEN-8462_Sprint_45

dialin (DEN-12358-sw_dev-sprint-67_mg): Merging DEN-8462_Sprint_45 into develop

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-8462: Updated build_common_defs.py

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

DIALIN-DEN-7605-1: comment by plucia "RESOLVED"

DIALIN-DEN-7605-1: comment by plucia "In init.py you should add from .checks impo..."