Fisheye on hdfirmware/firmware/App/Services https://devapps.diality.us/changelog/~br%3Dden-1404-code-review/hdfirmware/firmware/App/Services Recent activity in "hdfirmware" under directory /firmware/App/Services hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Put #define SIMULATOR in proper places Fri, 17 Jan 2020 11:39:46 -0800 Leonardo Baloa <lbaloa@diality.com> https://devapps.diality.us/changelog/hdfirmware?cs=9bf9b19ed82c7cc8cdb6b0fdcd67401dc1561d58 https://devapps.diality.us/changelog/hdfirmware?cs=9bf9b19ed82c7cc8cdb6b0fdcd67401dc1561d58 Leonardo Baloa <lbaloa@diality.com> committed 9bf9b19 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware Put #define SIMULATOR in proper places

· /firmware/App/Controllers/DialOutFlow.c (-1, +4) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-3, +1) | History | Source | Diff
]]> hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Testing changes as per code review Fri, 17 Jan 2020 10:50:53 -0800 Leonardo Baloa <lbaloa@diality.com> https://devapps.diality.us/changelog/hdfirmware?cs=d0c2c5ec93f7fae9772c14e9aa0baec0b20ed5ce https://devapps.diality.us/changelog/hdfirmware?cs=d0c2c5ec93f7fae9772c14e9aa0baec0b20ed5ce Leonardo Baloa <lbaloa@diality.com> committed d0c2c5e on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware Testing changes as per code review

· /firmware/App/Controllers/DialOutFlow.c (-37, +298) | History | Source | Diff
· /firmware/App/Controllers/DialOutFlow.h (-1, +19) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-13, +5) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
]]> hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Added changes due to code reviews Thu, 16 Jan 2020 09:12:27 -0800 Leonardo Baloa <lbaloa@diality.com> https://devapps.diality.us/changelog/hdfirmware?cs=90ff6d5060b3f679d17fada9057e4dcecdecae9c https://devapps.diality.us/changelog/hdfirmware?cs=90ff6d5060b3f679d17fada9057e4dcecdecae9c Leonardo Baloa <lbaloa@diality.com> committed 90ff6d5 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware Added changes due to code reviews

· /firmware/App/Common.h (-0, +3) | History | Source | Diff
· /firmware/App/Controllers/DialOutFlow.c (-16, +27) | History | Source | Diff
· /firmware/App/Services/PIControllers.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/PIControllers.c.old (-180, +0) | History | Source | Diff
· /firmware/App/Services/PIControllers.h.old (-54, +0) | History | Source | Diff
]]> hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Updated vectorcast testing Tue, 14 Jan 2020 17:38:24 -0800 Leonardo Baloa <lbaloa@diality.com> https://devapps.diality.us/changelog/hdfirmware?cs=edea658600106142cef72c6bb60825ca90c9c80b https://devapps.diality.us/changelog/hdfirmware?cs=edea658600106142cef72c6bb60825ca90c9c80b Leonardo Baloa <lbaloa@diality.com> committed edea658 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware Updated vectorcast testing

· /firmware/App/Controllers/DialOutFlow.c (-38, +45) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
]]> hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Checking for settings in parameters passed Tue, 14 Jan 2020 10:32:08 -0800 Leonardo Baloa <lbaloa@diality.com> https://devapps.diality.us/changelog/hdfirmware?cs=c8c95741c34a1768808a40152f0f2174bacb84ee https://devapps.diality.us/changelog/hdfirmware?cs=c8c95741c34a1768808a40152f0f2174bacb84ee Leonardo Baloa <lbaloa@diality.com> committed c8c9574 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware Checking for settings in parameters passed

· /firmware/App/Controllers/DialOutFlow.c (-42, +60) | History | Source | Diff
· /firmware/App/Controllers/DialOutFlow.h (-7, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-3, +4) | History | Source | Diff
]]> hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Added load cell simulation Mon, 13 Jan 2020 18:05:08 -0800 Leonardo Baloa <lbaloa@diality.com> https://devapps.diality.us/changelog/hdfirmware?cs=316e7117180362d54af53818822694c4f936e550 https://devapps.diality.us/changelog/hdfirmware?cs=316e7117180362d54af53818822694c4f936e550 Leonardo Baloa <lbaloa@diality.com> committed 316e711 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware Added load cell simulation

· /firmware/.launches/HD.launch (-1, +1) | History | Source | Diff
· /firmware/App/Common.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DialOutFlow.c (-22, +87) | History | Source | Diff
· /firmware/App/Controllers/DialOutFlow.h (-2, +1) | History | Source | Diff
· /firmware/App/Services/PIControllers.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-7, +7) | History | Source | Diff
]]> hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Updated code to make it work with dialin Fri, 10 Jan 2020 18:14:50 -0800 Leonardo Baloa <lbaloa@diality.com> https://devapps.diality.us/changelog/hdfirmware?cs=e7e4d0d8f84b61de25fe21ecf9aa11b2732b598d https://devapps.diality.us/changelog/hdfirmware?cs=e7e4d0d8f84b61de25fe21ecf9aa11b2732b598d Leonardo Baloa <lbaloa@diality.com> committed e7e4d0d on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware Updated code to make it work with dialin

· /firmware/App/Controllers/DialOutFlow.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-3, +2) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +6) | History | Source | Diff
]]> hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Update CAN interface to test DialOutFlow module Thu, 09 Jan 2020 17:16:03 -0800 Leonardo Baloa <lbaloa@diality.com> https://devapps.diality.us/changelog/hdfirmware?cs=5a8668a1a04cfa46b1a0aeece4f527ebbf26a106 https://devapps.diality.us/changelog/hdfirmware?cs=5a8668a1a04cfa46b1a0aeece4f527ebbf26a106 Leonardo Baloa <lbaloa@diality.com> committed 5a8668a on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware Update CAN interface to test DialOutFlow module

· /firmware/.settings/org.eclipse.core.resources.prefs (-0, +17) | History | Source | Diff
· /firmware/App/Controllers/DialOutFlow.c (-311, +108) | History | Source | Diff
· /firmware/App/Controllers/DialOutFlow.h (-25, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-2, +8) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +108) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +7) | History | Source | Diff
· /results/VectorCAST.log (-9572, +4827) | History | Source | Diff
· /results/cppcheck.log (-74, +43) | History | Source | Diff
· /results/cppcheckError.log (-570, +0) | History | Source | Diff
]]> hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Updated ports to be used for PWM, stop and dir for the outlet pump Wed, 08 Jan 2020 17:07:14 -0800 Leonardo Baloa <lbaloa@diality.com> https://devapps.diality.us/changelog/hdfirmware?cs=89a95cb8fbc537f1c7a5448a05788342f7319c01 https://devapps.diality.us/changelog/hdfirmware?cs=89a95cb8fbc537f1c7a5448a05788342f7319c01 Leonardo Baloa <lbaloa@diality.com> committed 89a95cb on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware Updated ports to be used for PWM, stop and dir for the outlet pump

· /firmware/App/Controllers/DialOutFlow.c (-626, +673) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-192, +193) | History | Source | Diff
]]> hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Updating DEN-1404 to DEN-1312 changes Wed, 08 Jan 2020 09:48:49 -0800 Leonardo Baloa <lbaloa@diality.com> https://devapps.diality.us/changelog/hdfirmware?cs=f8395d7271a1fbcb2e577ce48b9327b16d2b97e0 https://devapps.diality.us/changelog/hdfirmware?cs=f8395d7271a1fbcb2e577ce48b9327b16d2b97e0 Leonardo Baloa <lbaloa@diality.com> committed f8395d7 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware Updating DEN-1404 to DEN-1312 changes

· /firmware/App/Common.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/PIControllers.c (-17, +30) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-1, +1) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Minor improvements to CAN communications. +review HD-DEN-1312-1 Tue, 07 Jan 2020 22:05:55 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=620033425435de1fab63396301aa2404a49f8777 https://devapps.diality.us/changelog/hdfirmware?cs=620033425435de1fab63396301aa2404a49f8777 Sean Nash committed 6200334 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Minor improvements to CAN communications. +review HD-DEN-1312-1

· /firmware/App/Common.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/Comm.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/CommBuffers.c (-2, +2) | History | Source | Diff
· /firmware/App/Tasks/TaskBG.c (-2, +0) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Addressed code review feedback. +review HD-DEN-1312-1 Tue, 07 Jan 2020 21:01:06 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=0b740ea23455f3122c9b21b2394244fd6488fa0a https://devapps.diality.us/changelog/hdfirmware?cs=0b740ea23455f3122c9b21b2394244fd6488fa0a Sean Nash committed 0b740ea on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Addressed code review feedback. +review HD-DEN-1312-1

· /firmware/App/Services/FPGA.c (-1, +1) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.c (-1, +1) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-1, +1) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Updated PIControllers to behave in classic manner. Added more thread protection to CAN comm buffers. +review HD-DEN-13... Tue, 07 Jan 2020 12:30:53 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=5217f70ca5c74bd586dc14540e6404b43feea004 https://devapps.diality.us/changelog/hdfirmware?cs=5217f70ca5c74bd586dc14540e6404b43feea004 Sean Nash committed 5217f70 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Updated PIControllers to behave in classic manner. Added more thread protection to CAN comm buffers. +review HD-DEN-1312-1

· /firmware/App/Common.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/BloodFlow.c (-4, +1) | History | Source | Diff
· /firmware/App/Controllers/DialInFlow.c (-4, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-12, +15) | History | Source | Diff
· /firmware/App/Services/CommBuffers.c (-13, +19) | History | Source | Diff
· /firmware/App/Services/PIControllers.c (-17, +30) | History | Source | Diff
· /firmware/App/Services/PIControllers.h (-1, +1) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.c (-1, +1) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-1, +1) | History | Source | Diff
]]> hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Merge DEN-1312 into DEN-1404 branch Tue, 07 Jan 2020 09:24:38 -0800 Leonardo Baloa <lbaloa@diality.com> https://devapps.diality.us/changelog/hdfirmware?cs=a97e98d0f53f5825c5bc400f87f096f418e110cf https://devapps.diality.us/changelog/hdfirmware?cs=a97e98d0f53f5825c5bc400f87f096f418e110cf Leonardo Baloa <lbaloa@diality.com> committed a97e98d on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware Merge DEN-1312 into DEN-1404 branch

· /firmware/App/Common.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/PIControllers.c (-107, +130) | History | Source | Diff
· /firmware/App/Services/PIControllers.c.old (-0, +180) | History | Source
· /firmware/App/Services/PIControllers.h (-10, +9) | History | Source | Diff
· /firmware/App/Services/PIControllers.h.old (-0, +54) | History | Source
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Updated UT for SystemComm and SystemCommMessages modules. Fri, 03 Jan 2020 15:40:19 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=37cfaa86d4307dfb4096e94270d2f29afc900b86 https://devapps.diality.us/changelog/hdfirmware?cs=37cfaa86d4307dfb4096e94270d2f29afc900b86 Sean Nash committed 37cfaa8 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Updated UT for SystemComm and SystemCommMessages modules.

· /firmware/App/Services/SystemComm.c (-33, +28) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Updated UT for AlarmMgmt module. Fri, 03 Jan 2020 13:09:23 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=dd4ce30f73606a539e2b1f5c09ed1a3250db68c9 https://devapps.diality.us/changelog/hdfirmware?cs=dd4ce30f73606a539e2b1f5c09ed1a3250db68c9 Sean Nash committed dd4ce30 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Updated UT for AlarmMgmt module.

· /firmware/App/Services/AlarmMgmt.c (-2, +14) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Updated BloodFlow and DialInFlow modules per UT. Added new UT for DialInFlow. Fri, 03 Jan 2020 11:03:07 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=22f7bcd7e26dc6be337fdb6adbc9281e8f60dbbc https://devapps.diality.us/changelog/hdfirmware?cs=22f7bcd7e26dc6be337fdb6adbc9281e8f60dbbc Sean Nash committed 22f7bcd on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Updated BloodFlow and DialInFlow modules per UT. Added new UT for DialInFlow.

· /firmware/App/Controllers/BloodFlow.c (-9, +7) | History | Source | Diff
· /firmware/App/Controllers/DialInFlow.c (-12, +10) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-0, +2) | History | Source | Diff
· /firmware/source/sys_main.c (-0, +7) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Removed DialOutFlow module - Leo added to separate branch. Fixed alarm lamp POST. Fri, 03 Jan 2020 08:26:16 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=4a41a54d255afc5cef0599e2a832927ed2b0ee5d https://devapps.diality.us/changelog/hdfirmware?cs=4a41a54d255afc5cef0599e2a832927ed2b0ee5d Sean Nash committed 4a41a54 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Removed DialOutFlow module - Leo added to separate branch. Fixed alarm lamp POST.

· /firmware/App/Controllers/AlarmLamp.c (-3, +4) | History | Source | Diff
· /firmware/App/Controllers/BloodFlow.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DialInFlow.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/DialOutUF.c (-838, +0) | History | Source | Diff
· /firmware/App/Controllers/DialOutUF.h (-58, +0) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeOpParams.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModePostTreat.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModePreTreat.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModePrescription.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModeTreatment.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-28, +38) | History | Source | Diff
· /firmware/App/Services/WatchdogMgmt.c (-1, +3) | History | Source | Diff
… 4 more files in changeset.
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Added dialin messages for dialysate inlet pump. Fixes to watchdog expired fault. Updates to existing UT. Mon, 30 Dec 2019 14:55:19 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=8f8776e48894e31cba816ebef2edf96d14306ba8 https://devapps.diality.us/changelog/hdfirmware?cs=8f8776e48894e31cba816ebef2edf96d14306ba8 Sean Nash committed 8f8776e on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Added dialin messages for dialysate inlet pump. Fixes to watchdog expired fault. Updates to existing UT.

· /firmware/App/Controllers/DialInFlow.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-0, +28) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-0, +136) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-0, +33) | History | Source | Diff
· /firmware/App/Services/WatchdogMgmt.c (-2, +6) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.c (-1, +1) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-1, +1) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Fixed high priority alarm lamp blink frequency. Added alarm functionality for silence, escalation, and flags. Added a ... Fri, 27 Dec 2019 19:23:42 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=07b9515c080aa68fecfa331cbc593adea4c0b8dc https://devapps.diality.us/changelog/hdfirmware?cs=07b9515c080aa68fecfa331cbc593adea4c0b8dc Sean Nash committed 07b9515 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Fixed high priority alarm lamp blink frequency. Added alarm functionality for silence, escalation, and flags. Added a new boolean flag for whether there is at least one alarm pending escalation.

· /firmware/App/Controllers/AlarmLamp.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-7, +139) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-4, +4) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Added PIControllers module. Used new PIControllers module in BloodFlow and DialInFlow modules. Moved Watchdog POST to ... Fri, 27 Dec 2019 15:31:49 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=ea6ff77291eee02f351953b76c6720cf860c8be7 https://devapps.diality.us/changelog/hdfirmware?cs=ea6ff77291eee02f351953b76c6720cf860c8be7 Sean Nash committed ea6ff77 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Added PIControllers module. Used new PIControllers module in BloodFlow and DialInFlow modules. Moved Watchdog POST to first POST test. Prevent watchdog expired fault during watchdog POST test.

· /firmware/App/Controllers/BloodFlow.c (-26, +11) | History | Source | Diff
· /firmware/App/Controllers/DialInFlow.c (-26, +11) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-21, +15) | History | Source | Diff
· /firmware/App/Services/PIControllers.c (-0, +205) | History | Source
· /firmware/App/Services/PIControllers.h (-0, +54) | History | Source
· /firmware/App/Services/WatchdogMgmt.c (-5, +18) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Updated FPGA registers. Removed some CAN debug code. Removed html reports from vectorcast. Fri, 27 Dec 2019 09:10:01 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=ab432aeb5e140e5b17b149f980063843fcb76290 https://devapps.diality.us/changelog/hdfirmware?cs=ab432aeb5e140e5b17b149f980063843fcb76290 Sean Nash committed ab432ae on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Updated FPGA registers. Removed some CAN debug code. Removed html reports from vectorcast.

· /firmware/App/Services/CommBuffers.c (-13, +0) | History | Source | Diff
· /firmware/App/Services/FPGA.c (-16, +24) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-17, +7) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Updated CAN interrupts config. Added a watchdog expired alarm. Added PWM duty cycle to blood flow broadcast. Fri, 20 Dec 2019 16:30:32 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=6311eb9b65fdeec7a285d25e07f3932ac0fb6cf1 https://devapps.diality.us/changelog/hdfirmware?cs=6311eb9b65fdeec7a285d25e07f3932ac0fb6cf1 Sean Nash committed 6311eb9 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Updated CAN interrupts config. Added a watchdog expired alarm. Added PWM duty cycle to blood flow broadcast.

· /firmware/App/Common.h (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/BloodFlow.c (-4, +3) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-1, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/Interrupts.c (-0, +3) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-12, +12) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-14, +25) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/WatchdogMgmt.c (-1, +3) | History | Source | Diff
· /firmware/HD.dil (-28, +28) | History | Source | Diff
· /firmware/HD.hcg (-2, +4) | History | Source | Diff
· /firmware/include/can.h (-14, +14) | History | Source | Diff
· /firmware/include/sys_core.h (-5, +5) | History | Source | Diff
· /firmware/include/sys_vim.h (-1, +2) | History | Source | Diff
· /firmware/source/can.c (-14, +55) | History | Source | Diff
… 4 more files in changeset.
]]> hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Added PI Controllers module Wed, 18 Dec 2019 17:20:51 -0800 Leonardo Baloa <lbaloa@diality.com> https://devapps.diality.us/changelog/hdfirmware?cs=83c8cecd53d54b4ebfdb6d136701e9522ed99cf2 https://devapps.diality.us/changelog/hdfirmware?cs=83c8cecd53d54b4ebfdb6d136701e9522ed99cf2 Leonardo Baloa <lbaloa@diality.com> committed 83c8cec on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware Added PI Controllers module

· /firmware/App/Services/PIControllers.c (-0, +181) | History | Source
· /firmware/App/Services/PIControllers.h (-0, +54) | History | Source
]]> hdfirmware (leo-sprint-development): Adding FIR filters Wed, 18 Dec 2019 10:29:46 -0800 Leonardo Baloa <lbaloa@diality.com> https://devapps.diality.us/changelog/hdfirmware?cs=52cc3f36b92c467208247f655cd090bae70a6cc4 https://devapps.diality.us/changelog/hdfirmware?cs=52cc3f36b92c467208247f655cd090bae70a6cc4 Leonardo Baloa <lbaloa@diality.com> committed 52cc3f3 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review, leo-sprint-development in hdfirmware Adding FIR filters

· /firmware/App/Services/FIRFilters.c (-0, +194) | History | Source
· /firmware/App/Services/FIRFilters.h (-0, +37) | History | Source
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Added some more CAN debug code. Minor updates to blood and dialysate pump modules. Tue, 17 Dec 2019 19:22:16 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=85bfe5051e4d2bf67be39d394f96c075b4e52836 https://devapps.diality.us/changelog/hdfirmware?cs=85bfe5051e4d2bf67be39d394f96c075b4e52836 Sean Nash committed 85bfe50 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Added some more CAN debug code. Minor updates to blood and dialysate pump modules.

· /firmware/App/Controllers/BloodFlow.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DialInFlow.c (-13, +12) | History | Source | Diff
· /firmware/App/Services/CommBuffers.c (-0, +13) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +9) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.c (-2, +2) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-2, +2) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Added SPI driver for GPIO. Set appropriate motor dir and stop pins for dialysate pump modules. Added calls to init dia... Tue, 17 Dec 2019 11:23:12 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=2bb447181c2519690441d81f83563d17e0882ef2 https://devapps.diality.us/changelog/hdfirmware?cs=2bb447181c2519690441d81f83563d17e0882ef2 Sean Nash committed 2bb4471 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Added SPI driver for GPIO. Set appropriate motor dir and stop pins for dialysate pump modules. Added calls to init dialysate pump modules. Added exec calls from tasks for dialysate pump modules.

· /firmware/App/Controllers/BloodFlow.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/DialInFlow.c (-8, +9) | History | Source | Diff
· /firmware/App/Controllers/DialOutUF.c (-7, +8) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +10) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.c (-2, +10) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-0, +8) | History | Source | Diff
· /firmware/HD.dil (-3, +3) | History | Source | Diff
· /firmware/include/spi.h (-0, +18) | History | Source | Diff
· /firmware/source/notification.c (-0, +21) | History | Source | Diff
· /firmware/source/spi.c (-0, +746) | History | Source
· /firmware/source/sys_main.c (-0, +4) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Added DialInFlow and DialOutUF modules. Added alarms associated with dialysate pumps. Mon, 16 Dec 2019 22:36:24 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=96bff7c1a8c755eb28a89e131a737dc1c4a7d9fc https://devapps.diality.us/changelog/hdfirmware?cs=96bff7c1a8c755eb28a89e131a737dc1c4a7d9fc Sean Nash committed 96bff7c on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Added DialInFlow and DialOutUF modules. Added alarms associated with dialysate pumps.

· /firmware/App/Controllers/DialInFlow.c (-0, +983) | History | Source
· /firmware/App/Controllers/DialInFlow.h (-0, +58) | History | Source
· /firmware/App/Controllers/DialOutUF.c (-0, +837) | History | Source
· /firmware/App/Controllers/DialOutUF.h (-0, +58) | History | Source
· /firmware/App/Services/AlarmMgmt.c (-1, +9) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.h (-0, +14) | History | Source | Diff
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Updated flow filter in BloodFlow per discussion with Blaine. Added ADC channels for dialysate pumps. Added some debug ... Mon, 16 Dec 2019 21:52:18 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=ef0b3f0ec00fadc50f95e0db1a6477fb4b076ea1 https://devapps.diality.us/changelog/hdfirmware?cs=ef0b3f0ec00fadc50f95e0db1a6477fb4b076ea1 Sean Nash committed ef0b3f0 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Updated flow filter in BloodFlow per discussion with Blaine. Added ADC channels for dialysate pumps. Added some debug code for CAN tranmit issue. Added GPIO for dialysate pumps to HALCoGen.

· /firmware/App/Common.h (-0, +4) | History | Source | Diff
· /firmware/App/Controllers/BloodFlow.c (-27, +140) | History | Source | Diff
· /firmware/App/Controllers/BloodFlow.h (-0, +1) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-7, +6) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.h (-0, +4) | History | Source | Diff
· /firmware/App/Services/AlarmMgmt.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/CommBuffers.c (-4, +4) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-13, +13) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-8, +8) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
· /firmware/HD.dil (-77, +77) | History | Source | Diff
· /firmware/include/adc.h (-1, +1) | History | Source | Diff
· /firmware/include/etpwm.h (-10, +10) | History | Source | Diff
· /firmware/include/gio.h (-3, +3) | History | Source | Diff
· /firmware/include/mibspi.h (-3, +3) | History | Source | Diff
… 5 more files in changeset.
]]> hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Added bloodflow overrides for not yet implemented sensors. Condensed published alarms status message. Fri, 13 Dec 2019 18:39:53 -0800 Sean Nash https://devapps.diality.us/changelog/hdfirmware?cs=d71d1e6c2be627158cac9a8bc56adac7cdefd1c8 https://devapps.diality.us/changelog/hdfirmware?cs=d71d1e6c2be627158cac9a8bc56adac7cdefd1c8 Sean Nash committed d71d1e6 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware Added bloodflow overrides for not yet implemented sensors. Condensed published alarms status message.

· /firmware/App/Common.h (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/BloodFlow.c (-0, +1) | History | Source | Diff
· /firmware/App/Controllers/Buttons.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-5, +6) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-10, +57) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-6, +14) | History | Source | Diff
· /firmware/App/Services/Utilities.c (-3, +0) | History | Source | Diff
]]>