Fisheye on hdfirmware/

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Put #define SIMULATOR in proper places

Fri, 17 Jan 2020 11:39:46 -0800

Leonardo Baloa committed 9bf9b19 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Put #define SIMULATOR in proper places

· /firmware/App/Controllers/DialOutFlow.c	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Testing changes as per code review

Fri, 17 Jan 2020 10:50:53 -0800

Leonardo Baloa committed d0c2c5e on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Testing changes as per code review

· /firmware/App/Controllers/DialOutFlow.c	(-37, +298)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.h	(-1, +19)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-13, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Enhanced comments for the updateTargetVolume function

Thu, 16 Jan 2020 09:59:03 -0800

Leonardo Baloa committed 5bd79f9 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Enhanced comments for the updateTargetVolume function

· /firmware/App/Controllers/DialOutFlow.c

(-1, +2)

| History

| Source

| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Change a few comments on the code as per code review

Thu, 16 Jan 2020 09:54:39 -0800

Leonardo Baloa committed 73efc9e on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Change a few comments on the code as per code review

· /firmware/App/Controllers/DialOutFlow.c

(-2, +3)

| History

| Source

| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): More changes due to code review

Thu, 16 Jan 2020 09:49:54 -0800

Leonardo Baloa committed 313c0cd on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

More changes due to code review

· /firmware/App/Controllers/DialOutFlow.c

(-22, +22)

| History

| Source

| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Move #define to the top as per team's philosophy

Thu, 16 Jan 2020 09:39:05 -0800

Leonardo Baloa committed 25d7f8e on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Move #define to the top as per team's philosophy

· /firmware/App/Controllers/DialOutFlow.c	(-42, +37)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-12874, +1974)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Added changes due to code reviews

Thu, 16 Jan 2020 09:12:27 -0800

Leonardo Baloa committed 90ff6d5 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Added changes due to code reviews

· /firmware/App/Common.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-16, +27)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c.old	(-180, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h.old	(-54, +0)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Finalize vectorcast unit and integration testing for dialout module

Wed, 15 Jan 2020 10:13:58 -0800

Leonardo Baloa committed 453164f on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Finalize vectorcast unit and integration testing for dialout module

· /firmware/App/Tasks/TaskPriority.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-0, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Clean unit testing and integration test in vectorcast

Wed, 15 Jan 2020 09:25:26 -0800

Leonardo Baloa committed 520a29b on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Clean unit testing and integration test in vectorcast

· /firmware/App/Controllers/DialOutFlow.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Updated vectorcast testing

Tue, 14 Jan 2020 17:38:24 -0800

Leonardo Baloa committed edea658 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Updated vectorcast testing

· /firmware/App/Controllers/DialOutFlow.c	(-38, +45)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Added files in results folder

Tue, 14 Jan 2020 11:03:53 -0800

Leonardo Baloa committed 7fa1710 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Added files in results folder

· /results/.gitignore	(-0, +1)	\| History	\| Source
· /results/VectorCAST.log	(-4538, +11972)	\| History	\| Source	\| Diff
· /results/cppcheck.log	(-1, +0)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-0, +34)	\| History	\| Source

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Checking for settings in parameters passed

Tue, 14 Jan 2020 10:32:08 -0800

Leonardo Baloa committed c8c9574 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Checking for settings in parameters passed

· /firmware/App/Controllers/DialOutFlow.c	(-42, +60)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.h	(-7, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +4)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Added load cell simulation

Mon, 13 Jan 2020 18:05:08 -0800

Leonardo Baloa committed 316e711 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Added load cell simulation

· /firmware/.launches/HD.launch	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Common.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-22, +87)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.h	(-2, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-7, +7)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Updated code to make it work with dialin

Fri, 10 Jan 2020 18:14:50 -0800

Leonardo Baloa committed e7e4d0d on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Updated code to make it work with dialin

· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +6)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Code for testing with Board

Fri, 10 Jan 2020 17:34:05 -0800

Leonardo Baloa committed 8b32856 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Code for testing with Board

· /firmware/.launches/HD.launch	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Common.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskPriority.c	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-0, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Update CAN interface to test DialOutFlow module

Thu, 09 Jan 2020 17:16:03 -0800

Leonardo Baloa committed 5a8668a on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Update CAN interface to test DialOutFlow module

· /firmware/.settings/org.eclipse.core.resources.prefs	(-0, +17)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-311, +108)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.h	(-25, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +108)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +7)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-9572, +4827)	\| History	\| Source	\| Diff
· /results/cppcheck.log	(-74, +43)	\| History	\| Source	\| Diff
· /results/cppcheckError.log	(-570, +0)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Updated ports to be used for PWM, stop and dir for the outlet pump

Wed, 08 Jan 2020 17:07:14 -0800

Leonardo Baloa committed 89a95cb on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Updated ports to be used for PWM, stop and dir for the outlet pump

· /firmware/App/Controllers/DialOutFlow.c	(-626, +673)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-192, +193)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Update Dialoutflow.c due to a change made to PIControllers module. Module compiles, still not functional

Wed, 08 Jan 2020 09:52:06 -0800

Leonardo Baloa committed ea5e0b2 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Update Dialoutflow.c due to a change made to PIControllers module. Module compiles, still not functional

· /firmware/App/Controllers/DialOutFlow.c

(-2, +1)

| History

| Source

| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Updating DEN-1404 to DEN-1312 changes

Wed, 08 Jan 2020 09:48:49 -0800

Leonardo Baloa committed f8395d7 on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Updating DEN-1404 to DEN-1312 changes

· /firmware/App/Common.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c	(-17, +30)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Added DialOutFlow.c and h. It compiles, it is not functional

Wed, 08 Jan 2020 09:28:55 -0800

Leonardo Baloa committed 7a4ec0d on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Added DialOutFlow.c and h. It compiles, it is not functional

· /firmware/App/Controllers/DialOutFlow.c	(-0, +627)	\| History	\| Source
· /firmware/App/Controllers/DialOutFlow.h	(-0, +73)	\| History	\| Source

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Minor improvements to CAN communications. +review HD-DEN-1312-1

Sean Nash — Tue, 07 Jan 2020 22:05:55 -0800

Sean Nash committed 6200334 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware

Minor improvements to CAN communications. +review HD-DEN-1312-1

· /firmware/App/Common.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/Comm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/CommBuffers.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskBG.c	(-2, +0)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Addressed code review feedback. +review HD-DEN-1312-1

Sean Nash — Tue, 07 Jan 2020 21:01:06 -0800

Sean Nash committed 0b740ea on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware

Addressed code review feedback. +review HD-DEN-1312-1

· /firmware/App/Services/FPGA.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskPriority.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Updated PIControllers to behave in classic manner. Added more thread protection to CAN comm buffers. +review HD-DEN-13...

Sean Nash — Tue, 07 Jan 2020 12:30:53 -0800

Sean Nash committed 5217f70 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware

Updated PIControllers to behave in classic manner. Added more thread protection to CAN comm buffers. +review HD-DEN-1312-1

· /firmware/App/Common.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodFlow.c	(-4, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-4, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-12, +15)	\| History	\| Source	\| Diff
· /firmware/App/Services/CommBuffers.c	(-13, +19)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c	(-17, +30)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskPriority.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control): Merge DEN-1312 into DEN-1404 branch

Tue, 07 Jan 2020 09:24:38 -0800

Leonardo Baloa committed a97e98d on branch DEN-1404-hd-dialysate-outlet-pump-drive-flow-sensor-control, den-1404-code-review in hdfirmware

Merge DEN-1312 into DEN-1404 branch

· /firmware/App/Common.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c	(-107, +130)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.c.old	(-0, +180)	\| History	\| Source
· /firmware/App/Services/PIControllers.h	(-10, +9)	\| History	\| Source	\| Diff
· /firmware/App/Services/PIControllers.h.old	(-0, +54)	\| History	\| Source

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Added IT for DialInFlow module. Updated other IT. +review HD-DEN-1312-1

Sean Nash — Fri, 03 Jan 2020 16:55:11 -0800

Sean Nash committed d2faaae on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware

Added IT for DialInFlow module. Updated other IT. +review HD-DEN-1312-1

· /firmware/App/Tasks/TaskGeneral.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskPriority.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Updated UT for SystemComm and SystemCommMessages modules.

Sean Nash — Fri, 03 Jan 2020 15:40:19 -0800

Sean Nash committed 37cfaa8 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware

Updated UT for SystemComm and SystemCommMessages modules.

· /firmware/App/Services/SystemComm.c

(-33, +28)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Updated UT for AlarmMgmt module.

Sean Nash — Fri, 03 Jan 2020 13:09:23 -0800

Sean Nash committed dd4ce30 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware

Updated UT for AlarmMgmt module.

· /firmware/App/Services/AlarmMgmt.c

(-2, +14)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Updated BloodFlow and DialInFlow modules per UT. Added new UT for DialInFlow.

Sean Nash — Fri, 03 Jan 2020 11:03:07 -0800

Sean Nash committed 22f7bcd on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware

Updated BloodFlow and DialInFlow modules per UT. Added new UT for DialInFlow.

· /firmware/App/Controllers/BloodFlow.c	(-9, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-12, +10)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-0, +7)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Removed DialOutFlow module - Leo added to separate branch. Fixed alarm lamp POST.

Sean Nash — Fri, 03 Jan 2020 08:26:16 -0800

Sean Nash committed 4a41a54 on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware

Removed DialOutFlow module - Leo added to separate branch. Fixed alarm lamp POST.

· /firmware/App/Controllers/AlarmLamp.c

(-3, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DialInFlow.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DialOutUF.c

(-838, +0)

| History

| Source

| Diff

· /firmware/App/Controllers/DialOutUF.h

(-58, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-2, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeOpParams.c

(-1, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModePostTreat.c

(-1, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModePreTreat.c

(-1, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModePrescription.c

(-1, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-1, +0)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatment.c

(-1, +0)

| History

| Source

| Diff

· /firmware/App/Services/SystemComm.c

(-28, +38)

| History

| Source

| Diff

· /firmware/App/Services/WatchdogMgmt.c

(-1, +3)

| History

| Source

| Diff

… 4 more files in changeset.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Updated HALCoGen GIO pins.

Sean Nash — Mon, 30 Dec 2019 18:59:08 -0800

Sean Nash committed 668307b on branch DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 393 more in hdfirmware

Updated HALCoGen GIO pins.

· /firmware/HD.dil

(-4, +4)

| History

| Source

| Diff