Fisheye on dgfirmware/firmware/.ccsproject https://devapps.diality.us/changelog/~br%3Ddevelop/dgfirmware/firmware/.ccsproject Recent activity in "dgfirmware" under directory /firmware/.ccsproject DG-UCOMMITS-37: closed by Sean Nash Thu, 03 Aug 2023 13:21:06 -0700 Sean Nash https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash Closed DG-UCOMMITS-37 ]]> DG-UCOMMITS-37: reviewers finished Thu, 03 Aug 2023 10:09:19 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: reviewers finished Wed, 02 Aug 2023 16:01:41 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: started by Dara Navaei Mon, 08 May 2023 09:44:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei started review DG-UCOMMITS-37 ]]> DG-DEN-14763-1: closed by Dara Navaei Tue, 21 Mar 2023 17:12:45 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14763-1 https://devapps.diality.us/cru/DG-DEN-14763-1 Dara Navaei Closed DG-DEN-14763-1 ]]> DG-DEN-14763-1: reviewers resumed Tue, 21 Mar 2023 08:35:30 -0700 https://devapps.diality.us/cru/DG-DEN-14763-1 https://devapps.diality.us/cru/DG-DEN-14763-1 Sean Nash resumed reviewing DG-DEN-14763-1 DG-DEN-14763_DG HD Dev HD DG Dvt Update Part 10 ]]> DG-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 21 Mar 2023 08:33:20 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14763-1/#c16906 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16906 Sean Nash replied to Dara Navaei in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 21 Mar 2023 08:32:48 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14763-1/#c16905 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16905 Sean Nash replied to Dara Navaei in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14763-1: comment by Dara Navaei "Done" Tue, 21 Mar 2023 08:30:01 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14763-1/#c16904 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16904 Dara Navaei replied to Sean Nash in DG-DEN-14763-1

Done

]]> DG-DEN-14763-1: comment by Dara Navaei "Done" Tue, 21 Mar 2023 08:28:22 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14763-1/#c16903 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16903 Dara Navaei replied to Sean Nash in DG-DEN-14763-1

Done

]]> DG-DEN-14763-1: comment by Sean Nash "This seems wrong." Mon, 20 Mar 2023 23:50:50 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14763-1/#c16902 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16902 Sean Nash commented on DG-DEN-14763-1

This seems wrong.

]]> DG-DEN-14763-1: comment by Sean Nash "This seems wrong." Mon, 20 Mar 2023 23:50:13 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14763-1/#c16901 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16901 Sean Nash commented on DG-DEN-14763-1

This seems wrong.

]]> DG-DEN-14763-1: reviewers resumed Mon, 20 Mar 2023 20:31:36 -0700 https://devapps.diality.us/cru/DG-DEN-14763-1 https://devapps.diality.us/cru/DG-DEN-14763-1 wbracken  (deleted user) and jtaylor  (deleted user) resumed reviewing DG-DEN-14763-1 DG-DEN-14763_DG HD Dev HD DG Dvt Update Part 10 ]]> DG-DEN-14763-1: comment by jtaylor "RESOLVED in CODE WALKTHROUGH." Mon, 20 Mar 2023 16:34:46 -0700 jtaylor https://devapps.diality.us/cru/DG-DEN-14763-1/#c16899 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16899 jtaylor  (deleted user) replied to Sean Nash in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14763-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Mon, 20 Mar 2023 13:32:35 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-14763-1/#c16898 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16898 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-14763-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 20 Mar 2023 09:49:15 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14763-1/#c16891 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16891 Sean Nash replied to Dara Navaei in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 20 Mar 2023 09:48:46 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14763-1/#c16890 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16890 Sean Nash replied to Dara Navaei in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 20 Mar 2023 09:48:22 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14763-1/#c16889 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16889 Sean Nash replied to Dara Navaei in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14763-1: comment by Dara Navaei "Done. Thanks for catching it." Mon, 20 Mar 2023 09:34:18 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14763-1/#c16885 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16885 Dara Navaei replied to Sean Nash in DG-DEN-14763-1

Done. Thanks for catching it.

]]> DG-DEN-14763-1: comment by Dara Navaei "Done" Mon, 20 Mar 2023 09:28:53 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14763-1/#c16884 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16884 Dara Navaei replied to Sean Nash in DG-DEN-14763-1

Done

]]> DG-DEN-14763-1: comment by Dara Navaei "Done" Mon, 20 Mar 2023 09:28:17 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14763-1/#c16883 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16883 Dara Navaei replied to Sean Nash in DG-DEN-14763-1

Done

]]> DG-DEN-14763-1: comment by Sean Nash "Not all of these are disinfect usage (e.g. RO w..." Mon, 20 Mar 2023 08:55:49 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14763-1/#c16870 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16870 Sean Nash replied to jtaylor  (deleted user) in DG-DEN-14763-1

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

]]> DG-DEN-14763-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 20 Mar 2023 08:48:18 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14763-1/#c16869 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16869 Sean Nash replied to Dara Navaei in DG-DEN-14763-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-14763-1: comment by Sean Nash "Missing comment?" Mon, 20 Mar 2023 08:43:01 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14763-1/#c16868 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16868 Sean Nash commented on DG-DEN-14763-1

Missing comment?

]]> DG-DEN-14763-1: comment by Sean Nash "Everything else in this function should be in a..." Mon, 20 Mar 2023 08:42:12 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14763-1/#c16867 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16867 Sean Nash commented on DG-DEN-14763-1

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

]]> DG-DEN-14763-1: comment by Sean Nash "Why lower case when others are uppercase?" Mon, 20 Mar 2023 08:36:34 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-14763-1/#c16866 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16866 Sean Nash commented on DG-DEN-14763-1

Why lower case when others are uppercase?

]]> dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14763 addressed the code review comments' Sat, 18 Mar 2023 14:43:26 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=5fae4f2493e4a237ce0aedd2a3c71419ea297993 https://devapps.diality.us/changelog/dgfirmware?cs=5fae4f2493e4a237ce0aedd2a3c71419ea297993 Dara Navaei committed 5fae4f2 on branch DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 143 more in dgfirmware DEN-14763 addressed the code review comments'

· /firmware/.ccsproject (-1, +1) | History | Source | Diff
· /firmware/.cproject (-47, +47) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c (-1, +1) | History | Source | Diff
]]> DG-DEN-14763-1: comment by Dara Navaei "This is to find the target configuration which ..." Sat, 18 Mar 2023 14:36:22 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14763-1/#c16865 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16865 Dara Navaei replied to Sean Nash in DG-DEN-14763-1

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this check box being true or false. I set it back to true to be consistent.

]]> DG-DEN-14763-1: comment by Dara Navaei "Done" Fri, 17 Mar 2023 14:42:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-14763-1/#c16859 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16859 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-14763-1

Done

]]> DG-DEN-14763-1: comment by jtaylor "I would suggest a more consistent naming for th..." Fri, 17 Mar 2023 08:43:24 -0700 jtaylor https://devapps.diality.us/cru/DG-DEN-14763-1/#c16847 https://devapps.diality.us/cru/DG-DEN-14763-1/#c16847 jtaylor  (deleted user) commented on DG-DEN-14763-1

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS".
This would be more specific since "USAGE" and "INFO" are redundant, and "DIS" can be confused with "dis-", the Latin prefix.

]]>