Fisheye on hdfirmware/firmware/Release/App https://devapps.diality.us/changelog/~br%3Ddevelop/hdfirmware/firmware/Release/App Recent activity in "hdfirmware" under directory /firmware/Release/App HD-DEN-759-1: closed by Dara Navaei Fri, 13 Dec 2019 12:39:00 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-759-1 https://devapps.diality.us/cru/HD-DEN-759-1 Dara Navaei Closed HD-DEN-759-1 ]]> HD-DEN-759-1: reviewers finished Fri, 13 Dec 2019 10:24:32 -0800 https://devapps.diality.us/cru/HD-DEN-759-1 https://devapps.diality.us/cru/HD-DEN-759-1 lbaloa  (deleted user) , Behrouz NematiPour and Dara Navaei finished reviewing HD-DEN-759-1 HD-DEN-759_BloodFlow ]]> HD-DEN-759-1: reviewers finished Thu, 12 Dec 2019 15:47:13 -0800 https://devapps.diality.us/cru/HD-DEN-759-1 https://devapps.diality.us/cru/HD-DEN-759-1 pmontazemi  (deleted user) finished reviewing HD-DEN-759-1 HD-DEN-759_BloodFlow ]]> HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Thu, 12 Dec 2019 10:07:49 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c572 https://devapps.diality.us/cru/HD-DEN-759-1/#c572 pmontazemi  (deleted user) replied to pmontazemi  (deleted user) in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Thu, 12 Dec 2019 10:05:49 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c571 https://devapps.diality.us/cru/HD-DEN-759-1/#c571 pmontazemi  (deleted user) replied to pmontazemi  (deleted user) in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-759-1: comment by pmontazemi "Spaces between 0s." Wed, 11 Dec 2019 14:16:03 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c542 https://devapps.diality.us/cru/HD-DEN-759-1/#c542 pmontazemi  (deleted user) commented on HD-DEN-759-1

Spaces between 0s.

]]> HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Tue, 10 Dec 2019 16:44:17 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c534 https://devapps.diality.us/cru/HD-DEN-759-1/#c534 pmontazemi  (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-759-1: comment by pmontazemi "In group setting, decision was made to use the ..." Tue, 10 Dec 2019 16:43:01 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c533 https://devapps.diality.us/cru/HD-DEN-759-1/#c533 pmontazemi  (deleted user) replied to pmontazemi  (deleted user) in HD-DEN-759-1

In group setting, decision was made to use the () rules applied to [].

]]> HD-DEN-759-1: comment by lbaloa "RESOLVED IN CODE WALKTHROUGH" Fri, 06 Dec 2019 10:12:49 -0800 lbaloa https://devapps.diality.us/cru/HD-DEN-759-1/#c512 https://devapps.diality.us/cru/HD-DEN-759-1/#c512 lbaloa  (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED IN CODE WALKTHROUGH

]]> HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 06 Dec 2019 10:10:41 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c511 https://devapps.diality.us/cru/HD-DEN-759-1/#c511 pmontazemi  (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 06 Dec 2019 10:08:14 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c510 https://devapps.diality.us/cru/HD-DEN-759-1/#c510 pmontazemi  (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 06 Dec 2019 10:07:21 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c509 https://devapps.diality.us/cru/HD-DEN-759-1/#c509 pmontazemi  (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 06 Dec 2019 10:06:39 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c508 https://devapps.diality.us/cru/HD-DEN-759-1/#c508 pmontazemi  (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 06 Dec 2019 10:06:18 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c507 https://devapps.diality.us/cru/HD-DEN-759-1/#c507 pmontazemi  (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-759-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 06 Dec 2019 10:05:38 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c506 https://devapps.diality.us/cru/HD-DEN-759-1/#c506 pmontazemi  (deleted user) replied to Sean Nash in HD-DEN-759-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-759-1: comment by pmontazemi "What is the rule for arguments between [ ] ? D..." Fri, 06 Dec 2019 08:33:55 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c505 https://devapps.diality.us/cru/HD-DEN-759-1/#c505 pmontazemi  (deleted user) commented on HD-DEN-759-1

What is the rule for arguments between [ ] ? Does it need spacing like ( ) ?

]]> HD-DEN-759-1: comment by Sean Nash "Done." Fri, 06 Dec 2019 07:45:41 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-759-1/#c504 https://devapps.diality.us/cru/HD-DEN-759-1/#c504 Sean Nash replied to pmontazemi  (deleted user) in HD-DEN-759-1

Done.

]]> HD-DEN-759-1: comment by Sean Nash "Agreed." Fri, 06 Dec 2019 07:44:21 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-759-1/#c503 https://devapps.diality.us/cru/HD-DEN-759-1/#c503 Sean Nash replied to pmontazemi  (deleted user) in HD-DEN-759-1

Agreed.

]]> HD-DEN-759-1: comment by Sean Nash "Fixed." Thu, 05 Dec 2019 08:45:23 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-759-1/#c476 https://devapps.diality.us/cru/HD-DEN-759-1/#c476 Sean Nash replied to pmontazemi  (deleted user) in HD-DEN-759-1

Fixed.

]]> HD-DEN-759-1: comment by Sean Nash "Sorry - must have changed a different line of c..." Thu, 05 Dec 2019 08:43:43 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-759-1/#c475 https://devapps.diality.us/cru/HD-DEN-759-1/#c475 Sean Nash replied to pmontazemi  (deleted user) in HD-DEN-759-1

Sorry - must have changed a different line of code. Now done.

]]> HD-DEN-759-1: comment by pmontazemi "Spaces between arithmetic sign and arguments, a..." Thu, 05 Dec 2019 08:42:47 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c474 https://devapps.diality.us/cru/HD-DEN-759-1/#c474 pmontazemi  (deleted user) commented on HD-DEN-759-1

Spaces between arithmetic sign and arguments, also did you want to add spaces between (v, l, and u)? If so, we need to do it everywhere in this code and everywhere else.

]]> HD-DEN-759-1: comment by pmontazemi "I thought we agreed to have spaced between argu..." Thu, 05 Dec 2019 08:36:52 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c473 https://devapps.diality.us/cru/HD-DEN-759-1/#c473 pmontazemi  (deleted user) commented on HD-DEN-759-1

I thought we agreed to have spaced between arguments and parentheses?

]]> HD-DEN-759-1: comment by pmontazemi "I thought we agreed to have spaced between argu..." Thu, 05 Dec 2019 08:36:41 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c472 https://devapps.diality.us/cru/HD-DEN-759-1/#c472 pmontazemi  (deleted user) commented on HD-DEN-759-1

I thought we agreed to have spaced between arguments and parentheses?

]]> HD-DEN-759-1: comment by pmontazemi "I thought we agreed to have spaced between argu..." Thu, 05 Dec 2019 08:36:33 -0800 pmontazemi https://devapps.diality.us/cru/HD-DEN-759-1/#c471 https://devapps.diality.us/cru/HD-DEN-759-1/#c471 pmontazemi  (deleted user) commented on HD-DEN-759-1

I thought we agreed to have spaced between arguments and parentheses?

]]> HD-DEN-759-1: comment by Sean Nash "Done." Wed, 04 Dec 2019 15:11:44 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-759-1/#c470 https://devapps.diality.us/cru/HD-DEN-759-1/#c470 Sean Nash replied to pmontazemi  (deleted user) in HD-DEN-759-1

Done.

]]> HD-DEN-759-1: comment by Sean Nash "Done." Wed, 04 Dec 2019 15:10:58 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-759-1/#c469 https://devapps.diality.us/cru/HD-DEN-759-1/#c469 Sean Nash replied to pmontazemi  (deleted user) in HD-DEN-759-1

Done.

]]> HD-DEN-759-1: comment by Sean Nash "Done." Wed, 04 Dec 2019 15:09:22 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-759-1/#c468 https://devapps.diality.us/cru/HD-DEN-759-1/#c468 Sean Nash replied to pmontazemi  (deleted user) in HD-DEN-759-1

Done.

]]> HD-DEN-759-1: comment by Sean Nash "Done. And yes, we do have MIN and MAX macros i..." Wed, 04 Dec 2019 14:57:29 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-759-1/#c467 https://devapps.diality.us/cru/HD-DEN-759-1/#c467 Sean Nash replied to lbaloa  (deleted user) in HD-DEN-759-1

Done. And yes, we do have MIN and MAX macros in common.h.

]]> HD-DEN-759-1: comment by lbaloa "We should create a toggle macro for this. Also..." Wed, 04 Dec 2019 14:49:11 -0800 lbaloa https://devapps.diality.us/cru/HD-DEN-759-1/#c466 https://devapps.diality.us/cru/HD-DEN-759-1/#c466 lbaloa  (deleted user) commented on HD-DEN-759-1

We should create a toggle macro for this. Also, do we have a min and max macro?

]]> HD-DEN-759-1: comment by Behrouz NematiPour "RESOLVED IN CODE WALKTHROUGH" Wed, 04 Dec 2019 10:23:21 -0800 Behrouz NematiPour https://devapps.diality.us/cru/HD-DEN-759-1/#c465 https://devapps.diality.us/cru/HD-DEN-759-1/#c465 Behrouz NematiPour replied to Sean Nash in HD-DEN-759-1

RESOLVED IN CODE WALKTHROUGH

]]>