Fisheye on ro-firmware/firmware/App/Monitors https://devapps.diality.us/changelog/~br%3Ddevelop/ro-firmware/firmware/App/Monitors Recent activity in "ro-firmware" under directory /firmware/App/Monitors ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments Fri, 01 Aug 2025 15:56:30 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=6d85a90d2325163e936055a620a8b6aa1a6db65a https://devapps.diality.us/changelog/ro-firmware?cs=6d85a90d2325163e936055a620a8b6aa1a6db65a Michael Garthwaite committed 6d85a90 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: code review comments

· /firmware/App/Controllers/PermeateTank.c (-8, +7) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-3, +0) | History | Source | Diff
· /firmware/App/Modes/FPModeStandby.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-2, +0) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.h (-1, +0) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-1, +0) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-4, +0) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.h (-1, +0) | History | Source | Diff
· /firmware/App/Services/DDInterface.c (-6, +0) | History | Source | Diff
· /firmware/App/Services/DDInterface.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/FpgaFP.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-4, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommFP.c (-1, +0) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check ... Fri, 01 Aug 2025 12:08:14 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=3a5cc585b69ffa194e3601a005915d23b48bd865 https://devapps.diality.us/changelog/ro-firmware?cs=3a5cc585b69ffa194e3601a005915d23b48bd865 Michael Garthwaite committed 3a5cc58 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check for boost pump.

· /firmware/App/Controllers/BoostPump.c (-1, +3) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-4, +6) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-3, +3) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/PressureCheck.c (-0, +0) | History | Source | Diff
· /firmware/App/Modes/PressureCheck.h (-15, +0) | History | Source | Diff
· /firmware/App/Monitors/WaterQualityMonitor.c (-5, +0) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments. Wed, 30 Jul 2025 13:30:55 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=2652d50bbc5e78ed6fe3ad9ccbca0be6f802f1ff https://devapps.diality.us/changelog/ro-firmware?cs=2652d50bbc5e78ed6fe3ad9ccbca0be6f802f1ff Michael Garthwaite committed 2652d50 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: code review comments.

· /firmware/App/Controllers/BoostPump.c (-11, +5) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-650, +0) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-60, +0) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-18, +20) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-3, +0) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.c (-399, +0) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.h (-59, +0) | History | Source | Diff
· /firmware/App/Modes/FPModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-19, +24) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.h (-2, +1) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-10, +11) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-9, +13) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-30, +13) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.h (-9, +4) | History | Source | Diff
· /firmware/App/Monitors/Conductivity.c (-1, +0) | History | Source | Diff
… 5 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and c... Wed, 30 Jul 2025 11:24:46 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=6dd382e3988fac2f9ee041b4738d67305e17a6a2 https://devapps.diality.us/changelog/ro-firmware?cs=6dd382e3988fac2f9ee041b4738d67305e17a6a2 Michael Garthwaite committed 6dd382e on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and clear alarm overrides. Reworked temperature monitor to only publish.

· /firmware/App/Controllers/PermeateTank.c (-5, +350) | History | Source | Diff
· /firmware/App/Controllers/PermeateTank.h (-7, +10) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.c (-9, +7) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-5, +6) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-6, +5) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-7, +8) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-123, +11) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c (-4, +4) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-24, +25) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c (-12, +12) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-1, +66) | History | Source | Diff
· /firmware/App/Monitors/Temperature.h (-0, +20) | History | Source | Diff
· /firmware/App/Monitors/WaterQualityMonitor.c (-76, +0) | History | Source | Diff
· /firmware/App/Monitors/WaterQualityMonitor.h (-19, +0) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.c (-18, +26) | History | Source | Diff
… 6 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): WIP on develop... Tue, 29 Jul 2025 09:58:35 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=94d93795b2a516b3bdd7fc7030eb5eac933bfcd0 https://devapps.diality.us/changelog/ro-firmware?cs=94d93795b2a516b3bdd7fc7030eb5eac933bfcd0 Michael Garthwaite committed 94d9379 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware WIP on develop

LDT-566: code review comments. updated common naming to have a FP prefix.

· /firmware/App/Controllers/BoostPump.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-1, +2) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-12, +11) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FPModeFault.c (-0, +88) | History | Source
· /firmware/App/Modes/FPModeFault.h (-0, +40) | History | Source
· /firmware/App/Modes/FPModeInitPOST.c (-0, +66) | History | Source
· /firmware/App/Modes/FPModeInitPOST.h (-0, +44) | History | Source
· /firmware/App/Modes/FPModeStandby.c (-0, +149) | History | Source
· /firmware/App/Modes/FPModeStandby.h (-0, +47) | History | Source
· /firmware/App/Modes/FPOperationModes.c (-0, +475) | History | Source
· /firmware/App/Modes/FPOperationModes.h (-0, +62) | History | Source
· /firmware/App/Modes/FlushConcentrate.c (-1, +2) | History | Source | Diff
… 25 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: partial rework of alarm monitoring for water quality based on code review. updated valves to be in sync with la... Fri, 25 Jul 2025 08:28:53 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=337136fc77fe5628fa727aac6252a06238561a10 https://devapps.diality.us/changelog/ro-firmware?cs=337136fc77fe5628fa727aac6252a06238561a10 Michael Garthwaite committed 337136f on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: partial rework of alarm monitoring for water quality based on code review. updated valves to be in sync with latest HDD

· /firmware/App/Controllers/Valves.c (-1, +2) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-1, +4) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-0, +6) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-0, +6) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-0, +6) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-0, +7) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c (-0, +6) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeate.c (-0, +3) | History | Source | Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c (-0, +9) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-0, +3) | History | Source | Diff
· /firmware/App/Monitors/Conductivity.c (-25, +125) | History | Source | Diff
· /firmware/App/Monitors/Conductivity.h (-0, +1) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-167, +2) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-308, +2) | History | Source | Diff
… 6 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: fixes for removing P22 and P23. fix warnings Tue, 22 Jul 2025 14:08:36 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=81aa682aa24931c7f44aea82ec72fb3dfabc7890 https://devapps.diality.us/changelog/ro-firmware?cs=81aa682aa24931c7f44aea82ec72fb3dfabc7890 Michael Garthwaite committed 81aa682 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: fixes for removing P22 and P23. fix warnings

· /firmware/App/Controllers/Heaters.c (-24, +24) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.c (-35, +2) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-30, +6) | History | Source | Diff
· /firmware/App/Services/FpgaFP.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-0, +1) | History | Source | Diff
· /firmware/source/sys_main.c (-2, +4) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: Changed temperature handling back to their respective drivers. Kept combined published temperature value. Tue, 22 Jul 2025 13:47:10 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=af3b8065167834683ec01c8c8342b3d196fca593 https://devapps.diality.us/changelog/ro-firmware?cs=af3b8065167834683ec01c8c8342b3d196fca593 Michael Garthwaite committed af3b806 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: Changed temperature handling back to their respective drivers. Kept combined published temperature value.

· /firmware/App/Monitors/Pressure.c (-10, +0) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-9, +9) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: merge pressure temperatures and conductivity temperature sensors into the temperature sensor broadcast Tue, 22 Jul 2025 12:40:13 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=41c4d109b7bc172d93ae1f4e4b20acaf96547807 https://devapps.diality.us/changelog/ro-firmware?cs=41c4d109b7bc172d93ae1f4e4b20acaf96547807 Michael Garthwaite committed 41c4d10 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: merge pressure temperatures and conductivity temperature sensors into the temperature sensor broadcast

· /firmware/App/Drivers/TemperatureSensor.h (-5, +3) | History | Source | Diff
· /firmware/App/Monitors/Pressure.h (-9, +0) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-5, +12) | History | Source | Diff
· /firmware/App/Monitors/Temperature.h (-3, +9) | History | Source | Diff
· /firmware/App/Services/FpgaFP.c (-2, +2) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: removed unneeded defines. Added percentage values for pwm to RO and boost broadcasts. Removed X5 from pressure ... Thu, 17 Jul 2025 15:47:48 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=311c75cc5ac41b4b9ca4983df84e43af910f9be4 https://devapps.diality.us/changelog/ro-firmware?cs=311c75cc5ac41b4b9ca4983df84e43af910f9be4 Michael Garthwaite committed 311c75c on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: removed unneeded defines. Added percentage values for pwm to RO and boost broadcasts. Removed X5 from pressure sensors. Fixed Pre-Generate mode rushing through sub states.

· /firmware/App/Controllers/BoostPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-1, +3) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-3, +5) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.h (-3, +3) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-3, +0) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.h (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-17, +12) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-2, +0) | History | Source | Diff
· /firmware/App/Monitors/Pressure.h (-3, +1) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtFP.c (-1, +1) | History | Source | Diff
· /firmware/source/sys_main.c (-0, +2) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: generate water modes both defeatured and ro featured Wed, 09 Jul 2025 14:14:26 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=8d272582cbd2cb5fc0c6af0fead2867ce02658b0 https://devapps.diality.us/changelog/ro-firmware?cs=8d272582cbd2cb5fc0c6af0fead2867ce02658b0 Michael Garthwaite committed 8d27258 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: generate water modes both defeatured and ro featured

· /firmware/App/Controllers/BoostPump.c (-4, +31) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-1, +5) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-2, +28) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-1, +5) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.c (-1, +15) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.h (-0, +1) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.c (-39, +0) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-0, +395) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.h (-7, +48) | History | Source | Diff
· /firmware/App/Modes/FlushFilter.c (-0, +6) | History | Source | Diff
· /firmware/App/Modes/FlushPermeate.c (-5, +17) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.c (-21, +121) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeate.h (-0, +4) | History | Source | Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c (-5, +299) | History | Source | Diff
… 14 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: filtered conductivity implementation Thu, 03 Jul 2025 09:52:13 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=98a9ee30d7c8b568f3ccc52c4c48bdbc36a419e9 https://devapps.diality.us/changelog/ro-firmware?cs=98a9ee30d7c8b568f3ccc52c4c48bdbc36a419e9 Michael Garthwaite committed 98a9ee3 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: filtered conductivity implementation

· /firmware/App/Monitors/Conductivity.c (-14, +125) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-0, +1) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush imple... Wed, 02 Jul 2025 12:04:36 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=410afd26b3ae5e372310c696c82f58c59235e10d https://devapps.diality.us/changelog/ro-firmware?cs=410afd26b3ae5e372310c696c82f58c59235e10d Michael Garthwaite committed 410afd2 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 8 more in ro-firmware LDT-566: updated naming across the project. Renamed files some fits to fit naming. Filter flush and permeate flush implemented.

· /firmware/App/Controllers/BoostPump.c (-30, +34) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-6, +6) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FilterFlush.c (-139, +0) | History | Source | Diff
· /firmware/App/Modes/FilterFlush.h (-51, +0) | History | Source | Diff
· /firmware/App/Modes/FlushConcentrate.c (-0, +0) | History | Source
· /firmware/App/Modes/FlushConcentrate.h (-0, +15) | History | Source
· /firmware/App/Modes/FlushFilter.c (-0, +365) | History | Source
… 56 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments Mon, 30 Jun 2025 13:59:38 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=d5574e12aa9638c933d11b9bee8d5cf024864440 https://devapps.diality.us/changelog/ro-firmware?cs=d5574e12aa9638c933d11b9bee8d5cf024864440 Michael Garthwaite committed d5574e1 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware LDT-566: code review comments

· /firmware/App/Drivers/FluidPump.c (-13, +23) | History | Source | Diff
· /firmware/App/Drivers/FluidPump.h (-16, +16) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.h (-3, +0) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensor.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/FilterFlush.c (-3, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-0, +1) | History | Source | Diff
· /firmware/App/Modes/ModeWaterGen.c (-1, +0) | History | Source | Diff
· /firmware/App/Modes/ModeWaterPreGen.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/OperationModes.c (-11, +9) | History | Source | Diff
· /firmware/App/Modes/OperationModes.h (-1, +0) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/DDInterface.c (-2, +0) | History | Source | Diff
· /firmware/App/Services/DDInterface.h (-1, +0) | History | Source | Diff
· /firmware/source/sys_main.c (-1, +0) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: code review comments. S32 override implementations. Changed flow rates from FPGA to S32 Mon, 30 Jun 2025 13:24:36 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=863f8f88c73ee5dd285242f6e131a14862b4f5c4 https://devapps.diality.us/changelog/ro-firmware?cs=863f8f88c73ee5dd285242f6e131a14862b4f5c4 Michael Garthwaite committed 863f8f8 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware LDT-566: code review comments. S32 override implementations. Changed flow rates from FPGA to S32

· /firmware/App/Controllers/BoostPump.c (-27, +27) | History | Source | Diff
· /firmware/App/Controllers/BoostPump.h (-7, +7) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-28, +28) | History | Source | Diff
· /firmware/App/Controllers/ROPump.h (-5, +5) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensor.c (-3, +2) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.c (-10, +10) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.h (-1, +4) | History | Source | Diff
· /firmware/App/Monitors/Flow.c (-1, +1) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: various naming changes across various files. Switching RO to FP. Wed, 18 Jun 2025 15:21:44 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=99498a5bab0a1f4c706376feceadc66df6d1c22e https://devapps.diality.us/changelog/ro-firmware?cs=99498a5bab0a1f4c706376feceadc66df6d1c22e Michael Garthwaite committed 99498a5 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware LDT-566: various naming changes across various files. Switching RO to FP.

· /firmware/App/Controllers/Heaters.c (-3, +3) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-9, +9) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensor.c (-0, +793) | History | Source
· /firmware/App/Drivers/ConductivitySensor.h (-0, +77) | History | Source
· /firmware/App/Drivers/ConductivitySensors.c (-792, +0) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensors.h (-77, +0) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PAL.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-15, +4) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/SafetyShutdown.h (-1, +1) | History | Source | Diff
… 43 more files in changeset.
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: fixed implicit declarations for x pressure sensors. added x5 to broadcasts Tue, 13 May 2025 13:40:41 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=85a88a4ffdc56784d261ccd2e87d156805666c5d https://devapps.diality.us/changelog/ro-firmware?cs=85a88a4ffdc56784d261ccd2e87d156805666c5d Michael Garthwaite committed 85a88a4 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware LDT-566: fixed implicit declarations for x pressure sensors. added x5 to broadcasts

· /firmware/App/Monitors/Pressure.c (-0, +2) | History | Source | Diff
· /firmware/App/Monitors/Pressure.h (-0, +2) | History | Source | Diff
· /firmware/App/Services/FpgaRO.h (-0, +20) | History | Source | Diff
]]> ro-firmware (LDT-566-water-treatment-ro-pump-tuning): LDT-566: X pressure senors implemented to publishing and sensor reading Tue, 29 Apr 2025 14:59:33 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=69e32c52c41cfc8073a7eb59408fb30e6ac40f86 https://devapps.diality.us/changelog/ro-firmware?cs=69e32c52c41cfc8073a7eb59408fb30e6ac40f86 Michael Garthwaite committed 69e32c5 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 9 more in ro-firmware LDT-566: X pressure senors implemented to publishing and sensor reading

· /firmware/App/Drivers/PressureSensor.c (-0, +17) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.h (-0, +4) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-1, +7) | History | Source | Diff
· /firmware/App/Monitors/Pressure.h (-0, +6) | History | Source | Diff
· /firmware/App/Services/FpgaRO.c (-0, +192) | History | Source | Diff
]]> ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAHI-273: code review comments. Swapped level enums to be a more intuitive Tue, 11 Mar 2025 10:04:54 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=c6491e96503a221cd9524da289522afd3eb00b29 https://devapps.diality.us/changelog/ro-firmware?cs=c6491e96503a221cd9524da289522afd3eb00b29 Michael Garthwaite committed c6491e9 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 12 more in ro-firmware LEAHI-273: code review comments. Swapped level enums to be a more intuitive

· /firmware/App/Modes/ModeGenPermeate.c (-10, +5) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +0) | History | Source | Diff
· /firmware/App/Monitors/Level.h (-1, +1) | History | Source | Diff
]]> ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAH-1972: Addressed code review comments. Wed, 22 Jan 2025 11:02:12 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=72ae21d8343d3a2b07a47452ff48549e25f876df https://devapps.diality.us/changelog/ro-firmware?cs=72ae21d8343d3a2b07a47452ff48549e25f876df Sean Nash committed 72ae21d on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 14 more in ro-firmware LEAH-1972: Addressed code review comments.

· /firmware/App/Drivers/ConductivitySensors.c (-18, +7) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-24, +5) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.c (-13, +4) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.h (-2, +0) | History | Source | Diff
· /firmware/App/Monitors/Flow.c (-2, +4) | History | Source | Diff
· /firmware/App/Monitors/Flow.h (-2, +4) | History | Source | Diff
· /firmware/App/Monitors/Level.h (-1, +1) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-33, +33) | History | Source | Diff
· /firmware/App/Monitors/Pressure.h (-12, +12) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-7, +5) | History | Source | Diff
· /firmware/App/Monitors/Temperature.h (-7, +5) | History | Source | Diff
]]> ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAH-1972: Refactored component names. Tue, 21 Jan 2025 16:23:18 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=3241c6b7f66889b6443e377ab1f5ecf2cedd2602 https://devapps.diality.us/changelog/ro-firmware?cs=3241c6b7f66889b6443e377ab1f5ecf2cedd2602 Sean Nash committed 3241c6b on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 14 more in ro-firmware LEAH-1972: Refactored component names.

· /firmware/App/Controllers/Heaters.c (-15, +7) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-9, +5) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-8, +8) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-10, +10) | History | Source | Diff
· /firmware/App/Drivers/BoostPump.c (-9, +9) | History | Source | Diff
· /firmware/App/Drivers/BoostPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensors.c (-52, +52) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensors.h (-3, +3) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.c (-4, +4) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.h (-30, +30) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-25, +25) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.h (-8, +8) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.c (-23, +42) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.h (-3, +7) | History | Source | Diff
· /firmware/App/Monitors/Conductivity.c (-4, +2) | History | Source | Diff
… 11 more files in changeset.
]]> ro-firmware (develop): TEST: refactor component names. Mon, 20 Jan 2025 16:55:18 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=7b9a8c0cb9986368e1e38fcdb9daaf3cf707dfd2 https://devapps.diality.us/changelog/ro-firmware?cs=7b9a8c0cb9986368e1e38fcdb9daaf3cf707dfd2 Sean Nash committed 7b9a8c0 on branch develop in ro-firmware TEST: refactor component names.

· /firmware/App/Controllers/Heaters.c (-7, +7) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-4, +4) | History | Source | Diff
· /firmware/App/Controllers/ROPump.c (-8, +8) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-10, +10) | History | Source | Diff
· /firmware/App/Drivers/BoostPump.c (-9, +9) | History | Source | Diff
· /firmware/App/Drivers/BoostPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensors.c (-52, +52) | History | Source | Diff
· /firmware/App/Drivers/ConductivitySensors.h (-3, +3) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.c (-4, +4) | History | Source | Diff
· /firmware/App/Drivers/FlowSensor.h (-4, +4) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-25, +25) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.h (-8, +8) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.c (-23, +42) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.h (-3, +7) | History | Source | Diff
· /firmware/App/Monitors/Conductivity.c (-4, +2) | History | Source | Diff
… 11 more files in changeset.
]]> ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): More changes will integrating. Fri, 20 Dec 2024 11:12:50 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=340b6bedc5aac2ad47364ade48a842f00b12b8fe https://devapps.diality.us/changelog/ro-firmware?cs=340b6bedc5aac2ad47364ade48a842f00b12b8fe Sean Nash committed 340b6be on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 14 more in ro-firmware More changes will integrating.

· /firmware/App/Drivers/TemperatureSensors.c (-323, +133) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.h (-10, +7) | History | Source | Diff
· /firmware/App/Monitors/Flow.c (-101, +101) | History | Source | Diff
· /firmware/App/Monitors/Flow.h (-25, +25) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-37, +33) | History | Source | Diff
· /firmware/App/Monitors/Temperature.h (-7, +3) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-0, +2) | History | Source | Diff
· /firmware/App/Services/FpgaRO.c (-0, +26) | History | Source | Diff
· /firmware/App/Services/FpgaRO.h (-0, +3) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-2, +9) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-0, +4) | History | Source | Diff
]]> ro-firmware (develop): TEST: updates to temperature sensors and flow sensors. Fri, 20 Dec 2024 11:03:04 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=a1907314deab28c20945cd41d2d167924daf2c08 https://devapps.diality.us/changelog/ro-firmware?cs=a1907314deab28c20945cd41d2d167924daf2c08 Sean Nash committed a190731 on branch develop in ro-firmware TEST: updates to temperature sensors and flow sensors.

· /firmware/App/Drivers/TemperatureSensors.c (-323, +133) | History | Source | Diff
· /firmware/App/Drivers/TemperatureSensors.h (-10, +7) | History | Source | Diff
· /firmware/App/Monitors/Flow.c (-12, +12) | History | Source | Diff
· /firmware/App/Monitors/Flow.h (-2, +2) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-37, +33) | History | Source | Diff
· /firmware/App/Monitors/Temperature.h (-7, +3) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-0, +2) | History | Source | Diff
· /firmware/App/Services/FpgaRO.c (-0, +26) | History | Source | Diff
· /firmware/App/Services/FpgaRO.h (-0, +3) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-2, +9) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-0, +4) | History | Source | Diff
]]> ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAH-1972: More integration test changes. Fri, 13 Dec 2024 13:47:48 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=eaadab648c4c1d6d34f3927df6ce5cfb59cdebb6 https://devapps.diality.us/changelog/ro-firmware?cs=eaadab648c4c1d6d34f3927df6ce5cfb59cdebb6 Sean Nash committed eaadab6 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 14 more in ro-firmware LEAH-1972: More integration test changes.

· /firmware/App/Drivers/FlowSensor.c (-21, +21) | History | Source | Diff
· /firmware/App/Monitors/Level.c (-1, +19) | History | Source | Diff
· /firmware/App/Services/FpgaRO.c (-0, +27) | History | Source | Diff
· /firmware/App/Services/FpgaRO.h (-2, +2) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-0, +4) | History | Source | Diff
· /firmware/source/sys_main.c (-0, +2) | History | Source | Diff
]]> ro-firmware (develop): TEST: Initialize and execute flow monitor. Fixes to levels monitor. Fri, 13 Dec 2024 11:13:25 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=6525ec84b42e7d73710cc81ae93d2e2f0202a486 https://devapps.diality.us/changelog/ro-firmware?cs=6525ec84b42e7d73710cc81ae93d2e2f0202a486 Sean Nash committed 6525ec8 on branch develop in ro-firmware TEST: Initialize and execute flow monitor. Fixes to levels monitor.

· /firmware/App/Monitors/Level.c (-1, +19) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-0, +4) | History | Source | Diff
· /firmware/source/sys_main.c (-0, +2) | History | Source | Diff
]]> ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAH-1972: changes from alpha prototype integration testing. Wed, 11 Dec 2024 10:20:48 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=ce66580e076bffa157868ff7e422556f78a95cac https://devapps.diality.us/changelog/ro-firmware?cs=ce66580e076bffa157868ff7e422556f78a95cac Sean Nash committed ce66580 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 14 more in ro-firmware LEAH-1972: changes from alpha prototype integration testing.

· /firmware/App/Controllers/Valves.c (-142, +140) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-38, +39) | History | Source | Diff
· /firmware/App/Drivers/BoostPump.c (-0, +9) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-25, +32) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.h (-30, +31) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-96, +95) | History | Source | Diff
· /firmware/App/Monitors/Pressure.h (-24, +26) | History | Source | Diff
· /firmware/App/Services/FpgaRO.c (-6, +73) | History | Source | Diff
· /firmware/App/Services/FpgaRO.h (-1, +7) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-3, +1) | History | Source | Diff
· /firmware/RO.dil (-38, +38) | History | Source | Diff
· /firmware/include/can.h (-6, +6) | History | Source | Diff
· /firmware/source/adc.c (-15, +15) | History | Source | Diff
· /firmware/source/can.c (-31, +31) | History | Source | Diff
]]> ro-firmware (develop): TEST: Added PPi pressure sensor. Thu, 05 Dec 2024 09:47:57 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=e491c38c7c2e7850b5a7ff906c04d81eabf0efb8 https://devapps.diality.us/changelog/ro-firmware?cs=e491c38c7c2e7850b5a7ff906c04d81eabf0efb8 Sean Nash committed e491c38 on branch develop in ro-firmware TEST: Added PPi pressure sensor.

· /firmware/App/Drivers/PressureSensor.c (-0, +4) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.h (-0, +1) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-0, +2) | History | Source | Diff
· /firmware/App/Monitors/Pressure.h (-0, +2) | History | Source | Diff
· /firmware/App/Services/FpgaRO.c (-0, +48) | History | Source | Diff
· /firmware/App/Services/FpgaRO.h (-0, +5) | History | Source | Diff
]]> ro-firmware (develop): TEST: Fixed ADC channel config. Fixed pressure conversion. Added RO control register to FPGA. Tue, 03 Dec 2024 16:22:19 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=51d83f99e63d9cb52951097996641cc5b3ddffd7 https://devapps.diality.us/changelog/ro-firmware?cs=51d83f99e63d9cb52951097996641cc5b3ddffd7 Sean Nash committed 51d83f9 on branch develop in ro-firmware TEST: Fixed ADC channel config. Fixed pressure conversion. Added RO control register to FPGA.

· /firmware/App/Drivers/BoostPump.c (-0, +9) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.c (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/InternalADC.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/PressureSensor.c (-5, +8) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-5, +2) | History | Source | Diff
· /firmware/App/Services/FpgaRO.c (-1, +14) | History | Source | Diff
· /firmware/App/Services/FpgaRO.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-1, +1) | History | Source | Diff
· /firmware/RO.dil (-21, +21) | History | Source | Diff
· /firmware/source/adc.c (-15, +15) | History | Source | Diff
]]> ro-firmware (LDT-332-basic-dialysis-treatment-fp-UIT): LEAH-262: Addressed code review comments. Mon, 25 Nov 2024 14:55:05 -0800 Sean Nash https://devapps.diality.us/changelog/ro-firmware?cs=5aaed18e3cd460c091c36c95c81635273bad61c6 https://devapps.diality.us/changelog/ro-firmware?cs=5aaed18e3cd460c091c36c95c81635273bad61c6 Sean Nash committed 5aaed18 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 15 more in ro-firmware LEAH-262: Addressed code review comments.

· /firmware/App/Drivers/FlowSensor.c (-2, +2) | History | Source | Diff
· /firmware/App/Monitors/Flow.c (-10, +10) | History | Source | Diff
]]>