Fisheye on dgfirmware/firmware/App/Modes/ModeDisinfect.c https://devapps.diality.us/changelog/~br%3Ddgcommonfix/dgfirmware/firmware/App/Modes/ModeDisinfect.c Recent activity in "dgfirmware" under directory /firmware/App/Modes/ModeDisinfect.c DG-DEN-2650-1: closed by Dara Navaei Thu, 19 Oct 2023 08:42:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei Closed DG-DEN-2650-1 ]]> DG-DEN-2650-1: reviewers finished Thu, 19 Oct 2023 08:42:03 -0700 https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei finished reviewing DG-DEN-2650-1 DG-DEN-2650_DG Firmware Infrastructure ]]> DG-DEN-2650-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:41:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 Dara Navaei replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2650-1: started by Dara Navaei Thu, 19 Oct 2023 08:41:19 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei started review DG-DEN-2650-1 ]]> DG-UCOMMITS-37: closed by Sean Nash Thu, 03 Aug 2023 13:21:06 -0700 Sean Nash https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash Closed DG-UCOMMITS-37 ]]> DG-UCOMMITS-37: reviewers finished Thu, 03 Aug 2023 10:09:19 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: reviewers finished Wed, 02 Aug 2023 16:01:41 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: started by Dara Navaei Mon, 08 May 2023 09:44:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei started review DG-UCOMMITS-37 ]]> DG-DEN-2650-1: reviewers finished Tue, 07 Jul 2020 15:10:29 -0700 https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 pmontazemi  (deleted user) finished reviewing DG-DEN-2650-1 DG-DEN-2650_DG Firmware Infrastructure ]]> DG-DEN-2650-1: reviewers added to DG-DEN-2650_DG Firmware Infrastructure Mon, 06 Jul 2020 10:47:29 -0700 https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei added qnguyen  (deleted user) to DG-DEN-2650-1 DG-DEN-2650_DG Firmware Infrastructure ]]> DG-DEN-2650-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 19 Jun 2020 10:56:35 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2487 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2487 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2650-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 19 Jun 2020 10:54:10 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2486 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2486 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2650-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 19 Jun 2020 10:53:49 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2485 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2485 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2650-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 19 Jun 2020 10:53:35 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2484 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2484 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2650-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 19 Jun 2020 10:50:14 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2483 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2483 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2650-1: comment by Sean Nash "I have the typedef immediately following the as..." Fri, 19 Jun 2020 09:24:33 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2650-1/#c2462 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2462 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2650-1

I have the typedef immediately following the associated enum to show they are coupled. Previously I had the typedef included in the enum declaration but Qt didn't like that.

]]> DG-DEN-2650-1: comment by Sean Nash "The 4 reservoir valves are controlled by the HD..." Fri, 19 Jun 2020 09:21:32 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2650-1/#c2455 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2455 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2650-1

The 4 reservoir valves are controlled by the HD when it's connected and on. In Standby mode, the HD is connected and on.

]]> DG-DEN-2650-1: comment by Sean Nash "Yes, there are 4 DIP switches that go to GPIO i..." Fri, 19 Jun 2020 09:20:32 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2650-1/#c2453 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2453 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2650-1

Yes, there are 4 DIP switches that go to GPIO input pins on the RM46 that we can use for engineering/test purposes.

]]> DG-DEN-2650-1: comment by pmontazemi "There are many more valves on the DG Device, wh..." Fri, 19 Jun 2020 09:16:24 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2452 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2452 pmontazemi  (deleted user) commented on DG-DEN-2650-1

There are many more valves on the DG Device, why setting only these ones?

]]> DG-DEN-2650-1: comment by pmontazemi "Do we have dip switches on the DG Board?" Fri, 19 Jun 2020 09:13:37 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2447 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2447 pmontazemi  (deleted user) commented on DG-DEN-2650-1

Do we have dip switches on the DG Board?

]]> DG-DEN-2650-1: comment by Sean Nash "I do remove build flags that I don't need anymo..." Thu, 11 Jun 2020 09:20:09 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2650-1/#c2225 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2225 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2650-1

I do remove build flags that I don't need anymore every so often. If we're done with CAN testing I can remove that one. I'm still using the rest of these from time to time.

]]> DG-DEN-2650-1: comment by Sean Nash "I imagine we would settle on a nominal (theoret..." Thu, 11 Jun 2020 09:17:49 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-2650-1/#c2223 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2223 Sean Nash replied to pmontazemi  (deleted user) in DG-DEN-2650-1

I imagine we would settle on a nominal (theoretical) gain/offset here and then apply calibration gain/offset from NV memory afterward to get a final conversion.

]]> DG-DEN-2650-1: comment by pmontazemi "Clean up" Thu, 11 Jun 2020 09:15:39 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2222 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2222 pmontazemi  (deleted user) commented on DG-DEN-2650-1

Clean up

]]> DG-DEN-2650-1: comment by pmontazemi "What is our plan to adjust these constants acro..." Thu, 11 Jun 2020 09:10:56 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2221 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2221 pmontazemi  (deleted user) commented on DG-DEN-2650-1

What is our plan to adjust these constants across machines?

]]> DG-DEN-2650-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 05 Jun 2020 10:50:52 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2213 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2213 pmontazemi  (deleted user) replied to Dara Navaei in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2650-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 05 Jun 2020 10:49:59 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2212 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2212 pmontazemi  (deleted user) replied to Dara Navaei in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2650-1: comment by Dara Navaei "Done" Fri, 05 Jun 2020 10:49:43 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1/#c2211 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2211 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-2650-1

Done

]]> DG-DEN-2650-1: comment by Dara Navaei "Done" Fri, 05 Jun 2020 10:49:38 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1/#c2210 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2210 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-2650-1

Done

]]> DG-DEN-2650-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 05 Jun 2020 10:48:25 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2209 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2209 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-2650-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Fri, 05 Jun 2020 10:47:40 -0700 pmontazemi https://devapps.diality.us/cru/DG-DEN-2650-1/#c2208 https://devapps.diality.us/cru/DG-DEN-2650-1/#c2208 pmontazemi  (deleted user) replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH.

]]>