Fisheye on dgfirmware/firmware/App/Modes/ModeInitPOST.h https://devapps.diality.us/changelog/~br%3Ddgcommonfix/dgfirmware/firmware/App/Modes/ModeInitPOST.h Recent activity in "dgfirmware" under directory /firmware/App/Modes/ModeInitPOST.h DG-DEN-2650-1: closed by Dara Navaei Thu, 19 Oct 2023 08:42:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei Closed DG-DEN-2650-1 ]]> DG-DEN-2650-1: reviewers finished Thu, 19 Oct 2023 08:42:03 -0700 https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei finished reviewing DG-DEN-2650-1 DG-DEN-2650_DG Firmware Infrastructure ]]> DG-DEN-2650-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:41:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 Dara Navaei replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2650-1: started by Dara Navaei Thu, 19 Oct 2023 08:41:19 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei started review DG-DEN-2650-1 ]]> DG-DEN-9480-1: closed by Dara Navaei Thu, 19 Oct 2023 08:05:20 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1 https://devapps.diality.us/cru/DG-DEN-9480-1 Dara Navaei Closed DG-DEN-9480-1 ]]> DG-DEN-9480-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:05:10 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c19092 https://devapps.diality.us/cru/DG-DEN-9480-1/#c19092 Dara Navaei replied to Sean Nash in DG-DEN-9480-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-9480-1: started by Dara Navaei Thu, 19 Oct 2023 08:03:54 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1 https://devapps.diality.us/cru/DG-DEN-9480-1 Dara Navaei started review DG-DEN-9480-1 ]]> DG-UCOMMITS-37: closed by Sean Nash Thu, 03 Aug 2023 13:21:06 -0700 Sean Nash https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash Closed DG-UCOMMITS-37 ]]> DG-UCOMMITS-37: reviewers finished Thu, 03 Aug 2023 10:09:19 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: reviewers finished Wed, 02 Aug 2023 16:01:41 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: started by Dara Navaei Mon, 08 May 2023 09:44:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei started review DG-UCOMMITS-37 ]]> DG-DEN-9480-1: reviewers finished Thu, 11 Nov 2021 10:54:56 -0800 https://devapps.diality.us/cru/DG-DEN-9480-1 https://devapps.diality.us/cru/DG-DEN-9480-1 hnguyen  (deleted user) and Sean Nash finished reviewing DG-DEN-9480-1 DG-DEN-9480_DG_DEV Dialysate Temperature Control ]]> DG-DEN-9480-1: comment by hnguyen "RESOLVED IN CODE WALKTHROUGH" Thu, 11 Nov 2021 10:37:03 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11371 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11371 hnguyen  (deleted user) replied to Dara Navaei in DG-DEN-9480-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-9480-1: comment by hnguyen "RESOLVED IN CODE WALKTHROUGH" Thu, 11 Nov 2021 10:36:51 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11370 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11370 hnguyen  (deleted user) replied to Dara Navaei in DG-DEN-9480-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-9480-1: comment by hnguyen "RESOLVED IN CODE WALKTHROUGH" Thu, 11 Nov 2021 10:36:28 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11369 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11369 hnguyen  (deleted user) replied to Dara Navaei in DG-DEN-9480-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-9480-1: comment by hnguyen "RESOLVED IN CODE WALKTHROUGH" Thu, 11 Nov 2021 10:35:03 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11368 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11368 hnguyen  (deleted user) replied to Dara Navaei in DG-DEN-9480-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-9480-1: comment by Dara Navaei "Done." Wed, 10 Nov 2021 21:08:03 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c11329 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11329 Dara Navaei replied to hnguyen  (deleted user) in DG-DEN-9480-1

Done.

]]> DG-DEN-9480-1: comment by Dara Navaei "The const is an optional step in our code. Plus..." Wed, 10 Nov 2021 21:06:19 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c11328 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11328 Dara Navaei replied to hnguyen  (deleted user) in DG-DEN-9480-1

The const is an optional step in our code. Plus these are the local variables and their values are not changed inside the function.

]]> DG-DEN-9480-1: comment by Dara Navaei "Done." Wed, 10 Nov 2021 21:05:23 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c11327 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11327 Dara Navaei replied to hnguyen  (deleted user) in DG-DEN-9480-1

Done.

]]> DG-DEN-9480-1: comment by Dara Navaei "Done." Wed, 10 Nov 2021 21:04:10 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c11326 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11326 Dara Navaei replied to hnguyen  (deleted user) in DG-DEN-9480-1

Done.

]]> DG-DEN-9480-1: comment by hnguyen "Variable reservoirDataPublicationTimerCounter i..." Wed, 10 Nov 2021 17:36:50 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11303 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11303 hnguyen  (deleted user) commented on DG-DEN-9480-1

Variable reservoirDataPublicationTimerCounter is missing in the @detail Inputs and Output

]]> DG-DEN-9480-1: comment by hnguyen "I am not sure why you removed the "const" from ..." Wed, 10 Nov 2021 15:29:19 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11302 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11302 hnguyen  (deleted user) commented on DG-DEN-9480-1

I am not sure why you removed the "const" from dialysateTemp and targetTemp?

]]> DG-DEN-9480-1: comment by hnguyen "Added "pressuresDataPublicationTimerCounter" va..." Wed, 10 Nov 2021 14:35:08 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11301 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11301 hnguyen  (deleted user) commented on DG-DEN-9480-1

Added "pressuresDataPublicationTimerCounter" variable to @details Outputs

]]> DG-DEN-9480-1: comment by hnguyen "The state variable valvesStatesPublicationTimer..." Wed, 10 Nov 2021 14:27:48 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11300 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11300 hnguyen  (deleted user) commented on DG-DEN-9480-1

The state variable valvesStatesPublicationTimerCounter was read, increment, then write. Therefore, it needs to be added to the @details Outputs.

]]> DG-DEN-9480-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 10 Nov 2021 11:17:18 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-9480-1/#c11299 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11299 Sean Nash replied to Dara Navaei in DG-DEN-9480-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-9480-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 10 Nov 2021 11:16:39 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-9480-1/#c11298 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11298 Sean Nash replied to Dara Navaei in DG-DEN-9480-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-9480-1: comment by Dara Navaei "Done." Wed, 10 Nov 2021 11:09:29 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c11295 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11295 Dara Navaei replied to Sean Nash in DG-DEN-9480-1

Done.

]]> DG-DEN-9480-1: comment by Dara Navaei "Removed it." Wed, 10 Nov 2021 11:06:51 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c11292 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11292 Dara Navaei replied to Sean Nash in DG-DEN-9480-1

Removed it.

]]> DG-DEN-9480-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 10 Nov 2021 11:02:44 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-9480-1/#c11291 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11291 Sean Nash replied to Dara Navaei in DG-DEN-9480-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-9480-1: comment by hnguyen "RESOLVED in CODE WALKTHROUGH" Wed, 10 Nov 2021 11:02:31 -0800 hnguyen https://devapps.diality.us/cru/DG-DEN-9480-1/#c11290 https://devapps.diality.us/cru/DG-DEN-9480-1/#c11290 hnguyen  (deleted user) replied to Dara Navaei in DG-DEN-9480-1

RESOLVED in CODE WALKTHROUGH

]]>