Fisheye on dgfirmware/firmware/App/Tasks/TaskTimer.c https://devapps.diality.us/changelog/~br%3Ddgcommonfix/dgfirmware/firmware/App/Tasks/TaskTimer.c Recent activity in "dgfirmware" under directory /firmware/App/Tasks/TaskTimer.c DG-DEN-4217-1: closed by Dara Navaei Thu, 19 Oct 2023 08:28:36 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei Closed DG-DEN-4217-1 ]]> DG-DEN-4217-1: reviewers finished Thu, 19 Oct 2023 08:28:27 -0700 https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei , qnguyen  (deleted user) and pmontazemi  (deleted user) finished reviewing DG-DEN-4217-1 DG-DEN-4217_Level and Shock Detection ]]> DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:28:18 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1/#c19106 https://devapps.diality.us/cru/DG-DEN-4217-1/#c19106 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:27:53 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1/#c19105 https://devapps.diality.us/cru/DG-DEN-4217-1/#c19105 Dara Navaei replied to pmontazemi  (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-4217-1: started by Dara Navaei Thu, 19 Oct 2023 08:26:45 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-4217-1 https://devapps.diality.us/cru/DG-DEN-4217-1 Dara Navaei started review DG-DEN-4217-1 ]]> DG-UCOMMITS-37: closed by Sean Nash Thu, 03 Aug 2023 13:21:06 -0700 Sean Nash https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash Closed DG-UCOMMITS-37 ]]> DG-UCOMMITS-37: reviewers finished Thu, 03 Aug 2023 10:09:19 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: reviewers finished Wed, 02 Aug 2023 16:01:41 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: started by Dara Navaei Mon, 08 May 2023 09:44:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei started review DG-UCOMMITS-37 ]]> DG-DEN-3504-1: closed by qnguyen Mon, 23 Nov 2020 13:19:09 -0800 qnguyen https://devapps.diality.us/cru/DG-DEN-3504-1 https://devapps.diality.us/cru/DG-DEN-3504-1 qnguyen  (deleted user) Closed DG-DEN-3504-1 ]]> DG-DEN-3504-1: reviewers finished Mon, 23 Nov 2020 13:18:28 -0800 https://devapps.diality.us/cru/DG-DEN-3504-1 https://devapps.diality.us/cru/DG-DEN-3504-1 pmontazemi  (deleted user) , Dara Navaei and Sean Nash finished reviewing DG-DEN-3504-1 DG-DEN-3504_DG Dialysate Composition (1 of 2) ]]> DG-DEN-3504-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH." Mon, 23 Nov 2020 10:34:40 -0800 pmontazemi https://devapps.diality.us/cru/DG-DEN-3504-1/#c6293 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6293 pmontazemi  (deleted user) replied to qnguyen  (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-3504-1: comment by qnguyen "Good catch, it is actually an unintended L. Rem..." Tue, 17 Nov 2020 10:39:42 -0800 qnguyen https://devapps.diality.us/cru/DG-DEN-3504-1/#c6246 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6246 qnguyen  (deleted user) replied to pmontazemi  (deleted user) in DG-DEN-3504-1

Good catch, it is actually an unintended L. Removed.

]]> DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 17 Nov 2020 10:37:27 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-3504-1/#c6245 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6245 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-3504-1: comment by qnguyen "Pumps are now controlled individually. Reverse ..." Tue, 17 Nov 2020 10:36:33 -0800 qnguyen https://devapps.diality.us/cru/DG-DEN-3504-1/#c6244 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6244 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-3504-1

Pumps are now controlled individually. Reverse direction for motor has been added.

]]> DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 17 Nov 2020 10:34:35 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-3504-1/#c6243 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6243 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 17 Nov 2020 10:34:21 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-3504-1/#c6242 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6242 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-3504-1: comment by pmontazemi "Not a big fan of numbering variables like Speed..." Tue, 17 Nov 2020 10:33:35 -0800 pmontazemi https://devapps.diality.us/cru/DG-DEN-3504-1/#c6241 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6241 pmontazemi  (deleted user) commented on DG-DEN-3504-1

Not a big fan of numbering variables like Speed1, Speed2, etc.

]]> DG-DEN-3504-1: comment by Sean Nash "There may be a need to run these pumps in forwa..." Mon, 16 Nov 2020 08:20:00 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-3504-1/#c6225 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6225 Sean Nash commented on DG-DEN-3504-1

There may be a need to run these pumps in forward or reverse direction (heat disinfect mode). And this would not be tied to RO flow rate - we would want to set an independent flow. May also want to control the pumps independently in this mode.

]]> DG-DEN-3504-1: comment by qnguyen "This was responsible for turn off concentrate p..." Fri, 13 Nov 2020 10:48:34 -0800 qnguyen https://devapps.diality.us/cru/DG-DEN-3504-1/#c6212 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6212 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-3504-1

This was responsible for turn off concentrate pumps when HD commands DG to exit out of fill mode, but reservoir module has handled this.

]]> DG-DEN-3504-1: comment by qnguyen "It was acting as a function to turn off concent..." Fri, 13 Nov 2020 10:46:33 -0800 qnguyen https://devapps.diality.us/cru/DG-DEN-3504-1/#c6211 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6211 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-3504-1

It was acting as a function to turn off concentrate pump if HD commands DG exits fill mode, but has been removed due to reservoir module will handle this.

]]> DG-DEN-3504-1: comment by Sean Nash "We should think about this. I'm ok with adding..." Fri, 13 Nov 2020 09:40:12 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-3504-1/#c6186 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6186 Sean Nash commented on DG-DEN-3504-1

We should think about this. I'm ok with adding an explicit transition out handler (similar to the existing transition to handler), but if we do this we should build this into all modes (DG and HD).
To date, I've not required any clean-up on way out of a mode - mode can be reset on next entry. That seems to have been working so far.
Valve positions and motor states should be set as appropriate on entry to next mode, so we shouldn't have to worry about these kind of things on way out of a mode.

]]> DG-DEN-3504-1: comment by Sean Nash "I don't see this function actually exiting the ..." Fri, 13 Nov 2020 09:37:52 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-3504-1/#c6185 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6185 Sean Nash commented on DG-DEN-3504-1

I don't see this function actually exiting the mode. Is it caller's responsibility to return to re-circ mode after calling this function?

]]> DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 12 Nov 2020 10:51:51 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-3504-1/#c6160 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6160 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 12 Nov 2020 10:51:40 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-3504-1/#c6159 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6159 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 12 Nov 2020 10:51:12 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-3504-1/#c6158 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6158 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 12 Nov 2020 10:50:58 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-3504-1/#c6157 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6157 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-3504-1: comment by qnguyen "Changed variable name and added units in commen..." Thu, 12 Nov 2020 10:50:47 -0800 qnguyen https://devapps.diality.us/cru/DG-DEN-3504-1/#c6156 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6156 qnguyen  (deleted user) replied to Sean Nash in DG-DEN-3504-1

Changed variable name and added units in comment.

]]> DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 12 Nov 2020 10:50:45 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-3504-1/#c6155 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6155 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 12 Nov 2020 10:50:20 -0800 Sean Nash https://devapps.diality.us/cru/DG-DEN-3504-1/#c6154 https://devapps.diality.us/cru/DG-DEN-3504-1/#c6154 Sean Nash replied to qnguyen  (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

]]>