Fisheye on dgfirmware/firmware/source/notification.c https://devapps.diality.us/changelog/~br%3Ddgcommonfix/dgfirmware/firmware/source/notification.c Recent activity in "dgfirmware" under directory /firmware/source/notification.c DG-DEN-3421-1: closed by Dara Navaei Thu, 19 Oct 2023 08:34:58 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-3421-1 https://devapps.diality.us/cru/DG-DEN-3421-1 Dara Navaei Closed DG-DEN-3421-1 ]]> DG-DEN-3421-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:34:41 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-3421-1/#c19107 https://devapps.diality.us/cru/DG-DEN-3421-1/#c19107 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-3421-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-3421-1: reviewers resumed Thu, 19 Oct 2023 08:29:12 -0700 https://devapps.diality.us/cru/DG-DEN-3421-1 https://devapps.diality.us/cru/DG-DEN-3421-1 pmontazemi  (deleted user) , qnguyen  (deleted user) and Sean Nash resumed reviewing DG-DEN-3421-1 DG-DEN-3421_DG Heat Disinfection ]]> DG-DEN-3421-1: started by Dara Navaei Thu, 19 Oct 2023 08:29:07 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-3421-1 https://devapps.diality.us/cru/DG-DEN-3421-1 Dara Navaei started review DG-DEN-3421-1 ]]> DG-UCOMMITS-37: closed by Sean Nash Thu, 03 Aug 2023 13:21:06 -0700 Sean Nash https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash Closed DG-UCOMMITS-37 ]]> DG-UCOMMITS-37: reviewers finished Thu, 03 Aug 2023 10:09:19 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: reviewers finished Wed, 02 Aug 2023 16:01:41 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Sean Nash finished reviewing DG-UCOMMITS-37 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-37: started by Dara Navaei Mon, 08 May 2023 09:44:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-UCOMMITS-37 https://devapps.diality.us/cru/DG-UCOMMITS-37 Dara Navaei started review DG-UCOMMITS-37 ]]> DG-DEN-8030-1: closed by Dara Navaei Tue, 22 Jun 2021 10:52:11 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-8030-1 https://devapps.diality.us/cru/DG-DEN-8030-1 Dara Navaei Closed DG-DEN-8030-1 ]]> DG-DEN-8030-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Mon, 21 Jun 2021 10:38:01 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8030-1/#c10300 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10300 qnguyen  (deleted user) replied to Dara Navaei in DG-DEN-8030-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8030-1: comment by Dara Navaei "This a matter of trying the temperature sensors..." Mon, 21 Jun 2021 10:01:20 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-8030-1/#c10299 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10299 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-8030-1

This a matter of trying the temperature sensors more than once before we start the cycle. Making the wait time longer will not necessarily help the sensors to read within the range.

]]> DG-DEN-8030-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Thu, 17 Jun 2021 10:59:10 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8030-1/#c10298 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10298 qnguyen  (deleted user) replied to Dara Navaei in DG-DEN-8030-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8030-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Thu, 17 Jun 2021 10:57:57 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8030-1/#c10297 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10297 qnguyen  (deleted user) replied to Dara Navaei in DG-DEN-8030-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8030-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Thu, 17 Jun 2021 10:57:18 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8030-1/#c10296 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10296 qnguyen  (deleted user) replied to Dara Navaei in DG-DEN-8030-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8030-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Thu, 17 Jun 2021 10:56:14 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8030-1/#c10295 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10295 qnguyen  (deleted user) replied to Dara Navaei in DG-DEN-8030-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8030-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Thu, 17 Jun 2021 10:55:40 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8030-1/#c10294 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10294 qnguyen  (deleted user) replied to Dara Navaei in DG-DEN-8030-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8030-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Thu, 17 Jun 2021 10:55:20 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8030-1/#c10293 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10293 qnguyen  (deleted user) replied to Dara Navaei in DG-DEN-8030-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8030-1: comment by qnguyen "RESOLVED in CODE WALKTHROUGH." Thu, 17 Jun 2021 10:53:08 -0700 qnguyen https://devapps.diality.us/cru/DG-DEN-8030-1/#c10292 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10292 qnguyen  (deleted user) replied to Dara Navaei in DG-DEN-8030-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8030-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 17 Jun 2021 10:38:09 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8030-1/#c10291 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10291 Sean Nash replied to Dara Navaei in DG-DEN-8030-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8030-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 17 Jun 2021 10:36:44 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8030-1/#c10290 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10290 Sean Nash replied to Dara Navaei in DG-DEN-8030-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8030-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 17 Jun 2021 10:35:44 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-8030-1/#c10289 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10289 Sean Nash replied to Dara Navaei in DG-DEN-8030-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-8030-1: comment by Dara Navaei "CONC_PUMPS_REVERSE_SPEED_ML_PER_MIN = -30.0 to ..." Thu, 17 Jun 2021 09:56:12 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-8030-1/#c10287 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10287 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-8030-1

CONC_PUMPS_REVERSE_SPEED_ML_PER_MIN = -30.0 to indicate that the direction is in reverse.

]]> DG-DEN-8030-1: comment by Dara Navaei "Done." Wed, 16 Jun 2021 21:36:12 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-8030-1/#c10286 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10286 Dara Navaei replied to Sean Nash in DG-DEN-8030-1

Done.

]]> DG-DEN-8030-1: comment by Dara Navaei "Good catch, thanks. I changed it." Wed, 16 Jun 2021 21:33:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-8030-1/#c10285 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10285 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-8030-1

Good catch, thanks. I changed it.

]]> DG-DEN-8030-1: comment by Dara Navaei "I check in the inlet pressure only at the state..." Wed, 16 Jun 2021 21:32:30 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-8030-1/#c10284 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10284 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-8030-1

I check in the inlet pressure only at the states that are needed. There are times that I am not even pulling water from the inlet line.

]]> DG-DEN-8030-1: comment by Dara Navaei "It is no longer needed." Wed, 16 Jun 2021 21:28:10 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-8030-1/#c10283 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10283 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-8030-1

It is no longer needed.

]]> DG-DEN-8030-1: comment by Dara Navaei "2000 uS/cm is a safe value to determine if the ..." Wed, 16 Jun 2021 21:23:10 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-8030-1/#c10282 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10282 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-8030-1

2000 uS/cm is a safe value to determine if the acid is inserted in. Due to sensor to sensor variations, we decided to keep it a little lower than its conductivity value is.

]]> DG-DEN-8030-1: comment by Dara Navaei "Done." Wed, 16 Jun 2021 21:15:48 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-8030-1/#c10281 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10281 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-8030-1

Done.

]]> DG-DEN-8030-1: comment by Dara Navaei "We should keep this for now in case we wanted t..." Wed, 16 Jun 2021 21:07:43 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-8030-1/#c10280 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10280 Dara Navaei replied to qnguyen  (deleted user) in DG-DEN-8030-1

We should keep this for now in case we wanted to lower the heaters duty cycle to previous limits.

]]> DG-DEN-8030-1: comment by Dara Navaei "These functions are automatically generated onc..." Wed, 16 Jun 2021 20:31:18 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-8030-1/#c10279 https://devapps.diality.us/cru/DG-DEN-8030-1/#c10279 Dara Navaei replied to Sean Nash in DG-DEN-8030-1

These functions are automatically generated once a HET driver is enabled in HALCoGen.

]]>