remove FP valves

· /leahi.pro	(-4, +0)	| History	| Source	| Diff
· /sources/canbus/MessageGlobals.h	(-1, +0)	| History	| Source	| Diff
· /sources/canbus/MessageInterpreter.cpp	(-1, +0)	| History	| Source	| Diff
· /sources/gui/GuiGlobals.cpp	(-1, +0)	| History	| Source	| Diff
· /sources/gui/GuiGlobals.h	(-7, +3)	| History	| Source	| Diff
· /sources/gui/qml/dialogs/diagnostics/DiagnosticsFP.qml	(-16, +8)	| History	| Source	| Diff
· /sources/gui/qml/main.qml	(-2, +0)	| History	| Source	| Diff
· /sources/model/MModel.h	(-5, +0)	| History	| Source	| Diff
· /sources/model/dd/data/MDDValvesStatesData.h	(-4, +6)	| History	| Source	| Diff
· /sources/model/fp/data/MFPValvesStatesData.cpp	(-78, +0)	| History	| Source	| Diff
· /sources/model/fp/data/MFPValvesStatesData.h	(-107, +0)	| History	| Source	| Diff
· /sources/model/hd/alarm/MAlarmMapping.cpp	(-11, +14)	| History	| Source	| Diff
· /sources/view/VView.h	(-1, +0)	| History	| Source	| Diff
· /sources/view/dd/data/VDDValvesStatesData.cpp	(-27, +44)	| History	| Source	| Diff
· /sources/view/dd/data/VDDValvesStatesData.h	(-7, +22)	| History	| Source	| Diff
· /sources/view/fp/data/VFPValvesStatesData.cpp	(-49, +0)	| History	| Source	| Diff
· /sources/view/fp/data/VFPValvesStatesData.h	(-67, +0)	| History	| Source	| Diff

]]> Sun, 12 Oct 2025 13:55:46 -0700 Dara Navaei https://devapps.diality.us/changelog/leahi-application?cs=994d6d453820ba52adc987d81a2dbd54356a40eb https://devapps.diality.us/changelog/leahi-application?cs=994d6d453820ba52adc987d81a2dbd54356a40eb Dara Navaei committed 994d6d4 on branch develop, feature/LDT-2091-Prescription-Manager-SW-01-RI-2 and 35 more in leahi-application Bamboo Commit: Updated MAlarmMapping.cpp

· /sources/model/hd/alarm/MAlarmMapping.cpp

(-8, +8)

| History

| Source

| Diff

]]> Fri, 10 Oct 2025 15:43:19 -0700 Dara Navaei https://devapps.diality.us/changelog/leahi-application?cs=39b66a662bd8a9f3f5513764520c3b1c911b3777 https://devapps.diality.us/changelog/leahi-application?cs=39b66a662bd8a9f3f5513764520c3b1c911b3777 Dara Navaei committed 39b66a6 on branch develop, feature/LDT-2091-Prescription-Manager-SW-01-RI-2 and 35 more in leahi-application Bamboo Commit: Updated MAlarmMapping.cpp

· /sources/model/hd/alarm/MAlarmMapping.cpp

(-8, +8)

| History

| Source

| Diff

]]> Mon, 15 Sep 2025 16:58:43 -0700 Dara Navaei https://devapps.diality.us/changelog/leahi-application?cs=fcfd182ef7240f0b209eb9825f885fa72cf0c8c3 https://devapps.diality.us/changelog/leahi-application?cs=fcfd182ef7240f0b209eb9825f885fa72cf0c8c3 Dara Navaei committed fcfd182 on branch LDT-2428-Onboarding-Test-Message-and-Diag-Screen-View, develop and 38 more in leahi-application Bamboo Commit: Updated MAlarmMapping.cpp

· /sources/model/hd/alarm/MAlarmMapping.cpp

(-1, +2)

| History

| Source

| Diff

]]> Thu, 04 Sep 2025 09:42:10 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 Dara Navaei Closed LEAHI-APPLICATION-LDT-1788-1 ]]> Thu, 04 Sep 2025 09:41:40 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 Dara Navaei started review LEAHI-APPLICATION-LDT-1788-1 ]]> Wed, 03 Sep 2025 16:19:04 -0700 Dara Navaei https://devapps.diality.us/changelog/leahi-application?cs=bd19a0c3c4b62b4032e9600848f40d91fa01e547 https://devapps.diality.us/changelog/leahi-application?cs=bd19a0c3c4b62b4032e9600848f40d91fa01e547 Dara Navaei committed bd19a0c on branch LDT-2428-Onboarding-Test-Message-and-Diag-Screen-View, develop and 39 more in leahi-application Bamboo Commit: Updated MAlarmMapping.cpp

· /sources/model/hd/alarm/MAlarmMapping.cpp

(-5, +5)

| History

| Source

| Diff

]]> Fri, 29 Aug 2025 15:57:52 -0700 Dara Navaei https://devapps.diality.us/changelog/leahi-application?cs=6f670a710a3bbec41c9d0b71e1e51c0ccd0c6ae3 https://devapps.diality.us/changelog/leahi-application?cs=6f670a710a3bbec41c9d0b71e1e51c0ccd0c6ae3 Dara Navaei committed 6f670a7 on branch LDT-2428-Onboarding-Test-Message-and-Diag-Screen-View, develop and 40 more in leahi-application Bamboo Commit: Updated MAlarmMapping.cpp

· /sources/model/hd/alarm/MAlarmMapping.cpp

(-1, +6)

| History

| Source

| Diff

]]> Wed, 13 Aug 2025 18:07:50 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 Behrouz NematiPour Closed LEAHI-APPLICATION-LDT-1788-1 ]]> Wed, 13 Aug 2025 17:09:31 -0700 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1 Behrouz NematiPour and Stephen Quong finished reviewing LEAHI-APPLICATION-LDT-1788-1 LDT-1788 - Feature/LDT-1788 - General Alarm Instructions With New Design ]]> Wed, 13 Aug 2025 16:11:41 -0700 Stephen Quong https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1/#c23762 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-1788-1/#c23762 Stephen Quong replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-1788-1

RESOLVED

RESOLVED

RESOLVED

BN: RESOLVED

BN: RESOLVED

updated

updated

updated

as discussed to add the space after the parenthesis. updated all instances

I agree with this comment, to make the code fit in a shorter vertical area.
Please use the Bjarne Stroustrup everywhere and be consistent:

if () {
}
else {
}

Stephen Quong
Please let's do that only for the long template-based iterator types, and not for all the variables.

And agree with using const and also & when applicable.

Remove leading and trailing spaces in if conditionals to keep style consistent.

Declare variables using 'auto' and 'const auto' where possible, especially where initializing the variable.

Change to match other beginning { style.

Change to match other beginning { style.

Change to match above beginning { style.