Fisheye on leahi-application/sources/gui/qml/dialogs/NotificationDialog.qml https://devapps.diality.us/changelog/~br%3Dfeature%25402fLDT-5572-calibration-Hydraulics/leahi-application/sources/gui/qml/dialogs/NotificationDialog.qml Recent activity in "leahi-application" under directory /sources/gui/qml/dialogs/NotificationDialog.qml LEAHI-APPLICATION-LDT-5618-1: closed by Dara Navaei Thu, 20 Aug 2026 08:59:17 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5618-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5618-1 Dara Navaei Closed LEAHI-APPLICATION-LDT-5618-1 ]]> LEAHI-APPLICATION-LDT-5618-1: reviewers finished Wed, 19 Aug 2026 21:24:18 -0700 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5618-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5618-1 Dara Navaei , Tiffany Mejia , Stephen Quong and Nicholas Ramirez finished reviewing LEAHI-APPLICATION-LDT-5618-1 LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C ]]> LEAHI-APPLICATION-LDT-5618-1: started by Behrouz NematiPour Wed, 19 Aug 2026 20:07:10 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5618-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5618-1 Behrouz NematiPour started review LEAHI-APPLICATION-LDT-5618-1 ]]> LEAHI-APPLICATION-LDT-5618-1: closed by Behrouz NematiPour Wed, 19 Aug 2026 16:21:23 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5618-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5618-1 Behrouz NematiPour Closed LEAHI-APPLICATION-LDT-5618-1 ]]> LEAHI-APPLICATION-LDT-5618-1: started by Dara Navaei Wed, 19 Aug 2026 15:04:48 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5618-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5618-1 Dara Navaei started review LEAHI-APPLICATION-LDT-5618-1 ]]> LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "updated" Wed, 19 Aug 2026 13:51:31 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31512 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31512 Nicholas Ramirez replied to Behrouz NematiPour in LEAHI-APPLICATION-LDT-5158-1

updated

]]> LEAHI-APPLICATION-LDT-5158-1: comment by Behrouz NematiPour "APPROVED." Wed, 19 Aug 2026 12:49:41 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31494 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31494 Behrouz NematiPour replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

APPROVED.

]]> LEAHI-APPLICATION-LDT-5158-1: comment by Behrouz NematiPour "RESOLVED. Added another comment regarding the ..." Wed, 19 Aug 2026 12:49:11 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31493 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31493 Behrouz NematiPour replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

RESOLVED.
Added another comment regarding the same.

]]> LEAHI-APPLICATION-LDT-5158-1: comment by Behrouz NematiPour "[~nramirez] Thanks for the change to the ok an..." Wed, 19 Aug 2026 12:42:07 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31492 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31492 Behrouz NematiPour commented on LEAHI-APPLICATION-LDT-5158-1

Nicholas Ramirez
Thanks for the change to the ok and result.

  • To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
  • Also move the: 
    ; if ( ! ok ) { goto invalid; }

    on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

]]> LEAHI-APPLICATION-LDT-5158-1: comment by Behrouz NematiPour "APPROVED" Wed, 19 Aug 2026 12:40:37 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31491 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31491 Behrouz NematiPour replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

APPROVED

]]> LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "updated" Tue, 18 Aug 2026 16:24:52 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31478 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31478 Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

updated

]]> LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "updated" Tue, 18 Aug 2026 16:24:45 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31477 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31477 Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

updated

]]> LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "updated" Tue, 18 Aug 2026 16:24:38 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31476 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31476 Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

updated

]]> LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "remove the ok and just check result and if any ..." Tue, 18 Aug 2026 15:35:44 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31474 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31474 Nicholas Ramirez commented on LEAHI-APPLICATION-LDT-5158-1

remove the ok and just check result and if any fails goto invalid

]]> LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "see if you can use payloadLen from MessageGlob..." Tue, 18 Aug 2026 15:34:40 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31473 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31473 Nicholas Ramirez commented on LEAHI-APPLICATION-LDT-5158-1

see if you can use payloadLen from MessageGlobals.h

]]> LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "double check" Tue, 18 Aug 2026 15:17:13 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31472 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31472 Nicholas Ramirez commented on LEAHI-APPLICATION-LDT-5158-1

double check

]]> LEAHI-APPLICATION-LDT-5158-1: reviewers left LEAHI-APPLICATION-LDT-5158_SW Misc & Enhc - SW - ... Mon, 17 Aug 2026 17:03:25 -0700 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1 Sean Nash left LEAHI-APPLICATION-LDT-5158-1 LEAHI-APPLICATION-LDT-5158_SW Misc & Enhc - SW - 01 - SW Integration - Calibration - R&I ]]> LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "removedin https://devapps.diality.us/cru/LEAHI-..." Fri, 14 Aug 2026 10:22:18 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31383 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31383 Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-5158-1

removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

]]> LEAHI-APPLICATION-LDT-5158-1: comment by Nicholas Ramirez "remove from prime // priming - TODO check if ne..." Tue, 11 Aug 2026 16:53:30 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31226 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1/#c31226 Nicholas Ramirez commented on LEAHI-APPLICATION-LDT-5158-1

remove from prime // priming - TODO check if needed. may not need

]]> LEAHI-APPLICATION-LDT-5158-1: started by Dara Navaei Wed, 05 Aug 2026 13:04:56 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5158-1 Dara Navaei started review LEAHI-APPLICATION-LDT-5158-1 ]]> LEAHI-APPLICATION-LDT-5104-14: started by Dara Navaei Wed, 15 Jul 2026 04:04:28 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5104-14 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-5104-14 Dara Navaei started review LEAHI-APPLICATION-LDT-5104-14 ]]> LEAHI-APPLICATION-LDT-3932-1: closed by Behrouz NematiPour Tue, 19 May 2026 16:35:00 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1 Behrouz NematiPour Closed LEAHI-APPLICATION-LDT-3932-1 ]]> LEAHI-APPLICATION-LDT-3932-1: reviewers finished Tue, 19 May 2026 16:34:42 -0700 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1 Behrouz NematiPour finished reviewing LEAHI-APPLICATION-LDT-3932-1 LEAHI-APPLICATION-LDT-3932_Post-Treatment - SW - 01 - Foundation - R&I ]]> LEAHI-APPLICATION-LDT-3932-1: started by Behrouz NematiPour Tue, 19 May 2026 16:34:33 -0700 Behrouz NematiPour https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1 Behrouz NematiPour started review LEAHI-APPLICATION-LDT-3932-1 ]]> LEAHI-APPLICATION-LDT-3932-1: closed by Nicholas Ramirez Tue, 19 May 2026 16:33:05 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1 Nicholas Ramirez Closed LEAHI-APPLICATION-LDT-3932-1 ]]> LEAHI-APPLICATION-LDT-3932-1: comment by Nicholas Ramirez "BN APPROVES" Thu, 07 May 2026 15:16:16 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1/#c29014 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1/#c29014 Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-3932-1

BN APPROVES

]]> LEAHI-APPLICATION-LDT-3932-1: comment by Nicholas Ramirez "BN APPROVES" Thu, 07 May 2026 15:15:12 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1/#c29013 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1/#c29013 Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-3932-1

BN APPROVES

]]> LEAHI-APPLICATION-LDT-3932-1: comment by Nicholas Ramirez "BN APPROVES" Thu, 07 May 2026 15:14:56 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1/#c29012 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1/#c29012 Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-3932-1

BN APPROVES

]]> LEAHI-APPLICATION-LDT-3932-1: comment by Nicholas Ramirez "BN APPROVES" Thu, 07 May 2026 15:14:37 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1/#c29011 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1/#c29011 Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-3932-1

BN APPROVES

]]> LEAHI-APPLICATION-LDT-3932-1: comment by Nicholas Ramirez "BN APPROVES" Thu, 07 May 2026 15:13:38 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1/#c29010 https://devapps.diality.us/cru/LEAHI-APPLICATION-LDT-3932-1/#c29010 Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-APPLICATION-LDT-3932-1

BN APPROVES

]]>