Fisheye on application/sources/gui/qml/dialogs/ConfirmDialog.qml https://devapps.diality.us/changelog/~br%3Dfeature%25402fUI-MS-S117-Integration/application/sources/gui/qml/dialogs/ConfirmDialog.qml Recent activity in "application" under directory /sources/gui/qml/dialogs/ConfirmDialog.qml UI-LEAH-1958-1: closed by Behrouz NematiPour Thu, 05 Jun 2025 12:00:13 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-LEAH-1958-1 https://devapps.diality.us/cru/UI-LEAH-1958-1 Behrouz NematiPour Closed UI-LEAH-1958-1 ]]> UI-LEAH-1958-1: started by Dara Navaei Tue, 19 Nov 2024 12:01:46 -0800 Dara Navaei https://devapps.diality.us/cru/UI-LEAH-1958-1 https://devapps.diality.us/cru/UI-LEAH-1958-1 Dara Navaei started review UI-LEAH-1958-1 ]]> UI-DEN-16288-1: closed by Dara Navaei Thu, 19 Oct 2023 10:23:14 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16288-1 https://devapps.diality.us/cru/UI-DEN-16288-1 Dara Navaei Closed UI-DEN-16288-1 ]]> UI-DEN-16288-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 10:22:48 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16288-1/#c19144 https://devapps.diality.us/cru/UI-DEN-16288-1/#c19144 Dara Navaei replied to Behrouz NematiPour in UI-DEN-16288-1

RESOLVED

]]> UI-DEN-16288-1: started by Dara Navaei Thu, 19 Oct 2023 10:20:32 -0700 Dara Navaei https://devapps.diality.us/cru/UI-DEN-16288-1 https://devapps.diality.us/cru/UI-DEN-16288-1 Dara Navaei started review UI-DEN-16288-1 ]]> UI-DEN-16288-1: closed by Behrouz NematiPour Mon, 11 Sep 2023 16:00:51 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16288-1 https://devapps.diality.us/cru/UI-DEN-16288-1 Behrouz NematiPour Closed UI-DEN-16288-1 ]]> UI-DEN-16288-1: reviewers finished Mon, 11 Sep 2023 13:58:36 -0700 https://devapps.diality.us/cru/UI-DEN-16288-1 https://devapps.diality.us/cru/UI-DEN-16288-1 vduong  (deleted user) and msuleiman  (deleted user) finished reviewing UI-DEN-16288-1 UI-DEN-16288_UI BN S104 [ ready - application ] ]]> UI-DEN-16288-1: comment by Behrouz NematiPour "Since Vy is busy and it is not a code change an..." Mon, 11 Sep 2023 13:03:12 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16288-1/#c18886 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18886 Behrouz NematiPour replied to Behrouz NematiPour in UI-DEN-16288-1

Since Vy is busy and it is not a code change and is only type
I do resolve on her behalf.
RESOLVED

]]> UI-DEN-16288-1: comment by msuleiman "RESOLVED" Mon, 11 Sep 2023 12:53:38 -0700 msuleiman https://devapps.diality.us/cru/UI-DEN-16288-1/#c18885 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18885 msuleiman  (deleted user) replied to Behrouz NematiPour in UI-DEN-16288-1

RESOLVED

]]> UI-DEN-16288-1: comment by Behrouz NematiPour "fixed." Mon, 11 Sep 2023 12:42:25 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16288-1/#c18884 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18884 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-16288-1

fixed.

]]> UI-DEN-16288-1: comment by vduong "RESOLVED" Mon, 11 Sep 2023 12:00:22 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16288-1/#c18882 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18882 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-16288-1

RESOLVED

]]> UI-DEN-16288-1: comment by Behrouz NematiPour "good comment, will do in the next release" Mon, 11 Sep 2023 11:52:24 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16288-1/#c18881 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18881 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-16288-1

good comment,
will do in the next release

]]> UI-DEN-16288-1: comment by vduong "RESOLVED" Thu, 31 Aug 2023 16:54:01 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16288-1/#c18797 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18797 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-16288-1

RESOLVED

]]> UI-DEN-16288-1: comment by vduong "I suggest doing --enable-update-mode (all lower..." Thu, 31 Aug 2023 11:28:03 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16288-1/#c18783 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18783 vduong  (deleted user) commented on UI-DEN-16288-1

I suggest doing --enable-update-mode (all lowercase) to be consistent with the other params

]]> UI-DEN-16288-1: comment by vduong "her. => here." Thu, 31 Aug 2023 11:26:37 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16288-1/#c18782 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18782 vduong  (deleted user) commented on UI-DEN-16288-1

her. => here.

]]> UI-DEN-16288-1: comment by vduong "RESOLVED" Thu, 31 Aug 2023 11:26:00 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16288-1/#c18781 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18781 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-16288-1

RESOLVED

]]> UI-DEN-16288-1: comment by vduong "RESOLVED" Thu, 31 Aug 2023 11:25:53 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16288-1/#c18780 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18780 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-16288-1

RESOLVED

]]> UI-DEN-16288-1: comment by vduong "RESOLVED" Thu, 31 Aug 2023 11:25:43 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16288-1/#c18779 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18779 vduong  (deleted user) replied to Behrouz NematiPour in UI-DEN-16288-1

RESOLVED

]]> UI-DEN-16288-1: comment by Behrouz NematiPour "fixed" Thu, 31 Aug 2023 10:57:19 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16288-1/#c18778 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18778 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-16288-1

fixed

]]> UI-DEN-16288-1: comment by Behrouz NematiPour "thank you, fixed." Thu, 31 Aug 2023 10:57:10 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16288-1/#c18777 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18777 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-16288-1

thank you,
fixed.

]]> UI-DEN-16288-1: comment by Behrouz NematiPour "removed" Thu, 31 Aug 2023 10:56:46 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16288-1/#c18776 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18776 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-16288-1

removed

]]> UI-DEN-16288-1: comment by Behrouz NematiPour "It currently has." Wed, 30 Aug 2023 17:10:48 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16288-1/#c18772 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18772 Behrouz NematiPour replied to msuleiman  (deleted user) in UI-DEN-16288-1

It currently has.

]]> UI-DEN-16288-1: comment by Behrouz NematiPour "It currently has." Wed, 30 Aug 2023 17:10:44 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16288-1/#c18771 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18771 Behrouz NematiPour replied to msuleiman  (deleted user) in UI-DEN-16288-1

It currently has.

]]> UI-DEN-16288-1: comment by Behrouz NematiPour "it is being used and tend to be the bool. bein..." Wed, 30 Aug 2023 17:08:21 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-16288-1/#c18770 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18770 Behrouz NematiPour replied to vduong  (deleted user) in UI-DEN-16288-1

it is being used and tend to be the bool.
being alias of what?
it is being used to let the dialog know if the dialog can be closed upon button press or just emit the signal.

]]> UI-DEN-16288-1: comment by vduong "typo" Wed, 30 Aug 2023 05:11:00 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16288-1/#c18768 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18768 vduong  (deleted user) commented on UI-DEN-16288-1

typo

]]> UI-DEN-16288-1: comment by vduong "typo" Wed, 30 Aug 2023 05:10:47 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16288-1/#c18767 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18767 vduong  (deleted user) commented on UI-DEN-16288-1

typo

]]> UI-DEN-16288-1: comment by vduong "This property is not being used. Also, you m..." Wed, 30 Aug 2023 05:03:55 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16288-1/#c18766 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18766 vduong  (deleted user) commented on UI-DEN-16288-1

This property is not being used.

Also, you might be able to alias the property that the Dialog (root component of ModalDialog).

]]> UI-DEN-16288-1: comment by msuleiman "if statement indentation" Mon, 28 Aug 2023 09:20:16 -0700 msuleiman https://devapps.diality.us/cru/UI-DEN-16288-1/#c18752 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18752 msuleiman  (deleted user) commented on UI-DEN-16288-1

if statement indentation

]]> UI-DEN-16288-1: comment by msuleiman "If statement - needs indentation" Mon, 28 Aug 2023 09:18:29 -0700 msuleiman https://devapps.diality.us/cru/UI-DEN-16288-1/#c18751 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18751 msuleiman  (deleted user) commented on UI-DEN-16288-1

If statement - needs indentation

]]> UI-DEN-16288-1: comment by vduong "Did you mean to keep this commented out ?" Mon, 28 Aug 2023 07:13:53 -0700 vduong https://devapps.diality.us/cru/UI-DEN-16288-1/#c18750 https://devapps.diality.us/cru/UI-DEN-16288-1/#c18750 vduong  (deleted user) commented on UI-DEN-16288-1

Did you mean to keep this commented out ?

]]>